Hi!
On Thu, Apr 1, 2021 at 12:03 AM Sergei Golubchik wrote:
> > > > - DBUG_PRINT("info", ("Found partition %u is_subpart %d for name %s",
> > > > + DBUG_PRINT("info", ("Found partition %u is_subpart %d for name %.*s",
> > > >part_def->part_id, part_def->is_subpart,
> >
Hi, Monty!
On Mar 31, Michael Widenius wrote:
> > > > --- a/sql/sql_string.h
> > > > +++ b/sql/sql_string.h
> > > > @@ -600,25 +600,34 @@ class Binary_string: public Static_binary_string
> > > >
> > > >inline char *c_ptr()
> > > >{
> > > > -DBUG_ASSERT(!alloced || !Ptr || !Alloced_leng
Hi, Michael!
On Mar 31, Michael Widenius wrote:
>
> Yes, LEX_CSTRING *should* always be \0 terminated, but as we sometimes
> build these up I do not want to depend on that for generic usage. For
> usage to printf() than we should trust that the developer knows what
> he is doing.
>
> However Ite
Hi, Sujatha!
Note, it's a review of the combined `git diff e5fc78 21a84e`
On Mar 31, Sujatha wrote:
> revision-id: 21a84e23cf3 (mariadb-10.5.2-307-g21a84e23cf3)
> parent(s): 4e6de585ff7
> author: Sujatha
> committer: Sujatha
> timestamp: 2020-11-30 13:22:32 +0530
> message:
>
> MDEV-16437: mer
Hi!
Sorry, this was because gmail send it before I wanted to.
(I do not like that ctrl+return sends email as this causes problems
when one uses this a lot in slack!)
> > > --- a/sql/sql_string.h
> > > +++ b/sql/sql_string.h
> > > @@ -600,25 +600,34 @@ class Binary_string: public Static_binary_st
On Wed, Mar 31, 2021 at 9:45 PM Michael Widenius
wrote:
>
> Cut
> > > Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()
> > >
> > > The proble was that hen using String::alloc() to allocate a string,
> >
> > "hen" ? after a minute of staring I realized that you probably meant "when".
>
Cut
> > Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()
> >
> > The proble was that hen using String::alloc() to allocate a string,
>
> "hen" ? after a minute of staring I realized that you probably meant "when".
>
> (also, "problem")
>
> > the String ensures that there is space for an
Hi, Sergei!
On Wed, Mar 31, 2021 at 5:52 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Dec 01, Sergei Golubchik wrote:
> > Hi, Aleksey!
> >
> > just one comment below, no comments on all your other replies.
> >
> > The issue is in review, shall I take another look or it's on you now?
>
> I t
Hi, Michael!
On Mar 31, Michael Widenius wrote:
> Hi!
>
> On Mon, Mar 29, 2021 at 9:39 PM Sergei Golubchik wrote:
> >
> > Hi, Michael!
> >
> > On Mar 29, Michael Widenius wrote:
> > > revision-id: f8901333a82 (mariadb-10.5.2-534-gf8901333a82)
> > > parent(s): a194c5cfd41
> > > author: Michael Wi
Hi!
On Mon, Mar 29, 2021 at 3:55 PM Sergei Golubchik wrote:
>
> Hi, Michael!
>
> On Mar 29, Michael Widenius wrote:
> > revision-id: 1bbc852ef71 (mariadb-10.5.2-525-g1bbc852ef71)
> > parent(s): 039f4a054bb
> > author: Michael Widenius
> > committer: Michael Widenius
> > timestamp: 2021-03-24 14
Hi!
On Mon, Mar 29, 2021 at 4:20 PM Sergei Golubchik wrote:
>
> Hi, Michael!
Only people who do not know me calls me Michael...
Who are you?
> > Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
> >
> > diff --git a/sql/item.cc b/sql/item.cc
> > index e5be8699d80..e0ba4ff2c89 1
Hi!
On Mon, Mar 29, 2021 at 9:39 PM Sergei Golubchik wrote:
>
> Hi, Michael!
>
> On Mar 29, Michael Widenius wrote:
> > revision-id: f8901333a82 (mariadb-10.5.2-534-gf8901333a82)
> > parent(s): a194c5cfd41
> > author: Michael Widenius
> > committer: Michael Widenius
> > timestamp: 2021-03-24 15
Hi!
On Wed, Mar 31, 2021 at 5:18 PM Sergei Golubchik wrote:
>
> Hi, Michael!
>
> On Mar 31, Michael Widenius wrote:
> > commit 25fe7dbad5d
> > Author: Michael Widenius
> > Date: Wed Aug 12 20:29:55 2020 +0300
> >
> >Reduce usage of strlen()
>
> I'll only mention actual mistakes, no style c
Hi, Aleksey!
On Dec 01, Sergei Golubchik wrote:
> Hi, Aleksey!
>
> just one comment below, no comments on all your other replies.
>
> The issue is in review, shall I take another look or it's on you now?
I think I've never got a reply to this question.
Shall I take another look at the bb-10.6-m
Hi, Michael!
On Mar 31, Michael Widenius wrote:
> commit 25fe7dbad5d
> Author: Michael Widenius
> Date: Wed Aug 12 20:29:55 2020 +0300
>
>Reduce usage of strlen()
I'll only mention actual mistakes, no style comments or suggestions or
question, just want to get it over with.
> diff --git a
15 matches
Mail list logo