Re: [Maria-developers] d221068ae8b: Change CHARSET_INFO character set and collaction names to LEX_CSTRING

2021-04-06 Thread Michael Widenius
Hi! On Thu, Apr 1, 2021 at 4:19 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 01, Michael Widenius wrote: > > revision-id: d221068ae8b (mariadb-10.5.2-540-gd221068ae8b) > > parent(s): 896c3b0a00a > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2021-03-24 19:

Re: [Maria-developers] e3971006cca: Give a readable error in mtr if resolve_at_variable fails

2021-04-06 Thread Michael Widenius
Hi! On Mon, Apr 5, 2021 at 5:27 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 05, Michael Widenius wrote: > > revision-id: e3971006cca (mariadb-10.5.2-547-ge3971006cca) > > parent(s): ae009435e72 > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2021-03-24 19:25

Re: [Maria-developers] 405a89353b2: Don't reset StringBuffers in loops when not needed

2021-04-06 Thread Michael Widenius
Hi! On Sat, Apr 3, 2021 at 12:54 AM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 02, Michael Widenius wrote: > > revision-id: 405a89353b2 (mariadb-10.5.2-542-g405a89353b2) > > parent(s): 2dd8d472fcc > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2021-03-24 19:2

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-06 Thread Sergei Golubchik
Hi, Aleksey! On Apr 06, Aleksey Midenkov wrote: > > > But, since we need to specify implicit system fields we cannot > > > avoid adding one more session variable. In my current iteration I > > > made @@force_fields_visible which is more straightforward in what > > > it does: > > > > I'm sorry, I d

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-06 Thread Aleksey Midenkov
Hi Sergei, On Mon, Apr 5, 2021 at 8:04 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Feb 26, Aleksey Midenkov wrote: > > > > > > > > > > In other words, if one can create an arbitrary history by > > > > > manipulating @@timestamp variable, > > > > > @@system_versioning_insert_history allows