Re: [Maria-developers] commit 192fea6b104b249bb4764635bb3a52fb9c8a2148 MDEV-27128

Hi, Rucha. I decided i dislike the overall design of the struct json_schema. Seems better to do it with C++ classes using virtual methods. So instead of structures we'd have classes as json_schema_const json_schema_enum json_scnema_string json_schema_number etc. they all inherited

Re: [Maria-developers] b248988c8b6: MDEV-19275 Provide SQL service to plugins.

Hi, Sergei. Unfortunately the taken approach led to compiler errors on Windows and (seemingly) the rpl_shutdown_wait_slaves test failure. So i made the change - to preserve the way we do the includes. 76c4616c2cc47ecc85362d0c5a2bffd9495e4753 Best regards. HF On Mon, Sep 13, 2021 at 12:42 PM

Re: [Maria-developers] b248988c8b6: MDEV-19275 Provide SQL service to plugins.

atch with the abovementioned changes. 9ad45b41d385fca8215880cce1757ebe7f2396eb Best regards. HF On Fri, Sep 10, 2021 at 7:54 PM Sergei Golubchik wrote: > Hi, Alexey! > > On Sep 10, Alexey Botchkov wrote: > > > For example, I'd think it connects to the current server, internally. > > >

Re: [Maria-developers] b248988c8b6: MDEV-19275 Provide SQL service to plugins.

shed 71338ddada9f331af57b737a586f56dc6f2e483f. Best regards. HF On Tue, Sep 7, 2021 at 5:58 PM Sergei Golubchik wrote: > Hi, Alexey! > > see questions below > > On Sep 07, Alexey Botchkov wrote: > > revision-id: b248988c8b6 (mariadb-10.6.1-74-gb248988c8b6) > >

Re: [Maria-developers] MDEV-25822: Re: JSON_TABLE: on default values

e is the new patch. https://github.com/MariaDB/server/commit/8dae7ee02f98e71e9352d73d1da235fd4128d076 Best regards. HF On Tue, Jun 8, 2021 at 6:50 PM Sergey Petrunia wrote: > Hi Alexey, > > > On Sun, May 30, 2021 at 06:44:19AM +0400, Alexey Botchkov wrote: > > > Hi, Serg

Re: [Maria-developers] MDEV-25875: RE 02469b: MDEV-17399 JSON_TABLE Accept JSON values for the JSON fields

Hello, Sergey! > The name "store_json_in_json" doesn't look good to me. > Do you think store_element_as_json_doc() would be better? I decided to rename it as store_value_as_json_doc() The 'element' sounds somewhat unclear to me. > > + if (!(error= store_json_in_json(*f, ))) > > +

Re: [Maria-developers] Tips on Writing/Reading JSON

Hello, Michael! Simple tools for reading JSON are declared in the include/mysql/service_json.h. Functions declared there are easy to use and understand, and they can read any JSON. Should be enough for you, at least to begin with. You need to look any deeper only if you have to make your code

Re: [Maria-developers] Using JSON_TABLE to create JSON columns?

Hi, Sergey! I think saving JSON values in the JSON fields (as the MySQL does) makes sense. So here is the patch for it https://github.com/MariaDB/server/commit/02469bdead5753eccb5d70c98a158a07027f4eb2 Best regards. HF On Mon, Jun 22, 2020 at 4:48 PM Sergey Petrunia wrote: > Hi Alexey and

Re: [Maria-developers] JSON_TABLE: on default values

Hi, Sergey! I meditated about it for some time. I remember i was thinking on that part before and did that so for some reason. Though either i was wrong or didn't finish what i planned. This time i'd say we should allow numeric constants there too. Here's the patch i'd push to fix this:

Re: [Maria-developers] 308c28e8a60: MDEV-15888 Implement FLUSH TABLES tbl_name [, tbl_name] ... WITH READ LOCK for views.

uss it later. Best regards. HF On Sun, Mar 21, 2021 at 7:48 PM Sergei Golubchik wrote: > Hi, Alexey! > > On Mar 21, Alexey Botchkov wrote: > > revision-id: 308c28e8a60 (mariadb-10.5.2-393-g308c28e8a60) > > parent(s): 786bc312b85 > > author: Alexey Botchkov > > co

Re: [Maria-developers] MDEV-13467 review.

r review, hope everything is ok now. > Here is the new patch 1f618e36577a2a322807 > <https://github.com/MariaDB/server/commit/1f618e36577a2a32280705c640d6f9a74861a3c6> > according > to your review and comments below. > > On Sat, Jan 9, 2021 at 2:09 PM Alexey Botchkov >

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

classes as friends so we explicitly allow access to the internals to that one class and disallow to everyone else. But yes, it's rather the matter of taste. Best regards. HF On Fri, Mar 12, 2021 at 2:33 AM Sergey Petrunia wrote: > On Sat, Mar 06, 2021 at 01:13:53AM +0400, Alexey Botchkov wr

Re: [Maria-developers] MDEV-17399: JSON_TABLE: Incorrect code with table elimination

I've rewritten it using the json->select_lex->leaf_tables as you suggested. So the JSON_TABLE is calculated properly and all the dependencies seem to be marked. Still your testcase query fails the same way, so needs some more investigation. To me it looks more like optimizer issue than the

Re: [Maria-developers] MDEV-17399: JSON_TABLE: Odd code in table.cc:create_view_field ?

Well i should have removed those changes after i did the last version of the check for table dependencies. Now we never set the thd->current_select to the 0. So that part wrapper_to_set part deleted. Best regards. HF On Fri, Mar 12, 2021 at 1:35 AM Sergey Petrunia wrote: > Hi Alexey, > > What

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

forgot about the embedded server. Fixed. On Wed, Mar 10, 2021 at 12:47 PM Sergey Petrunia wrote: > Hi Alexey, > > > On Sat, Mar 06, 2021 at 01:13:53AM +0400, Alexey Botchkov wrote: > > Hi, Sergei! > > > > I pushed the patch to the feature branch for you to ta

Re: [Maria-developers] MDEV-17399: JSON_TABLE: final input

Hi, Sergei! I pushed the patch to the feature branch for you to take a look. The patch you proposed http://lists.askmonty.org/pipermail/commits/2021-March/014492.html I liked and adapted with one exception. The nested paths list is built using the **last_sibling_hook instead of

Re: [Maria-developers] MDEV-17399: JSON_TABLE: Crash with nested path

Found one more ps-protocol issue to fix... On Thu, Feb 25, 2021 at 5:27 PM Sergey Petrunia wrote: > Hi Alexey, > > I was looking at Json_table_nested_path::set_position(), wondering why > does > it have an assignment > > np->m_null= TRUE; > > but doesn't clear the NULL values and trying to

Re: [Maria-developers] MDEV-17399: JSON_TABLE: Crash with nested path

Things are fixed now as far as i can see. Best regards. HF On Thu, Feb 25, 2021 at 5:27 PM Sergey Petrunia wrote: > Hi Alexey, > > I was looking at Json_table_nested_path::set_position(), wondering why > does > it have an assignment > > np->m_null= TRUE; > > but doesn't clear the NULL

Re: [Maria-developers] MDEV-17399: JSON_TABLE, commit 85757ecbef44484270e385a8d52998c67f72d11a

Ok, fixed that as you said. See the last commit to the bb-10.6-mdev17399-hf for details Best regards. HF On Tue, Feb 23, 2021 at 3:57 PM Sergey Petrunia wrote: > On Mon, Feb 22, 2021 at 09:59:54PM +0300, Sergey Petrunia wrote: > > == On table dependencies: table elimination == > > > > create

Re: [Maria-developers] MDEV-17399: Columns of JSON datatype?

> What do you think? Returning the JSON subdocument would violate the standard. I think it makes sense as the user normally expects the scalar value and if there is the JSON subdocument in the searched field, it's rather an error and must be detected. I'd add the FORMAT JSON keyword to handle

Re: [Maria-developers] MDEV-17399: Name resolution and handling dependencies

Well i just did that end_lateral_table trick for now. HF On Tue, Feb 9, 2021 at 3:05 PM Sergey Petrunia wrote: > Hi Alexey, > > At the moment, name resolution of JSON_TABLE's first argument is done > "like in > the WHERE clause" - one can refer to any table that is defined in the WHERE >

Re: [Maria-developers] MDEV-17399 New patch for JSON_TABLE

Some updates were pushed. See here for the review. https://github.com/MariaDB/server/commit/d7ff97bd1343a94430152389f90c4d08f56fce44 On Wed, Nov 18, 2020 at 8:17 PM Sergey Petrunia wrote: > On Mon, Nov 16, 2020 at 01:53:39PM +0300, Sergey Petrunia wrote: > > Input on the latest patch for

Re: [Maria-developers] MDEV-17399 New patch for JSON_TABLE

Hello, Sergei! New patch was made. I think i addressed what you've noticed in last review. https://github.com/MariaDB/server/commit/75ae330f877240e903690f282fad3ebdb02a0eeb > CREATE TABLE t2 SELECT * > FROM JSON_TABLE('"test"', '$' COLUMNS(x VARCHAR(10) >

[Maria-developers] MDEV-13467 review.

Hi, Anel! Sorry for that long delay with this review. Had real difficult weeks of my life :( Now it seems to be over, so getting back to normal. Below is my opinions of the code i see in the branch bb-10.1-anel-MDEV-13467-gis-feature-st_sphere-v2 Hope it's the recent version. + Adapter for

Re: [Maria-developers] Question about JSONPath and '**' wildcard

On the second thought, i decided to do it like MySQL does. There is a value of "124" and it's patch fits the specification, so we return it. No need to do it twice. Are you ok with that? HF/ On Fri, Nov 20, 2020 at 12:18 AM Sergey Petrunia wrote: > Hi Alexey, > > I've found this discrepancy

Re: [Maria-developers] Question about JSONPath and '**' wildcard

Hi, Sergey. To me the XPath version seems correct here. So both we and MySQL are wrong. Though the JSON_Extract function is the MySQL-s invention so it's tempting to make it working like they do. So i'm in doubt how to fix this. A. On Fri, Nov 20, 2020 at 12:18 AM Sergey Petrunia wrote: > Hi

Re: [Maria-developers] New patch on the JSON_TABLE.

8PM +0400, Alexey Botchkov wrote: > > Hi, Sergei!. > > > > so the branch name is 'bb-mdef17399-hf'. > > It has slightly changed since last patch so please pay attention. > > > > There i present the patch that resolves issues that you mentioned > > in your l

Re: [Maria-developers] [Commits] MDEV-16166 RBR breaks with HA_ERR_KEY_NOT_FOUND upon DELETE

Ok to push. 05.06.2018 13:45, Sachin Setiya wrote: commit bde95bc70d0ac011f55f1b3b55fee1c9276859da Author: sachin > Date:   Tue Jun 5 15:14:19 2018 +0530     MDEV-16166 RBR breaks with HA_ERR_KEY_NOT_FOUND upon DELETE from table...     with spatial index    

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

ets for those two issues (or at least for the first one). Regards Mattias On Thu, Apr 26, 2018 at 11:26 AM, Alexey Botchkov <holyf...@mariadb.com <mailto:holyf...@mariadb.com>> wrote: No, there's no JIRA task for that problem. So i guess you can create one :) Best

Re: [Maria-developers] Questions regarding closing partitions in MDEV-11084

Hi, Mattias, guys! While investigating the crash, i'd like to discuss that it seems to close partitions whenever it is not used in a statement (i.e. require it to be reopened in the next statement that would use another partition Yes, it does that, handling statements with the specified

Re: [Maria-developers] Please review MDEV-11292 Item_func_sp::fix_length_and_dec() does not set collation derivation properly

The patch looks ok with me. Best regards. HF 17.11.2016 6:58, Alexander Barkov wrote: Hello Alexey, Please review a patch for MDEV-11292 (for 10.3). Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to :

Re: [Maria-developers] 0310b44: MDEV-10418 Assertion `m_extra_cache' failed in ha_partition::late_extra_cache(uint)

2;' query. Best regards. HF 21.12.2016 0:35, Sergei Golubchik wrote: Hi, Alexey! On Dec 20, Alexey Botchkov wrote: revision-id: 0310b444dba1b9cbd6921963dd3bff689ca23a24 (mariadb-5.5.53-34-g0310b44) parent(s): f23b41b9b8a30e0e54a1ec7a8923057b0e57e0f5 committer: Alexey Botchkov timestamp: 2016

Re: [Maria-developers] [Commits] 41a12f9: MDEV-8320 Allow index usage for DATE(datetime_column) = const.

d_key_fields' lines would have to be changed. Best regards. HF 02.11.2016 2:38, Sergey Petrunia пишет: In-Reply-To: <20160928105123.6D948140DDC@nebo.localdomain> Hi Alexey, Thanks for your patience in waiting for the review. Please find it below. On Wed, Sep 28, 2016 at 02:50:19PM +0400, Alexey

Re: [Maria-developers] new PLUGIN API.

in some context inside the audit_notify functions for example) but not accessible in another. Best regards. HF 23.10.2016 15:55, Sergei Golubchik wrote: Hi, Alexey! On Oct 23, Alexey Botchkov wrote: Hi, Sergei. I'd like to draw your attention to this old issue: https://jira.mariadb.org/browse

Re: [Maria-developers] Rewiew requested.

Right. That's for 10.2. HF 24.10.2016 23:40, Sergey Petrunia wrote: Hi Alexey, I think this change is good. Which version is it going into? (I assume, 10.2?) On Mon, Oct 24, 2016 at 05:54:57PM +0400, Alexey Botchkov wrote: I'd like your opinion about this difference in the result

[Maria-developers] Rewiew requested.

Hi, Sergey. I'd like your opinion about this difference in the result of the null.test: -- --- /home/hf/wgit/cmt-mdev-9143/mysql-test/r/null.result 2016-10-23 13:33:54.050093010 +0400 +++

[Maria-developers] new PLUGIN API.

Hi, Sergei. I'd like to draw your attention to this old issue: https://jira.mariadb.org/browse/MDEV-7389 The idea was to make a bigger thing - to modify the plugin API so it is easier to use and let user to do more. Particularly to notify warnings to the audit plugins for this 7389 task. That

Re: [Maria-developers] review for MDEV-9143 (JSON).

how rapid is RapidJSON? why MySQL bothers with the new JSON field type? Best regards. HF 25.07.2016 14:10, Alexey Botchkov wrote: Hi, Sergei. I've requested your review on this, here are few additional notes. I ran some benchmarks comparing against MySQL5.7's JSON field type.

[Maria-developers] review for MDEV-9143 (JSON).

Hi, Sergei. I've requested your review on this, here are few additional notes. I ran some benchmarks comparing against MySQL5.7's JSON field type. And it seems that the difference in performance is negligible. For instance here are results for 20M rows with rather complicated JSON: Space

[Maria-developers] When SP DEFINER is empty.

Hi, Sergey, all. I'm in doubts about how this one should be fixed: https://jira.mariadb.org/browse/MDEV-10119 The story goes like this: - mysql_install_db script runs 'mysqld --skip-grant-tables' In this case the 'current_user()' seems to be empty. - so the CREATE PROCEDURE command

Re: [Maria-developers] JSON libraries

http://www.json.org/JSON_checker/ 31.05.2016 16:53, Sergey Petrunia wrote: On Tue, May 31, 2016 at 03:35:22PM +0400, Alexey Botchkov wrote: .. That JSON_CHECKER was produced by JSON.org itself, is really fast and nice. But it's not a parser - it just checks if the text makes the correct JSON

[Maria-developers] JSON libraries

Hi. So i spent quite some time trying to get in use an existing JSON-parsing libraries. But surprisingly enough none seemed to be good enough. Problems i met were like this: 1. Parsers are just slow. - because they copy data - particularly key names and values. - because they use

Re: [Maria-developers] c75cbc1: MDEV-717 LP:1003679 - Wrong binlog order on concurrent DROP schema and

> Your test here expects "either ER_BAD_DB_ERROR or a success". > I asked - does that mean that even with your debug_sync points the result is still non-deterministic? Ah, got it. The test is deterministic, so we should only wait for the BAD_DB_ERROR. Will remove the '0'. Best regards. HF.

Re: [Maria-developers] c75cbc1: MDEV-717 LP:1003679 - Wrong binlog order on concurrent DROP schema and

, it's just a thought I had when looking at that line in the patch. On May 03, Alexey Botchkov wrote: revision-id: c75cbc19806223be8e750c27ba0bd4b17ef61f54 (mariadb-10.1.13-24-gc75cbc1) parent(s): 94cd0f6c9b3b04db67501ef29d470f32527ceda2 committer: Alexey Botchkov timestamp: 2016-05-03 13:20:12 +04

Re: [Maria-developers] ad8b439: MDEV-9618 solaris sparc build fails on 10.1.

ize_encryption_plugin(). It worked but then i needed to add the 'extern "C"' to the initialize_encryption_plugin() declaration. What would you suggest? HF. 02.05.2016 19:32, Sergei Golubchik wrote: Hi, Alexey! On May 02, Alexey Botchkov wrote: revision-id: ad8b4399f2fcd1d5e9dcdb8b2

[Maria-developers] MDEV-5513 merge audit api changes from 5.5.34.

Hello Sergei, all. I didn't quite understand what exact changes in 5.5.34 are important to us, so in order to begin i'm going to mention shortly what is new in MySQL 5.7 audit plugin API. 1. New event classes added: MYSQL_AUDIT_PARSE_CLASS= 2,

Re: [Maria-developers] [Commits] 50dc8c0: MDEV-8842 add group support to pam_user_map module.

) parent(s): bed4e847950eef50930b44632eea43416e7b37d1 committer: Alexey Botchkov timestamp: 2015-10-07 00:51:33 +0500 message: MDEV-8842 add group support to pam_user_map module. Added to the pam_user_map module. Looks pretty much ok. Just one suggestion: I'd keep groups in the pam_sm_authenticate

Re: [Maria-developers] [Commits] c934b5e: MDEV-8842 add group support to pam_user_map module.

21:43, Sergei Golubchik wrote: Hi, Holyfoot! On Oct 06, holyf...@askmonty.org wrote: revision-id: c934b5e661b19b7934d1a9af40afc70b727c2273 (mariadb-10.1.7-64-gc934b5e) parent(s): 90f2c822469a4f88f882ba8974e790f0fb0b2702 committer: Alexey Botchkov timestamp: 2015-10-06 14:02:29 +0500 message: M

Re: [Maria-developers] [Commits] 7ea735b: MDEV-8431 Feedback plugin needs an option for http proxy.

: 7ea735baa2df4f4577cf951bc69ccf87fd91f436 (mariadb-10.1.7-40-g7ea735b) parent(s): ba0b6685510f4a271da8d386ff75bfd83d3156c2 committer: Alexey Botchkov timestamp: 2015-10-05 14:46:12 +0500 message: MDEV-8431 Feedback plugin needs an option for http proxy. 'feedback_http_proxy' system variable added to specify the proxy

Re: [Maria-developers] [Commits] 7ea735b: MDEV-8431 Feedback plugin needs an option for http proxy.

-id: 7ea735baa2df4f4577cf951bc69ccf87fd91f436 (mariadb-10.1.7-40-g7ea735b) parent(s): ba0b6685510f4a271da8d386ff75bfd83d3156c2 committer: Alexey Botchkov timestamp: 2015-10-05 14:46:12 +0500 message: MDEV-8431 Feedback plugin needs an option for http proxy. 'feedback_http_proxy' system variable added to specify the pr

Re: [Maria-developers] Question regarding MDEV-7682

Hello, Vicențiu. In the SELECT you mentioned SELECT 1 FROM t1 NATURAL LEFT JOIN t1 AS t2 the SPATIAL key should not be used, just doesn't fit. And I must note that i couldn't reproduce the testcase as it was described. What i got was:

[Maria-developers] Additions to GIS in 10.1.

Hi all. What's new about GIS in 10.1. Related tasks in JIRA are: MDEV-4045 Missing OGC Spatial functions. MDEV-60 Support for Spatial Reference systems for the GIS data. MDEV-12 OpenGIS: create required tables: GeometryColumns, related views. Speaking shortly, the MariaDB GIS part is now

Re: [Maria-developers] [Commits] MDEV-60 Support for Spatial Reference systems for the GIS data.

Hi, Sergei. Would like a bit of your opinion before the revised patch. 21.10.2014 22:22, Sergei Golubchik пишет: First, please, please, *do not* send patches from Thunderbird. Sorry about that. diff --git a/sql/field.cc b/sql/field.cc --- a/sql/field.cc +++ b/sql/field.cc @@ -7808,6

Re: [Maria-developers] [Commits] Rev 4271: MDEV-6601 Assertion `!thd-in_active_multi_stmt_transa ction() || thd-in_multi_stmt_transaction_mode()' failed on executing a stored procedure with commit i

Hi, Sergei. I'd add SERVER_STATUS_LAST_ROW_SENT to the status_backup_mask. It's not necessary as I don't see it affecting anything, but just to make a sign that we don't want this status to go higher out of the call. Best regards. HF 25.08.2014 10:49, Sergei Golubchik wrote: At

Re: [Maria-developers] Rev 4077: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

? To close that issue with your patch? Eventually we will need to remove thd-clear_error() completely Agree. Best regards. HF 02.04.2014 2:37, Sergei Golubchik wrote: Hi, Alexey! On Mar 20, Alexey Botchkov wrote: This looks too complex to me. Why would you extend the base Internal_error_handler

Re: [Maria-developers] [Commits] Rev 3995: MDEV-5138 Numerous test failures in mtr --ps --embedded

to the client with the resulting recordset only. Best regards. HF 31.03.2014 7:33, Sergei Golubchik wrote: Hi, Alexey! On Mar 27, Alexey Botchkov wrote: Hi, Sergei. Why does embedded fail while a normal client-server protocol is ok with that? The difference is that the client checks

Re: [Maria-developers] [Commits] Rev 3991: MDEV-5138 Numerous test failures in mtr --ps --embedded

: 3991 revision-id: holyf...@askmonty.org-20131130132432-etlmes8qhhqhr1iu parent: ele...@wheezy-64.home-20131128160251-vn857wx5qlon6j1p committer: Alexey Botchkov holyf...@askmonty.org branch nick: mdev-5138 timestamp: Sat 2013-11-30 17:24:32 +0400 message: MDEV-5138 Numerous test failures in mtr

Re: [Maria-developers] [Commits] Rev 3995: MDEV-5138 Numerous test failures in mtr --ps --embedded

/ revno: 3995 revision-id: holyf...@askmonty.org-20131209020845-9o3l30ao90vzf600 parent: holyf...@askmonty.org-20131208143921-3veatgg9wngyzb47 committer: Alexey Botchkov holyf...@askmonty.org branch nick: mdev-5138 timestamp: Mon 2013-12-09 06:08:45 +0400

[Maria-developers] Two 10.0-related things.

Hi, Sergei. I'd like to share my recently obtained knowledge :) 1. Mac OS X and sockets. As you know there on Labrador machine that mysql-test-run.pl failed if not run with --tmpdir=/tmp. The problem apparently is that the /Users directory has the access restrictions that /tmp doesn't. I

Re: [Maria-developers] Rev 4077: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

, Holyfoot! On Feb 22, holyf...@askmonty.org wrote: revno: 4077 revision-id: holyf...@askmonty.org-20140222173543-xkzlp5rpga41evur parent: s...@mariadb.org-20140218065405-vw3bfhvhrfjsc6hh committer: Alexey Botchkov holyf...@askmonty.org branch nick: mdev-4856 timestamp: Sat 2014-02-22 21:35:43 +0400

Re: [Maria-developers] [GSOC 2014] GIS Enhancement

Hi, Bang. I think yes, the third coordinate operations should be implemented in that tool MariaDB is going to support that later anyway and we can specify the SQL syntax and other ways to input 3d points now. Best regards. HF 18.03.2014 22:36, bang honam wrote: Hi everybody. I am Honam

Re: [Maria-developers] MDEV-5681- audit log not rotating

Hi, Tan Tran. Your patch is quite correct. I just don't think the 'internal_stop_logging' and 'mark_always_logged' lines are superfluous in this case. And there are 2 more variables that don't effectively change it's value until restart logging. So i modified the patch with all that, it's

Re: [Maria-developers] GSOC 14: Discussion on GIS enhancements to MariaDB

Hi, Abhishek. You can look here for the possible tasks. https://mariadb.atlassian.net/browse/MDEV-5813 They're lower-medium complexity meaning coding scills. Of course one needs to familiarize oneself with the subject. Best regards. HF 06.03.2014 0:02, Abhishek Kumar wrote: Hi, I am

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Hi. As you didn't react on my last patch about it, i decided to remind: http://lists.askmonty.org/pipermail/commits/2014-February/005931.html Best regards. HF 19.02.2014 20:43, Sergei Golubchik wrote: Hi, Alexey! On Feb 19, Alexey Botchkov wrote: Hi, Sergei. Could you, please remove

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

, what is your opinion here? Best regards. HF 17.02.2014 20:30, Sergei Golubchik wrote: Hi, Alexey! On Feb 14, Alexey Botchkov wrote: But I don't understand that. Do you mean, old code did *not* suppress errors here? How could selects from I_S tables work without it? Here's how it works today

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

-20140131103303-1rx7ielo83f8iahe parent: holyf...@askmonty.org-20140124020722-dd5twtwlcc8o1xiy committer: Alexey Botchkov holyf...@askmonty.org branch nick: mdev-4856 timestamp: Fri 2014-01-31 14:33:03 +0400 message: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Re: [Maria-developers] uint6korr optimization

Thanks for the suggestions, Kristian. I for some reason didn't notice that __builtin_bswap things. Best regards. HF 23.01.2014 19:51, Kristian Nielsen wrote: Kristian Nielsen kniel...@knielsen-hq.org writes: Do it like this: static inline ulonglong mi_uint6korr(const void *p) { uint32 a=

[Maria-developers] MDEV-5273

Hi, Serg, all. I'm not sure how about fixing this one: https://mariadb.atlassian.net/browse/MDEV-5273 So would like your opinion. The thing is that the SHOW commands with old-fasioned implementations (those that aren't mapped to the SELECT FROM information_schema.something) return

Re: [Maria-developers] uint6korr optimization

Widenius wrote: Hi! Alexey == Alexey Botchkov holyf...@askmonty.org writes: Alexey Hi, Monty. Alexey I've looked at that part of the code, and tried to make the improved Alexey versions of uint6korr and mi_uint6korr. Alexey The small program attached that benchmarks these. Alexey Depending on enabled

Re: [Maria-developers] [Spatial] On current implementation approach

Loskot wrote: On 23 September 2013 22:10, Alexey Botchkov holyf...@askmonty.org wrote: 1. Is it possible to implement MariaDB extensions like Spatial (custom type + set of functions) without such a tight coupling with the internal implementation of the type system (without messing Field class

Re: [Maria-developers] MDEV-4472 Audit-plugin. Server-related part of the task

07.09.2013 16:14, Sergei Golubchik wrote: Hi, Holyfoot! + //local_mysql_data_home= (char *)GetProcAddress(0, mysql_data_home); +//#else + //local_mysql_data_home= mysql_data_home; +//#endif /*_WIN32*/ I think you can completely remove this and the #ifndef above. For your MySQL plugin you can

Re: [Maria-developers] Rev 3876: MDEV-4472 Audit-plugin. Server-related part of the task

03.09.2013 16:02, Sergei Golubchik wrote: Hi, Holyfoot! unsigned long long general_rows; + /* Added for 0x302 */ A bit confusing. Better Added in version 0x0302 Fixed. + long long query_id; should it rather be unsigned? For the THD structure we have: typedef int64 query_id_t; So

Re: [Maria-developers] Rev 3876: MDEV-4472 Audit-plugin. Server-related part of the task

04.09.2013 16:06, Sergei Golubchik wrote: Hi, Alexey! On Sep 04, Alexey Botchkov wrote: 03.09.2013 16:02, Sergei Golubchik wrote: + long long query_id; should it rather be unsigned? For the THD structure we have: typedef int64 query_id_t; So that it's originally unsigned. You mean

Re: [Maria-developers] MDEV-4472 (audit plugin)

into a service? Ok, will do right after this task (so it won't be forgotten). But yes, I think it's better to do it separately. Best regards. HF 02.07.2013 14:34, Sergei Golubchik wrote: Hi, Alexey! On Jul 01, Alexey Botchkov wrote: Hi, Serg. Here is the last version of the plugin for your

Re: [Maria-developers] MDEV-4472 (audit plugin)

wrote: Hi, Alexey! On Jun 25, Alexey Botchkov wrote: Modified version of the file is in the same place: Ok ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https

[Maria-developers] MDEV-4472 (audit plugin)

Hi, Sergei. Here is the plugin code for you to check out. It constists of a single new file, so i send you the link to it. http://myoffice.izhnet.ru/~alex/server_audit/server_audit.c What's missing in it as i'm not sure how it can be done: - No server host/ip in the log. How get that

Re: [Maria-developers] Rev 3497: MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE (MWL #252)

Hi, Sergei. remove your new opt_if_not_exists_ident rule, write it like - normal_key_type opt_ident key_alg '(' key_list ')' + normal_key_type opt_if_not_exists opt_ident key_alg '(' key_list ')' I don't think it's a good idea. The 'opt_if_not_exists_ident' actually has the

Re: [Maria-developers] Rev 3663: MDEV-3819 missing constraints for spatial column types

+ERROR HY000: Incorrect POLYGON value: 'POINT' I'm sorry, but you got it backwards :) The value above is POLYGON. The type is POINT. The error message should be ERROR HY000: Incorrect POINT value: 'POLYGON' Regards, Sergei How do you know the difference i wonder :) But fine, fixing

Re: [Maria-developers] Summary of the MDEV-3882 (.deb upgrade from mysql to mariadb fails due to apt-get considering it a downgrade)

Hello. would help us only temporarely - to the moment Oracle releases even later' version. We can use epoch to ensure that our version will always be bigger than the official Debian/Ubuntu version of MySQL: http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version

Re: [Maria-developers] MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE

18.12.2012 15:30, Sergei Golubchik wrote: And one more thing. It's easy to imagine a user that likes to do the ALTER IF EXISTS queries often. But even if the 'new_field' exists already, ADD FIELD IF EXISTS new_field still does a lot. The list of calls is: mysql_create_table_no_lock() -

Re: [Maria-developers] MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE

30.07.2012 18:27, Sergei Golubchik wrote: Hi, Alexey! First: You didn't include all my comments in your reply. Should I assume that all omitted comments you simply agree with and you will change the patch accordingly? That's right. Why did you do that in a separate function? You have

Re: [Maria-developers] MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE

$ bzr diff dif2 bzr: ERROR: exceptions.UnboundLocalError: local variable 'diff_file' referencedbefore assignment Python is sentisive to indentation levels. May be you've messed up the whitespace when copy-pasting from the kb? I'll attach the correct __init__.py to this

Re: [Maria-developers] MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE

11.07.2012 20:14, Sergei Golubchik wrote: +Note 1061Duplicate key name 'x_param' +ALTER TABLE t1 ADD KEY IF NOT EXISTS x_param(x_param); typo? you test ADD KEY IF NOT EXISTS twice. Yes, but not this line. The 'KEY x_param' wasn't supposed to be created with the CREATE TABLE.

Re: [Maria-developers] MDEV-318 IF (NOT) EXIST clauses for ALTER TABLE

Hi, Sergei. +++ sql/field.cc2012-07-11 14:28:40 + @@ -9182,6 +9182,7 @@ void Create_field::init_for_tmp_table(en First: please, see the last section in http://kb.askmonty.org/en/how-to-get-more-out-of-bzr-when-working-on-mariadb/ and do as it suggests I had to apply your patch

Re: [Maria-developers] MDEV-136 Non-blocking set read_only

Sergei, Here is the new patch: http://lists.askmonty.org/pipermail/commits/2012-May/003324.html I tested things in various ways, and it seems working decent. 1st client: LOCK TABLE t1 WRITE; done 2nd client: SET READ_ONLY=1; if the t1 is MyISAM, it hangs until t1

Re: [Maria-developers] MDEV-136 Non-blocking set read_only

Sergei, 11.05.2012 19:44, Sergei Golubchik wrote: === modified file 'mysql-test/r/read_only.result' --- a/mysql-test/r/read_only.result 2009-03-06 14:56:17 + +++ b/mysql-test/r/read_only.result 2012-05-09 18:59:45 + @@ -59,7 +59,7 @@ connection con1; select

Re: [Maria-developers] MDEV-136 Non-blocking set read_only

16.05.2012 12:48, Michael Widenius написал: Holyfoot, how did you test this feature? I started a long-running query in one session, then ran the 'SET GLOBAL read_lock=1' in another. After the change the 'SET read_lock' doesn't wait for the INNODB to complete the query. Regards HF

Re: [Maria-developers] [Commits] Rev 3145: MDEV-80 Memory engine table full at much less than max_heap_table_size with btree index. in file:///home/hf/wmar/mdev80/

Sergei, 06.04.2012 1:21, Sergei Golubchik wrote: Hi, Holyfoot! So, does that mean you've managed to reproduce the bug? Or you just found a possible cause for such a behavior and fixed it? I finally found out how to reproduce this bug and verified the fix cures the problem. (thanks to Jason

Re: [Maria-developers] [Commits] Rev 3145: MDEV-80 Memory engine table full at much less than max_heap_table_size with btree index. in file:///home/hf/wmar/mdev80/

06.04.2012 1:21, Sergei Golubchik wrote: So, does that mean you've managed to reproduce the bug? If you're interested i've reproduced this bug on our terrier machine as well. Thought it takes about half-an-hour to happen. Takes the eternity with the debug build. Regards. HF

Re: [Maria-developers] Please fix: innodb_plugin.innodb_gis fails on 'gcov' builder

Well there is the --source include/have_innodb_plugin.inc there in the test. The problem is that this checks for 'have innodb or xtradb', and we don't have create table t engine=innodb or xtradb; Will decide something a bit later. Regards HF 14.12.2011 19:03, Kristian Nielsen wrote: Sergei

Re: [Maria-developers] [Commits] Rev 2983: WL#77 - INSTALL PLUGIN * in http://bazaar.launchpad.net/~maria-captains/maria/5.2/

I'm fine with this last patch. One thing i can think of is if we should add a new error instead of adding static english texts to the ER_CANT_OPEN_LIBRARY like 'API version for ... plugin ... not supported'. Second question if we should have INSTALL PLUGIN ... IF NOT INSTALLED; to be even more