Varun,
1. The mdev # in the test case should be 12145
2. Could you please explain why do you need
> @@ -9735,8 +9735,7 @@ make_join_select(JOIN *join,SQL_SELECT
*select,COND *cond)
>!(used_tables & tab->emb_sj_nest->sj_inner_tables))
>{
> save_used_tables=
On 04/22/2016 03:10 PM, Sergei Golubchik wrote:
> Hi, Igor!
>
> On Apr 15, Igor Babaev wrote:
>>
>> Please help me if you are aware of such code.
>> In my case the tables are similar.
>> I understand that it's easy to write this code.
>> (Read rows from t
Hi,
Please help me if you are aware of such code.
In my case the tables are similar.
I understand that it's easy to write this code.
(Read rows from the source table one by one
updating the destination table).
Still I would prefer to use the existing code.
Regards,
Igor.
Sergey,
I fixed the problem and pushed the fix.
Regards,
Igor.
On 04/04/2016 01:15 PM, Sergey Petrunia wrote:
> Hello Igor,
>
> I'm trying this example:
>
> create table t1 (a int, b int);
> insert into t1 values (1,1),(2,2),(3,3);
>
> select rank() over (order by a), rank() over (order by
Sanja,
Correct the comment for the commit and push.
The only question I have concerns another comment:
+# MDEV-5515: sub-bug nets of 3rd execution crash
^ Is this an intended word?
Regards,
Igor.
On 07/28/2014 05:36 AM, sa...@askmonty.org wrote:
At
On 02/21/2014 04:14 PM, Sergey Petrunia wrote:
Hello,
I was looking at how to make extended_keys=ON by default in 10.0.
There haven't been any bugs in the feature for quite some time, but we still
have a question of how to be with the testsuite (do we run it with
extended_keys=OFF, the
On 10/10/2013 07:42 AM, Sergei Petrunia wrote:
Hi Sanja,
My experiment was successfull. It seems, one can fix identation in
sql_join_cache.cc so in the following way:
Great!
Regards,
Igor
# Create a branch in a state right after the problem
bzr branch
trace. The most important: the optimizer trace does not actually
explain WHY the chosen alternative is REALLY better than rejected ones:
the calculation of the costs remains under the cover.
Regards,
Igor.
Just my $.02.
-Zardosht
On Mon, Jun 17, 2013 at 10:37 PM, Igor Babaev i
On 06/17/2013 04:24 PM, Roberto Spadim wrote:
hi guys, i was reading mysql 5.6 and 5.7 manual
i know that mariadb is very different (a bit) than mysql internally
there's a mysql merge issue or something like that i can see what will
be merged and what not?
i like the partition lock prune,
On 04/22/2013 03:45 PM, Daniel Bartholomew wrote:
I've begun prepping MariaDB 10.0.2-alpha for release.
Draft changelog and release notes are here:
- https://kb.askmonty.org/en/mariadb-1002-release-notes/
- https://kb.askmonty.org/en/mariadb-1002-changelog/
Daniel,
Don't forget about:
-
have a separate branch
when Unique fits the allocated memory:
to get the count in this case we just take it from the
RB tree of the Unique object, bypassing the tree retrieval.
Regards,
Igor.
Any reason this will not work?
On Sun, Mar 24, 2013 at 10:20:41AM -0700, Igor Babaev wrote:
On 03
Timour,
It's ok to push this patch as a fix.
Yet remember that this fix leads us to a performance regression
5.2 5.3 when the range expression contains a constant [single-row]
subquery.
This is due to the changes when and how we build range trees in 5.3.
When we have a range expression with
Hi Sergey,
I looked through your code trying to figure out in what direction you
are moving. If my understanding of the code is correct you move in the
right direction.
Here are some general notes.
Ideally I would like to see the following architecture (I ignore here
the fact that we have to
On 01/11/2013 09:33 PM, Matthew Lagoe wrote:
I was talking with a few people about a query such as
|select * from table order by X, Y, Z limit G;|
As the ORDER BY for me could change to any number of 12 values in any
order I am not able to use a multicolumn index as such I was
(), table.cc (mariadb)
You have to change it.
There is a similar code in mysql, also in open_binary_frm(),table.cc
Regards,
Igor.
On Sun, Dec 16, 2012 at 10:58 PM, Igor Babaev i...@askmonty.org wrote:
On 12/14/2012 11:33 AM, Rich Prohaska wrote:
MySQL 5.6.9 changed how the number of key
On 12/14/2012 11:33 AM, Rich Prohaska wrote:
MySQL 5.6.9 changed how the number of key parts are measured. They
replaced one simple counter (key_parts) with four counters. Glancing
at the code, i assume that this was done to support extended keys. If
so, the mariadb implementation of
are in GA anyway.
Regards,
Igor.
On Thu, Nov 01, 2012 at 02:54:34PM -0700, Igor Babaev wrote:
At file:///home/igor/maria/maria-5.3-mdev585/
revno: 3589
revision-id: i...@askmonty.org-20121101215433-ctfm3zfhc6uhuy3i
parent: pser
too much in reducing the test case. Would you agree that
I push your patch without a test case?
I think you still have to add the test case case (in a separate file)
that is run with the --big option.
Regards,
Igor.
Timour
On 20.10.2012 08:56, Igor Babaev wrote:
On 10/19/2012 12:43 PM
On 10/22/2012 07:54 AM, Igor Babaev wrote:
On 10/22/2012 12:53 AM, Timour Katchaounov wrote:
Igor,
Great, the patch indeed fixes the bug both on 5.3 and 5.5, however the
reduced test case I produced still takes 21 MB, and I was not successful
in reducing it to a size that can be added
On 10/19/2012 12:43 PM, Timour Katchaounov wrote:
Hi Igor,
Could you please look at this bug
https://mariadb.atlassian.net/browse/MDEV-3801,
and read my last comment. The bug may be (just a guess ATM) related to
index
creation on the temporary table created for the derived table. Since
On 05/19/2012 04:22 AM, Sergei Golubchik wrote:
Hi, Igor!
On May 10, Igor Babaev wrote:
Serg,
Here's the patch we talked about on IRC today.
...
+ANALYZE TABLE t1(COLUMN(), INDEX());
+ANALYZE TABLE t1(COLUMN(c,e,b), INDEX(idx2,idx4));
+ANALYZE TABLE t1(COLUMN(*), INDEX(*));
I see
Serg,
All,
On 05/19/2012 10:51 AM, Sergei Golubchik wrote:
Hi, Igor!
On May 19, Igor Babaev wrote:
On 05/19/2012 04:22 AM, Sergei Golubchik wrote:
On May 10, Igor Babaev wrote:
Alternatively, it could have an explicit PERSISTENT keyword:
ANALYZE TABLE t1 PERSISTENT; -- meaning all
On 03/23/2012 02:41 PM, Sergei Petrunia wrote:
Hello Igor,
Could you please review the below:
Hi Sergey,
Here's my feedback:
- Forwarded message from Sergey Petrunya pser...@askmonty.org -
From: Sergey Petrunya pser...@askmonty.org
To: comm...@mariadb.org
X-Mailer: mail
On 02/17/2012 08:00 AM, Sergei Petrunia wrote:
Hi Timour,
So, we're trying to fix this by making group-by-loose-scan access method be
able to scan forwards (when evaluating MIN) and/or backwards (if evaluating
MAX) until it finds a record that satisfies the WHERE condition.
We still need
On 01/08/2012 02:46 AM, Sergei Petrunia wrote:
Hello Igor, Timour
Could anybody of please review the below fix?
additional details about the problem were posted at
https://mariadb.atlassian.net/browse/MDEV-67.
Sergey,
After the discussion with you on skype I reviewed Timour's code
if
it be a reference to Monty's
opinion?I have to admit it would be pretty pretty lame.
Regards,
Igor.
Timour
On 3.01.2012 06:06, Igor Babaev wrote:
At file:///home/igor/maria/maria-5.3-bug910083/
revno: 3376
revision-id: i
client.
I returned the code that you removed. I don't think I have to explain
why you were wrong.
Timour
Regards,
Igor.
Timour
On 3.01.2012 06:06, Igor Babaev wrote:
At file:///home/igor/maria/maria-5.3-bug910083/
revno
OK to push.
Regards,
Igor.
On 09/28/2011 07:23 AM, Timour Katchaounov wrote:
Hi Igor,
Could you please review the following fix.
It is very much related to a bug you fixed:
https://bugs.launchpad.net/bugs/702301
Thanks,
Timour
Original Message
Return-Path:
Hi,
Here are the results for DBT3 query set I've got on my laptop with
MariaDB 5.3.0 installed.
[ Dell Latitude E6510: 4-cores with multithreading (8 threads in total)
Memory: 8GB, SSD,
SuSE 11.3 ]
DBT3 factor 10 (60M rows in lineitem) built for InnoDB.
Mysqld was launched with the
On 07/13/2011 02:34 PM, Timour Katchaounov wrote:
Igor,
Could you please review this fix for bug lp:809266.
Timour,
If you have full coverage of the new code from the patch
then you may push it.
Regards,
Igor.
Timour
On 07/13/2011 07:38 AM, Timour Katchaounov wrote:
Igor,
Could you please review my patch for bug LP:809245.
Ttimour
Timour,
It's ok to push this patch
Regards,
Igor.
Original Message
Return-Path: commits-boun...@mariadb.org
X-Original-To: tim...@askmonty.org
On 06/04/2011 02:19 AM, Sergey Petrunya wrote:
Hi!
All of the recent 5.3 builds in buildbot have two failures:
innodb_plugin.innodb_bug54044 'innodb_plugin'
innodb_plugin.innodb_information_schema 'innodb_plugin'
The failure happens only with innodb_plugin. XtraDB is fine.
I've
On 04/23/2011 05:26 PM, Sergey Petrunya wrote:
On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote:
Hello Igor,
First, an overall comment: there are lots of typos/coding style violations in
the patch. To reduce amount of effort spent on such things, I was just
fixing
them as I
On 02/28/2011 01:31 PM, Sergey Petrunya wrote:
Hello Igor,
Could you please review the below:
Ok to push.
Regards,
Igor.
- Forwarded message from Sergey Petrunya pser...@askmonty.org -
From: Sergey Petrunya pser...@askmonty.org
To: comm...@mariadb.org
X-Mailer: mail (GNU
Hi,
I've just reported bug #611648 that probably explains the strange
results I had when trying to run my benchmark queries for DS-MRR
about which I talked at today's optimizer meeting.
Philip, please assign this bug to SergeyP.
Regards,
Igor.
___
On 01/19/2011 02:32 PM, Sergey Petrunya wrote:
Hello,
index_merge uses @@sort_buffer_size as a guide of how much space it can use
for
sorting. I think there is an issue with the way it is done.
Before index_merge was introduced, @@sort_buffer_size was used only by
filesort (also for
: i...@askmonty.org-20091112043128-yd6odg8zr5ribjal
parent: pser...@askmonty.org-20091104224158-nk2s2luvlqwa02bl
parent: i...@askmonty.org-20091110023239-vgttyweq2qmh0y25
committer: Igor Babaev i...@askmonty.org
branch nick: maria-5.2-vcol
timestamp: Wed 2009-11-11 20:31:28
Sanja.
Ok to push after the required changes in comments
Regards,
Igor.
sa...@askmonty.org wrote:
At file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/
revno: 2977
revision-id:
On 11/19/2010 08:17 AM, Daniel Bartholomew wrote:
All,
I've created the download, release notes, and changelog pages for
MariaDB 5.1.51:
http://askmonty.org/wiki/MariaDB:Download:MariaDB_5.1.51
http://kb.askmonty.org/v/mariadb-5151-release-notes
Daniel Bartholomew wrote:
On Fri, 19 Nov 2010 09:04:17 -0800
Igor Babaev i...@askmonty.org wrote:
Igor * MySQL Bug #51242
Igor http://bugs.mysql.com/bug.php?id=51242 /HAVING clause on table
Igor join produce incorrect results/
Igor
Igor Daniel,
Igor
Igor this 'fix' was reverted
On 11/15/2010 04:45 AM, Philip Stoev wrote:
Igor,
As you have noticed I have started filing bugs that require 4-5
tables, self joins, etc. to show up. I continue running the same tests
as before, it is just that the 2-table bugs have all been fixed by now.
While I do consider 4-5 table bugs
Jocelyn Fournier wrote:
Hi,
There's a really annoying bug in the mysql optimiser existing for a
really long time now, and which has a direct impact on performances :
http://bugs.mysql.com/bug.php?id=36817
Since MySQL definitly doesn't seem to want to fix it, I hope MariaDB
could do
Dan Meany wrote:
One thing about dynamic columns is that they have sped up our development
cycle by a factor of 5, since we are not spending time on hard coded binding
layers, and analysts can create application tables instead of developers and
DBAs. We have other mechanisms in place to
#At lp:maria based on revid:i...@askmonty.org-20091103182103-jnjuss2b4t72rz83
2750 Igor Babaev 2010-06-28
An implementation of index intersect via a modified Unique class.
This code is planned to be used for mwl#21.
modified:
include/my_tree.h
mysys/tree.c
#At lp:maria based on
revid:kniel...@knielsen-hq.org-20091130132430-edrwle5zh6udx9rp
2779 Igor Babaev 2010-06-28
Optimization that checks for expressions whether they are always null.
modified:
mysql-test/r/func_in.result
sql/item.h
sql/item_cmpfunc.cc
ones where parts of the key cache will behave
themselves differently.
Regards,
Igor.
Henrik Ingo wrote:
On Mon, May 17, 2010 at 9:14 PM, Igor Babaev i...@askmonty.org wrote:
1. the author of the original patch
2. our community members (not only PeterZ!)
3. our developers
what term they prefer
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100513065914-yq9y2pbd9zn2fm7w
2791 Igor Babaev 2010-05-18
Fixed bugs in the backport of derived tables (mwl106).
modified:
mysql-test/r/derived_view.result
mysql-test/r/table_elim.result
sql
into MariaDB by Igor Babaev
from Monty Program.
--
If there are any factual errors with the above, let me know.
Improvements and suggestions are also welcome.
One thing I'm not happy with is this sentence:
Threads compete
Hi Daniel,
Daniel Bartholomew wrote:
Hello everyone,
Summarizing from my previous email: I'm working on the documentation for
the Segmented Key Cache, one of the new features in MariaDB 5.2. My
previous email was about the About section of the documentation. This
email is about the Syntax
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100512040958-yc654eq2zdfo8l8m
2790 Igor Babaev 2010-05-12
Cleanup
modified:
sql/sql_derived.cc
=== modified file 'sql/sql_derived.cc'
--- a/sql/sql_derived.cc2010-05-12 04:09:58 +
+++ b/sql/sql_derived.cc
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100429211039-rp1mza3xjeqd4t1w
2789 Igor Babaev 2010-05-11
Fixed several bugs in the backport code (mwl#106).
modified:
mysql-test/r/innodb_lock_wait_timeout_1.result
mysql-test/r/lock_multi_bug38499.result
= make_cond_for_table(curr_join-tmp_having,
used_tables,
used_tables);
Regards,
Igor.
3447 Igor Babaev2010-05-02
Fixed bug #53334.
The fix actually reverts the change introduced by the patch
Hi!
Kristian Nielsen wrote:
Hi Igor, Timour, Sergey,
Can one of you please check this patch from MySQL 5.1.46? It is a commit to
fix http://bugs.mysql.com/bug.php?id=51494
This patch introduces a regression:
http://bugs.mysql.com/bug.php?id=53334
If I revert the patch, the
#At lp:maria based on revid:mo...@askmonty.org-20100408115657-lxjm4cpvi4zp81rk
2845 Igor Babaev 2010-04-08
Fixed a problem of merge from mysql-5.1 baseline.
modified:
sql/sql_select.cc
=== modified file 'sql/sql_select.cc'
--- a/sql/sql_select.cc 2010-03-10 09:12:23
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100405202809-beg2cwhelygpbl6i
2750 Igor Babaev 2010-04-05
Post review fixes.
modified:
include/keycache.h
mysql-test/suite/funcs_1/r/is_columns_is.result
mysql-test/suite/funcs_1/r/is_tables_is.result
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100331231003-9gvmv2y8384kbqfa
2746 Igor Babaev 2010-03-31
Made the results of the key_cache test to be platform independent.
modified:
mysql-test/r/key_cache.result
mysql-test/t/key_cache.test
=== modified
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100317023231-w7h0euroof0lul8e
2745 Igor Babaev 2010-03-18
Made the vcol suite independent on time zone.
modified:
mysql-test/suite/vcol/inc/vcol_supported_sql_funcs_main.inc
mysql-test/suite/vcol/r
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20100319062332-4ghnaoaxcgagwj3m
2746 Igor Babaev 2010-03-19 [merge]
Merge
modified:
configure.in
mysql-test/Makefile.am
=== modified file 'configure.in'
--- a/configure.in 2010-03-15 11:51:23 +
+++ b
#At lp:maria/5.2 based on revid:ser...@pisem.net-20100315115123-21tgprclhz7qbk6m
2744 Igor Babaev 2010-03-16
Fixed bug #539643.
The cause of the problem is a bad merge MariaDB-5.1=MariaDB-5.2.
Added the vcol suite to the list of the default suites run
Daniel Bartholomew wrote:
On Sat, 13 Mar 2010 09:34:22 +0100
Kristian Nielsen kniel...@knielsen-hq.org wrote:
Kristian One thing we could do is disable the worklog...@askmonty.org
Kristian alias (eg. send it to /dev/null). This should disable sending
Kristian the mails to the mailing list
#At lp:maria/5.2 based on
revid:pser...@askmonty.org-20100225080910-38wapbgw5vpm6nax
2771 Igor Babaev 2010-03-04
Corrected Evgen's fix for bug #45191.
Made sure that join buffers could be used for inner tables of
any semi-join when the first match strategy is employed
#At lp:maria/5.2 based on
revid:i...@askmonty.org-20091221022615-kx5ieiu0okmiupuc
2740 Igor Babaev 2009-12-21 [merge]
Merge from 5.2-dsmrr
modified:
mysql-test/r/innodb_mrr.result
mysql-test/r/type_date.result
=== modified file 'mysql-test/r/innodb_mrr.result
Kristian,
There should be a common sense after all.
Adding 7K files from boost doesn't comply with a common sense.
no matter what Arjen thinks about it.
If oqgraph cannot do without boost in the MariaDB development tree we'd
better drop oqgraph.
Regards,
Igor.
Sergei Golubchik wrote:
Hi,
#At lp:maria based on revid:mo...@mysql.com-2009111749-dnv4ams2mnb8b8rp
2765 Igor Babaev 2009-11-11
Corrected a line from the patch for table elimination (WL#17)
to fix a problem with the test case for bug#42116.
modified:
sql/sql_select.cc
=== modified file
#At lp:maria based on revid:i...@askmonty.org-20091026173514-biry7lgxqiz2zz7a
2747 Igor Babaev 2009-10-29
Replaced a lame implementation of the function sel_trees_must_be_ored
that blocked building index merge plans for the queries with where
conditions of the form
#At lp:maria based on revid:i...@askmonty.org-20091029184958-1b1iyhu09sihxc6o
2748 Igor Babaev 2009-10-29
Fixed a bug in the code of the patch for WL#24 that manifested
itself when running the pbxt.group_min_max test leading to
wrong result sets and execution plans
#At lp:maria based on revid:i...@askmonty.org-20090920030226-xxh7a4i3gre9rqhe
2754 Igor Babaev 2009-09-24
Took care of mysql test suite failures on Windows.
modified:
mysql-test/suite/rpl/t/rpl_binlog_corruption.test
mysql-test/suite/rpl/t/rpl_killed_ddl.test
vio/viosocket.c
#At lp:maria based on revid:i...@askmonty.org-20090925064243-2kf7ah4m6u25ex58
2755 Igor Babaev 2009-09-24 [merge]
Merge
modified:
mysql-test/r/create.result
mysql-test/r/information_schema.result
mysql-test/t/information_schema.test
mysql-test/t/not_embedded_server.test
sql
#At lp:maria based on revid:i...@askmonty.org-20090919212129-p3ydr02t0es1py7y
2752 Igor Babaev 2009-09-19 [merge]
Merge
modified:
mysql-test/mysql-test-run.pl
mysql-test/r/myisam.result
mysql-test/suite/maria/r/maria3.result
mysql-test/t/myisam.test
sql/sql_table.cc
#At lp:maria based on revid:i...@askmonty.org-20090919221119-bpy6nqq2xmn64dh4
2753 Igor Babaev 2009-09-19
Applied the fix for bug #47016 - a failure of rpl_do_grant
watched on Windows.
modified:
mysql-test/suite/rpl/t/rpl_do_grant.test
=== modified file 'mysql-test/suite/rpl
#At lp:maria based on revid:i...@askmonty.org-20090918190257-descsgkvdgbqtfgq
2750 Igor Babaev 2009-09-18
Made innodb_xtradb_bug317074.test to be a 'big' test
to avoid a timeout failure of it on Windows.
modified:
mysql-test/t/innodb_xtradb_bug317074.test
=== modified file
Kristian Nielsen wrote:
Igor Babaev i...@askmonty.org writes:
#At lp:maria based on revid:i...@askmonty.org-20090916174301-lzzh1r0khn3dxwvp
2744 Igor Babaev2009-09-16
Fixed a failure of the merge_innodb test on windows.
modified:
storage/myisammrg/ha_myisammrg.cc
#At lp:maria based on
revid:kniel...@knielsen-hq.org-20090916120716-ssmx93bg4znld9l8
2743 Igor Babaev 2009-09-16
Fix of bug #417751 by Yasufumi Kinoshita.
modified:
storage/xtradb/srv/srv0start.c
=== modified file 'storage/xtradb/srv/srv0start.c'
--- a/storage/xtradb/srv
73 matches
Mail list logo
