Re: [Maria-developers] MDEV-14785 SYSTEM_INVISIBLE behaviour not consistent ---Initial Patch

2018-01-29 Thread Sergei Golubchik
+my_error(ER_BAD_FIELD_ERROR,MYF(0), > +field->field->field_name.str, > +field->field->table->s->table_name.str); > +DBUG_RETURN(TRUE); > + } > +} > + } Dunno. What if I do UPDATE ... SET normal_field =

Re: [Maria-developers] [Commits] Mdev-15085 Rebased to latest 10.3

2018-01-29 Thread Sergei Golubchik
d to do here (and it doesn't depend on AUTO_INCREMENT_FLAG or field->default_value), you need to set all_fields_have_values to false. Like if (field->invisible) { all_fields_have_values= false; continue; } Indeed, hidden columns did not get a value, so all_fields_have_values

[Maria-developers] Wording suggestion?

2018-01-29 Thread Sergei Golubchik
of "simultaneously" (and the statement above would swap the values). What could the name for this new sql_mode be? Regards, Sergei ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net U

Re: [Maria-developers] MDEV-13790 UNHEX() of a somewhat complicated CONCAT() returns NULL

2018-01-29 Thread Sergei Golubchik
Hi, Alexander! On Jan 29, Alexander Barkov wrote: > Hi Sergei, > > Thanks for review. Comments follow inline: ok to push Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-develo

Re: [Maria-developers] 980a5c31880: MDEV-14572: Assertion `! is_set()' failed in Diagnostics_area::set_eof_status upon EXPLAIN UPDATE in PS

2018-01-28 Thread Sergei Golubchik
Hi, Oleksandr! On Jan 28, Oleksandr Byelkin wrote: > Hi, Sergei! > > Flag in SELECT_LEX options dropped at the end of execution (in our case > prepare). All commands where EXPLAIN is possible restore the flag in main > SELECT_LEX (in mysql_explain_union()) except UPDATE (because

Re: [Maria-developers] MDEV-13790 UNHEX() of a somewhat complicated CONCAT() returns NULL

2018-01-28 Thread Sergei Golubchik
Hi, Alexander! On Nov 03, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-13790. > > It removes the attempt to search the best suitable buffer > and just returns the result in "str" passed to val_str(). > > I'm quite sure this op

Re: [Maria-developers] 980a5c31880: MDEV-14572: Assertion `! is_set()' failed in Diagnostics_area::set_eof_status upon EXPLAIN UPDATE in PS

2018-01-28 Thread Sergei Golubchik
ERT/DELETE/SELECT) Please explain what was the reason for the bug, why the status was set twice, and how your change fixes it. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to

Re: [Maria-developers] [Commits] ee8755e3c51: MDEV-15012: ASAN: numerous test failures in PS

2018-01-26 Thread Sergei Golubchik
t; timestamp: 2018-01-24 14:42:52 +0100 > message: > > MDEV-15012: ASAN: numerous test failures in PS > > First roll back changes, then free Items which can lead to memory freeing. > Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___

Re: [Maria-developers] Patch for MDEV-13417 - UPDATE produces wrong values if an updated column is later used as an update source

2018-01-24 Thread Sergei Golubchik
Hi, Jerome! On Jan 24, jerome brauge wrote: > Hello Sergei, > Here is a new version of the patch following your comments. > I let you decide if SET_CONSISTENCY must also be part of TRADITIONAL and ANSI. Thanks. We can no longer make it part of TRADITIONAL or ANSI in 10.3, because 10.

Re: [Maria-developers] [Commits] 16298d9e82e: MDEV-7533: COLUMN_JSON() doesn't escape control characters in string values

2018-01-22 Thread Sergei Golubchik
-22 16:53:10 +0100 > message: > > MDEV-7533: COLUMN_JSON() doesn't escape control characters in string values > > escape all charecters less or equal 0x1F (control symbols) > (shorter sequence are not used to make code simple, long encoding is > always legal according to th

Re: [Maria-developers] MDEV-14603 signal 11 with short stacktrace

2018-01-22 Thread Sergei Golubchik
Hi, Alexander! On Jan 22, Alexander Barkov wrote: > Hi Sergei, > > > On 01/20/2018 10:35 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > Thanks! Looks more robust, indeed. > > Isn't there a need to save/restore the arena? > > > > You call

Re: [Maria-developers] [JIRA] (MDEV-14185) CREATE TEMPORARY TABLE AS SELECT causes error 1290 with read_only and InnoDB

2018-01-22 Thread Sergei Golubchik
Hi, Vesa! On Jan 16, Vesa Pentti (JIRA) wrote: > > Vesa Pentti updated MDEV-14185: > --- > Status: In Review (was: In Progress) > Assignee: Sergei Golubchik (was: Vesa Pentti) > > commit d4366c4a2c9b41901b11ca180d3ddbf79e992490 Plea

Re: [Maria-developers] 47bb2dcbcc8: MDEV-14786: Server crashes in Item_cond::transform on 2nd execution of SP querying from a view

2018-01-22 Thread Sergei Golubchik
second execution before fix_left() > + call. This call fix the pointer. > +*/ > + > +void Item_in_optimizer::restore_first_argumet() > +{ > + if (args[1]->type() == Item::SUBSELECT_ITEM && > + ((Item_subselect *)args[1])->is_in_predicate()) > + { > +args[0]=

Re: [Maria-developers] MDEV-14603 signal 11 with short stacktrace

2018-01-20 Thread Sergei Golubchik
. On Jan 18, Alexander Barkov wrote: > On 12/27/2017 08:33 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Dec 26, Alexander Barkov wrote: > >> Hi Sergei, > >> > >> can you please review a patch for MDEV-14603? > > > > I agr

Re: [Maria-developers] Mdev-14586 Assertion `0' failed in retrieve_auto_increment upon attempt to drop PK

2018-01-19 Thread Sergei Golubchik
in the starting of index. So I have changed the find_ref_key > function to take account that if first N fields is Bit field then simply > go > to next field which is not Bit field. > Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___

Re: [Maria-developers] [Commits] 6ffd535e415: MDEV-14229: Stack trace is not resolved for shared objects

2018-01-18 Thread Sergei Golubchik
0) > - return "pipe(in)"; > -if (pipe(out) < 0) > - return "pipe(out)"; > - > -pid = fork(); > -if (pid == -1) > - return "fork"; > - > -if (!pid) /* child */ > -{ > - dup2(in[0], 0); > -

Re: [Maria-developers] [Commits] 4b4267288cb: MDEV-14743: Server crashes in Item_func_match::init_search

2018-01-12 Thread Sergei Golubchik
/* > + it mean that clause where was FT function was removed, so we have > + to remove the function from the list. > +*/ > +li.remove(); > +#endif > + >} >return 0; > } Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___

Re: [Maria-developers] Check constraints

2018-01-10 Thread Sergei Golubchik
Hi, Martijn! On Jan 10, Martijn Tonies (Upscene Productions) wrote: > Hello Sergei, > >On Jan 09, Martijn Tonies (Upscene Productions) wrote: > >> Hi, > >> > >> Where can I find meta information for check constraints on tables? > > &g

Re: [Maria-developers] Check constraints

2018-01-09 Thread Sergei Golubchik
y visible in SHOW CREATE TABLE. They'll be in INFORMATION_SCHEMA.CHECK_CONSTRAINTS when https://jira.mariadb.org/browse/MDEV-14474 will be implemented. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.n

Re: [Maria-developers] Partial indexes?

2017-12-28 Thread Sergei Golubchik
Hi, Jared! On Dec 27, Jared Beck wrote: > On Wed, Dec 27, 2017 at 3:30 PM, Sergei Golubchik <s...@mariadb.org> wrote: > >> Any plans to implement partial indexes? > >> (https://www.postgresql.org/docs/10/static/indexes-partial.html) > > > > No such plans

Re: [Maria-developers] Partial indexes?

2017-12-27 Thread Sergei Golubchik
d like to show valid use cases for partial indexes or explain why it's an important feature to have :) Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-

Re: [Maria-developers] MDEV-14603 signal 11 with short stacktrace

2017-12-27 Thread Sergei Golubchik
Hi, Alexander! On Dec 26, Alexander Barkov wrote: > Hi Sergei, > > can you please review a patch for MDEV-14603? I agree with the fix. But I don't like that there are many things to backup/restore (Statement, arena, free_list, and now change_list), they're all saved/restored in

Re: [Maria-developers] a01f9ff: MDEV-11071 - Assertion `thd->transaction.stmt.is_empty()' failed in

2017-12-27 Thread Sergei Golubchik
The problem is that there's no track of which temporary table was "locked" by > LOCK TABLES. Looks reasonable. Could you also add a test where t2 is locked and t2 is dropped? Just to show that pos_in_locked_tables works for temporary tables. Ok to push after that. Regard

Re: [Maria-developers] [Commits] 203a658: MDEV-11084 Select statement with partition selection against MyISAM table opens all partitions.

2017-12-19 Thread Sergei Golubchik
ened partitions? And make sure that the whole tree compiles without partitioning. Then ok to push into 10.3 Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria

Re: [Maria-developers] [Commits] 7a7ad82: MDEV-13478 Full SST sync fails because of the error in the cleaning part

2017-12-19 Thread Sergei Golubchik
log_dir $ib_undo_dir $DATA -mindepth 1 -regex > $cpat -prune -o -exec rm -rfv {} 1>&2 \+ > +find $ib_home_dir $ib_log_dir $ib_undo_dir $DATA -mindepth 1 -prune > -regex $cpat -o -exec rm -rfv {} 1>&2 \+ > > tempdir=$(parse_cnf mysqld log-bin

Re: [Maria-developers] 665402a: MDEV-14265 - RPMLint warning: shared-lib-calls-exit

2017-12-18 Thread Sergei Golubchik
). > > my_load_defaults() did exit(1) on error, replaced with abort(). I'd say, return 2 instead of exit/abort. my_load_defaults already does it, because my_search_option_files returns 2 for OOM. > my_load_defaults() still does exit(0) when invoked with --print-defaults. dunno, retu

Re: [Maria-developers] [Commits] 2603dc0: MDEV-11084 Select statement with partition selection against MyISAM table opens all partitions.

2017-12-15 Thread Sergei Golubchik
tions, table, FALSE, > + table_list->partition_names); Please, make sure you code compiles without partitioning too. (in this case I wouldn't make the last argument of open_table_from_share conditional, but I'd rather make table_list->partition_names uncondit

Re: [Maria-developers] 14acb68: MDEV-14593 human-readable XA RECOVER.

2017-12-14 Thread Sergei Golubchik
s'" + rus "Неизвестное имя формата команды %s: '%s'" note, you'll need either to remove/rephrase the russian error message, or use "XA RECOVER" as the first argument, not "XID". Ok to push (into bb-10.2-ext) with these changes. Regards, Sergei Chief Architect

Re: [Maria-developers] Mysterious files after build

2017-12-09 Thread Sergei Golubchik
97 Subscribe to it and you'll know when they'll be free to skip. > /usr/bin/mytop > - you (mariaDB) do not ship this file it's an old fork of mytop, but many distributions have a separate mytop package (I think Fedora 27 does too), so we don't ship

Re: [Maria-developers] b610986: MDEV-14593 human-readable XA RECOVER

2017-12-08 Thread Sergei Golubchik
all */ > #define MIN_XID_LIST_SIZE 128 > #define MAX_XID_LIST_SIZE (1024*128) > diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy > index 17e6904..d0fa642 100644 > --- a/sql/sql_yacc.yy > +++ b/sql/sql_yacc.yy > @@ -1705,6 +1705,7 @

Re: [Maria-developers] 78a1779: mysqldump fix for invisible column

2017-12-07 Thread Sergei Golubchik
quote_name(row[SHOW_FIELDNAME], name_buff, 0)); init=1; } if (complete_insert) dynstr_append_checked(_pat, select_field_names->str); > } > num_fields= mysql_num_rows(result); > mysql_free_result(result); Regards, Sergei Chief Architect MariaDB

Re: [Maria-developers] 0f47171: MDEV-14005 Remove need for Partition Key to be part of Primary Key.

2017-12-06 Thread Sergei Golubchik
ing. Then the first thread inserts 1 into the first partition, second thread inserts 1 into the second partition. Monty's idea was to insert optimistically - first you insert, then check for duplicates. Not ideal, in the above example you can have both threads getting a duplicate key error. There could be

Re: [Maria-developers] 339dd3d: Invisible Column mysqldump bug fix

2017-12-05 Thread Sergei Golubchik
append_checked(_string, "SELECT /*!40001 SQL_NO_CACHE */ * > FROM "); > +dynstr_append_checked(_string, "SELECT /*!40001 SQL_NO_CACHE */ "); > +if (invisble_table) > + dynstr_append_checked(_string, select_field_names.str); > +else > + dynstr_append_checked(_string, &qu

Re: [Maria-developers] review of MDEV-10177 Hidden columns

2017-11-23 Thread Sergei Golubchik
goto err; >} > + uint dup_index= 0; > + if ((dup_index= check_if_keyname_exists(key->name.str, table->key_info, > +table->key_info + table->s->keys))) > + { > +if (table->s->key_info[dup_index - 1].flags & HA_INVISIBLE_KEY) > +

Re: [Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Sergei Golubchik
Hi, Alexander! Fair enough. Ok to push On Nov 16, Alexander Barkov wrote: > On 11/16/2017 08:27 AM, Sergei Golubchik wrote: > > On Nov 15, Alexander Barkov wrote: > >> diff --git a/sql/partition_info.cc b/sql/partition_info.cc > >> index 512bf29..740e508 100644 >

Re: [Maria-developers] Please review MDEV-13788 Server crash when issuing bad SQL partition syntax

2017-11-15 Thread Sergei Golubchik
ALUES was used where needed, so there should be no need to do additional checks here. Why does the parser allow invalid syntax? > DBUG_ASSERT(part_type == RANGE_PARTITION ? > num_elements == 1U : TRUE); > for (j= 0; j < num_elements; j++) Regards,

Re: [Maria-developers] MDEV-10173.

2017-11-14 Thread Sergei Golubchik
n improvement i can see using '7' instead of '39' as an > 'NOT_FIXED_DEC' marker for the Item_temporal_func. Why? One wouldn't be able simply to compare with NOT_FIXED_DEC, it'll be type dependent. > Or we can just document that '39' value so clients interpret it right. Isn't it document

Re: [Maria-developers] d78273d: MDEV-14288 Add MTR option to run tests with real server defaults

2017-11-05 Thread Sergei Golubchik
quot;--loose-skip-plugin-$_") for @optional_plugins; > +# starting from 10.0 bootstrap scripts require InnoDB > +mtr_add_arg($args, "--loose-innodb"); > +mtr_add_arg($args, "--loose-innodb-log-file-size=5M"); > +mtr_add_arg($args, "--disable-sync-frm")

Re: [Maria-developers] [Commits] f88fcf2: MDEV-12542 Add bind_address system variable.

2017-10-30 Thread Sergei Golubchik
mysqld.h | 1 + > sql/sys_vars.cc| 7 ++ > 6 files changed, 174 insertions(+), 3 deletions(-) > Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org __

Re: [Maria-developers] MDEV-13997 Change Item_bool_rowready_func2 to cache const items at fix time rather than evaluation time

2017-10-29 Thread Sergei Golubchik
Hi, Alexander! ok to push On Oct 27, Alexander Barkov wrote: > On 10/26/2017 07:29 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Oct 04, Alexander Barkov wrote: > >> Hello Sergei, > >> > >> Please review a patch for MDEV-13997

Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-27 Thread Sergei Golubchik
Hi, Sergey! On Oct 26, Sergey Vojtovich wrote: > Hi Sergei, > > The only reason is there were minor requests to make it tunable. It is easier > to convert read-only var to command line option. > > If we know for sure that we won't do it, I can make it status var instead. A

Re: [Maria-developers] Code syntax: questions on pointers, etc.

2017-10-27 Thread Sergei Golubchik
Hi, Aleksey! On Oct 23, Aleksey Midenkov wrote: > On Sun, Oct 22, 2017 at 10:27 PM, Sergei Golubchik <s...@mariadb.org> wrote: > >> 2. It is still passed as a pointer to functions. Why is that? > >> > >> The main feature of C++ references is that it cannot be

Re: [Maria-developers] 9145b7d: MDEV-11153 - Introduce status variables for table cache monitoring and tuning

2017-10-26 Thread Sergei Golubchik
instances), NO_CMD_LINE, > + VALID_RANGE(1, 64), DEFAULT(1), BLOCK_SIZE(1)); Why did you do it as a sysvar, not as a status variable? Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-dev

Re: [Maria-developers] MDEV-13997 Change Item_bool_rowready_func2 to cache const items at fix time rather than evaluation time

2017-10-26 Thread Sergei Golubchik
Hi, Alexander! On Oct 04, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-13997. > > It's needed for: > MDEV-13995 MAX(timestamp) returns a wrong result near DST change > and for: > MDEV-4912 Add a plugin to field types (column types) > &g

Re: [Maria-developers] MDEV-13118 Wrong results with LOWER and UPPER and subquery

2017-10-24 Thread Sergei Golubchik
Hi, Alexander! On Jul 22, Alexander Barkov wrote: > On 06/20/2017 12:45 PM, Alexander Barkov wrote: > > Hello Sergei, > > > > > > Please review a patch for MDEV-13118. > > > > Thanks! > > > commit dc7352fa2bc21fd9b66b12ec33cdacf88b478157 >

Re: [Maria-developers] Code syntax: questions on pointers, etc.

2017-10-22 Thread Sergei Golubchik
; > typedef st_mysql_lex_string LEX_CUSTRING; > > ? What would that change? > 4. There are some duplicate types: MYSQL_LEX_STRING, > MYSQL_CONST_LEX_STRING. Why? These are names used in the plugin API. They start from MYSQL_* to avo

Re: [Maria-developers] MDEV-13550 is test case required?

2017-10-14 Thread Sergei Golubchik
e you're saying that this will be tested in the versioning.partition test. Perhaps you can simply push it together with versioning.partition test instead of pushing it separately? Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https:

Re: [Maria-developers] [Commits] 06bb7ee: MDEV-10892 - rpl.rpl_semi_sync_uninstall_plugin fails with Assertion `0' failure

2017-10-13 Thread Sergei Golubchik
~(PLUGIN_IS_FREED | PLUGIN_IS_DYING), > + tables->table)) > DBUG_RETURN(1); >DBUG_RETURN(0); > } agree, ok to push Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org

Re: [Maria-developers] [Commits] 96e982b: MDEV-7140 - Sporadic buildbot failures in rpl.rpl_semi_sync_uninstall_plugin

2017-10-13 Thread Sergei Golubchik
> Removed state_mask inversion: doesn't seem to make any sense. > > When collecting local plugins list, only add plugins that match state_mask. > > Use plugin ref counting to protect against concurrent plugin destruction. ok to push Regards, S

Re: [Maria-developers] Please review MDEV-10802 TIMESTAMP NOT NULL field with explicit_defaults_for_timestamp and NO_ZERO_DATE shouldn't throw error

2017-10-13 Thread Sergei Golubchik
Hi, Alexander! On Oct 07, Alexander Barkov wrote: > Hi Sergei, > > Please review a patch for MDEV-10802. > > Thanks! > diff --git > a/mysql-test/suite/sys_vars/inc/explicit_defaults_for_timestamp.inc > b/mysql-test/suite/sys_vars/inc/explicit_defaults_for_times

Re: [Maria-developers] 46b93fc: MDEV-13676: Field "create Procedure" is NULL, even if the the user has role which is the definer. (SHOW CREATE PROCEDURE)

2017-10-09 Thread Sergei Golubchik
acing it with /* Check if current role or any of the sub-granted roles own the routine. */ (sp->m_definer_host.length == 0 && check_role_is_granted(thd->security_ctx->priv_user, thd->security_ctx->priv_host,

Re: [Maria-developers] MDEV-13972 crash in Item_func_sec_to_time::get_date

2017-10-09 Thread Sergei Golubchik
> with what the caller later checks again. Only > Item_func_sec_to_time::get_date() passes maxsec=TIME_MAX_VALUE_SECONDS, > while the other two calls pass LONGLONG_MAX. > > This way I wanted to preserve the behavior in 5.5 a much as possible. Yes, I understand why you introduced it and w

Re: [Maria-developers] MDEV-13972 crash in Item_func_sec_to_time::get_date

2017-10-07 Thread Sergei Golubchik
in 10.4, when Items will return a Value object? On Oct 05, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-13972. > > The patch is for 5.5, as we agreed in slack. > > Thanks! > commit 003c19c7677e1ce5b18b4081e21b7864700f8250 > Author: Alexand

Re: [Maria-developers] MDEV-11819 NO_ZERO_IN_DATE: Incorrect generated column value

2017-10-06 Thread Sergei Golubchik
Hi, Alexander! On Oct 06, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-11819. > > Thanks. Looks ok to push. #if is a good idea Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mail

Re: [Maria-developers] Add RMariaDB CRAN Link to MariaDB Foundation Download Webpage

2017-10-06 Thread Sergei Golubchik
ibuted (or having a link to CRAN) from the MariaDB Foundation > Download Webpage. > > I believe that many people has putted a great effort on this connector, and > it would benefit from greater visibility for better support and maintenance. > > Thank you, > Juan Regards, Sergei Chie

Re: [Maria-developers] [Commits] 3f7e619647f: MDEV-13928: Missing symbols building RocksDB on macOS 10.12.6

2017-10-05 Thread Sergei Golubchik
lang") ># includes requires it. So, now everything in MariaRocks is compiled with ># -frtti) >set_source_files_properties(event_listener.cc rdb_cf_options.cc > + rdb_sst_info.cc > PROPERTIES COMPILE_FLAGS -frtti) > ENDIF() Regards, Sergei Chief Archite

[Maria-developers] review of MDEV-10177 Hidden columns

2017-09-28 Thread Sergei Golubchik
e=v++; > +if (need_default_value && field->field_visibility != NOT_INVISIBLE) > + value = new (thd->mem_root) Item_default_value(thd,context); > +else > + value=v++; 1. Hmm, you will create a new Item for every inserted row? What if it's INSERT ... SELECT * FROM

Re: [Maria-developers] ha_innobase::info_low() n_rows hack

2017-09-11 Thread Sergei Golubchik
Hi, Aleksey! On Sep 11, Aleksey Midenkov wrote: > On Mon, Sep 11, 2017 at 4:37 PM, Sergei Golubchik <s...@mariadb.org> wrote: > > Hi, Aleksey! > > > > On Sep 11, Aleksey Midenkov wrote: > >> In ha_innobase::info_low() there is following dirty hack:

Re: [Maria-developers] ha_innobase::info_low() n_rows hack

2017-09-11 Thread Sergei Golubchik
make_join_statistics(). Yes, relying on HA_STATUS_TIME is a hack. A safer solution would be to return "1 row" for an "seemingly empty" table, unless it was proven to be empty, under a lock. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org __

Re: [Maria-developers] 6a72d15: MDEV-10767 /tmp/wsrep_recovery.${RANDOM} file created in unallowed SELinux context

2017-08-31 Thread Sergei Golubchik
cover --disable-log-error 2>"$log_file" Note, that the similar piece of code is used in mysqld_safe.sh, only there it uses DATADIR/wsrep_recovery.XX, apparently somebody's attempt to work around selinux. Better to make it identical to galera_recovery.sh, I'd say. Regar

Re: [Maria-developers] Patch for MDEV-12874 - UPDATE statements with the same source and target

2017-08-29 Thread Sergei Golubchik
Hi, Jérôme! Sorry, it took a while, there were releases in the plan :( On Aug 18, jerome brauge wrote: > Hi, Sergei > Here is a version that reuses used logic when one searches and updates > the same index. > The principal impact is that we can't use the can_compare optimization

Re: [Maria-developers] Patch for MDEV-12874 - UPDATE statements with the same source and target

2017-08-17 Thread Sergei Golubchik
much less code and simpler implementation. Would that work? Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https:

Re: [Maria-developers] history of lf_hash

2017-08-14 Thread Sergei Golubchik
rdered Lists: Lock-Free Extensible Hash Tables by Ori Shalev and Nir Shavit. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net

Re: [Maria-developers] MDEV-13439: Database permissions are not enough to run a subquery with GROUP BY within a view

2017-08-09 Thread Sergei Golubchik
;is_derived()); > + DBUG_ASSERT(derived->is_anonymous_derived_table()); Hmm, if derived->is_derived() is always true here, why there's an if() below? If it's redundant - please, remove it. >table->grant.privilege= SELECT_ACL; >if (derived->is_derived()) >

Re: [Maria-developers] 4c26b71c77d: MDEV-8960: Can't refer the same column twice in one ALTER TABLE

2017-08-04 Thread Sergei Golubchik
+ { > +my_error(ER_BLOB_CANT_HAVE_DEFAULT, MYF(0), def->change); > +goto err; > + } > + if ((def->def=alter->def)) // Use new default > +def->flags&= ~NO_DEFAULT_VALUE_FLAG; > + else > +def->flags|= NO_

Re: [Maria-developers] 1 Transaction and several threads

2017-08-03 Thread Sergei Golubchik
everal threads abut inside one InnoDB transaction (maybe one XA > > transaction)? Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpa

Re: [Maria-developers] HAVE_LONG_LONG check

2017-07-20 Thread Sergei Golubchik
> Field_longlong(ptr,field_length,null_pos,null_bit, > unireg_check, field_name, > f_is_zerofill(pack_flag) != 0, > f_is_dec(pack_flag) == 0); > Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org

Re: [Maria-developers] 0aa6217: MDEV-13065 rpl.rpl_mdev-11092 fails sporadically in buildbot

2017-07-19 Thread Sergei Golubchik
or_slave_param.inc; and put a comment before it, like # start_slave.inc returns when Slave_SQL_Running=Yes. But the slave # thread sets it before clearing Last_SQL_Errno. So we have to wait # for Last_SQL_Errno=0 separately. > --let $include_filename= wait_for_

Re: [Maria-developers] 10.2 and merges (e.g. TokuDB)

2017-07-10 Thread Sergei Golubchik
Hi, Jocelyn! On Jul 05, jocelyn fournier wrote: > Le 05/07/2017 à 15:36, Sergei Golubchik a écrit : > > On Jun 25, Phil Sweeney wrote: > >> Hi Sergei, > >> > >> Appreciate you considering other options. Unfortunately in this case > >> it seems Perc

Re: [Maria-developers] mariadb_config broken in 10.2.6

2017-07-06 Thread Sergei Golubchik
https://jira.mariadb.org/browse/MDEV-13270 but if you want to be notified when it's fixed, you need to press the "Start watching this issue" link yourself, I cannot do it for you. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___

Re: [Maria-developers] 10.2 and merges (e.g. TokuDB)

2017-07-05 Thread Sergei Golubchik
Hi, Phil! On Jun 25, Phil Sweeney wrote: > Hi Sergei, > > Appreciate you considering other options. Unfortunately in this case > it seems Percona did not release a new 5.6 version in time for this > 10.1.25 merge. > > However, interestingly, they did tag a

Re: [Maria-developers] Project Progress Report[PHASE-1]

2017-06-30 Thread Sergei Golubchik
github.com/ankitkumar031/server/commits/10.2-MDEV-11340 * there are no test results * show create user is not tested * your code doesn't seem to compile at all it looks like the non-working skeleton of the future implementation, not something that can actually work. Regards, Sergei Chief Arc

Re: [Maria-developers] Project Progress Report[PHASE-1]

2017-06-27 Thread Sergei Golubchik
roughout. Good, thinking is the important part. Even a cat can press keys on a keyboard. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.laun

Re: [Maria-developers] exact commands to produce similar mariadb release tarball

2017-06-25 Thread Sergei Golubchik
name, e.g. 10.1, then on one of the latest builds for one of the bintar builders). For example, see http://buildbot.askmonty.org/buildbot/builders/kvm-bintar-trusty-amd64/builds/1625/steps/compile/logs/stdio Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org _

Re: [Maria-developers] [Commits] 62021f3: MDEV-12070 - Introduce thd_query_safe() from MySQL 5.7

2017-06-23 Thread Sergei Golubchik
thread; in this case we better > avoid mutex for performance reasons. Makes sense. May be you can enforce it with an assert? At least, make sure that a function comment says that thd_query_string can only be used by the THD owner thread. Regards, Sergei

Re: [Maria-developers] [Commits] 62021f3: MDEV-12070 - Introduce thd_query_safe() from MySQL 5.7

2017-06-23 Thread Sergei Golubchik
y unsafe and should not be used. Few other engines use thd_query_string() need to be fixed too (but they bypass the plugin API and we don't promise stability for internal functions). Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org __

Re: [Maria-developers] [Commits] 922f970: MDEV-12882 - Assertion failed in MDL_context::upgrade_shared_lock

2017-06-22 Thread Sergei Golubchik
lock_type, > thd->variables.lock_wait_timeout); This only works if you lock WRITE, then READ. If you do it the other way around, you'll get an error. Isn't it inconsistent? Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org __

Re: [Maria-developers] MDEV-12620 - set lock_wait_timeout = 1; flush tables with read lock;

2017-06-16 Thread Sergei Golubchik
NOTE: my_error() has been already called by reopen_tables() within >close_cached_tables(). > */ > -result= 1; > +thd->global_read_lock.unlock_global_read_lock(thd); > +return 1; >} Sure. Looks correct. Regards, Sergei Chief Architect MariaD

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-06-16 Thread Sergei Golubchik
Item_func_format >Item_func_binlog_gtid_pos >Item_func_spatial_collection: > > e. Removing Item_func_buffer::tmp_value, because it's not used any more. > > f. Renaming Item_func_[un]compress::buffer to "tmp_value&

Re: [Maria-developers] header change in MariaDB 10.2.6 and mysqlclient python binding

2017-05-30 Thread Sergei Golubchik
tors to use MYSQL_OPT_RECONNECT. Or both. Or something else. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://lau

Re: [Maria-developers] Weekly Progress Report of the Project

2017-05-29 Thread Sergei Golubchik
for it) Sounds good! > TODOs- Extend CREATE USER, GRANT and SET PASSWORD to provide this > method. When you're ready - please create a pull request with your feature on github. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org

Re: [Maria-developers] Building LibraOffice w/ MariaDB installed fails apt-get build-dep

2017-05-27 Thread Sergei Golubchik
or > something like that. > > Any idea of what is going wrong or how to fix it? I think it's a bug, reported as https://jira.mariadb.org/browse/MDEV-12934 Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://l

Re: [Maria-developers] 10.2 and merges (e.g. TokuDB)

2017-05-23 Thread Sergei Golubchik
10.0 will be released only quarterly from now on (following MySQL-5.5 release schedule). We'll try a new strategy, https://jira.mariadb.org/browse/MDEV-12881 means that 10.1.25 should have the latest TokuDB (as usual, it's the plan, not a promise; plans may change). Regards, Sergei Chief Architect Maria

Re: [Maria-developers] Weekly Progress Report of the Project

2017-05-22 Thread Sergei Golubchik
can get > Started with my project. Yes, good thinking. Now you can look at MDEV-12321 to start getting familiar with the code base. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/

Re: [Maria-developers] 55a4858fe6f: MDEV-12666: CURRENT_ROLE() does not work in a view

2017-05-22 Thread Sergei Golubchik
e clause of WHERE role_name = NULL, while the second SHOW > CREATE VIEW would show a correctly created view. > > The solution proposed is to not replace any function with an Item_null, > but instead use an Item_static_string_func. > Regards, Sergei Chief Architect MariaDB and secur...@mariad

Re: [Maria-developers] MariaDB License Clarification

2017-05-19 Thread Sergei Golubchik
is GPLv2, we cannot change that. MariaDB Connector/C was and is LGPLv2.1 Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscr

Re: [Maria-developers] strange IF in translog_flush_buffers()

2017-05-18 Thread Sergei Golubchik
{ > -DBUG_PRINT("info", ("There is no LSNs yet generated => do nothing")); > -translog_unlock(); > -DBUG_VOID_RETURN; > - } > - >/* flush buffers */ >*sent_to_disk= translog_get_sent_to_disk(); >if (cmp_translog_addr(*lsn, *sent_t

Re: [Maria-developers] Item_func_group_concat::fix_fields - indentation and check positioning?

2017-04-18 Thread Sergei Golubchik
indentation (in 5.5). Returning TRUE means an error anyway, the query processing is aborted. It shouldn't matter what with_subselect is in that case. Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net

Re: [Maria-developers] [JIRA] (MDEV-12499) ARCHIVE tables still don't show up in I_S.TABLES when storage engine is not loaded

2017-04-17 Thread Sergei Golubchik
Hi, Jean-Francois! On Apr 17, Jean-Francois B. Gagne wrote: > Hi Sergei, > > (sorry for cross-posting to MariaDB.dev and MariaDB.discuss: I think this > interest both audiences.) > > Sergei Golubchik commented on MDEV-12499: > > ---

Re: [Maria-developers] How to report progress for InnoDB background tasks (esp. at startup/shutdown)?

2017-04-17 Thread Sergei Golubchik
don't see why not. From the user point of view an aborted (with a shutdown or a disconnect) transaction should always be rolled back. But how exactly it's implemented is up to us, as long as the user visible behavior stays the same. Regards, Sergei Chief Architect MariaDB and secur...@maria

Re: [Maria-developers] b4a223e3381: MDEV-10355 Weird error message upon CREATE TABLE with DEFAULT

2017-04-07 Thread Sergei Golubchik
Hi, Jacob! On Apr 06, Jacob Mathew wrote: > Hi Sergei, > > After doing more testing with the recursive call to > Item::cleanup_processor(), I have found problems with column default values > that reference another column as an argument to a date/time function. At &

Re: [Maria-developers] b7aa15458db: MDEV-11117 CHECK constraint fails on intermediate step of ALTER

2017-04-06 Thread Sergei Golubchik
G_RETURN(1); > + } >vcol->flags= res.errors; There is already a check for auto-increment in generated columns. I've added it in commit a418c9920047d5222a0d065343347312127b780f (see the change in item.cc). But the error message is somewhat confusing. And very confusing when applied

Re: [Maria-developers] mariadb-connector-c on mingw-w64 with pthreads

2017-04-06 Thread Sergei Golubchik
> 1. What would be the correct way to configure/build > mariadb-connector-c on mingw-w64 with native pthread support? > 2. Is there a cmake option to disable threading alltogether? > Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org _

Re: [Maria-developers] Please review a patch removing LEX::text_string_is_7bit

2017-04-04 Thread Sergei Golubchik
Hi, Alexander! On Mar 30, Alexander Barkov wrote: > Hello Sergei, > > Can you please review a patch for bb-10.2-ext fixing the problem > that in case of possible changes in look-ahead in rules using > TEXT_STRING or NCHAR_STRING, Lex->text_string_is_7bit can get out of > sy

Re: [Maria-developers] b4a223e3381: MDEV-10355 Weird error message upon CREATE TABLE with DEFAULT

2017-03-31 Thread Sergei Golubchik
Hi, Jacob! On Mar 30, Jacob Mathew wrote: > Hi Sergei, > > > 2. Why the test for FUNC_ITEM? I don't see any logical reason why > >skipping of "" should only apply to functions. > > > > ... I think this method could be like this: > >

Re: [Maria-developers] b4a223e3381: MDEV-10355 Weird error message upon CREATE TABLE with DEFAULT

2017-03-30 Thread Sergei Golubchik
6 +7374,10 @@ int TABLE::update_virtual_fields(handler *h, > enum_vcol_update_mode update_mode) > > if (update) > { > + // Clear any cached function values in the virtual field expression > + // to trigger their reevaluation > + vcol_info->exp

Re: [Maria-developers] Query on MDEC-7502

2017-03-27 Thread Sergei Golubchik
Hi, Vishwanath! On Mar 23, Vishwanath Bharadwaj wrote: > Hello Mr. Sergei, > What I propose is rather than dumping the table into a single bin log. > What your idea proposes is we slide through the table based on primary > key. This becomes a bit of a problem if there i

Re: [Maria-developers] [GSoC2017]Project prosoal [MDEV-12296] Cassandra Storage Engine V2

2017-03-27 Thread Sergei Golubchik
a proposal or an idea that you want to discuss? Or you just want something to start from? Look at https://summerofcode.withgoogle.com/organizations/5889423829893120/ At the end it has a part "How to work with us" with guidelines. Regards, Sergei Ch

Re: [Maria-developers] GSOC 2017 ideas

2017-03-24 Thread Sergei Golubchik
ake, and then we decide who we will take for this GSoC. So, please, feel free to submit a proposal for the Cassandra Storage Engine project or any other project that you like. Just make sure to do it before the deadline :) Regards, Sergei Chief Ar

Re: [Maria-developers] Queries on ticket MDEV-7502(GSOC)

2017-03-22 Thread Sergei Golubchik
Hi, Vishwanath! What do you mean by "provisioning mode permissions"? What would you suggest to do for tables without a primary key? On Mar 22, Vishwanath Bharadwaj wrote: > Hi, Vishwanath! > > > Hello MR. Sergei, > > I am Vishwanath Bharadwaj and I've con

<    5   6   7   8   9   10   11   12   13   14   >