Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-21 Thread Kristian Nielsen
Hi Daniel, I have merged this from Paul into MariaDB. This means that the next MariaDB release (5.1.41) will include PBXT version 1.0.09f RC3 as described by Paul below. I hope you can use this to prepare MariaDB 5.1.41 release notes. - Kristian. Paul McCullagh writes: > Paul McCullagh has

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Sergei Golubchik
Hi, Paul! On Dec 02, Paul McCullagh wrote: > On Dec 2, 2009, at 2:46 PM, Paul McCullagh wrote: >> >> I have tested this, and it all works as you specified, but now I have >> found a problem with PBXT. >> >> The problem stems from code in PBXT (in functions ha_pbxt::write_row, >> ha_pbxt::update_ro

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Paul McCullagh
Hi Kristian, On Dec 2, 2009, at 1:07 PM, Kristian Nielsen wrote: Serg, thanks a lot for your help and comments! Paul, for now I have removed the whole #ifdef block following Serg's suggestion, and pushed the result for full Buildbot testing; if everything looks ok I will merge into main lp:

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Paul McCullagh
Hi Sergei, I have tested this, and it all works as you specified, but now I have found a problem with PBXT. The problem stems from code in PBXT (in functions ha_pbxt::write_row, ha_pbxt::update_row, ha_pbxt::delete_row) which I have pasted below. The code is a hack! According to the com

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Kristian Nielsen
Serg, thanks a lot for your help and comments! Paul, for now I have removed the whole #ifdef block following Serg's suggestion, and pushed the result for full Buildbot testing; if everything looks ok I will merge into main lp:maria. It is great that you are following up on this, just let me know

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Sergei Golubchik
Hi, Paul! On Dec 02, Paul McCullagh wrote: >> >> Now, if a binlog doesn't indicate a crash (last binlog file was >> closed properly, showing a normal shutdown procedure) or, for >> example, there're no binlog files at all, the server cannot perform >> the recovery - it doesn't know what transactio

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Paul McCullagh
Hi Sergei, Thanks for the great explanation. On Dec 1, 2009, at 2:50 PM, Sergei Golubchik wrote: Hi, Paul! On Dec 01, Paul McCullagh wrote: Thanks for the heads-up on that! The code in question is as follows: #ifndef WILL_BE_DELETED_LATER /* for now, only InnoDB supports 2pc. It means

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-01 Thread Sergei Golubchik
Hi, Paul! On Dec 01, Paul McCullagh wrote: > > Thanks for the heads-up on that! > > The code in question is as follows: > > #ifndef WILL_BE_DELETED_LATER > /* > for now, only InnoDB supports 2pc. It means we can always safely > rollback all pending transactions, without risking inconsist

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-01 Thread Paul McCullagh
Hi Sergei, Thanks for the heads-up on that! The code in question is as follows: #ifndef WILL_BE_DELETED_LATER /* for now, only InnoDB supports 2pc. It means we can always safely rollback all pending transactions, without risking inconsistent data */ DBUG_ASSERT(total_ha_2pc ==

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-01 Thread Sergei Golubchik
Hi, Paul! On Dec 01, Paul McCullagh wrote: > > This patch changes MariaDB code in one case: > > File handler.cc, Line 1591 > > DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and binlog > > This line has been commented out, because the assertions fails now > that PBXT suppor