Re: [Maria-developers] 387839e44cc: Plugin for Hashicorp Vault Key Management System

2019-12-04 Thread Sergei Golubchik
Hi, Julius! Just a couple of comments, see below: On Dec 04, Julius Goryavsky wrote: > revision-id: 387839e44cc (mariadb-10.4.10-179-g387839e44cc) > parent(s): 8115a02283d > author: Julius Goryavsky > committer: Julius Goryavsky > timestamp: 2019-11-15 13:37:35 +0100 > message: > > Plugin for

Re: [Maria-developers] 387839e44cc: Plugin for Hashicorp Vault Key Management System

2019-12-02 Thread Sergei Golubchik
Hi, Julius! Looks good! A couple of minor comments, see below On Dec 02, Julius Goryavsky wrote: > revision-id: 387839e44cc (mariadb-10.4.10-179-g387839e44cc) > parent(s): 8115a02283d > author: Julius Goryavsky > committer: Julius Goryavsky > timestamp: 2019-11-15 13:37:35 +0100 > message: >

Re: [Maria-developers] 387839e44cc: Plugin for Hashicorp Vault Key Management System

2019-11-28 Thread Sergei Golubchik
Hi, Julius! On Nov 28, Julius Goryavsky wrote: > Hi, Sergey, > > many thanks for the detailed review, I fixed all the flaws and left only > what raises questions or where I have explanations: > > >> + if ((list= curl_slist_append(list, token_header.c_str())) == NULL || > >> + (list=

Re: [Maria-developers] 387839e44cc: Plugin for Hashicorp Vault Key Management System

2019-11-27 Thread Sergei Golubchik
Hi, Julius! On Nov 27, Julius Goryavsky wrote: > revision-id: 387839e44cc (mariadb-10.4.10-179-g387839e44cc) > parent(s): 8115a02283d > author: Julius Goryavsky > committer: Julius Goryavsky > timestamp: 2019-11-15 13:37:35 +0100 > message: > > Plugin for Hashicorp Vault Key Management System