Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-08-18 Thread Sergei Golubchik
Hi! On Aug 14, Sergei Golubchik wrote: On Jul 10, Sergei Golubchik wrote: So, I'm trying to make ONLINE to mean LOCK=NONE. And as I've realized, there can no possibly be a truly online, LOCK=NONE ALTER TABLE operation. For example, ... So, at best LOCK=NONE is inconsistent. But really,

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-08-14 Thread Sergei Golubchik
Hi! On Jul 10, Sergei Golubchik wrote: In 5.5 we have ALTER ONLINE TABLE syntax, where ONLINE de facto means without copying the data. Now, after 5.6 merge we also have ALGORITHM=COPY|INPLACE and LOCK=NONE|SHARED|EXCLUSIVE. I've mapped ONLINE to ALGORITHM=INPLACE, because that's what

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-08-14 Thread Elena Stepanova
Hi, On 8/14/2013 3:49 PM, Sergei Golubchik wrote: Hi! On Jul 10, Sergei Golubchik wrote: In 5.5 we have ALTER ONLINE TABLE syntax, where ONLINE de facto means without copying the data. Now, after 5.6 merge we also have ALGORITHM=COPY|INPLACE and LOCK=NONE|SHARED|EXCLUSIVE. I've mapped

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-08-14 Thread Kristian Nielsen
Sergei Golubchik s...@mariadb.org writes: Unless we redefine what online mean. If not, there's no choice but stop claming an online alter support and remove ONLINE and LOCK=NONE from the syntax. Opinions? I think ONLINE should mean: no exclusive lock is taken while data is migrated from the

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-08-14 Thread Roberto Spadim
HI! IMHO,as a user (not a developer) i will show my vision about 'alter'... i think the ONLINE is equal to: please don't lock my table and report waiting table lock at processlist for more than 1 second or users will kill me! =] hehe about algorithms i think it's something related to using this

[Maria-developers] ALTER ONLINE TABLE syntax

2013-07-10 Thread Sergei Golubchik
Hi, You've added this ALTER ONLINE TABLE syntax, where ONLINE de facto means without copying the data. Now, after 5.6 merge we also have ALGORITHM=COPY|INPLACE and LOCK=NONE|SHARED|EXCLUSIVE. I've mapped ONLINE to ALGORITHM=INPLACE, because that's what it means. But it's confusing, one can

Re: [Maria-developers] ALTER ONLINE TABLE syntax

2013-07-10 Thread Sergei Golubchik
Hi, Jan! On Jul 10, Jan Lindström wrote: I really do not see why you would want to define both algorithm and lock mode. In my transactional view ALGORITHM=COPY would mean EXCLUSIVE lock and INPLACE would mean SHARED lock. Is there some other lock that protects from concurrent online alter