Re: [Maria-developers] Comments for parallel replication patch (MDEV-4506)

2013-10-18 Thread Kristian Nielsen
Michael Widenius michael.widen...@gmail.com writes: What about Rotate_log_event::do_update_pos() and Stop_log_event::do_update_pos()? They currently access the flag in rli. I am not sure that is right, as this could be far ahead of the event they are actually executing? Aren't the above

[Maria-developers] Comments for parallel replication patch (MDEV-4506)

2013-10-07 Thread Kristian Nielsen
Hi Monty, I read through your latest patch for the MDEV-4506 task, parallel replication. Just to re-cap, this is a work-in-progress patch, so these are just some comments along the way that I hope will be useful. -static bool sql_slave_killed(THD* thd, Relay_log_info* rli) +static bool