Re: [Maria-developers] MDEV-13467 review.

2021-03-19 Thread Alexey Botchkov
One thing i'd still like you to do differently. + if (g->get_class_info()->m_type_id == Geometry::wkb_multipoint) + { +const char point_size= 4 + WKB_HEADER_SIZE + POINT_DATA_SIZE+1; //1 for the type +char point_temp[point_size]; +memset(point_temp+4, Geometry::wkb_point, 1); +me

[Maria-developers] MDEV-13467 review.

2021-01-09 Thread Alexey Botchkov
Hi, Anel! Sorry for that long delay with this review. Had real difficult weeks of my life :( Now it seems to be over, so getting back to normal. Below is my opinions of the code i see in the branch bb-10.1-anel-MDEV-13467-gis-feature-st_sphere-v2 Hope it's the recent version. + Adapter for funct