Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Hi. As you didn't react on my last patch about it, i decided to remind: http://lists.askmonty.org/pipermail/commits/2014-February/005931.html Best regards. HF 19.02.2014 20:43, Sergei Golubchik wrote: Hi, Alexey! On Feb 19, Alexey Botchkov wrote: Hi, Sergei. Could you, please remove

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Hi, Sergei. Could you, please remove that piece of fine creativity and thd-clear_error() too and use the error handler instead? There's one puzzle. We need to fill the INFORMATION_SCHEMA.TABLES.TABLE_COMMENT field. If a table exists but corrupt, that field presently is filled with the error

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Hi, Alexey! On Feb 19, Alexey Botchkov wrote: Hi, Sergei. Could you, please remove that piece of fine creativity and thd-clear_error() too and use the error handler instead? There's one puzzle. This field is set here: sql_show.cc:4899 (get_schema_tables_record()) if (res ||

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

Hi, Alexey! On Feb 14, Alexey Botchkov wrote: But I don't understand that. Do you mean, old code did *not* suppress errors here? How could selects from I_S tables work without it? Here's how it works today: get_all_tables() Trigger_error_handler err_handler;

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

But I don't understand that. Do you mean, old code did *not* suppress errors here? How could selects from I_S tables work without it? Here's how it works today: get_all_tables() Trigger_error_handler err_handler; thd-push_internal_handler(err_handler);