Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-24 Thread Michael Widenius
Hi! Alexander == Alexander Barkov b...@mariadb.org writes: cut Alexander http://en.wikipedia.org/wiki/Base64 Alexander I believe the modern base64 is associated with: Alexander - Char for index 62 = + Alexander - Char for index 63 = - Alexander - Pad character = mandatory Alexander Look at

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Michael Widenius
Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander On 09/17/2013 08:12 PM, Michael Widenius wrote: cut Alexander I added a reference to http://en.wikipedia.org/wiki/Base64, Alexander as well all added these your comments in proper places of the code.

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
hi guys! i used many base64 libs when i was developing to android, windows ce and windows phone some base64 don't work without == or = on the end of base64 encoded string in that time i made a workaround with = at the end, based on the length() of the string well direct to the point...

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
thanks alexander! :D i will read and test it as soon as possible :) 2013/9/23 Alexander Barkov b...@mariadb.org Hi Roberto, the patch has been pushed to the 10.0 tree: lp:~maria-captains/maria/10.0 See here for more details about the 10.0 tree. https://launchpad.net/maria/**10.0

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
Hi Monty, On 09/23/2013 07:16 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: cut Should we allow not '=' padding in our decoder too? (I think it's best to always pad on encoding). cut Alexander Just checked PostgreSQL. They also pad on encode,

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
Sorry if i'm posting too much, it's my last post for this ... intbase64_decode_max_arg_length(){#if (SIZEOF_INT == 8) return 0x7FFFLL;#else return 0x7FFF;#endif} if we reeturn LL (longlong) with a int function, this will cause overflow/warnings at gcc? will the long long be

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
On 09/23/2013 09:25 PM, Roberto Spadim wrote: Sorry if i'm posting too much, it's my last post for this ... int base64_decode_max_arg_length() { #if (SIZEOF_INT == 8) return 0x7FFFLL; #else return 0x7FFF; #endif } Oops. Some remainders after moving from size_t to int

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Roberto Spadim
hi guys! one question, as a mariadb user... base64 will be exposed to sql layer? could i use TO_BASE64() and FROM_BASE64() at mysql client? there's a MDEV in JIRA about it, if you could attach it to this patch could be nice: MDEV-4387 https://mariadb.atlassian.net/browse/MDEV-4387 and with time,

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Michael Widenius
Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander thanks for review. Alexander I have addressed most of your suggestions. See the new version attached, Alexander and the detailed comments inline: Alexander On 09/12/2013 04:32 PM, Michael Widenius

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Roberto Spadim
nice =) after this patch commited, could report where i could get it? i will try to rewrite to base32 if possible :) and send at jira thanks! 2013/9/17 Alexander Barkov b...@mariadb.org Hello Roberto, On 09/17/2013 06:38 PM, Roberto Spadim wrote: hi guys! one question, as a mariadb

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
On 09/17/2013 08:52 PM, Alexander Barkov wrote: Hi Monty, On 09/17/2013 08:12 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander thanks for review. Alexander I have addressed most of your suggestions. See the new

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
Hello Roberto, On 09/17/2013 06:38 PM, Roberto Spadim wrote: hi guys! one question, as a mariadb user... base64 will be exposed to sql layer? could i use TO_BASE64() and FROM_BASE64() at mysql client? there's a MDEV in JIRA about it, if you could attach it to this patch could be nice:

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
Hi Monty, On 09/17/2013 08:12 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander thanks for review. Alexander I have addressed most of your suggestions. See the new version attached, Alexander and the detailed comments

[Maria-developers] Review of base64.diff and german2.diff

2013-09-12 Thread Michael Widenius
Hi! Here is the review for the code that we should put into 10.0 First the base64: === modified file 'mysql-test/t/func_str.test' --- mysql-test/t/func_str.test2013-05-07 11:05:09 + +++ mysql-test/t/func_str.test2013-08-28 13:14:24 + @@ -1555,3 +1555,118 @@ drop