Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2022-08-24 Thread Sergei Golubchik
Hi, Aleksey, On Aug 03, Aleksey Midenkov wrote: > > > diff --git a/sql/log_event.h b/sql/log_event.h > > > index 3adc7a26d93..dc269955c5f 100644 > > > --- a/sql/log_event.h > > > +++ b/sql/log_event.h > > > @@ -535,16 +535,12 @@ class String; > > > */ > > > #define OPTIONS_WRITTEN_TO_BIN_LOG \

Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2022-08-02 Thread Aleksey Midenkov
Hi Sergei, On Tue, Feb 15, 2022 at 4:35 PM Sergei Golubchik wrote: > > Hi, Aleksey, > > I've took a look at the whole diff bad1440325ba 9af2883e2692. > (but without MDEV-16029) > > I have a couple of comments about minor issues, and a suggestion, > please, see below. Nothing big, really. > > >

Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2022-02-15 Thread Sergei Golubchik
Hi, Aleksey, I've took a look at the whole diff bad1440325ba 9af2883e2692. (but without MDEV-16029) I have a couple of comments about minor issues, and a suggestion, please, see below. Nothing big, really. > diff --git a/include/my_base.h b/include/my_base.h > index 053bf3fbb69..f1c0d8dbc99

Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2021-07-09 Thread Sergei Golubchik
Hi, Aleksey! On Jun 28, Aleksey Midenkov wrote: > > > > * system_versioning_insert_history > > * allows pseudocolumns ROW_START and ROW_END be specified in INSERT > > doesn't affect invisible columns > > Done. Probably the name "system_versioning_insert_history" may be > confused with

Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2021-06-28 Thread Aleksey Midenkov
Hi Sergei! On Tue, Jun 8, 2021 at 3:04 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Jun 08, Aleksey Midenkov wrote: > > revision-id: b3844107287 (mariadb-10.5.2-424-gb3844107287) > > parent(s): 27d66d644cf > > author: Aleksey Midenkov > > committer: Aleksey Midenkov > > timestamp:

Re: [Maria-developers] b3844107287: MDEV-16546 System versioning setting to allow history modification

2021-06-08 Thread Sergei Golubchik
Hi, Aleksey! On Jun 08, Aleksey Midenkov wrote: > revision-id: b3844107287 (mariadb-10.5.2-424-gb3844107287) > parent(s): 27d66d644cf > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: 2021-03-01 17:43:34 +0300 > message: > > MDEV-16546 System versioning setting to allow