Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Jan 05, Aleksey Midenkov wrote: > On Wed, Jan 1, 2020 at 4:07 PM Sergei Golubchik wrote: > > On Jan 01, Aleksey Midenkov wrote: > > > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote: > > > > On Dec 22, Aleksey Midenkov wrote: > > > > > > My concern is mostly about our

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Sergei! On Wed, Jan 1, 2020 at 4:07 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Jan 01, Aleksey Midenkov wrote: > > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote: > > > On Dec 22, Aleksey Midenkov wrote: > > > > My concern is mostly about our plugins. Let the third-party

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Jan 01, Aleksey Midenkov wrote: > On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote: > > On Dec 22, Aleksey Midenkov wrote: > > My concern is mostly about our plugins. Let the third-party plugins > use that API, but our plugins are not restricted to it? Unfortunately it

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Sergei! On Fri, Dec 27, 2019 at 8:22 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 22, Aleksey Midenkov wrote: > > > > > > > > Particularly to this function I don't like its name, semantics and > > > > signature. > > > > > > As far as the service is concerned, "don't like" is too

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Dec 22, Aleksey Midenkov wrote: > > > > > > Particularly to this function I don't like its name, semantics and > > > signature. > > > > As far as the service is concerned, "don't like" is too weak an > > argument, changing a service comes with a compatibility cost. > > Of course,

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Sergei! On Thu, Dec 19, 2019 at 11:32 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 18, Aleksey Midenkov wrote: > > On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik > wrote: > > > On Dec 18, Aleksey Midenkov wrote: > > > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik > wrote: >

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Dec 18, Aleksey Midenkov wrote: > On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik wrote: > > On Dec 18, Aleksey Midenkov wrote: > > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote: > > > > > > > > On Dec 18, Aleksey Midenkov wrote: > > > > > > > > > > We better go away

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Sergei, On Wed, Dec 18, 2019 at 7:23 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 18, Aleksey Midenkov wrote: > > Sergei, > > > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik > wrote: > > > > > Hi, Aleksey! > > > > > > On Dec 18, Aleksey Midenkov wrote: > > > > On Wed, Dec 4, 2019

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Dec 18, Aleksey Midenkov wrote: > Sergei, > > On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote: > > > Hi, Aleksey! > > > > On Dec 18, Aleksey Midenkov wrote: > > > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > > > > > But it's better to be from the other

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Sergei, On Wed, Dec 18, 2019 at 1:11 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 18, Aleksey Midenkov wrote: > > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > > > But it's better to be from the other side: > > > > bool Lex_cstring::strdup(MEM_ROOT *mem_root, const

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Dec 18, Aleksey Midenkov wrote: > On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > > But it's better to be from the other side: > > bool Lex_cstring::strdup(MEM_ROOT *mem_root, const Lex_cstring ) > { > // allocate and deep-copy from src to this > } > > I'd really

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi Sergei! On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > ... > > + Lex_cstring *strdup_root(MEM_ROOT _root) > > The way you use it, it looks like you really need a constructor, not > a strdup. > On second thought, it can't be a constructor because it can fail with allocation

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Sergei! On Fri, Dec 6, 2019 at 5:34 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Dec 05, Aleksey Midenkov wrote: > > > > > > > 3. Invalidate referenced shares on: > > > > > > > > - RENAME TABLE > > > > - DROP TABLE > > > > - RENAME COLUMN > > > > - CREATE TABLE > > > > - ADD

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! On Dec 05, Aleksey Midenkov wrote: > > > > > 3. Invalidate referenced shares on: > > > > > > - RENAME TABLE > > > - DROP TABLE > > > - RENAME COLUMN > > > - CREATE TABLE > > > - ADD FOREIGN KEY > > > > > > When foreign table is created or altered by the above operations > >

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi Sergei! On Wed, Dec 4, 2019 at 10:10 PM Sergei Golubchik wrote: > Hi, Aleksey! > > Just a question for now > (and a couple of style comments, I didn't look at the logic yet) > > On Dec 04, Aleksey Midenkov wrote: > > revision-id: c91ec05e01b (mariadb-10.4.4-427-gc91ec05e01b) > > parent(s):

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

Hi, Aleksey! Just a question for now (and a couple of style comments, I didn't look at the logic yet) On Dec 04, Aleksey Midenkov wrote: > revision-id: c91ec05e01b (mariadb-10.4.4-427-gc91ec05e01b) > parent(s): e6d653b448d > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: