Re: [Maria-developers] cd41d376d41: MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level

2018-11-06 Thread Sergei Golubchik
Hi, Oleksandr! ok to push On Nov 06, Oleksandr Byelkin wrote: > Am 06.11.18 um 20:47 schrieb Sergei Golubchik: > > Hi, Oleksandr! > > > > Why did you do that? > > > > You wrote "Fix difference between 32bit/windows and 64bit systems", but > > to fix just that it would've been enough to change nes

Re: [Maria-developers] cd41d376d41: MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level

2018-11-06 Thread Oleksandr Byelkin
Am 06.11.18 um 20:47 schrieb Sergei Golubchik: Hi, Oleksandr! Why did you do that? You wrote "Fix difference between 32bit/windows and 64bit systems", but to fix just that it would've been enough to change nesting_map to ulonglong. Using Bitmap<> you're basically preparing for any arbitrary >6

Re: [Maria-developers] cd41d376d41: MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level

2018-11-06 Thread Sergei Golubchik
Hi, Oleksandr! Why did you do that? You wrote "Fix difference between 32bit/windows and 64bit systems", but to fix just that it would've been enough to change nesting_map to ulonglong. Using Bitmap<> you're basically preparing for any arbitrary >64 nesting depth. Is this your goal? What feature