Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-10 Thread Nikita Malyavin
It's done: 56e2cd20ed3 -- Yours truly, Nikita Malyavin ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net

Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-09 Thread Sergei Golubchik
Hi, Nikita, On May 08, Nikita Malyavin wrote: > Sorry, the assertion should be > DBUG_ASSERT(table->file == this || dynamic_cast(table->file) > == NULL); > > Well, the tests seem passing after adding this assertion (and a similar one > for myisam): >

Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-08 Thread Nikita Malyavin
Sorry, the assertion should be DBUG_ASSERT(table->file == this || dynamic_cast(table->file) == NULL); Well, the tests seem passing after adding this assertion (and a similar one for myisam): https://github.com/MariaDB/server/commit/f221bc46e6981c9e7c5d2806faefb1ed086e7bf8 Okay, I think I can

Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-08 Thread Sergei Golubchik
Hi, Nikita, On May 08, Nikita Malyavin wrote: > On Fri, 5 May 2023 at 20:46, Sergei Golubchik wrote: > > > > #ifdef HAVE_REPLICATION > > > - if (unlikely(!error && table->s->online_alter_binlog)) > > > + if (unlikely(!error && table->s->online_alter_binlog && > > > +

Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-08 Thread Nikita Malyavin
Hi, On Fri, 5 May 2023 at 20:46, Sergei Golubchik wrote: > > #ifdef HAVE_REPLICATION > > - if (unlikely(!error && table->s->online_alter_binlog)) > > + if (unlikely(!error && table->s->online_alter_binlog && > > + !table->skip_online_logging)) > > this doesn't need any juggling

Re: [Maria-developers] da5a72f32d4: MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a partitioned table

2023-05-05 Thread Sergei Golubchik
Hi, Nikita, On May 05, Nikita Malyavin wrote: > revision-id: da5a72f32d4 (mariadb-11.0.1-114-gda5a72f32d4) > parent(s): 0d6584c019c > author: Nikita Malyavin > committer: Nikita Malyavin > timestamp: 2023-05-01 01:15:41 +0300 > message: > > MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a