Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Kristian, hello. The patch is polished to address your comments and Ian's editorial work. I apologize for a possible invinient delay with the final version. It's here: https://github.com/MariaDB/server/pull/460/commits/56b000b2e7d9c4dec61429f0ff7affe9c75409ca as well as appended to the end of

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Kristian, salve. Thanks for checking the patch so promptly! > andrei.el...@pp.inet.fi writes: > >> The patch is ready for review and can be located on bb-10.1-andrei, >> https://github.com/MariaDB/server/pull/460 > > I think the patch is ok, it looks of good quality and well thought out. > > A

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Kristian, hello. The patch is ready for review and can be located on bb-10.1-andrei, https://github.com/MariaDB/server/pull/460 (Ignore https://github.com/MariaDB/server/pull/459 which specified 10.2 base by mistake) In case you won't be able to, I'll find replacement, no worries. Have a good

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Kristian, thanks for more remarks! >>> If you “forget" the domain on the upstream server what happens if >>> there >>> are downstream slaves? I think you’ll break replication if they >>> disconnect >>> from this box and try to reconnect. Their GTID information will no >>> longer match. >>> IMO

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

>> If you “forget" the domain on the upstream server what happens if >> there >> are downstream slaves? I think you’ll break replication if they >> disconnect >> from this box and try to reconnect. Their GTID information will no >> longer match. >> IMO and if I’ve understood correctly this is

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Kristian, Simon, hello. Replication side of FLUSH BINARY LOGS DELETE_DOMAIN_ID is actually bound to another requirement specified in early mails. The command is successful only *after* the user has run PURGE BINARY LOGS to 'the-first-log-free-of-old-domains' which is not replicated.

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Simon, hello. > Hi Andrei, > >> On 25 Sep 2017, at 20:17, andrei.el...@pp.inet.fi wrote: > > ... >> the "vanilla" FLUSH-LOGS is not binlogged by decision commented in >> reload_acl_and_cache(): > > In the normal case I think it makes sense to not trigger another flush > and to not binlog the

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Hello. I've completed with the patch which passes few tests. However I had to make one concession with regard to replication. Actually.. >>> So I see the DELETE DOMAIN (MariaDB) or “remove old UUID” (MySQL) >>> type request >>> to be one that means the master will only pretend that it can serve

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Simon, Kristian, salute. > Simon, thanks for your detailed answer. > > I see your point on having access to powerful tools when they are needed, > even when such tools can be dangerous when used incorrectly. It reminds me > of the old "goto considered harmful" which I never agreed with. > > It

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Simon, thanks for your detailed answer. I see your point on having access to powerful tools when they are needed, even when such tools can be dangerous when used incorrectly. It reminds me of the old "goto considered harmful" which I never agreed with. It occurs to me that there are actually

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Hi Kristian, Sorry for the late response. > On 12 Sep 2017, at 10:21, Kristian Nielsen wrote: > > Simon Mudd writes: > >> ids. Obviously once all appropriate bin logs have been purged >> (naturally by other means) then no special processing

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Hello, Simon, Kristian. (The mail was meant to be sent out yesterday, but it got stuck in my outgoing box). > Simon Mudd writes: > >> ids. Obviously once all appropriate bin logs have been purged >> (naturally by other means) then no special processing will be needed. >

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Simon Mudd writes: > ids. Obviously once all appropriate bin logs have been purged > (naturally by other means) then no special processing will be needed. Right. Hence my original idea (which was unfortunately never implemented so far). If at some point a domain has been

Re: [Maria-developers] [External] Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

Hi all, > On 8 Sep 2017, at 16:48, andrei.el...@pp.inet.fi wrote: > > Kristian, hello. > > Now to the implementation matter, > >> The procedure to fix it will then be: >> >> 1. FLUSH BINARY LOGS, note the new GTID position. >> >> 2. Ensure that all slaves are past the problematic point with