Hi, Aleksey!
On Jun 10, Aleksey Midenkov wrote:
> On Thu, Jun 3, 2021 at 1:58 PM Sergei Golubchik wrote:
> > Hi, Aleksey!
> >
> > On Jan 26, Aleksey Midenkov wrote:
> > > On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
> > > > On Nov 03, Aleksey Midenkov wrote:
> > > >
> > > > And
Hi Sergei!
On Thu, Jun 3, 2021 at 1:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Jan 26, Aleksey Midenkov wrote:
> > On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
> > > On Nov 03, Aleksey Midenkov wrote:
> > >
> > > And please, pretty please, don't use non-constant references
Hi, Aleksey!
On Jun 03, Aleksey Midenkov wrote:
> Hi Sergei!
>
> Do you plan to fix everything you just said and push yourself or let
> me push it as is?
Neither. As a reviewer I plan to reply "ok to push" when the code is
changed according to the review.
> Btw, there were many allocations
Hi Sergei!
Do you plan to fix everything you just said and push yourself or let
me push it as is? Btw, there were many allocations over one loop:
that's why I used mem_root. multi_malloc() won't do the job there.
That could be done either with explicit moving pointer or some utility
class holding
Hi, Aleksey!
I think it's better to wrap it up quickly, agree on changes and push the
fix before the next release.
On Jun 01, Aleksey Midenkov wrote:
> Hi Sergei!
>
> Users could benefit from this fix of MDEV-18734 since the last
> changes. Do you really think the open questions left are so
Hi, Aleksey!
On Jan 26, Aleksey Midenkov wrote:
> On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
> > On Nov 03, Aleksey Midenkov wrote:
> >
> > And please, pretty please, don't use non-constant references as
> > function arguments.
>
> Why? With pointers we can pass NULL and we don't
Hi Sergei!
Users could benefit from this fix of MDEV-18734 since the last
changes. Do you really think the open questions left are so important
for this bug to be still not pushed?
On Tue, Jan 26, 2021 at 1:51 AM Aleksey Midenkov wrote:
>
> Hi Sergei,
>
> On Tue, Dec 22, 2020 at 7:58 PM Sergei
Hi Sergei,
On Tue, Dec 22, 2020 at 7:58 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> On Nov 03, Aleksey Midenkov wrote:
> >
> > the updated patches are here:
> >
> > https://github.com/MariaDB/server/commits/5f6bcd6cd0145513974b0dfc5b2cefba28b72f1a
>
> I started writing my comments there, but
Hi, Aleksey!
On Nov 03, Aleksey Midenkov wrote:
>
> the updated patches are here:
>
> https://github.com/MariaDB/server/commits/5f6bcd6cd0145513974b0dfc5b2cefba28b72f1a
I started writing my comments there, but realized that it'd be clearer
if I reply here, more context. That is, see below.
Hi Sergei!
The updated patches are here:
https://github.com/MariaDB/server/commits/2c2e79487a9189e02fce8f884a9ab2b42b9aa333
On Tue, Nov 3, 2020 at 8:28 PM Aleksey Midenkov wrote:
>
> Sergei,
>
> the updated patches are here:
>
>
Sergei,
the updated patches are here:
https://github.com/MariaDB/server/commits/5f6bcd6cd0145513974b0dfc5b2cefba28b72f1a
On Mon, Nov 2, 2020 at 11:33 PM Sergei Golubchik wrote:
>
> Hi, Aleksey!
>
> Don't be confused, the commit header and the comment come from your last
> commit, but the diff
Hi, Aleksey!
Don't be confused, the commit header and the comment come from your last
commit, but the diff below includes all three commits that mention MDEV-18734.
On Nov 02, Aleksey Midenkov wrote:
> revision-id: 2f9bbf392072 (mariadb-10.2.31-543-g2f9bbf392072)
> parent(s): 1f4960e3f2ac
>
12 matches
Mail list logo
