Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

2022-09-28 Thread Oleksandr Byelkin
The check of triggers (if present) need only if definition did not changed. Before the check need all that if would be just "return true". Sergei Golubchik schrieb am Mi., 28. Sept. 2022, 19:15: > Hi, Oleksandr, > > On Sep 28, Oleksandr Byelkin wrote: > > > > +bool

Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

2022-09-28 Thread Sergei Golubchik
Hi, Oleksandr, On Sep 28, Oleksandr Byelkin wrote: > > > +bool TABLE_LIST::is_the_same_definition(THD* thd, TABLE_SHARE *s) > > > +{ > > > + enum enum_table_ref_type tp= s->get_table_ref_type(); > > > + if (m_table_ref_type == tp) > > > + { > > > +bool res= m_table_ref_version ==

Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

2022-09-28 Thread Oleksandr Byelkin
Hi, Sergei! On Tue, Sep 27, 2022 at 2:36 PM Sergei Golubchik wrote: > Hi, Oleksandr, > > Few minor comments, see below > > On Sep 27, Oleksandr Byelkin wrote: > > revision-id: 5265f7001c6 (mariadb-10.3.36-60-g5265f7001c6) > > parent(s): 86953d3df0a > > author: Oleksandr Byelkin > > committer:

Re: [Maria-developers] 5265f7001c6: MDEV-17124: mariadb 10.1.34, views and prepared statements: ERROR 1615 (HY000): Prepared statement needs to be re-prepared

2022-09-27 Thread Sergei Golubchik
Hi, Oleksandr, Few minor comments, see below On Sep 27, Oleksandr Byelkin wrote: > revision-id: 5265f7001c6 (mariadb-10.3.36-60-g5265f7001c6) > parent(s): 86953d3df0a > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2022-09-27 10:23:31 +0200 > message: > > MDEV-17124: