Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-06-25 Thread Alexander Barkov
Hi Sergei, This is a new version. Please also see some comments below. Thanks. On 06/25/2015 01:00 PM, Sergei Golubchik wrote: Hi, Alexander! On Jun 25, Alexander Barkov wrote: Hi Sergei, diff --git a/sql/field_conv.cc b/sql/field_conv.cc index e31f7c5..14f2947 100644 ---

Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-06-25 Thread Alexander Barkov
Hi Sergei, Thanks for review. I have a couple of questions before I can send a new version. See the questions and other comments below. On 06/24/2015 08:32 PM, Sergei Golubchik wrote: Hi, Alexander! I rewrote the patch slightly, so now we don't need to remember all_default_are_checked or

Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-06-24 Thread Sergei Golubchik
Hi, Alexander! I rewrote the patch slightly, so now we don't need to remember all_default_are_checked or write_set_defaults_are_checked. The default values are now checked before the query execution and before the first restore_record() call. They are now checked directly in

Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-05-18 Thread Alexander Barkov
Hi Sergei, Thanks for review! See my comments inline: On 05/07/2015 06:57 PM, Sergei Golubchik wrote: Hi, Alexander! On Mar 25, Alexander Barkov wrote: Hi Sergei, Please review a patch for mdev-7824. It's based on a MySQL patch for http://bugs.mysql.com/bug.php?id=68041 and is a blocker

Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-05-07 Thread Sergei Golubchik
Hi, Alexander! On Mar 25, Alexander Barkov wrote: Hi Sergei, Please review a patch for mdev-7824. It's based on a MySQL patch for http://bugs.mysql.com/bug.php?id=68041 and is a blocker for: MDEV-3929 Add full support for auto-initialized/updated timestamp and datetime That looks