Re: [Maria-developers] Review of 5.2 pluggable-auth tree

Hi! 26 марта 2010, в 12:12, Sergei Golubchik написал(а): [skip] + #ifdef _WIN32 In the rest of my_global.h we use __WIN__ Wouldn't it be better to use the same constant everywhere? Yes, it would. And this constant should be _WIN32, __WIN__ was historically used, but it's incorrect - as was

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

Hi, Oleksandr! On Mar 29, Oleksandr Byelkin wrote: [skip] + #ifdef _WIN32 In the rest of my_global.h we use __WIN__ Wouldn't it be better to use the same constant everywhere? Yes, it would. And this constant should be _WIN32, __WIN__ was historically used, but it's incorrect - as was

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

29.03.2010 09:53, Sergei Golubchik пишет: Hi, Oleksandr! On Mar 29, Oleksandr Byelkin wrote: [skip] + #ifdef _WIN32 In the rest of my_global.h we use __WIN__ Wouldn't it be better to use the same constant everywhere? Yes, it would. And this constant should

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

Hi, Monty! On Mar 26, Sergei Golubchik wrote: Hi, Monty! See the answers below: (no reply means ok, changed) On Mar 25, Michael Widenius wrote: And here's a patch that implements your review comments. Regards, Sergei === modified file 'client/mysql.cc' *** client/mysql.cc

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

Hi, Monty! See the answers below: (no reply means ok, changed) On Mar 25, Michael Widenius wrote: === modified file 'client/mysql.cc' + /** + An example of mysql_authentication_dialog_ask callback. + + The C function with the name mysql_authentication_dialog_ask, if exists, +