Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-10-20 Thread Alexander Barkov
Hi Sergei, Thanks for review. My comments go inline: On 10/17/2014 07:29 PM, Sergei Golubchik wrote: Hi, Alexander! Thanks! The patch is pretty much ok. There are only few comments/questions, see below. On Aug 29, Alexander Barkov wrote: Hi, Please review my patch for MDEV-5528. It

Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-10-20 Thread Sergei Golubchik
Hi, Alexander! On Oct 20, Alexander Barkov wrote: === modified file 'mysql-test/suite/binlog/r/binlog_mysqlbinlog_row.result' --- mysql-test/suite/binlog/r/binlog_mysqlbinlog_row.result 2013-09-14 01:09:36 + +++ mysql-test/suite/binlog/r/binlog_mysqlbinlog_row.result

[Maria-developers] Problem with KVM version in Buildbot?

2014-10-20 Thread Kristian Nielsen
Hi Daniel, We have a problem with a build in Buildbot: https://internal.askmonty.org/buildbot/builders/kvm-rpm-centos7_0-x86_64/builds/127/steps/compile/logs/stdio + qemu-img create -b /kvm/vms/vm-centos7_0-x86_64-build.qcow2 -f qcow2 /dev/shm/vm-tmp-2302.qcow2 qemu-img: '' uses a qcow2

Re: [Maria-developers] Problem with KVM version in Buildbot?

2014-10-20 Thread Otto Kekäläinen
2014-10-20 12:27 GMT+03:00 Kristian Nielsen kniel...@knielsen-hq.org: $ qemu-img info /kvm/vms/vm-sid-amd64-build.qcow2 image: /kvm/vms/vm-sid-amd64-build.qcow2 file format: qcow2 virtual size: 40G (42949672960 bytes) disk size: 3.1G cluster_size: 65536 Format specific information:

Re: [Maria-developers] Problem with KVM version in Buildbot?

2014-10-20 Thread Kristian Nielsen
Otto Kekäläinen writes: There is no need for this image to be so big. The OS is maybe that 3.1 GB and the MariaDB build output is about 3 GB, so something like 9 GB disk size should be well enough by a fair margin. Right. On the other hand, there is a lot of work involved in re-doing the VM

[Maria-developers] Igor please review: [Commits] Rev 4446: MDEV-6879: Dereference of NULL primary_file-table in DsMrr_impl::get_disk_sweep_mrr_cost()

2014-10-20 Thread Sergey Petrunia
Hello Igor, Could you please review the below: At file:///home/psergey/dev2/10.0-cp2/ revno: 4446 revision-id: psergey at askmonty.org-20141020175620-vodbkx9ugmdhh8c1 parent: psergey at askmonty.org-20141016135713-md92qr4g9fzhitxh