Re: [Maria-developers] Review of MDEV-4506, parallel replication, part 1

2013-09-23 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: Kristian We _do_ need a full memory barrier here (memory barrier is implied in taking a Kristian mutex). Otherwise the compiler or CPU could re-order the setting of the Kristian wakeup_subsequent_commits_running flag with the reads and writes

Re: [Maria-developers] Galera-10.0 still does not work with rollbacks

2013-09-23 Thread Jan Lindström
Hi, Full unedited log using --valgrind and --mysqld=--debug=+d at location: https://www.dropbox.com/s/dcufp7l1cch8dfs/mysql.err.gz In below lines I have: static int binlog_commit(handlerton *hton, THD *thd, bool all) {   int

Re: [Maria-developers] Review of MDEV-4506, parallel replication, part 1

2013-09-23 Thread Kristian Nielsen
Michael Widenius mo...@askmonty.org writes: What should happen if you kill a replication thread is that replication should stop for that master. Kristian This needs more thought, I think ... certainly something looks not right. After looking at the full code, I think that the logical way

Re: [Maria-developers] [Roles] Final Status

2013-09-23 Thread Sergei Golubchik
Hi, Vicentiu! On Sep 21, Vicentiu Ciorbaru wrote: Even though I didn't manage to implement everything yet, I want to finish this project and get it ready for an upstream push, outside of GSoC. 1. I'd need either from you in email (but then cc: it to maria-developers) or in your blog

[Maria-developers] [Spatial] On current implementation approach

2013-09-23 Thread Mateusz Loskot
Hi, I'm going to ask question about how the current Spatial Extensions are implemented. I have spent some time reading the source code in the current trunk (spatial.h|cc, gcal*.h|cc, related Field and Item definitions, etc.), so I have a rough understanding of the overall structure, how the

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Michael Widenius
Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander On 09/17/2013 08:12 PM, Michael Widenius wrote: cut Alexander I added a reference to http://en.wikipedia.org/wiki/Base64, Alexander as well all added these your comments in proper places of the code.

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
hi guys! i used many base64 libs when i was developing to android, windows ce and windows phone some base64 don't work without == or = on the end of base64 encoded string in that time i made a workaround with = at the end, based on the length() of the string well direct to the point...

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
thanks alexander! :D i will read and test it as soon as possible :) 2013/9/23 Alexander Barkov b...@mariadb.org Hi Roberto, the patch has been pushed to the 10.0 tree: lp:~maria-captains/maria/10.0 See here for more details about the 10.0 tree. https://launchpad.net/maria/**10.0

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
Hi Monty, On 09/23/2013 07:16 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: cut Should we allow not '=' padding in our decoder too? (I think it's best to always pad on encoding). cut Alexander Just checked PostgreSQL. They also pad on encode,

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Roberto Spadim
Sorry if i'm posting too much, it's my last post for this ... intbase64_decode_max_arg_length(){#if (SIZEOF_INT == 8) return 0x7FFFLL;#else return 0x7FFF;#endif} if we reeturn LL (longlong) with a int function, this will cause overflow/warnings at gcc? will the long long be

Re: [Maria-developers] [Roles] Final Status

2013-09-23 Thread Vicentiu Ciorbaru
Hi Sergei! On Mon, Sep 23, 2013 at 5:23 PM, Sergei Golubchik s...@mariadb.org wrote: Hi, Vicentiu! On Sep 21, Vicentiu Ciorbaru wrote: Even though I didn't manage to implement everything yet, I want to finish this project and get it ready for an upstream push, outside of GSoC. 1. I'd

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
On 09/23/2013 09:25 PM, Roberto Spadim wrote: Sorry if i'm posting too much, it's my last post for this ... int base64_decode_max_arg_length() { #if (SIZEOF_INT == 8) return 0x7FFFLL; #else return 0x7FFF; #endif } Oops. Some remainders after moving from size_t to int

[Maria-developers] The Usability of Free/Libre/Open Source Projects, A Review

2013-09-23 Thread Jan Lindström
In http://www.ijcit.com/archives/volume2/issue5/Paper020519.pdf For some reason MySQL/MariaDB is not mentioned. R: -- Jan Lindstrm Principal Engineer MariaDB | MaxScale | skype: jan_p_lindstrom www.skysql.com

Re: [Maria-developers] Review of MDEV-4506, parallel replication, part 1

2013-09-23 Thread Michael Widenius
Hi! Kristian == Kristian Nielsen kniel...@knielsen-hq.org writes: cut So there is a barrier between we set it and potentially clear it. As the 'clear' may now happen 'any time' (from other threads point of view) I don't see why it needs to be protected. Kristian Right. Kristian I looked

Re: [Maria-developers] Review of MDEV-4506, parallel replication, part 1

2013-09-23 Thread Michael Widenius
Hi! Kristian == Kristian Nielsen kniel...@knielsen-hq.org writes: Kristian Michael Widenius mo...@askmonty.org writes: What should happen if you kill a replication thread is that replication should stop for that master. cut Kristian It seems to make sense that KILL CONNECTION on the SQL

Re: [Maria-developers] [Spatial] On current implementation approach

2013-09-23 Thread Mateusz Loskot
On 23 September 2013 22:10, Alexey Botchkov holyf...@askmonty.org wrote: 1. Is it possible to implement MariaDB extensions like Spatial (custom type + set of functions) without such a tight coupling with the internal implementation of the type system (without messing Field class with geometry

Re: [Maria-developers] [Spatial] On current implementation approach

2013-09-23 Thread Roberto Spadim
Hi mateusz, i'm a user and a hobby developer... i will answer with what i know 2013/9/23 Mateusz Loskot mate...@loskot.net Hi, I'm going to ask question about how the current Spatial Extensions are implemented. I have spent some time reading the source code in the current trunk

Re: [Maria-developers] [Spatial] On current implementation approach

2013-09-23 Thread Roberto Spadim
hi again :) i'm not a mariadb team developer, so please consider me as an user/udf developer =] 2013/9/23 Mateusz Loskot mate...@loskot.net On 23 September 2013 22:10, Alexey Botchkov holyf...@askmonty.org wrote: 1. Is it possible to implement MariaDB extensions like Spatial (custom type