Re: [Maria-developers] MDEV-7937: Enforce SSL when --ssl client option is used

2015-05-18 Thread Sergei Golubchik
Hi, Vicențiu! On May 17, Vicențiu Ciorbaru wrote: Hi Sergei! I've done some work on this issue. I've read MySQL's implementation of this and have looked at our implementation. They have done a bit of refactoring, introducing an enforce_ssl flag, as well as changing the C interface a bit,

Re: [Maria-developers] Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value

2015-05-18 Thread Alexander Barkov
Hi Sergei, Thanks for review! See my comments inline: On 05/07/2015 06:57 PM, Sergei Golubchik wrote: Hi, Alexander! On Mar 25, Alexander Barkov wrote: Hi Sergei, Please review a patch for mdev-7824. It's based on a MySQL patch for http://bugs.mysql.com/bug.php?id=68041 and is a blocker

Re: [Maria-developers] MDEV-8112: PATCH: no slave left behind

2015-05-18 Thread Kristian Nielsen
Hi Jonas, Thanks for the patch! I read through the patch. I am not that familiar with the semi-sync plugin code, but it looks reasonable. But the patch causes a test failure in sys_vars.all_vars. This is because not all newly introduced variables have corresponding test cases in