[Maria-developers] MDEV-9521 Least function returns 0000-00-00 for null date columns instead of null

2016-02-09 Thread Alexander Barkov
Hi Sergei, Please review a patch for MDEV-9521. Thanks. diff --git a/mysql-test/r/type_date.result b/mysql-test/r/type_date.result index 4e299ec..31add0f 100644 --- a/mysql-test/r/type_date.result +++ b/mysql-test/r/type_date.result @@ -440,3 +440,38 @@ id select_type table type possible_keys

Re: [Maria-developers] MDEV-9371 select insert('a', 2, 1, 'b') doesn't return expected 'a'

2016-02-09 Thread Sergei Golubchik
Hi, Alexander! On Feb 09, Alexander Barkov wrote: > Hello Sergei, > > Please review a fix for MDEV-9371. > > I'd suggest to push it to 10.0 instead of 5.5, > as MySQL fixed this bug in 5.6 (not 5.5). I think 5.5 is fine. It's clearly a bug. And a very safe fix. > Also, I think it's worthy to

Re: [Maria-developers] [Commits] 841c317: MDEV-7122: Assertion `0' failed in subselect_hash_sj_engine::init

2016-02-09 Thread Sergey Petrunia
Hi Vicentiu, Please find some cosmetic feedback below. Ok to push after it is addressed. On Tue, Feb 09, 2016 at 04:02:58PM +0200, Vicentiu Ciorbaru wrote: > revision-id: 841c317d237453f3e6c253e2a884cad73622b59a > (mariadb-5.5.47-33-g841c317) > parent(s):

Re: [Maria-developers] MDEV-9371 select insert('a', 2, 1, 'b') doesn't return expected 'a'

2016-02-09 Thread Alexander Barkov
Hi Sergei, On 02/09/2016 05:01 PM, Sergei Golubchik wrote: Hi, Alexander! On Feb 09, Alexander Barkov wrote: Hello Sergei, Please review a fix for MDEV-9371. I'd suggest to push it to 10.0 instead of 5.5, as MySQL fixed this bug in 5.6 (not 5.5). I think 5.5 is fine. It's clearly a bug.