Re: [Maria-developers] Window functions: why some functions are not in select_lex->window_funcs?

2016-03-23 Thread Sergey Petrunia
This is because of this in sql_yacc.yy: window_func_expr: window_func OVER_SYM window_name { $$= new (thd->mem_root) Item_window_func(thd, (Item_sum *) $1, $3); if ($$ == NULL) MYSQL_YYABORT; } | window_func OVE

[Maria-developers] Window functions: why some functions are not in select_lex->window_funcs?

2016-03-23 Thread Sergey Petrunia
Hello Igor, I was trying to move JOIN::process_window_functions() from using join->fields_list to using join->select_lex->window_funcs. And I discovered that join->select_lex->window_funcs does not contain window function items that use window definition. Is this intentional? Example: create

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-23 Thread Sergei Golubchik
Hi, Jan! On Mar 23, Jan Lindström wrote: > Hi, > > All below is correct and naturally you may re-implement duplicate search on > different index type. I think there is more code that needs change as this > new index type would contain a column (hash value of the blob field) that > is not on store

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-23 Thread Jan Lindström
Hi, All below is correct and naturally you may re-implement duplicate search on different index type. I think there is more code that needs change as this new index type would contain a column (hash value of the blob field) that is not on stored on base table, right ? Indexed columns are also stor

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-23 Thread Sergei Golubchik
Hi, Sachin! On Mar 23, Sachin Setia wrote: > Hello Sergei > Today I made some progress related to project. > MyISAM/ARIA > Got clear understanding of how to implement unique index for query like > create table tbl(col1 int primary key , col2 blob ,col3 blob , > unique(col2,col3)) > InnoDB >

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-23 Thread Shubham Barai
Hello Sergei, I have gone through some of the source files in InnoDB. / handler/ha_innodb.cc /row/row0mysql.cc /row/row0ins.cc /dict/dict0mem.cc

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-23 Thread Sachin Setia
Hello Sergei Today I made some progress related to project. MyISAM/ARIA Got clear understanding of how to implement unique index for query like create table tbl(col1 int primary key , col2 blob ,col3 blob , unique(col2,col3)) InnoDB Reading about it.Actually Sir, I want to do this project whether I

Re: [Maria-developers] More memory allocation for key seg

2016-03-23 Thread Sachin Setia
Thanks Sergei , this solved the mystery. Regards sachin On Wed, Mar 23, 2016 at 12:03 AM, Sergei Golubchik wrote: > Hi, Sachin! > > On Mar 22, Sachin Setia wrote: > > Hello Devlopers > > I was debugging the source code of mariadb. My query was > > MariaDB [sachin]> create table pro2(abc int prim