Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

> On 5 May 2016, at 22:33, Sergei Golubchik wrote: > > confirmation that we can take it under BSD-new or MCA >>^^ >>> The question is not about relicensing GPLv2 patch under BSD. It's >>> about getting any license at

Re: [Maria-developers] Please review MDEV-10030 sql_yacc.yy: Split table_expression and remove PROCEDURE from create_select, select_paren_derived, select_derived2, query_specification

Hi, Alexander! Sure, that's ok. A couple of comments below: On May 05, Alexander Barkov wrote: > diff --git a/sql/sql_select.cc b/sql/sql_select.cc > index a6bbfc8..0d8bfb3 100644 > --- a/sql/sql_select.cc > +++ b/sql/sql_select.cc > @@ -988,6 +988,7 @@ JOIN::prepare(TABLE_LIST *tables_init, >

Re: [Maria-developers] Joinable threads

Hi Monty, Thanks for you reply. Please allow me to disagree with some points. :) Attached please find 2 patches, both fix this memory leak. One approach is for detached threads, another one is for joinable threads. On Thu, May 05, 2016 at 02:12:17PM +0300, Michael Widenius wrote: > Hi! > > On

Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

Sergei Golubchik writes: > Was it under GPLv2, that would've been enough. Ok, this is good to know. So if a patch is made available only under GPLv2, not BSD or MCA, it can still be included in MariaDB, same as any other contribution. > So, indeed, the standard request is

Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

Hi, Kristian! On May 05, Kristian Nielsen wrote: > Sergei Golubchik writes: > > >> > confirmation that we can take it under BSD-new or MCA > ^^ > > The question is not about relicensing GPLv2 patch under BSD. It's > >

Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

Sergei Golubchik writes: >> > confirmation that we can take it under BSD-new or MCA ^^ > The question is not about relicensing GPLv2 patch under BSD. It's about > getting any license at all. So do I understand you

Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

Hi, Kristian! On May 05, Kristian Nielsen wrote: > Sergey Vojtovich writes: > > > Since Alexey's patch wasn't yet accepted by MySQL we need his > > confirmation that we can take it under BSD-new or MCA > > terms. @akopytov, could you confirm? > > That _really_ is

Re: [Maria-developers] [MariaDB/server] MDEV-9857: line cache size (to 10.1) (#169)

Sergey Vojtovich writes: > Since Alexey's patch wasn't yet accepted by MySQL we need his > confirmation that we can take it under BSD-new or MCA > terms. @akopytov, could you confirm? That _really_ is completely ridiculous! So here we have a patch. You will gladly

Re: [Maria-developers] Joinable threads

Hi! On Wed, May 4, 2016 at 11:13 AM, Sergey Vojtovich wrote: > Hi Monty, > > I vaguely recall you told me once that you like detached threads more than > joinable, specifically for service threads. Could you remind me what were > the reasons behind it? > > I need this to fix

Re: [Maria-developers] MDEV-9712 Performance degradation of nested NULLIF

Hi, Alexander! On May 04, Alexander Barkov wrote: > >> @@ -2513,7 +2530,14 @@ void Item_func_nullif::update_used_tables() > >> } > >> else > >> { > >> -Item_func::update_used_tables(); > >> +/* > >> + No needs to iterate through args[2] when it's just a copy of > >>

[Maria-developers] Please review MDEV-10030 sql_yacc.yy: Split table_expression and remove PROCEDURE from create_select, select_paren_derived, select_derived2, query_specification

Hi Sergei, Please review a patch for MDEV-10030, which is a part of MDEV-8909 union parser cleanup. Thanks! commit 0f4f2e3b5ebabce1308c45772785aec084092674 Author: Alexander Barkov Date: Thu May 5 12:29:36 2016 +0400 MDEV-10030 sql_yacc.yy: Split table_expression and