Hi!
I reviewed yet another time the code and have following toughts:
a) if we store the tag separately (like deterministic or not) then separate
field is better
b) If we get the value form function content then flag is what we need.
for now we are going by a) i.e. we clearly in the header of th
Hi Varun,
I've reviewed your patch. Looks good from my side. Just stylistic comments.
Feel free to keep your own version if you don't agree with them.
I think that you could have used the m_flags field, but having a specific
member makes things a lot clearer in my opinion. Perhaps Sanja has a
dif
Yes, the decision is right. I'll check later the code on github.
On Tue, May 24, 2016 at 10:27 AM, Varun Gupta
wrote:
> Hi,
> I had been going through the LEX struct and could not find any flag member
> there which could be used to specify if a function is aggregate or not. So
> i created the ne
Hi,
I had been going through the LEX struct and could not find any flag member
there which could be used to specify if a function is aggregate or not. So
i created the new flag inside sp_head, so as to make sure it could be used
for stored procedures too in the future.
I have committed the changes
4 matches
Mail list logo
