Re: [Maria-developers] [Commits] 2c9bb42: MDEV-11432 Change the informational redo log format tag to "MariaDB 10.2.3"

Hi, ok to push. R: Jan On Thu, Dec 1, 2016 at 8:36 AM, wrote: > revision-id: 2c9bb42d901fc4f48f4884e4a85af74eae6d0929 > (mariadb-10.2.2-91-g2c9bb42) > parent(s): dc9f919f27fccfeb0de3ab392f33bc5efdfd59a0 > author: Marko Mäkelä > committer: Marko Mäkelä > timestamp:

Re: [Maria-developers] Please review MDEV-11298 Split Item_func_hex::val_str_ascii() into virtual methods in Type_handler

Hello Alexey, Thanks for review! I addressed your suggestions. Also, Vicentiu expressed a concern (when reviewing another patch with the same approach) that this kind of cast that I used in sql_type.cc might be unsafe, because it's non-standard. We're discussion other possible solutions now.

[Maria-developers] Review form MDEV-11297 patch

Hi Varun, Please find my review comments below. We'll need another review pass once these are addressed. > commit e9d1969a9758801674828f26431306350bb4c0ab > Author: Varun > Date: Mon Nov 28 15:09:03 2016 +0530 > > LIMIT Clause without optimisation added to

Re: [Maria-developers] Review for MDEV-9069

Hi, Georg! On Nov 03, Georg Richter wrote: > Hello Serg, > > attached you will find the patch for MDEV-9069. > > /Georg > > -- > Georg Richter, Senior Software Engineer > MariaDB Corporation Ab > From bde4b9d0683f115fa55bb6d2e2164739f89d732c Mon Sep 17 00:00:00 2001 > From: Georg Richter

Re: [Maria-developers] Working on spider patches, MDEV-7701

Hi! > The above test could be simple: > > additional_table_flags &= (ulonglong) ((*file)->ha_table_flags(); > > Should be the same thing. I did however remove this code, as > HA_CAN_BG... are not used anywhere in the current spider code. See > comment below. ok. > I also changed so that

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > Is this because the table ta_l is connected to a remote table trough > spider that already has the > rows in it ? Yes. > If yes, then it would be good to have a comment about this is in the > test and also insert > data that is different from the original one to make this part clear.

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > All spider tests now passes in 10.2 Great! > This fails as the above variable doesn't yet exists. > I will update the test results as soon the variable exists again. ok. Thanks, Kentoku 2016-11-25 0:55 GMT+09:00 Michael Widenius : > Hi! > > On Thu, Nov 24,

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! > Better to instead test MYSQL versions than have a define that is > always declared. > With current code, the last #else in spd_param.cc will never be used: You right and I'll add code of testing MYSQL versions in Spider code later. Thanks, Kentoku 2016-11-24 23:07 GMT+09:00 Michael

Re: [Maria-developers] 1579140: MDEV-11005: Incorrect error message when using ONLINE alter table with GIS

Sergei Golubchik writes: > ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE, the next error > message, was added in 10.0. If you add a new error message here, then > the error number for ER_SQL_SLAVE_SKIP_COUNTER_NOT_SETTABLE_IN_GTID_MODE > will change. But 10.0 is GA, and

Re: [Maria-developers] 1579140: MDEV-11005: Incorrect error message when using ONLINE alter table with GIS

Hi, Jan! On Oct 10, Jan Lindström wrote: > parent(s): a6f032af5778018051d41fc8ba7e9c983b4b7fbf > author: Jan Lindström > committer: Jan Lindström > timestamp: 2016-10-10 12:34:06 +0300 > message: > > MDEV-11005: Incorrect error message when using ONLINE alter table with GIS > > Fix incorrect

Re: [Maria-developers] [Commits] dabf6ca: MDEV-10340: support COM_RESET_CONNECTION

Hi, Oleksandr! On Oct 17, Oleksandr Byelkin wrote: > revision-id: dabf6cac60987e88266396a28e40b341899704e6 > (mariadb-10.2.2-49-gdabf6ca) > parent(s): 8303aded294ce905bbc513e7ee42623d5f1fdb50 > committer: Oleksandr Byelkin > timestamp: 2016-10-17 16:59:36 +0200 > message: > > MDEV-10340: