Re: [Maria-developers] MDEV-11503 Introduce Type_handler::make_in_vector() and Item_func_in_fix_comparator_compatible_types()

2016-12-09 Thread Alexander Barkov
Hello Sanja, here's a new version, with a better test coverage. On 12/09/2016 01:44 PM, Alexander Barkov wrote: > Hello Sanja, > > Please review a patch for MDEV-11503. > > Thanks! > commit 29ec93e1595b019b9ab4f2f440c2b9b45dee928e Author: Alexander Barkov Date: Sat Dec

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread jocelyn fournier
When running the server in debug, I hit the following assert : 2016-12-09 18:12:03 140057763633920 [Note] Slave SQL thread initialized, starting replication in log 'mysql-bin.001445' at position 4, relay log './sql-slave-relay-bin.01' position: 4; GTID position '0-1-483188364' mysqld:

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread Kristian Nielsen
jocelyn fournier writes: > It seems the entry corresponds to a table having a trigger, don't know > if it could have an impact on the parallel replication ? Triggers should work ok, otherwise it would be a bug. But it's hard to tell what is going on without a way

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread jocelyn fournier
I've just check what happened at position 1046751490 in the binlog. It seems the entry corresponds to a table having a trigger, don't know if it could have an impact on the parallel replication ? /*!11 SET @@session.gtid_seq_no=482509269*//*!*/; BEGIN /*!*/; # at 1046751112 #161209

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread jocelyn fournier
Ok, to make it clear, here are the actions related to the log entries : *** Server startup : *** 2016-12-09 11:48:05 140259564768000 [Note] Slave I/O thread: connected to master 'repl@172.16.4.1:3306',replication starts at GTID position '0-1-482499150' 2016-12-09 11:48:05 140259546905344

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread jocelyn fournier
Actually it's normal stop slave. The first one is when I shutted down the server and switched to the new version. The second one when I stop slave & set global slave_parallel_mode=optimistic; and the last one when I put back the conservative mode. So there's actually nothing in the log

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread Kristian Nielsen
jocelyn fournier writes: > I've just tried your tokudb_optimistic_parallel_replication branch, > and it behaves very strangely: the SQL thread stop by itself without > any replication error when the parallel_mode is set to optimistic. That's strange, the log looks

Re: [Maria-developers] Fix for TokuDB and parallel replication

2016-12-09 Thread jocelyn fournier
Hi Kristian, I've just tried your tokudb_optimistic_parallel_replication branch, and it behaves very strangely: the SQL thread stop by itself without any replication error when the parallel_mode is set to optimistic. In the error.log : 2016-12-09 11:48:05 140259564768000 [Note] Slave I/O

[Maria-developers] MDEV-11503 Introduce Type_handler::make_in_vector() and Item_func_in_fix_comparator_compatible_types()

2016-12-09 Thread Alexander Barkov
Hello Sanja, Please review a patch for MDEV-11503. Thanks! commit f6ed01873f184a717f52b718122fd18fab9dafa2 Author: Alexander Barkov Date: Fri Dec 9 13:43:36 2016 +0400 MDEV-11503 Introduce Type_handler::make_in_vector() and Item_func_in_fix_comparator_compatible_types()