Re: [Maria-developers] MDEV-10142 - bb-10.2-compatibility

2016-12-19 Thread Alexander Barkov
Hello Jerome, On 12/19/2016 05:16 PM, jerome brauge wrote: > Hello, > To build this branch on windows (Visual Studio Express 2015), I have to add > "#pragma warning( disable : 4099 )" in sql_lex.h. > But I don't know if it's the right solution. What happened without #pragma? > > I have some

Re: [Maria-developers] 10.3 branches

2016-12-19 Thread Alexander Barkov
Hi Sergei, On 12/19/2016 08:29 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Dec 19, Alexander Barkov wrote: >> >> I created a new branch bb-10.2-ext. >> >> So the tentative data flow looks like this: >> >> 10.2-->10.3 <---(once) >> \ ^ ^ >> \|

Re: [Maria-developers] 10.3 branches

2016-12-19 Thread Alexander Barkov
Hello Sergey, On 12/19/2016 07:26 PM, Sergey Petrunia wrote: > On Mon, Dec 19, 2016 at 10:49:42AM +0400, Alexander Barkov wrote: >> Hi Sergei, >> >> Thanks! Please see my replies inline: >> >> On 12/16/2016 05:38 PM, Sergei Golubchik wrote: >>> Hi, Alexander! >>> >>> Sure, 10.2-ext or 10.3-base -

Re: [Maria-developers] 10.3 branches

2016-12-19 Thread Sergei Golubchik
Hi, Alexander! On Dec 19, Alexander Barkov wrote: > > I created a new branch bb-10.2-ext. > > So the tentative data flow looks like this: > > 10.2-->10.3 <---(once) > \ ^ ^ > \| | >\- bb-10.2-ext ---> bb-10.2-compatibility > > > > -

Re: [Maria-developers] 10.3 branches

2016-12-19 Thread Sergey Petrunia
On Mon, Dec 19, 2016 at 10:49:42AM +0400, Alexander Barkov wrote: > Hi Sergei, > > Thanks! Please see my replies inline: > > On 12/16/2016 05:38 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > Sure, 10.2-ext or 10.3-base - whatever you prefer. > > I understand that bb-10.2-compatibility

Re: [Maria-developers] [Commits] 9f863a15b03: MDEV-11602 InnoDB leaks foreign key metadata on DDL operations

2016-12-19 Thread Jan Lindström
ok to push. Most likely the double free was result of some other bug fixed later. R: Jan On Mon, Dec 19, 2016 at 4:00 PM, wrote: > revision-id: 9f863a15b037c0ddffc2d12c1f7d841466f9f345 (mariadb-10.0.28-27- > g9f863a15b03) > parent(s):

[Maria-developers] MDEV-10142 - bb-10.2-compatibility

2016-12-19 Thread jerome brauge
Hello, To build this branch on windows (Visual Studio Express 2015), I have to add "#pragma warning( disable : 4099 )" in sql_lex.h. But I don't know if it's the right solution. I have some questions: - I read the comment of Michael Widenius on subtask MDEV-10574. I think that it's important

Re: [Maria-developers] [Commits] 8bfc350: MDEV-10148: Database crashes in the query to the View

2016-12-19 Thread Oleksandr Byelkin
Hi, Sergei! On 12/16/2016 03:16 PM, Sergei Petrunia wrote: revision-id: 8bfc35041195b46c8f4666dd02f600e878f45643 parent(s): 96d2e0480ffbc36c803db5a7d5bcefd3470c5f72 committer: Sergei Petrunia branch nick: 5.5 timestamp: 2016-12-16 17:16:02 +0300 message: MDEV-10148: Database crashes in the

Re: [Maria-developers] Please review MDEV-10524 Assertion `arg1_int >= 0' failed in Item_func_additive_op::result_precision()

2016-12-19 Thread Alexander Barkov
On 12/16/2016 09:31 PM, Sergei Golubchik wrote: > Hi, Alexander! > > Looks ok. One question below > > On Dec 15, Alexander Barkov wrote: >> commit 72817bb386320080de87f9cfe899e6f74341d251 >> Author: Alexander Barkov >> Date: Thu Dec 15 19:40:09 2016 +0400 >> >>