Re: [Maria-developers] Please review MDEV-11672 mysql_list_field() returns wrong default values for VIEW

Sanja, On 12/27/2016 09:39 PM, Oleksandr Byelkin wrote: > Hi, Alexander! > > It is OK to push after fixing in the comment of the patch > mysql_list_fields with mysqld_list_fields (IMHO it is server function > do not set type etc.) Thanks for review! I fixed the comment. But then I realized

Re: [Maria-developers] [Commits] 9416779: MDEV-11636 Extra persistent columns on slave always gets NULL in RBR

Hi Kristian, On Wed, Dec 28, 2016 at 2:43 AM, Kristian Nielsen wrote: > abc writes: > >> I have updates the patch, please have a look, > >> revision-id: 941677928aa40aa1f5abf981b74d2c3c80441459 >> (mariadb-galera-10.0.28-8-g9416779) >>

Re: [Maria-developers] [Commits] 9416779: MDEV-11636 Extra persistent columns on slave always gets NULL in RBR

abc writes: > I have updates the patch, please have a look, > revision-id: 941677928aa40aa1f5abf981b74d2c3c80441459 > (mariadb-galera-10.0.28-8-g9416779) > parent(s): be430b80df0cdd4eba32df1570195721dbfd1b39 > author: Sachin Setiya > committer: Sachin Setiya >

Re: [Maria-developers] check_sql_mode

Hi, jerome! On Dec 27, jerome brauge wrote: > Sergei, > On SQLServer these kind of option (ANSI_NULLS, CONCAT_NULL_YIELDS_NULL > and so on) can be set at session level or inside stored procedure (but > not in function). In the last case, the scope of the setting is > limited to the stored

Re: [Maria-developers] [External] check_sql_mode

Sergei, On SQLServer these kind of option (ANSI_NULLS, CONCAT_NULL_YIELDS_NULL and so on ) can be set at session level or inside stored procedure (but not in function). In the last case, the scope of the setting is limited to the stored procedure. Jérôme. -Message d'origine- De :

Re: [Maria-developers] [External] check_sql_mode

Hi, Simon! On Dec 27, Simon J Mudd wrote: > > Slightly off topic but changes in sql_mode has the potential to cause > problems with major version changes and incompatible behaviour. So > combining all sorts of new settings into this variable does not seem > like a good idea to me. It’s already

[Maria-developers] Please review MDEV-11672 mysql_list_field() returns wrong default values for VIEW

Hello Sanja, Can you please review a patch for MDEV-11672? Thanks! commit c41ccee0fcf5d5354faceadcb77e2e508075be74 Author: Alexander Barkov Date: Tue Dec 27 19:44:54 2016 +0400 MDEV-11672 mysql_list_field() returns wrong default values for VIEW The problem

Re: [Maria-developers] [External] check_sql_mode

Thanks Simon, Sergei. Initially , I've done this change only for sql_mode=oracle (where concat null and a string doesn’t return null) but as SQLServer has an option to have the same behavior (set CONCAT_NULL_YIELDS_NULL ON|OFF), I was thinking to add a dedicated option. How replication will

Re: [Maria-developers] [External] check_sql_mode

> On 27 Dec 2016, at 11:35, Sergei Golubchik wrote: > > Hi, jerome! > > On Dec 27, jerome brauge wrote: >> Hello, >> I'm trying to add an option to sql_mode. >> For this, I'm adding in sql_class.h : >> #define MODE_CONCAT_NULL_YIELDS_NULL(1ULL << 32) >> >> But now, my

[Maria-developers] MDEV-11636 Extra persistent columns on slave always gets NULL in RBR

Hi Kristian, I have updates the patch, please have a look, http://lists.askmonty.org/pipermail/commits/2016-December/010338.html. I also created a branch bb-10-0-gal-sachin , where I pushed this commit . Build bot status:-

Re: [Maria-developers] check_sql_mode

Hi, jerome! On Dec 27, jerome brauge wrote: > Hello, > I'm trying to add an option to sql_mode. > For this, I'm adding in sql_class.h : > #define MODE_CONCAT_NULL_YIELDS_NULL(1ULL << 32) > > But now, my serveur doesn't start and show "Sysvar 'sql_mode' failed 'def_val > <=

[Maria-developers] check_sql_mode

Hello, I'm trying to add an option to sql_mode. For this, I'm adding in sql_class.h : #define MODE_CONCAT_NULL_YIELDS_NULL(1ULL << 32) But now, my serveur doesn't start and show "Sysvar 'sql_mode' failed 'def_val <= my_set_bits(typelib.count)'" The problem seems to be in sys_vars.ic