Hi Alexander!
Ok to push this one. I really like how this splits the function.
Please put a comment that collation does not make sense (and thus is no
concern) for numerical type handlers in the function where you compare them
by pointer address.
Also, Item_get_cache should be on a separate line
Hello Sanja,
Sending another version, as discussed on slack.
Thanks!
On 01/12/2017 01:12 PM, Alexander Barkov wrote:
> Hello Sanja,
>
> Can you please review a patch for MDEV-11030?
>
> Thanks!
>
commit 56a3992a095a5f3c3ca1953dda3b3204b3c8d81e
Author: Alexander Barkov
Date: Thu Jan 12 15:
Hello Sanja,
Can you please review a patch for MDEV-11030?
Thanks!
commit f50bf07ed91a8a0c5db4628ed051070699b8563a
Author: Alexander Barkov
Date: Thu Jan 12 13:04:50 2017 +0400
MDEV-11030 Assertion `precision > 0' failed in decimal_bin_size
Fixing Item_func_signed::decimal_precis
3 matches
Mail list logo