Re: [Maria-developers] Dead code Type_handler_hybrid_field_type::m_vers_trx_id ?

Hi Aleksey, Sergei, On 04/11/2018 01:34 AM, Aleksey Midenkov wrote: > Hi Alexander! > > On Tue, Apr 10, 2018 at 12:15 PM, Alexander Barkov wrote: >> Hi Aleksey, >> >> You added Type_handler_hybrid_field_type::m_vers_trx_id. >> >> Is it really needed? It seems to be always

Re: [Maria-developers] Questions regarding closing partitions in MDEV-11084

Hi, Mattias, guys! While investigating the crash, i'd like to discuss that it seems to close partitions whenever it is not used in a statement (i.e. require it to be reopened in the next statement that would use another partition Yes, it does that, handling statements with the specified

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

Hi Sergei, If you disable just DebugMutex but leave UNIV_DEBUG enabled, how do you make assertions like this work properly: `ut_ad(mutex_own())`? Regards, Sergey On Mon, Apr 16, 2018 at 01:30:33PM +0200, Sergei Golubchik wrote: > Hi, Sergey! > > On Apr 16, Sergey Vojtovich wrote: > > > >

Re: [Maria-developers] innobase/sync0policy.h converts opaquepthread_t to ULINT

I’m not sure what is the discussion about exactly. On Linux, pthread_t has exactly the same size as ulint. On 32bit Linux , this “invalid cast from type ‘os_thread_id_t {aka long unsigned int}’ to type ‘ulint {aka unsigned int}’” Is a compiler nonsense, because the types are 100% compatible

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

Hi, Sergey! On Apr 16, Sergey Vojtovich wrote: > > Something similar (HAVE_IB_ATOMIC_PTHREAD_T_GCC) was removed in > 2b47f8ff03845f7ffe2fa3bd583dd4123dae2b61. IIRC the reason was: relevant code > didn't follow this macro properly and this code was still functional. > > You may use

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

Hi! Something similar (HAVE_IB_ATOMIC_PTHREAD_T_GCC) was removed in 2b47f8ff03845f7ffe2fa3bd583dd4123dae2b61. IIRC the reason was: relevant code didn't follow this macro properly and this code was still functional. You may use os_thread_pf(os_thread_get_curr_id()) to cast it to ulint. Yes, it is

Re: [Maria-developers] a91fdd1: Fixed the bug mdev-15575 different results when using CTE and big_tables=1.

Hi, Igor On Apr 14, IgorBabaev wrote: > revision-id: a91fdd1288b3cbc5616f2ef9e0ce04bf7f0ef9ce > (mariadb-10.2.14-35-ga91fdd1) > parent(s): 740fc2ae084f8f81990de557d696aefbc507752d > author: Igor Babaev > committer: Igor Babaev > timestamp: 2018-04-14 21:32:41 -0700 > message: > > Fixed the bug

Re: [Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

Hi, Teodor! I'd just say that this MutexDebug thing relies on pthread_t being ulint. So, I'd add a test to innodb.cmake, like, PTHREAD_T_IS_ULINT or detected that by the compiler in sync0policy.h. And only compiled MutexDebug is pthread_t is ulint. Or, at least, sizeof(pthread_t) ==

[Maria-developers] Questions regarding closing partitions in MDEV-11084

Hi MariaDB Devs, I tried to evaluate spider engine and found an issue where it crashes, most likely due to MDEV-11084 (Stacktrace and reproducible test case attached). That also leads me to wonder about the performance for partitioned tables after MDEV-11084, when it seems to close partitions

[Maria-developers] innobase/sync0policy.h converts opaque pthread_t to ULINT

Hi, While trying to build on macOS 10.13.4 with clang 9.1.0 I originally came across this error: -- .../storage/innobase/include/sync0policy.h:79:4: error: cannot initialize a parameter of type 'int64' (aka 'long long') with an rvalue of type 'os_thread_id_t' (aka '_opaque_pthread_t *')

Re: [Maria-developers] Fwd: [Commits] b32031991e4: initial oracle parser fix

On 04/16/2018 10:38 AM, Alexander Barkov wrote: > - Adds a function relink_hack() to properly bind st_select_lex containing > an IN/EXISTS subselect to thd->lex->builtin_select. This is needed for > the cases when the statement does not do main_select_push(). > I does not know this code