Re: [Maria-developers] c39f74ce0d9: MDEV-16974 Application period tables: UPDATE

2019-01-31 Thread Nikita Malyavin
On Fri, Feb 1, 2019 at 3:16 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Jan 30, Nikita Malyavin wrote: > > > > > > #define ER_NO_CONST_EXPR_IN_RANGE_OR_LIST_ERROR > ER_NOT_CONSTANT_EXPRESSION > > > > > This error seems to be unused... Considering that, do You still want the > > macro added to

Re: [Maria-developers] 43296f4: MDEV-17599 ALTER TABLE DROP CONSTRAINT does not work for foreign keys.

2019-01-31 Thread Sergei Golubchik
Hi, Alexey! On Jan 31, Alexey Botchkov wrote: > > can a CHECK constraint have the same name as an existing FK? > > Yes, it can. > So in this case the 'ALTER ... DROP CONSTRAINT c' drops the FOREIGN KEY. On > the second call this ALTER > removes the CHECK. > How do you like that? > I think it's o

Re: [Maria-developers] 43296f4: MDEV-17599 ALTER TABLE DROP CONSTRAINT does not work for foreign keys.

2019-01-31 Thread Sergei Golubchik
Hi, Alexey! Few questions first: * can a CHECK constraint have the same name as an existing FK? * what about UNIQUE constraint? it's also a constraint. The standard says that DROP CONSTRAINT should work for uniques, and ALTER already supports ADD CONSTRAINT UNIQUE (and ADD CONSTRAINT FOREIGN

Re: [Maria-developers] c39f74ce0d9: MDEV-16974 Application period tables: UPDATE

2019-01-31 Thread Sergei Golubchik
Hi, Nikita! On Jan 30, Nikita Malyavin wrote: > > > > #define ER_NO_CONST_EXPR_IN_RANGE_OR_LIST_ERROR ER_NOT_CONSTANT_EXPRESSION > > > This error seems to be unused... Considering that, do You still want the > macro added to mysql.h? Okay, if it's never issued, then no need to add the define. >

Re: [Maria-developers] Review for follow up fix of MDEV-17323: Backport INFORMATION_SCHEMA.CHECK_CONSTRAINTS to 10.2

2019-01-31 Thread Anel Husakovic
Hi Vicentiu, the patch is updated and notes are in comment: https://github.com/MariaDB/server/pull/1127/ 1. Should I support embedded server in this case, since it is supported in `10.3`? What else could be done => According to the comment in this task https://jira.mariadb.org/browse/MDEV-14474?f

[Maria-developers] Review for follow up fix of MDEV-17323: Backport INFORMATION_SCHEMA.CHECK_CONSTRAINTS to 10.2

2019-01-31 Thread Vicențiu Ciorbaru
Hi Anel! This is not a terribly bad patch, however you have forgotten the following things: You removed the misspelled is_check_constraint.test file, but forgot to remove the is_check_constraint.result file. Now we would be left with a dangling result file. Please be more careful next time. Yo