[Maria-developers] Weekly Report

2019-07-07 Thread Rucha Deodhar
Report for week 6: Hello! This week I was able to make replace...returning work. But before pushing changes for insert...select...returning, I had done a git merge because I didn't know I was supposed to do a git rebase. While undoing the merge I ran into a problem. With help from mentors I was

Re: [Maria-developers] INSERT ... RETURNING Initial code review

2019-07-07 Thread Rucha Deodhar
Hello! Thanks for the review. It will indeed help me write better code and test cases. To begin with, I' ll first get familiar with git bisect. I'll keep you updated about my progress. Regards, Rucha Deodhar On Sun, Jul 7, 2019, 7:16 PM Vicențiu Ciorbaru wrote: > Hi Rucha! > > > Here is the

[Maria-developers] INSERT ... RETURNING Initial code review

2019-07-07 Thread Vicențiu Ciorbaru
Hi Rucha! Here is the promised review. I have run the main test suite locally and have noticedthat some tests fail if you run with a debug build. The failure is an assertionfailure on the protocol level. This means you forgot to call a my_ok or my_errorat an appropriate time. I suggest you try and