Re: [Maria-developers] d7b274fa257: MDEV-16932: ASAN heap-use-after-free in my_charlen_utf8 / my_well_formed_char_length_utf8 on 2nd execution of SP with ALTER trying to add bad CHECK

2019-07-15 Thread Sergei Golubchik
Hi, Oleksandr! A couple of minor comments, see below On Jul 15, Oleksandr Byelkin wrote: > revision-id: d7b274fa257 (mariadb-10.2.25-63-gd7b274fa257) > parent(s): 64900e3d7c3 > author: Oleksandr Byelkin > committer: Oleksandr Byelkin > timestamp: 2019-07-11 13:29:51 +0200 > message: > >

Re: [Maria-developers] Interaction between rpl_slave_state and rpl_binlog_state

2019-07-15 Thread Kristian Nielsen
Hi Andrei! The @@gtid_current_pos exists for one sole purpose. This is to let the user promote a slave as the new master and attach the old master as a slave to the new master. By using master_use_gtid=current_pos, the exact same command can be used to attach a slave to the new master,

Re: [Maria-developers] [Commits] 7cabdc461b2: MDEV-6860 Parallel async replication hangs on a Galera node

2019-07-15 Thread Kristian Nielsen
Sachin Setiya writes: > On Mon, Jul 15, 2019 at 4:00 PM Kristian Nielsen > wrote: >> (I wonder if this isn't just another symptom of the underlying problem that >> Galera has never been integrated properly into MariaDB and the group commit >> algorithm / transaction master?). > For example

Re: [Maria-developers] [Commits] 7cabdc461b2: MDEV-6860 Parallel async replication hangs on a Galera node

2019-07-15 Thread Sachin Setiya
Hi Kristian! On Mon, Jul 15, 2019 at 4:00 PM Kristian Nielsen wrote: > > sachin.set...@mariadb.com writes: > > > revision-id: 7cabdc461b24fdebe599799d7964efa4b53815e3 > > (mariadb-10.1.39-91-g7cabdc461b2) > > > > MDEV-6860 Parallel async replication hangs on a Galera node > > > > Wait for

Re: [Maria-developers] [Commits] 7cabdc461b2: MDEV-6860 Parallel async replication hangs on a Galera node

2019-07-15 Thread Kristian Nielsen
sachin.set...@mariadb.com writes: > revision-id: 7cabdc461b24fdebe599799d7964efa4b53815e3 > (mariadb-10.1.39-91-g7cabdc461b2) > > MDEV-6860 Parallel async replication hangs on a Galera node > > Wait for previous commit beore preparing next transation for galera > diff --git