Re: [Maria-developers] 6768e3a2830: MDEV-22166 MIGRATE PARTITION: move out partition into a table

2021-09-06 Thread Aleksey Midenkov
Sergei, On Wed, Sep 1, 2021 at 8:51 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Aug 27, Aleksey Midenkov wrote: > > > > > > I still don't quite understand why did you introduce a new method > > > with frm backup and a (low probability) window where it won't clean > > > up. > > > > > >

Re: [Maria-developers] 6768e3a2830: MDEV-22166 MIGRATE PARTITION: move out partition into a table

2021-09-06 Thread Sergei Golubchik
Hi, Aleksey! On Sep 06, Aleksey Midenkov wrote: > > > > I did. I also grepped include/ for IF_[A-Z]+, we have > > > > IF_WIN, IF_EMBEDDED, IF_PARTITIONING, IF_WSREP, IF_DBUG, IF_VALGRIND > > > > together they're used on 165 lines. It would be very unhelpful, if > > IF_DBUG would suddenly deviate

Re: [Maria-developers] 6768e3a2830: MDEV-22166 MIGRATE PARTITION: move out partition into a table

2021-09-06 Thread Aleksey Midenkov
Hi Sergei! On Thu, Sep 2, 2021 at 5:13 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Sep 01, Aleksey Midenkov wrote: > > On Wed, Sep 1, 2021 at 10:20 PM Sergei Golubchik wrote: > > > On Sep 01, Aleksey Midenkov wrote: > > > > > > > > > > > > Looks like IF_DBUG is superfluous macro and

Re: [Maria-developers] 6768e3a2830: MDEV-22166 MIGRATE PARTITION: move out partition into a table

2021-09-06 Thread Aleksey Midenkov
Hi Sergei! On Sat, Sep 4, 2021 at 3:34 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Aug 26, Sergei Golubchik wrote: > > > > > > > > ALTER ... MOVE TABLE table_name TO PARTITION (...) > > > > ALTER ... MOVE PARTITION ... TO TABLE table_name > > > > > > > There is no MOVE symbol and