Hi Sergei,
Please have a look into the patch for MDEV-7288.
It consists of the USER/ROLE related part of the big
GSoC patch from Sriram that you reviewed earlier, with
review suggestions addressed.
You earlier had the following suggestions/questions:
diff --git a/sql/sql_acl.cc
Hi Pavel,
On 12/19/2014 01:13 AM, Pavel Ivanov wrote:
On Thu, Dec 18, 2014 at 12:24 AM, Oleksandr Byelkin
sa...@montyprogram.com wrote:
Hi!
On 18.12.14 08:52, Alexander Barkov wrote:
The same behaviour is observed with DROP USER.
IMHO it is general problem for all our multi- commands
Hi Sergei,
On 12/22/2014 02:26 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Dec 22, Alexander Barkov wrote:
Hi Sergei, Kristian,
I'm looking at:
MDEV-7268 Column of table cannot be converted from type 'decimal(0,?)'
to type ' 'decimal(10,7)'
This bug cannot be fixed in general case
Hi Daniel,
On 12/22/2014 03:30 PM, Daniel Black wrote:
- Original Message -
Hi, Alexander!
On Dec 22, Alexander Barkov wrote:
Hi Sergei, Kristian,
I'm looking at:
MDEV-7268 Column of table cannot be converted from type 'decimal(0,?)'
to type ' 'decimal(10,7)'
This bug cannot
Hi Kristian,
On 12/23/2014 02:08 PM, Kristian Nielsen wrote:
On Dec 22, Alexander Barkov wrote:
Hi Sergei, Kristian,
So, there are a lot of details in that bug and in the discussion, and I did
not get a full overview of the problem, or what you were asking from me, but
I'll try to answer
mysql_upgrade to rebuild tables with the old
DECIMAL automatically.
Looks like a lot of work...
On 12/23/2014 02:17 PM, Alexander Barkov wrote:
Hi Kristian,
On 12/23/2014 02:08 PM, Kristian Nielsen wrote:
On Dec 22, Alexander Barkov wrote:
Hi Sergei, Kristian,
So, there are a lot
Hello Kentoku,
Can you please have a look into this problem?
https://mariadb.atlassian.net/browse/MDEV-7440
Can you fix please?
Thanks.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Hi Sergei,
Thanks for your suggestions that you gave in the first review.
Please review a new patch for MDEV-7281, which addresses your suggestions.
diff --git a/mysql-test/r/create_drop_event.result b/mysql-test/
/create_drop_event.result
again, same thing. I don't see a test that the
Hello Sergei,
Please review a patch that fixes the problem described in MDEV-7574.
The idea is that a SELECT from a view over a CONNECT table
now checks FILE privileges of the view definer
(unless CREATE VIEW states SQL SECURITY INVOKER).
It looks like a very good idea and gives more
Hi Hartmut,
On 01/10/2015 04:08 AM, Hartmut Holzgraefe wrote:
Any idea how that happened, as I can't find anything that seems
to be related in the 5.5.38 changelog?
http://bugs.mysql.com/bug.php?id=68557
From a glance, the patch for
MDEV-5459 Illegal mix of collations for datetime'
fixed
Hi Serg,
Please review a patch for MDEV-7286.
Thanks.
diff --git a/mysql-test/r/create.result b/mysql-test/r/create.result
index ec70dba..e90dba0 100644
--- a/mysql-test/r/create.result
+++ b/mysql-test/r/create.result
@@ -2120,6 +2120,11 @@ CREATE TRIGGER f BEFORE INSERT ON t1 FOR EACH ROW
Hi Sergei,
Please review a patch for MDEV-6566.
Thanks.
diff --git a/include/m_ctype.h b/include/m_ctype.h
index f08efb4..4fa8779 100644
--- a/include/m_ctype.h
+++ b/include/m_ctype.h
@@ -444,7 +444,55 @@ struct my_charset_handler_st
size_t(*scan)(CHARSET_INFO *, const char *b,
Hi Sergei,
On 03/12/2015 11:57 PM, Sergei Golubchik wrote:
Hi, Alexander!
On 03/12/2015 08:47 PM, Sergei Golubchik wrote:
Hi, Alexander!
See below.
My main concern is the stability of the charset API.
I'd like it to be moved into a service, as plugins surely need it
(not will need,
Hi Sergei,
Thanks for review. Please see comments inline.
On 03/12/2015 08:47 PM, Sergei Golubchik wrote:
Hi, Alexander!
See below.
My main concern is the stability of the charset API.
I'd like it to be moved into a service, as plugins surely need it
(not will need, various plugins need it
Hi Sergei,
Do you think it's ok to change FixVersion for MDEV-7649 to 10.1?
It requires some changes in sql_lex.cc, sql_yacc.yy and needs
a new Item_string-alike Item to handle such malformed strings
properly. Too big change to 10.0 or 5.5.
___
Hi Sergei,
On 02/26/2015 08:02 PM, Sergei Golubchik wrote:
Hi, Alexander!
Please review a patch for MDEV-7286.
Pretty good. I have just a couple of comments about
build_trig_stmt_query() usage, see below.
Thanks. A fixed version is attached.
See my comments inline:
diff --git
Hi Sergei,
On 02/19/2015 07:12 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 17, Alexander Barkov wrote:
From what I understood, FILE_ACL is written (among the other
privileges) into thd-security_ctx.privilege in
TABLE_LIST::prepare_security(). In case of a DEFINER view,
thd
Hi Sergei, Kristian, all,
Thanks to everyone who participated in the discussion on this topic.
I tried to collect all ideas into a JIRA task:
https://mariadb.atlassian.net/browse/MDEV-7628
Please have a look.
Thanks.
___
Mailing list:
Hi Sergey,
Can you please review the step 2 part of MDEV-7950?
This is rather a mechanical cut-and-paste change.
It does the following things:
1. Removes the function build_equal_items_for_cond() and
introduces a new method Item::build_equal_items() instead,
with specific
Hi Daniel,
On 04/18/2015 08:30 AM, Daniel Black wrote:
- Original Message -
Hi Bar,
Can you please merge the following patch 10.0 - 10.1?
commit bc902a2bfc46add0708896c07621e3707f66d95f
Author: Alexander Barkov b...@mariadb.org
Date: Fri Mar 13 16:12:54 2015
Hi Kristian, Daniel,
I just pushed a merge patch into 10.1.
On 04/20/2015 11:28 AM, Alexander Barkov wrote:
Hi Daniel,
On 04/18/2015 08:30 AM, Daniel Black wrote:
- Original Message -
Hi Bar,
Can you please merge the following patch 10.0 - 10.1?
commit
Hi Sergei,
Please review a patch for MDEV-7778.
As agreed on IRC, this is a merge from the latest MySQL, which has
already fixed the problem.
Greetings.
diff --git a/mysql-test/r/function_defaults.result b/mysql-test/r/function_defaults.result
index 50183a1..b8f42b8 100644
---
Hi Olivier,
MariaDB fails with some Connect tests on IBM s390.
Please have a look into Debian build bot results:
https://buildd.debian.org/status/fetch.php?pkg=mariadb-10.0arch=s390xver=10.0.17-1stamp=1428754888
I currently have a temporary access to an IMB s390 machine.
It would be nice to
in Item_cond::build_equal_items? They were also present in
original code.
It's because Item_cond_and::build_equal_items() calls
update_used_tables() at the end.
(discussed on IRC)
Regards,
Sergey
On Thu, Apr 23, 2015 at 07:17:50PM +0400, Alexander Barkov wrote:
Hi Sergey,
Can you please review
Hi Sergey,
Please review a patch for the next step for MDEV-7950
(one small thing at a time, to avoid huge unclear patches)
Thanks.
diff --git a/sql/item.h b/sql/item.h
index 043605a..a665d23 100644
--- a/sql/item.h
+++ b/sql/item.h
@@ -1133,6 +1133,13 @@ class Item: public Type_std_attributes
Hi Sergey,
Please review the next iteration for MDEV-7950.
This one splits the function add_key_fields() into a method in Item.
This change removes about 3 virtual calls item-type(), as well as some
virtual calls item_func-functype(), and adds one virtual call
item-add_key_fields() instead.
Hi Sergey,
please review the next step for MDEV-7950.
This step changes the function remove_eq_conds() into a method in Item.
It removes 6 virtual calls for Item_func::type(), and adds only 2
virtual calls for Item***::remove_eq_conds().
Thanks.
diff --git a/sql/item.h b/sql/item.h
index
Hi Sergei,
Thanks for review! See my comments inline:
On 05/07/2015 06:57 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Mar 25, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for mdev-7824.
It's based on a MySQL patch for
http://bugs.mysql.com/bug.php?id=68041
and is a blocker
Hi Sergei,
Please review the patch for:
MDEV-7807 information_schema.processlist truncates queries with binary
strings
The patch is for 10.1, as agreed with the reporter.
Previously in 10.1 we fixed binary-string conversion behaviour not to
truncate on bad bytes, and replace bad bytes to
Hi Sergei,
I tested comparison behaviour for various different situations.
Please find the comment with the summary table in the end of:
https://mariadb.atlassian.net/browse/MDEV-7649
Currently there are 5 possible reactions on bad bytes on comparison,
depending on the collation, presence of
Hi Sergei,
Please review a patch for MDEV-7649 for 5.5.
It fixes the case #1 to return empty set.
(by treating bad bytes as greater than any valid character).
Thanks.
On 04/07/2015 02:07 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Apr 07, Alexander Barkov wrote:
Hi Sergei,
I tested
Hi Sergei,
Please review a patch for mdev-7268.
Thanks.
diff --git a/mysql-test/suite/rpl/r/rpl_old_decimal.result b/mysql-test/suite/rpl/r/rpl_old_decimal.result
new file mode 100644
index 000..3e2fa3b
--- /dev/null
+++ b/mysql-test/suite/rpl/r/rpl_old_decimal.result
@@ -0,0 +1,9 @@
Hi Sergei,
On 06/04/2015 08:24 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 04, Alexander Barkov wrote:
On 06/04/2015 06:20 PM, Sergei Golubchik wrote:
On Jun 04, Alexander Barkov wrote:
Please review a joint patch for:
MDEV-7269 mysqlbinlog Don't know how to handle column type=0
Hi Sergei,
Please review my patch for MDEV-8067.
Some subselect_(mat|sj) test chanted EXPLAIN output.
Perhaps the new results are correct. Please advise.
Thanks.
diff --git a/mysql-test/r/ctype_utf8.result b/mysql-test/r/ctype_utf8.result
index b8ecc05..a964384 100644
---
Hi Igor,
I noticed that during Item_cond::fix_fields() and
Item_func_between::fix_fields() update these optimizer
related SELECT_LEX members:
thd-lex-current_select-cond_count and
thd-lex-current_select-between_count
The purpose of these members is to allocate optimizer related buffers
in:
-
Hi Sergei,
I'm thinking about what to do with MDEV-8109 unexpected CAST result.
Observations:
1. An empty string in VALUES
SET sql_mode='STRICT_ALL_TABLES';
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a DECIMAL);
INSERT INTO t1 VALUES ('');
ERROR 1292 (22007): Truncated incorrect DECIMAL
Hi Sergei,
This is a new version.
Please also see some comments below.
Thanks.
On 06/25/2015 01:00 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 25, Alexander Barkov wrote:
Hi Sergei,
diff --git a/sql/field_conv.cc b/sql/field_conv.cc
index e31f7c5..14f2947 100644
--- a/sql
Hi Sergei,
On 06/24/2015 08:46 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 23, Alexander Barkov wrote:
+#define MY_FUNCTION_NAME(x) my_ ## x ## _big5_chinese_ci
+#define WEIGHT_MB1(x)(sort_order_big5[(uchar) (x)])
+#define WEIGHT_MB2(x,y) (big5code(x, y))
+#include
Hi Sergei,
Thanks for review.
I have a couple of questions before I can send a new version.
See the questions and other comments below.
On 06/24/2015 08:32 PM, Sergei Golubchik wrote:
Hi, Alexander!
I rewrote the patch slightly, so now we don't need to remember
all_default_are_checked or
Hi Sergei,
I created this task based on our discussion:
MDEV-8322 Distinguish between time and date strings more carefully
Please also see comments below:
On 06/15/2015 12:49 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 15, Alexander Barkov wrote:
(preference matters, as it tells how
Hi Sergei,
On 06/10/2015 06:47 PM, Sergei Golubchik wrote:
Hi, Alexander!
Summary: agree with 1,2,3, not so sure about 4.
I'm thinking about what to do with MDEV-8109 unexpected CAST result.
Observations:
1. An empty string in VALUES
SET sql_mode='STRICT_ALL_TABLES';
DROP TABLE IF EXISTS
Hi Sergei,
I'm not sure what to do with this:
MariaDB [test] select
- timediff('2014-01-01 00:00:00' , '2014-01-01 01:00:00' ),
- timediff(2014010100.000 , 2014010101.000 ),
- timediff(2014010100.000 , '2014-01-01 01:00:00' ),
- datediff('2014-01-01 00:00:00'
Hi Sergei,
On 06/10/2015 06:47 PM, Sergei Golubchik wrote:
SET sql_mode='STRICT_ALL_TABLES';
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a DECIMAL);
...
INSERT INTO t1 VALUES(CAST('' AS DECIMAL));
ERROR 1292 (22007): Truncated incorrect DECIMAL value: ''
I think this is not OK.
I wrote an
Hi Sergey,
On 05/27/2015 11:23 AM, Sergey Vojtovich wrote:
Hi Alexander,
ok to push. I just wish to study this code a bit before we continue.
Thanks!
I'm sending the next step, as agreed on IRC.
Thanks,
Sergey
On Wed, May 27, 2015 at 08:03:57AM +0400, Alexander Barkov wrote:
Hi
Hi Sergey,
please review the next step for MDEV-7950.
It breaks get_mm_parts() into a virtual method in Item, so
- replaces one virtual call item-type() to another virtual call,
item-get_mm_tree().
- and also removes this virtual call for functype(), which used to
distinguish between
Hello Sergey,
Please review the next step for MDEV-7950.
It does the following:
- Adds specific implementations of virtual method get_mm_tree() into
Item_func_like, Item_bool_rowready_func2, Item_func_spatial_rel
- Gets rid of two virtual calls: select_optimize() and have_rev_func().
-
Hi Sergei,
On 06/02/2015 07:51 PM, Sergei Golubchik wrote:
Hi, Alexander!
MDEV-6691 seems to be unrelated. What bug did you mean?
Sorry for confusing.
I meant this one:
(MDEV-8229) GROUP_MIN_MAX is erroneously applied for BETWEEN in some cases
Regards,
Sergei
On Jun 02, Alexander
Hi Sergei,
For simplicity I decided to split:
MDEV-8036 Fix all collations to compare broken bytes as greater than
any non-broken character
into sub-tasks.
Please review a patch for the first sub-task MDEV-8214.
The overall plan is:
- MDEV-8214, for the Asian charsets with mbmaxlen=2
-
Hi Sergey,
I probably found a bug in simple_pred() in opt_sum.cc.
In this piece of code:
case 3:
/* field BETWEEN const AND const */
item= func_item-arguments()[0]-real_item();
if (item-type() == Item::FIELD_ITEM)
{
args[0]= item;
for (int i= 1 ; i = 2; i++)
Hi Sergei,
I created a task according to our discussion a few weeks ago:
https://mariadb.atlassian.net/browse/MDEV-8433
Which version should we do this task in?
Thanks.
___
Mailing list: https://launchpad.net/~maria-developers
Post to :
Hi Kentoku and Kouhei,
FYI, I just filed this bug report:
https://mariadb.atlassian.net/browse/MDEV-8643
Can you please have a look into this?
Thanks!
___
Mailing list: https://launchpad.net/~maria-developers
Post to :
Key: MDEV-7063
URL: https://mariadb.atlassian.net/browse/MDEV-7063
Project: MariaDB Server
Issue Type: Task
Reporter: Alexander Barkov
Assignee: Michael Widenius
Fix For: 10.1
The string class currently consists
Hi Sergei,
Please review my patch for MDEV-8433.
I had doubts about one detail: how to make Field::store() that we're
currently creating a value for range search rather than regular doing a
INSERT/UPDATE.
I could think of two options:
1. Using sql_mode, similar to how temporal types pass
Hi Sergei,
On 07/18/2015 12:18 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 08, Alexander Barkov wrote:
Hi Sergei,
Please review my patch for mdev-8372.
I found only a few places to reuse the new methods.
Also, had to add some more helper methods to make
the code clearer.
I
!
On Feb 24, Alexander Barkov wrote:
There is only one problem with that. In case of embedded server
table-grant.privilege is always 0, because the embedded version
of check_table_access() is just an empty function.
This change in sql/handler.cc, in handler::ha_external_lock() helps:
+#ifdef
Hi Sergei,
On 07/24/2015 10:55 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 24, Alexander Barkov wrote:
Hi Sergei,
Sorry for delay, I was busy with 10.1 issues.
That's perfectly fine. And even good - there's little sense to spend
time on 10.0 bugs when the next release in line
Hi Sergei,
Please review a patch that merges a new read-only variables
--explicit-defaults-for-timestamp from MySQL.
Note, the original MySQL patch updates many tests,
to make the tests independent from the compiled-in default
--explicit-defaults-for-timestamp value. I guess Oracle is planning
Hi,
On 07/09/2015 05:00 PM, Michael Widenius wrote:
Hi!
Hi Igor,
I noticed that during Item_cond::fix_fields() and
Item_func_between::fix_fields() update these optimizer
related SELECT_LEX members:
thd-lex-current_select-cond_count and
thd-lex-current_select-between_count
The purpose of
Forgot to attach the patch.
On 07/13/2015 12:54 PM, Alexander Barkov wrote:
Hi Sergei,
Please review a patch that merges a new read-only variables
--explicit-defaults-for-timestamp from MySQL.
Note, the original MySQL patch updates many tests,
to make the tests independent from the compiled
Hi Sanja,
Please review a patch for MDEV-8441.
Thanks.
diff --git a/mysql-test/suite/vcol/r/vcol_misc.result b/mysql-test/suite/vcol/r/vcol_misc.result
index 521952f..e68adf8 100644
--- a/mysql-test/suite/vcol/r/vcol_misc.result
+++ b/mysql-test/suite/vcol/r/vcol_misc.result
@@ -322,3 +322,29
Hi Sergei,
On 07/18/2015 01:01 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 13, Alexander Barkov wrote:
Hi Sergei,
Please review a patch that merges a new read-only variables
--explicit-defaults-for-timestamp from MySQL.
Note, the original MySQL patch updates many tests,
to make
Hi Sergei,
Please review my patch for mdev-8372.
I found only a few places to reuse the new methods.
Also, had to add some more helper methods to make
the code clearer.
Thanks.
diff --git a/sql/field.cc b/sql/field.cc
index 25506d6..bc040fa 100644
--- a/sql/field.cc
+++ b/sql/field.cc
@@
Hi Sergei,
Thanks for the review!
Please see comments and questions below:
On 09/11/2015 06:58 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jul 13, Alexander Barkov wrote:
Forgot to attach the patch.
Thanks, here's the review below.
I did not review all the test changes, I suppose you've
Hi Sergei,
Please review a patch for MDEV-7055.
Thanks.
diff --git a/mysql-test/include/ctype_date_format.inc b/mysql-test/include/ctype_date_format.inc
new file mode 100644
index 000..d836090
--- /dev/null
+++ b/mysql-test/include/ctype_date_format.inc
@@ -0,0 +1,14 @@
+--echo #
+--echo #
Hi Jan,
Can you please review a patch for:
MDEV-8721 AIX: Compile error xtradb:log0log.cc
which seems to be the same bug with:
MDEV-8516 AIX xtradb -> log -> log0log.cc.o
Note, I don't have an AIX 7 machine.
Just applying the fix suggested by the complainer.
The fix looks fine for me.
Hi Sergei,
Please review a patch for MDEV-8844.
Thanks!
diff --git a/include/m_ctype.h b/include/m_ctype.h
index a552226..b059258 100644
--- a/include/m_ctype.h
+++ b/include/m_ctype.h
@@ -582,6 +582,7 @@ struct charset_info_st
extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_bin;
Hi Sergei,
On 01/07/2016 08:53 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Nov 27, Alexander Barkov wrote:
Hi Serg,
Please review a patch for MDEV-8092.
I didn't review a lot of it, sorry. Because my first two comments - if
we agree on them - might cause quite a few changes (search
Hi Sergei,
On 01/08/2016 03:48 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jan 08, Alexander Barkov wrote:
diff --git a/sql/field.h b/sql/field.h
index 0591914..a40e307 100644
--- a/sql/field.h
+++ b/sql/field.h
@@ -537,6 +537,115 @@ inline bool is_temporal_type_with_time(enum_field_types
Hi Sergei,
Please review the second version, according to our discussion on IRC.
Thanks.
On 12/17/2015 10:15 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Dec 16, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-8844.
Thanks!
diff --git a/sql/sql_error.cc b/sql
Hi,
The patch is for 10.2
(but should probably be safe for 10.1 as well)
Thanks.
diff --git a/mysql-test/r/sp-error.result b/mysql-test/r/sp-error.result
index 1f38e38..c56597e 100644
--- a/mysql-test/r/sp-error.result
+++ b/mysql-test/r/sp-error.result
@@ -779,7 +779,7 @@ drop procedure
Hi Sergei,
Please review a patch for MDEV-10181.
Thanks!
diff --git a/mysql-test/r/ctype_recoding.result b/mysql-test/r/ctype_recoding.result
index c84da0d..2555749 100644
--- a/mysql-test/r/ctype_recoding.result
+++ b/mysql-test/r/ctype_recoding.result
@@ -277,9 +277,40 @@ CREATE TABLE t1 ( a
Hi Sergei,
On 06/08/2016 11:58 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 08, Alexander Barkov wrote:
This script:
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a VARCHAR(30), b DOUBLE);
INSERT INTO t1 values(' ', MATCH (a) AGAINST('' IN
BOOLEAN MODE));
SELECT
Hello Sergei,
This script:
DROP TABLE IF EXISTS t1;
CREATE TABLE t1 (a VARCHAR(30), b DOUBLE);
INSERT INTO t1 values(' ', MATCH (a) AGAINST('' IN
BOOLEAN MODE));
SELECT * FROM t1;
returns:
+-+--+
| a | b|
Hi Sergei,
Please review a patch for MDEV-8909.
It removes some old remainders that are not needed anymore.
Thanks.
diff --git a/sql/sql_lex.cc b/sql/sql_lex.cc
index adc443a..28add87 100644
--- a/sql/sql_lex.cc
+++ b/sql/sql_lex.cc
@@ -2455,7 +2455,6 @@ bool
Hi Sergei,
Please review MDEV-10124
Thanks.
Here's the story of the related code:
1. The original patch from Wax
commit: 0b505fb437eedd1b31c99888247c2259539c095b
date: Tue Mar 18 03:07:40 2003
opt_gorder_clause reused the regular order_clause,
which already had some protection against
Hi Sergei,
On 06/20/2016 05:44 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 20, Alexander Barkov wrote:
Hello Sergei,
Please review a patch for mdev-9524.
Thanks.
diff --git a/sql/event_data_objects.cc b/sql/event_data_objects.cc
index 09256a3..45fca08 100644
--- a/sql
Hi Serg.
Please review a patch for MDEV-10236.
Thanks.
commit bb3afc8aea61bc090a1119be0a1dad32d9dc8feb
Author: Alexander Barkov <b...@mariadb.org>
Date: Wed Jun 22 16:30:15 2016 +0400
MDEV-10236 Where expression with NOT function gives incorrect result
diff --git a/mysql-
Hi Sergei,
Please review a patch for mdev-10020.
The problem was that the loop in get_func_mm_tree()
accessed an improperly initialized instance of String,
which is a bzero'ed part of the in_vector::base array.
Strings in in_vector::base are initialized
in Item_func_in::fix_length_and_dec():
Hello Sergei,
Please review a patch for mdev-9524.
Thanks.
diff --git a/mysql-test/r/events_1.result b/mysql-test/r/events_1.result
index e03ccf51..4e7ff52 100644
--- a/mysql-test/r/events_1.result
+++ b/mysql-test/r/events_1.result
@@ -469,6 +469,26 @@ DROP EVENT ev1;
SHOW EVENTS;
Db Name
Hello Sergei,
Please review a patch fixing:
MDEV-8502 DECIMAL accepts out of range DEFAULT values
MDEV-10277 Redundant NOTE when inserting '0.1 ' into a DECIMAL(2,1)
column
Thanks.
commit 21c77129a072e244d5cc7956d8739c8d21e86af4
Author: Alexander Barkov <b...@mariadb.org>
Date: F
Hi Sergei,
On 01/09/2016 11:54 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jan 09, Alexander Barkov wrote:
I disagree to go the easier way with LEX_STRING. LEX_STRING is a
very unfortunately designed thing for the server side code.
It was a kind of Ok on 32 bit platforms.
But now
Hello Sergei,
Please review a fix for MDEV-9371.
I'd suggest to push it to 10.0 instead of 5.5,
as MySQL fixed this bug in 5.6 (not 5.5).
Also, I think it's worthy to backport MDEV-9332 to 10.0 as well,
because the patch for MDEV-9371 touches the test which
we modified in MDEV-9332.
Thanks!
Hi Sergei,
Please review a patch for MDEV-9521.
Thanks.
diff --git a/mysql-test/r/type_date.result b/mysql-test/r/type_date.result
index 4e299ec..31add0f 100644
--- a/mysql-test/r/type_date.result
+++ b/mysql-test/r/type_date.result
@@ -440,3 +440,38 @@ id select_type table type possible_keys
Hi Sergei,
On 02/09/2016 05:01 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 09, Alexander Barkov wrote:
Hello Sergei,
Please review a fix for MDEV-9371.
I'd suggest to push it to 10.0 instead of 5.5,
as MySQL fixed this bug in 5.6 (not 5.5).
I think 5.5 is fine. It's clearly a bug
Hi Sergei,
Please review a patch form MDEV-9332.
It does the following:
- Changes the behaviour of copy_if_not_alloced in case
from->Alloced_length==0 and from_length==0 to return "to" instead of
"from",
because "from" can point to a constant string.
- Rewrites the code to make it more
Hi Georg,
a gentle reminder :)
Thanks.
On 01/27/2016 10:17 AM, Alexander Barkov wrote:
Hi Georg,
Can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-9415
ConnectSE crashes on INSERT statements inside the ODBC driver,
while UPDATE, SELECT, DELETE work fine.
Any
Hello Jan.
a gentle reminder ;)
Thanks.
On 01/26/2016 04:35 PM, Alexander Barkov wrote:
Hi Jan,
can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-8691
Otto managed to get a stack trace from mips machine.
It seems to crash inside InnoDB.
Thanks.
#3
#4
Hi Sergei,
On 02/26/2016 11:19 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 12, Alexander Barkov wrote:
Hello Sergei,
I'm sending a new version for Type_handler and INET6 for your review.
There are three patches attached.
1. inet6-v65-prepare.diff.gz
Includes preparatory changes
Hello Sergei,
On 02/27/2016 12:53 AM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 12, Alexander Barkov wrote:
Hello Sergei,
I'm sending a new version for Type_handler and INET6 for your review.
There are three patches attached.
1. inet6-v65-prepare.diff.gz
Includes preparatory
really uses single quoted strings as aliases.
What do you think about this?
Please also find comments inline:
On 02/27/2016 12:11 AM, Michael Widenius wrote:
Hi!
On 25 Feb 2016 19:16, "Alexander Barkov" <b...@mariadb.org
<mailto:b...@mariadb.org>> wrote:
>> As '
Hi Monty,
On 02/25/2016 12:26 PM, Michael Widenius wrote:
Hi!
Hello Monty, all,
We discussed this with Sergei and both think that it will be a good idea
to deprecate this syntax:
SELECT a'test';
where 'a' is an identifier and 'test' its alias.
Is this dependent on if there is a
Hi Sergei,
On 01/26/2016 06:06 PM, Sergei Golubchik wrote:
Hi, Alexander!
Looks good. Great comments.
See my suggestions below.
Thanks! See replies below:
On Jan 26, Alexander Barkov wrote:
diff --git a/sql/sql_string.cc b/sql/sql_string.cc
index b14c3af..606e71d 100644
--- a/sql
Hi,
Please review a new version of a patch for MDEV-9181.
Thanks.
diff --git a/mysql-test/r/null.result b/mysql-test/r/null.result
index b4cebac..af24ad4 100644
--- a/mysql-test/r/null.result
+++ b/mysql-test/r/null.result
@@ -1465,5 +1465,65 @@ Warnings:
Note 1003 select `test`.`t1`.`a` AS
Hi Jan,
can you please have a look into:
https://mariadb.atlassian.net/browse/MDEV-8691
Otto managed to get a stack trace from mips machine.
It seems to crash inside InnoDB.
Thanks.
#3
#4 0x00fff6b48e80 in
std::__detail::_List_node_base::_M_hook(std::__detail::_List_node_base*)
Hi Sergei,
IIRC you fixed this bug during the meeting in Amsterdam.
Can you please confirm?
(or just close it, if so)
Thanks.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe :
Hi Sergei,
Please review a patch for MDEV-7231.
Thanks.
diff --git a/include/m_ctype.h b/include/m_ctype.h
index a552226..ee49e94 100644
--- a/include/m_ctype.h
+++ b/include/m_ctype.h
@@ -533,6 +533,7 @@ struct my_charset_handler_st
extern MY_CHARSET_HANDLER my_charset_8bit_handler;
Hi Sergei,
On 02/18/2016 06:45 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 18, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-7231.
Sorry, I cannot understand what parts of this patch are fixing MDEV-7231
and what is fixing charset issue.
Could you please split
Hi Sergei,
On 02/18/2016 07:02 PM, Alexander Barkov wrote:
Hi Sergei,
On 02/18/2016 06:45 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Feb 18, Alexander Barkov wrote:
Hi Sergei,
Please review a patch for MDEV-7231.
Sorry, I cannot understand what parts of this patch are fixing MDEV
Hello Monty, all,
We discussed this with Sergei and both think that it will be a good idea
to deprecate this syntax:
SELECT a'test';
where 'a' is an identifier and 'test' its alias.
This is a non-standard way, and it conflicts with some other important
standard SQL grammar. See below.
Hello Melisa,
On 03/16/2016 10:22 PM, Melissa Rose wrote:
> Thanks for the kind response Alexander Barkov: I have already build the
> Server from source and I am looking at some character sets in string/*.c
> files and how they are implemented.
Excellent.
> I have also written a
101 - 200 of 568 matches
Mail list logo
