Re: [Maria-developers] [Commits] Rev 3984: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-06 Thread Sergei Golubchik
Hi, Jan! On Feb 06, Jan Lindström wrote: > Hi, > > Change: Another change is that it uses the index name for the internal > dictionary. > > Not ok. Firstly, that change should affect many test cases using > foreign keys. Not many, only two: innodb.innodb_information_schema and rpl.rpl_mdev382.

Re: [Maria-developers] [Commits] Rev 3984: MDEV-4439 ALTER TABLE .. [ADD|DROP] FOREIGN KEY IF [NOT] EXISTS does not work if constraint name is not used. in file:///home/hf/wmar/10-hf/

2014-02-06 Thread Sergei Golubchik
Hi, Jan! On Feb 06, Jan Lindström wrote: > Hi, > > I agree all other points except the fact that you do not need to use > SHOW commands. Applications might rely on fact that internal foreign > key names on InnoDB are form _ibfk_. But maybe this is > only a minor 'matter'. Current, patch handles

Re: [Maria-developers] Rev 4056: MDEV-5607: Query cache destroys uninitialized rwlock

2014-02-10 Thread Sergei Golubchik
Hi, Sanja! On Feb 08, sa...@askmonty.org wrote: > > revno: 4056 > revision-id: sa...@askmonty.org-20140208132448-qdkkpdncnya0tr6j > parent: ele...@wheezy-64.home-20140205102537-7ern5gfca6a6ojg3 > committer: sa...@askmonty.org > branch ni

Re: [Maria-developers] Minor glitch when doing out of tree cmake build

2014-02-10 Thread Sergei Golubchik
Hi, Andrew! On Feb 08, Andrew McDonnell wrote: > Hi, > > I like to build MariaDB in a separate directory to keep the source tree clean. > > This works for me as follows: > > cd path/to/maria/source > mkdir mybuildir > cd mybuildir > cmake .. "-DWITH_PLUGIN_ARIA=1 (etc...)" > make >

Re: [Maria-developers] Rev 3967: MDEV-5597 - Reduce usage of LOCK_open: LOCK_flush

2014-02-12 Thread Sergei Golubchik
Hi, Sergey! On Jan 31, Sergey Vojtovich wrote: > > > You wait here on a condition, how do you know there's FLUSH TABLES (or > > anything at all) running that will signal this condition? > 1. we're protected by exclusive metadata lock, so the only possible statement >that may cause concurrency

Re: [Maria-developers] Rev 4056: MDEV-5616 - Deadlock between CREATE/DROP FUNCTION and SELECT from view

2014-02-13 Thread Sergei Golubchik
Hi, Sergey! Ok to push. A couple of comments below. On Feb 07, Sergey Vojtovich wrote: > revno: 4056 > revision-id: s...@mariadb.org-20140207100451-8pnzn85pjjwvwfs4 > parent: ele...@wheezy-64.home-20140205102537-7ern5gfca6a6ojg3 > committer: Sergey Vojtovich > branch nick: 5.5-mdev5616 > timesta

Re: [Maria-developers] Problems installing mariadb published debian packages when using tmpfs for /tmp

2014-02-17 Thread Sergei Golubchik
Hi, Andrew! On Feb 16, Andrew McDonnell wrote: > Hiya, > > I followed the instructions here: > > > https://downloads.mariadb.org/mariadb/repositories/#mirror=aarnet_pty_ltd&distro=Debian&distro_release=wheezy&version=10.0 > > cluminating with: > > apt-get install mariadb-server mariadb-cl

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

2014-02-17 Thread Sergei Golubchik
Hi, Alexey! On Feb 14, Alexey Botchkov wrote: > > But I don't understand that. Do you mean, old code did *not* suppress > > errors here? How could selects from I_S tables work without it? > > Here's how it works today: > > get_all_tables() > Trigger_error_handler err_handler; > thd->push_int

Re: [Maria-developers] system variable value

2014-02-17 Thread Sergei Golubchik
Hi, Rich! On Dec 23, Rich Prohaska wrote: > I have a ULONGLONG system variable in my storage engine, and I set its > value to '-1' on the mysqld command line. Its value gets set to all > ones without any warnings or errors. The number conversion functions > just cast between longlong and ulonglo

Re: [Maria-developers] Plugin init()/deinit() call convention

2014-02-17 Thread Sergei Golubchik
Hi, Sergey! On Dec 26, Sergey Vojtovich wrote: > Hi Sergei, > > IIRC during early days of plugins framework there was a strict convention when > plugin deinit() function must be called. Specifically only after successful > call to init() function. > > I'm now fixing a bug in related code (5.5) a

Re: [Maria-developers] Rev 4029: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

2014-02-19 Thread Sergei Golubchik
Hi, Alexey! On Feb 19, Alexey Botchkov wrote: > Hi, Sergei. > > > Could you, please remove that piece of fine creativity and > > thd->clear_error() too and use the error handler instead? > > There's one puzzle. > This field is set here: > sql_show.cc:4899 (get_schema_tables_record()) >if (re

Re: [Maria-developers] MariaDB C-API and specific P_S tables

2014-02-24 Thread Sergei Golubchik
Hi, Peter! On Feb 24, Peter Laursen wrote: > BTW: the two tables do not exist in P_S in MariaDB 10.0.8 What tables don't exist? MariaDB [test]> SELECT * FROM performance_schema.session_connect_attrs; ++-++--+ | PROCESSLIST_ID | AT

Re: [Maria-developers] Rev 4077: MDEV-4856 SQL_ERROR_LOG shows 1146 errors which didnt appear in mysql client

2014-02-24 Thread Sergei Golubchik
Hi, Holyfoot! On Feb 22, holyf...@askmonty.org wrote: > revno: 4077 > revision-id: holyf...@askmonty.org-20140222173543-xkzlp5rpga41evur > parent: s...@mariadb.org-20140218065405-vw3bfhvhrfjsc6hh > committer: Alexey Botchkov > branch nick: mdev-4856 > timestamp: Sat 2014-02-22 21:35:43 +0400 > me

Re: [Maria-developers] MariaDB 5.5.36 stable and MariaDB Galera 10.0.7 alpha release prep

2014-02-25 Thread Sergei Golubchik
Hi, Hartmut! On Feb 24, Hartmut Holzgraefe wrote: > On 02/24/2014 05:45 AM, Daniel Bartholomew wrote: > > > Obilgatory note #1: The plan is for these files to be the officially > > released files without any changes, but that may change if something > > unexpected comes up (and such things have h

Re: [Maria-developers] MariaDB 5.5.36 stable and MariaDB Galera 10.0.7 alpha release prep

2014-02-25 Thread Sergei Golubchik
Hi, Otto! On Feb 25, Otto Kekäläinen wrote: > > On Feb 24, Hartmut Holzgraefe wrote: > >> On 02/24/2014 05:45 AM, Daniel Bartholomew wrote: > >> > >> i stumbled across this with 5.5.35 Ubuntu packages yesterday, and it > >> still seems to be an issue with 5.5.36: the embedded server library > >> d

Re: [Maria-developers] Problem with debug_sync, THD::enter_cond(), and kill ...

2014-02-26 Thread Sergei Golubchik
Hi, Kristian! On Feb 26, Kristian Nielsen wrote: > I got a crash in my parallel replication test case, and this one turned out to > be caused by a fundamental problem in debug_sync. I am not sure how to solve > it, so I wanted to explain the issue in case others have some ideas. > > The crash ha

Re: [Maria-developers] MDEV-5081 - Simple performance improvement for MariaDB

2014-02-28 Thread Sergei Golubchik
Hi, Sergey! On Feb 27, Sergey Vojtovich wrote: > Hi Sergei, > > do you know if we ship any binaries with fast mutex (-DMY_PTHREAD_FASTMUTEX) > enabled or officially suggest it? What was it's intention and what loads it > was > supposed to make faster? As far as I understand, we built with fastm

Re: [Maria-developers] Keystone authentication plugin GSoc 14

2014-02-28 Thread Sergei Golubchik
Hi, Abhishek! On Feb 27, Abhishek Solanki wrote: > Hello MariaDB members , > > I am interested to work on "Keystone authentication plugin" project , i > have a good knowledge of C/C++ and OpenStack. > > So can anyone help me how to get started with this project, so that i cold > dig something be

Re: [Maria-developers] MDEV-5081 - Simple performance improvement for MariaDB

2014-02-28 Thread Sergei Golubchik
Hi, Sergey! On Feb 28, Sergey Vojtovich wrote: > Hi Sergei, > > indeed, but that's only for -DBUILD_CONFIG=mysql_release or explicit > -DWITH_FAST_MUTEXES=ON. I though it should be enabled by > -DCMAKE_BUILD_TYPE=Release (the way I was attempting to get it). We build release binaries (I believe)

Re: [Maria-developers] MDEV-5674 - Performance: my_hash_sort_bin is called too often

2014-03-01 Thread Sergei Golubchik
Hi, Sergey! On Feb 20, Sergey Vojtovich wrote: > At lp:maria/10.0 > > > revno: 4007 > revision-id: s...@mariadb.org-20140220072533-ko14y1714ouvd2f7 > parent: s...@mariadb.org-20140214122541-tenvcllk760deai8 > committer: Sergey Vojtovich

Re: [Maria-developers] MDEV-5755 - Scalability: let LOCK_open and THR_LOCK::mutex be normal mutexes

2014-03-01 Thread Sergei Golubchik
Hi, Sergey! On Feb 27, Sergey Vojtovich wrote: > At lp:maria/10.0 > > > revno: 4011 > revision-id: s...@mariadb.org-20140227141521-fgj5b0h3qbijyojh > parent: s...@mariadb.org-20140220072533-l3au3y7mrsyclfpb > committer: Sergey Vojtovich

Re: [Maria-developers] New member, Need suggestion

2014-03-02 Thread Sergei Golubchik
Hi, Neil! On Mar 02, Neil Shah wrote: > Hello fellow developers, > > I joined MariaDB community today and need few suggestions/projects/bugs > that i can work on. > I do not have any knowledge of MariaDB source, but I will start looking > into it now. > > I have hands on experience in C/C++/Java

Re: [Maria-developers] New member, Need suggestion

2014-03-03 Thread Sergei Golubchik
Hi, Neil! On Mar 03, Neil Shah wrote: > Hello Sergei, > > Thank you for your reply. I did go through the given URL. But before > applying and submitting my proposals for the Google Summer of Code 2014, i > was planning to get familiar with the community by contributing on bug > fixes. > > I also

Re: [Maria-developers] Suggestion ,a new member

2014-03-04 Thread Sergei Golubchik
Hi, Anupama! On Mar 04, anupama vijjapu wrote: > Hello fellow developers, > > I joined MariaDB community today and need few > suggestions/projects/bugs that i can work on. I do not have any > knowledge of MariaDB source, but I will start looking > into it now. > > I have hands on experience in

Re: [Maria-developers] [Gsoc] LDAP authentication plug-in project

2014-03-04 Thread Sergei Golubchik
Hi, Sudheera! On Mar 04, Sudheera Palihakkara wrote: > Hi, > > I'm started to work above project. I want to know that if I have to > use a local ldap server to test the feature like OpenLdapServer or are > there any remote servers that I can connect to? Local one is perfectly fine. Regards, Ser

Re: [Maria-developers] MDEV-5674 - Performance: my_hash_sort_bin is called too often

2014-03-04 Thread Sergei Golubchik
Hi, Sergey! On Mar 03, Sergey Vojtovich wrote: > Hi Sergei, > > thanks for your comments. Did you also review the first patch? > revno: 4009 > committer: Sergey Vojtovich > branch nick: 10.0 > timestamp: Fri 2014-02-14 16:25:41 +0400 > message: > MDEV-5674 - Performance: my_hash_sort_bin is ca

Re: [Maria-developers] MDEV-5674 - Performance: my_hash_sort_bin is called too often

2014-03-04 Thread Sergei Golubchik
Hi, Sergey! On Mar 03, Sergey Vojtovich wrote: > > > === modified file 'sql/mdl.cc' > > > --- a/sql/mdl.cc 2014-02-14 12:25:41 + > > > +++ b/sql/mdl.cc 2014-02-20 07:25:33 + > > > @@ -760,13 +760,22 @@ void MDL_map::init() > > > } > > > > > > > > > +my_hash_value_type mdl_hash_funct

Re: [Maria-developers] Rev 4006: MDEV-5674 - Performance: my_hash_sort_bin is called too often

2014-03-04 Thread Sergei Golubchik
Hi, Sergey! On Feb 14, Sergey Vojtovich wrote: > At lp:maria/10.0 > > > revno: 4006 > revision-id: s...@mariadb.org-20140214122541-tenvcllk760deai8 > parent: s...@mariadb.org-20140213071355-psk0jpsarx2u7myc > committer: Sergey Vojtovich

Re: [Maria-developers] regarding the project in gsoc 2014

2014-03-05 Thread Sergei Golubchik
Hi, nitin! On Mar 04, nitin goel wrote: > Sir/Ma'am, > I would like to bring to your notice that i used 'mysql' to drop and create > tables to understand project better but would like to know more > specifications for the project 'create or replace, create if not exists, > and drop if exists'. I h

Re: [Maria-developers] Active Directory authentication plugin - GSoC 2014

2014-03-05 Thread Sergei Golubchik
Hi, Talina! On Feb 28, talinashrotr...@gmail.com wrote: > Hello Sir, > > My name is Talina, presently studying Computer Science from India. > > I am interested to work on the “Active Directory authentication > plugin”project. I am good at C/C++ , MYSQL and also have good knowledge about > Act

Re: [Maria-developers] Standard way for time->datetime cast

2014-03-05 Thread Sergei Golubchik
Hi, Alexander! On Mar 04, Alexander Barkov wrote: > Hi Sergei, > > (my mailer failed during the previous attempt. writing again, > sorry if you get this twice) No problem. I did get it twice, but only the second copy was cc: to the mailing list, that's why I'm replying to it. > Please review th

Re: [Maria-developers] [GSoC] Student interested in "Optimize mysql-test runs" or adding SQL features

2014-03-06 Thread Sergei Golubchik
Hi, Pablo! On Mar 06, Pablo Estrada wrote: > > Although I am interested in software development, I am more interested > in data analysis. That's why I switched from computer science to > scientific computing, and that's why the project that interests me the > most is the one called "Statistically

Re: [Maria-developers] Project in GSOC 2014.

2014-03-06 Thread Sergei Golubchik
Hi, Puneet! On Mar 06, Puneet Dewan wrote: > Hi All, > > A gentle reminder on Java Client Library for Maria DB as the deadline for > start of proposal is near. > > I would be very happy to receive a response and want to participate in GSOC > with MariaDB > > Regards > Puneet. Unfortunately, it

Re: [Maria-developers] Standard way for time->datetime cast

2014-03-06 Thread Sergei Golubchik
Hi, Alexander! On Mar 06, Alexander Barkov wrote: > >> +/* Usefull constants */ > >> +#define SECONDS_IN_24H 86400L > > > > in a separate follow-up changeset, please replace all instances of > > 86400 with SECONDS_IN_24H (althought I'd probably use > > SECONDS_IN_DAY) > > I replaced more instance

Re: [Maria-developers] Rev 4009: MDEV-5675 - Performance: my_hash_sort_bin is called too often in lp:maria/10.0

2014-03-06 Thread Sergei Golubchik
Hi, Sergey! On Mar 06, Sergey Vojtovich wrote: > revno: 4009 > revision-id: s...@mariadb.org-20140306121912-2a2soan1oc7u1hrt > parent: s...@mariadb.org-20140226085528-80vzk8f2c4b4ugxm > committer: Sergey Vojtovich > branch nick: 10.0 > timestamp: Thu 2014-03-06 16:19:12 +0400 > message: > MDEV-

Re: [Maria-developers] Rev 4004: RBR triggers compiled-out with ifdefs in 10.0

2014-03-07 Thread Sergei Golubchik
Hi, Sanja! On Feb 12, sa...@askmonty.org wrote: > At file:///home/bell/maria/bzr/work-maria-10.0-MDEV-5095/ > > > revno: 4004 > revision-id: sa...@askmonty.org-20140212204600-n89hns6zvrut1nl7 > parent: sa...@askmonty.org-20140212190858-

Re: [Maria-developers] Review to fix for mdev-5437

2014-03-08 Thread Sergei Golubchik
Hi, Savita! On Mar 08, Savita Agrawal wrote: > Hi, > I am a student from India interested in participating gsoc. This is my > first fix to mariadb. Please review it. Link is: > > http://bazaar.launchpad.net/~savitarit0/maria/maria-fix-mdev-5437/revision/4104 Yes, this looks pretty good, thanks!

Re: [Maria-developers] Project in GSOC 2014.

2014-03-10 Thread Sergei Golubchik
Hi, Puneet! > I appreciate your response. > But It will be really good if you can provide me the details of future > tasks in the project. > I will choose certain tasks and prepare the propsal.In case, help is > required I can ask in the community. > The whole community is a mentor. A mentor in G

Re: [Maria-developers] [Gsoc] LDAP authentication plug-in project

2014-03-10 Thread Sergei Golubchik
Hi, Sudheera! On Mar 09, Sudheera Palihakkara wrote: > Hi all, > It seems we need openldap-devel libraries for the client ldap. I'm not sure > about the way how I can add these libraries in maria code. I mean of course > I can install these libraries when the maria is build and install, but > ther

Re: [Maria-developers] Some questions on GSOC project User Defined Event

2014-03-10 Thread Sergei Golubchik
Hi, Savita! On Mar 08, Savita Agrawal wrote: > > what is the difference between a trigger and user defined event? A main difference: a trigger is automatially run by DBMS when something happens. User defined event - you need to wait for it, it's more procedural programming. > In postgres there

Re: [Maria-developers] Some questions on GSOC project User Defined Event

2014-03-10 Thread Sergei Golubchik
Hi, Savita! On Mar 09, Savita Agrawal wrote: > > As far as I know user defined events are supposed to save applications > resources used in polling. But I think the application developer could > have created a trigger and udf and use lib_mysqludf_sys to invoke > external application. But there ar

Re: [Maria-developers] Some questions on GSOC project User Defined Event

2014-03-10 Thread Sergei Golubchik
Hi, Savita! On Mar 09, Savita Agrawal wrote: > If we want the application developers to take advantage from events > occurring on a table then we could reuse a plugin from drizzle > database which one of friends developed as part of gsoc last year. > This plugin allows the drizzle client to call a

Re: [Maria-developers] Rev 4033: MDEV-5766 - my_atomic_load does memory writes

2014-03-10 Thread Sergei Golubchik
Hi, Sergey! On Mar 07, Sergey Vojtovich wrote: > revno: 4033 > revision-id: s...@mariadb.org-20140307074306-i3l4fllu2rj5pouf > parent: s...@mariadb.org-20140306121912-i1p8iilpsgc8m4bn > committer: Sergey Vojtovich > branch nick: 10.0 > timestamp: Fri 2014-03-07 11:43:06 +0400 > message: > MDEV-

Re: [Maria-developers] [Commits] Rev 3768: MDEV-5717: Server crash with insert statement containing DEFAULT into view

2014-03-12 Thread Sergei Golubchik
Hi, Sanja! On Mar 12, sa...@montyprogram.com wrote: > revno: 3768 > revision-id: sa...@montyprogram.com-20140312103416-3v6tan06crsqry28 > parent: sa...@montyprogram.com-20140307115707-poaet8iwv9d55azm > committer: sa...@montyprogram.com > branch nick: work-maria-5.3-MDEV-5717 > timestamp: Wed 2014

Re: [Maria-developers] TokuDB Performance Regression (MDEV-5777)

2014-03-13 Thread Sergei Golubchik
Hi, Tim! On Mar 11, Tim Callaghan wrote: > I'm very concerned about the regression I reported in > https://mariadb.atlassian.net/browse/MDEV-5777, as users of the > MariaDB.org supplied builds of both 5.5 and 10.0 are getting > substantially less throughput than the MariaDB 5.5 build supplied by >

Re: [Maria-developers] For Google Summer of Code 2014, Interested in the task of "statistically optimize mysql-test runs by running less tests"

2014-03-13 Thread Sergei Golubchik
Hi, Zhongyi Hu! On Mar 14, Zhongyi Hu wrote: > Dear Sergei Golubchik, > > I am a post graduate student of Institute of Software, Chinese Academy > of Sciences and my name is Zhongyi Hu. > I major in computer science and my research field is data stream > mining. Because I have

Re: [Maria-developers] [Commits] Rev 4066: MDEV-5089 - possible deadlocks between rwlocks and mutexes

2014-03-13 Thread Sergei Golubchik
Hi, Sergey! On Feb 13, Sergey Vojtovich wrote: > revno: 4066 > revision-id: s...@mariadb.org-20140213074049-70zbqa98y95sfpox > parent: sa...@askmonty.org-20140212150705-e1tfabmhjggqws7q > committer: Sergey Vojtovich > branch nick: 5.5 > timestamp: Thu 2014-02-13 11:40:49 +0400 > message: > MDEV

Re: [Maria-developers] [GSOC 2014] "CREATE OR REPLACE, CREATE IF NOT EXISTS, and DROP IF EXISTS" Project

2014-03-16 Thread Sergei Golubchik
Hi, Sriram! On Mar 16, sriram patil wrote: > Hi Sergei, > > I am interested to work on "CREATE OR REPLACE, CREATE IF NOT EXISTS, and > DROP IF EXISTS" project as part of GSOC 2014. I want to apply my subject > knowledge at a bigger level which will also give me an idea about the > practical issue

Re: [Maria-developers] For Google Summer of Code 2014, Interested in the task of "statistically optimize mysql-test runs by running less tests"

2014-03-16 Thread Sergei Golubchik
Hi, Zhongyi Hu! On Mar 17, Zhongyi Hu wrote: > Hi, Sergei Golubchik! > > I am afraid I don't understand the following items very well, could you > explain them for me? > >- average over different combinations or builders >- or don't average and treat tri

Re: [Maria-developers] redundant compilation of targets in mariadb 10.0

2014-03-16 Thread Sergei Golubchik
Hi, Rohit! On Mar 16, Rohit Kalhans wrote: > hello all, > > I am trying to fix a few bugs but ever after small modifications in > specific files, make command build all targets irrespective of whether or > not they are dependent on the modified source. I am no expert in build > commands but this

Re: [Maria-developers] redundant compilation of targets in mariadb 10.0

2014-03-17 Thread Sergei Golubchik
Hi, Rohit! On Mar 17, Rohit Kalhans wrote: > hello Sergei > > the modification was made in some replication specific files > rpl_gtid.h & rpl_gtid.cc > > *rohit@ubuntu:/work/mariadb/mariadb/mariadb10$ bzr st * > *modified:* > * sql/rpl_gtid.cc* > * sql/rpl_gtid.h* > *unknown:* > * mysql-test/

Re: [Maria-developers] redundant compilation of targets in mariadb 10.0

2014-03-17 Thread Sergei Golubchik
Hi, Rohit! On Mar 17, Rohit Kalhans wrote: > Apart from the above even if i try to build twice without any modification, > it builds all the target again. > I have confirmed that none of the files was 'touched'. I have never seen that. And I've just tried again - nope, no target is rebuilt. This

Re: [Maria-developers] [GSoC] MDEV-371- index on BLOB

2014-03-17 Thread Sergei Golubchik
Hi, Smit! On Mar 17, smit hinsu wrote: > Hi Sergei and Roberto, > > My name is Smit Hinsu and I am final year undergrad student. I have good > knowledge about database internals and good experience with C++. > > I find feature of creating index on BLOB quickly using MD-5 interesting. I > have un

Re: [Maria-developers] [GSOC 2014] "CREATE OR REPLACE, CREATE IF NOT EXISTS, and DROP IF EXISTS" Project

2014-03-18 Thread Sergei Golubchik
Hi, Sriram! First: please don't forget to cc: the list maria-developers@lists.launchpad.net Thank you. On Mar 18, sriram patil wrote: > Hi Sergei, > > I was going through the source code and was able to figure out the > flow of query execution and major functions through which a query goes > bef

Re: [Maria-developers] [Commits] Rev 3992: MDEV-5138 Numerous test failures in "mtr --ps --embedded". in file:///home/hf/wmar/mdev-5138/

2014-03-18 Thread Sergei Golubchik
Hi, holyfoot! On Nov 30, holyf...@askmonty.org wrote: > At file:///home/hf/wmar/mdev-5138/ > > > revno: 3992 > revision-id: holyf...@askmonty.org-20131130142537-7j272euoaoy0svg1 > parent: holyf...@askmonty.org-20131130132432-etlmes8qhhq

Re: [Maria-developers] [Commits] Rev 3993: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-18 Thread Sergei Golubchik
Hi, holyfoot! On Dec 02, holyf...@askmonty.org wrote: > At file:///home/hf/wmar/mdev-5138/ > > > revno: 3993 > revision-id: holyf...@askmonty.org-20131202104753-srqqm7hv1rtcurx4 > parent: holyf...@askmonty.org-20131130142537-7j272euoaoy

Re: [Maria-developers] [Commits] Rev 3994: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-18 Thread Sergei Golubchik
Hi, Holyfoot! On Dec 08, holyf...@askmonty.org wrote: > > revno: 3994 > revision-id: holyf...@askmonty.org-20131208143921-3veatgg9wngyzb47 > parent: holyf...@askmonty.org-20131202104753-srqqm7hv1rtcurx4 > committer: Alexey Botchkov > br

Re: [Maria-developers] [Commits] Rev 3995: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-18 Thread Sergei Golubchik
Hi, Holyfoot! On Dec 09, holyf...@askmonty.org wrote: > At file:///home/hf/wmar/mdev-5138/ > > > revno: 3995 > revision-id: holyf...@askmonty.org-20131209020845-9o3l30ao90vzf600 > parent: holyf...@askmonty.org-20131208143921-3veatgg9wng

Re: [Maria-developers] [GSOC 2014] "CREATE OR REPLACE, CREATE IF NOT EXISTS, and DROP IF EXISTS" Project

2014-03-18 Thread Sergei Golubchik
Hi, Sriram! On Mar 18, Sriram Patil wrote: > Hi Sergei, > > Thank you for such a quick reply. > I will look into the files you have mentioned. > > Also, is there any particular format for the proposal draft? Or may be if > you expect some points to be mentioned clearly in the proposal draft. No

Re: [Maria-developers] Intermediate status for test cases merge

2014-03-18 Thread Sergei Golubchik
Hi, Sergey! On Mar 11, Sergey Vojtovich wrote: > Hi! > > So far I processed 431 test cases from the main suite. Most of them are up to > date, a few merged without problems, a few tests fail (bugs reported), a few > need extra analysis. > > There are a few items which I'd like to discuss: > - IN

Re: [Maria-developers] [Commits] Rev 3991: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-18 Thread Sergei Golubchik
Hi, Holyfoot! On Nov 30, holyf...@askmonty.org wrote: > At file:///home/hf/wmar/mdev-5138/ > > > revno: 3991 > revision-id: holyf...@askmonty.org-20131130132432-etlmes8qhhqhr1iu > parent: ele...@wheezy-64.home-20131128160251-vn857wx5qlo

Re: [Maria-developers] rbr triggers (all)

2014-03-18 Thread Sergei Golubchik
Hi, Oleksandr! Ok to push. See a couple of comments below. On Mar 18, Oleksandr Byelkin wrote: > === added file 'mysql-test/suite/rpl/t/rpl_row_triggers.test' > --- mysql-test/suite/rpl/t/rpl_row_triggers.test 1970-01-01 00:00:00 > + > +++ mysql-test/suite/rpl/t/rpl_row_triggers.test

Re: [Maria-developers] [GSOC 2014] CREATE OR REPLACE, CREATE IF NOT EXISTS, and DROP IF EXISTS

2014-03-18 Thread Sergei Golubchik
Hi, Kesha! On Mar 18, Kesha Shah wrote: > Dear Sergei Golubchik, > > Hope this mail finds you well. > > I am Kesha Shah, a third year undergraduate from DA-IICT, Gandhinagar, > India. I was a Google Summer of Code student previous year as well as > Google Code-In mentor wit

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-18 Thread Sergei Golubchik
Hi, Alexander! On Feb 20, Alexander Barkov wrote: > please review a fix for MDEV-5689. > > It also fixes > MDEV-5709 ExtractValue() with XPath variable references returns wrong > result. > > Description: > > 1. The main problem was that that nodeset_func->fix_fields() was > called in Item_func

Re: [Maria-developers] [Commits] Rev 4053: MDEV-5864 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables

2014-03-19 Thread Sergei Golubchik
Hi, Sergey! On Mar 15, Sergey Vojtovich wrote: > At lp:maria/10.0 > > > revno: 4053 > revision-id: s...@mariadb.org-20140315185301-ce4r6br023co80dm > parent: sa...@montyprogram.com-20140314073116-nklb0jkjd4t1w40n > committer: Sergey Voj

Re: [Maria-developers] [GSOC 2014] "CREATE OR REPLACE, CREATE IF NOT EXISTS, and DROP IF EXISTS" Project

2014-03-19 Thread Sergei Golubchik
Hi, sriram! On Mar 19, sriram patil wrote: > Hi Sergei, > > I studied lex and yacc and understood complete parser written in > sql_yacc.yy. Also went through the constants and symbols declared in lex.h, > sql_yacc.h, sql_cmd.h. Right > I found out that OR REPLACE and IF NOT EXISTS is already im

Re: [Maria-developers] [Commits] Rev 4053: MDEV-5864 - Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables

2014-03-19 Thread Sergei Golubchik
Hi, Sergey! On Mar 19, Sergey Vojtovich wrote: > > > === modified file 'sql/sql_plist.h' > > > --- a/sql/sql_plist.h 2013-11-20 11:05:39 + > > > +++ b/sql/sql_plist.h 2014-03-15 18:53:01 + > > > @@ -142,6 +142,14 @@ class I_P_List : public C, public I > > > > > > return resu

Re: [Maria-developers] [GSoC 2014]

2014-03-20 Thread Sergei Golubchik
Hi, Ivan! On Mar 20, Ivan Nikulin wrote: > Hello, > > I would like to take part into one of your projects on base of GSoC > 2014. I am an experienced C/C++ programmer with wide knowledge of > algorithms and data structures and huge interest into this sphere. I > have some basic knowledge of SQL l

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-20 Thread Sergei Golubchik
Hi, Alexander! On Mar 20, Alexander Barkov wrote: > On 03/19/2014 12:03 AM, Sergei Golubchik wrote: > > On Feb 20, Alexander Barkov wrote: > >> please review a fix for MDEV-5689. > >> > >> It also fixes > >> MDEV-5709 ExtractValue() with XPath

Re: [Maria-developers] Engine independent index statistics - infrastructure questions

2014-03-20 Thread Sergei Golubchik
Hi, Sergey! Here's my opinion below: On Mar 20, Sergey Petrunia wrote: > Hello Igor and others, > > == dropping table statistics == > How does one drop table statistics? are we satisfied with needing to run > three statements > > DELETE FROM mysql.column_stats WHERE schema_name=$db AND > table

Re: [Maria-developers] Intermediate status for test cases merge

2014-03-21 Thread Sergei Golubchik
Hi, Sergey! On Mar 21, Sergey Vojtovich wrote: > On Tue, Mar 18, 2014 at 05:25:59PM +0100, Sergei Golubchik wrote: > > On Mar 11, Sergey Vojtovich wrote: > > > > > - SHOW PROFILE is deprecated in 5.6, do we want to deprecate it too? > > > > I'm not sure

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-23 Thread Sergei Golubchik
Hi, Alexander! On Mar 23, Alexander Barkov wrote: > >>> On Feb 20, Alexander Barkov wrote: > please review a fix for MDEV-5689. > > It also fixes > MDEV-5709 ExtractValue() with XPath variable references returns wrong > result. > > I pushed my patch to 10.0. > But the rep

Re: [Maria-developers] Intermediate status for test cases merge

2014-03-24 Thread Sergei Golubchik
Hi, Sergey! On Mar 24, Sergey Vojtovich wrote: > > > > > > > - YEAR(2) is deprecated in 5.6, do we want to deprecate it too? > > > > I'd deprecate it - I agree about "ill design", it has lots of > > > > gotchas that are literally impossible to fix. In some cases it > > > > seems to work, but it's

Re: [Maria-developers] maria-developers@lists.launchpad.net

2014-03-24 Thread Sergei Golubchik
Hi, Sergey! On Mar 24, Sergey Vojtovich wrote: > > This is second list of questions I came up while merging test cases: > - --ignore-builtin-innodb is deprecated in 5.6, do we want to deprecate it > too? No, of course not. It was introduced in 5.1 so that one could load the engine from storage/

Re: [Maria-developers] Two 10.0-related things.

2014-03-25 Thread Sergei Golubchik
Hi, Alexey! On Mar 25, Alexey Botchkov wrote: > Hi, Sergei. > > I'd like to share my recently obtained knowledge :) > > 1. Mac OS X and sockets. > As you know there on Labrador machine that mysql-test-run.pl failed > if not run with --tmpdir=/tmp. > The problem apparently is that the /Users dire

Re: [Maria-developers] Core MariaDB 10. Task suggestion.

2014-03-26 Thread Sergei Golubchik
Hi, Sergey! On Mar 26, Sergey Dudoladov wrote: > > Hello everyone, > > I would like to ask for a task I could do to start contributing to the > MariaDB 10. > Right now I am looking for something relatively simple so that I can > familiarize myself with the development process. Great! We've recen

Re: [Maria-developers] Adding a storage engine - compilation

2014-03-26 Thread Sergei Golubchik
Hi, Amith! On Mar 25, Amith Nagarajappa wrote: > Hi, > > When i am creating a folder in storage/. I have placed the > makefile from example folder and in the customEngine folder and have made > required changes. > > However, makefile is not generated in the storage/ folder. > > What change I ha

Re: [Maria-developers] [Commits] Rev 3994: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-26 Thread Sergei Golubchik
Hi, Alexey! On Mar 26, Alexey Botchkov wrote: > Hi, Sergei. > > > What do you mean by that? > > It can be seen in the sys_vars.completion_type_func test. oops. obscure feature. Okay, thanks. ok to push that. > > revno: 3994 > > message: > > MDEV-5138 Numerous test failures in "mtr --ps --em

Re: [Maria-developers] [Commits] Rev 3991: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-30 Thread Sergei Golubchik
Hi, Alexey! On Mar 26, Alexey Botchkov wrote: > Hi, Sergei. > > The Protocol::net_store_data is virtual in the embedded-server case > because we need it implemented differently for Protocol_binary. Ok, got it (finally), sorry. I'm almost always use ctags when looking for definitions, but in thi

Re: [Maria-developers] [Commits] Rev 3995: MDEV-5138 Numerous test failures in "mtr --ps --embedded"

2014-03-30 Thread Sergei Golubchik
Hi, Alexey! On Mar 27, Alexey Botchkov wrote: > Hi, Sergei. > > > Why does embedded fail while a normal client-server protocol is ok with > > that? > > The difference is that the client checks the server status twice during > execution > - after the metadata reading and after the actual data. >

Re: [Maria-developers] Engine independent statistics - naming issues?

2014-03-30 Thread Sergei Golubchik
Hi, Sergey! On Mar 27, Sergey Petrunia wrote: > Hello, > > I was looking at whether column names used by EIS feature are consistent with > themselves and with ther parts of the server. ... > What's your opinion, should we make some renames to make things more > consistent? I don't think it matte

Re: [Maria-developers] [Commits] cf04c06: MDEV-10435 crash with bad stat tables.

2016-12-01 Thread Sergei Golubchik
Hi, Alexey! On Nov 02, Alexey Botchkov wrote: > revision-id: cf04c06a58e3d0e700491f8f9167e9323cf1de1d > (mariadb-10.1.18-28-gcf04c06) > parent(s): c18054deb2b5cfcf1f13aa71574406f2bafb87c6 > committer: Alexey Botchkov > timestamp: 2016-11-02 13:02:32 +0400 > message: > > MDEV-10435 crash with bad

Re: [Maria-developers] Please review MDEV-10717 Assertion `!null_value' failed in virtual bool Item::send(Protocol*, String*)

2016-12-05 Thread Sergei Golubchik
Hi, Alexander! On Dec 05, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-10717. ok to push Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~maria-developers Post to

Re: [Maria-developers] [Commits] 78c093a: MDEV-10435 crash with bad stat tables.

2016-12-06 Thread Sergei Golubchik
Hi, Alexey! On Dec 06, Alexey Botchkov wrote: > revision-id: 78c093a042ccee6c7b8d11ab1b7e6069efb4af24 > (mariadb-10.1.19-24-g78c093a) > parent(s): 611f91605adce17df87acf96b5aede0b73d0fc12 > committer: Alexey Botchkov > timestamp: 2016-12-06 18:32:48 +0400 > message: > > MDEV-10435 crash with ba

Re: [Maria-developers] [Commits] 895309f: MDEV-10663: Use of Inline table columns in HAVING clause throws 1463 Error

2016-12-06 Thread Sergei Golubchik
Hi, Oleksandr! On Dec 06, Oleksandr Byelkin wrote: > revision-id: 895309f441e0262229671dcec5d49c4ff8f8ca2c > (mariadb-5.5.53-16-g895309f) > parent(s): 18cdff6765b954431934f6e6d0b1e281c8f0e0b8 > committer: Oleksandr Byelkin > timestamp: 2016-12-06 14:18:24 +0100 > message: > > MDEV-10663: Use of

Re: [Maria-developers] MDEV-10787 Assertion `ltime->neg == 0' failed in void date_to_datetime(MYSQL_TIME*)

2016-12-07 Thread Sergei Golubchik
Hi, Alexander! On Dec 07, Alexander Barkov wrote: > Hello Sergei, > > this is an improved version, as discussed in slack. thanks, ok to push! Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org ___ Mailing list: https://launchpad.net/~ma

Re: [Maria-developers] [Commits] 514b557: MDEV-11170: MariaDB 10.2 cannot start on MySQL 5.7 datadir:

2016-12-12 Thread Sergei Golubchik
Hi, Vicentiu! I think mariadb should support 5.7 user table (without the password column) without any errors. That shouldn't be too difficult, just detect at run-time whether the column "Password" exists and adjust all other column numbers accordingly. On Dec 12, Vicentiu wrote: > revision-id: 51

Re: [Maria-developers] [Commits] 5f02c66: MDEV-11227 - mysqlimport -l doesn't issue UNLOCK TABLES

2016-12-15 Thread Sergei Golubchik
Hi, Sergey! On Dec 13, Sergey Vojtovich wrote: > revision-id: 5f02c661f3d30baf08071acad29cef40fad0739c > (mariadb-10.2.2-225-g5f02c66) > parent(s): 65b4d7457e40ee25302d2df28b0d200ff59d9e6d > committer: Sergey Vojtovich > timestamp: 2016-12-13 16:17:49 +0400 > message: > > MDEV-11227 - mysqlimpor

Re: [Maria-developers] [Commits] 5f02c66: MDEV-11227 - mysqlimport -l doesn't issue UNLOCK TABLES

2016-12-15 Thread Sergei Golubchik
Hi, Sergey! On Dec 15, Sergey Vojtovich wrote: > > > + /* > > > An upgradable shared metadata lock which blocks all attempts to > > > update > > > table data, allowing reads. > > > A connection holding this kind of lock can read table metadata and > > > read > > > diff --git a/sq

Re: [Maria-developers] 10.3 branches

2016-12-16 Thread Sergei Golubchik
Hi, Alexander! Sure, 10.2-ext or 10.3-base - whatever you prefer. I understand that bb-10.2-compatibility will be eventually pushed into 10.3 too, when it'll be ready. For now, I'd suggest the following: 10.2--->10.3 \ \- 10.2-ext ---> 10.2-compat and eventually 10.2-ext

Re: [Maria-developers] Please review MDEV-10524 Assertion `arg1_int >= 0' failed in Item_func_additive_op::result_precision()

2016-12-16 Thread Sergei Golubchik
Hi, Alexander! Looks ok. One question below On Dec 15, Alexander Barkov wrote: > commit 72817bb386320080de87f9cfe899e6f74341d251 > Author: Alexander Barkov > Date: Thu Dec 15 19:40:09 2016 +0400 > > MDEV-10524 Assertion `arg1_int >= 0' failed in > Item_func_additive_op::result_precision(

Re: [Maria-developers] 10.3 branches

2016-12-19 Thread Sergei Golubchik
Hi, Alexander! On Dec 19, Alexander Barkov wrote: > > I created a new branch bb-10.2-ext. > > So the tentative data flow looks like this: > > 10.2-->10.3 <---(once) > \ ^ ^ > \| | >\- bb-10.2-ext ---> bb-10.2-compatibility > > > > - 10

Re: [Maria-developers] 0310b44: MDEV-10418 Assertion `m_extra_cache' failed in ha_partition::late_extra_cache(uint)

2016-12-20 Thread Sergei Golubchik
Hi, Alexey! On Dec 20, Alexey Botchkov wrote: > revision-id: 0310b444dba1b9cbd6921963dd3bff689ca23a24 > (mariadb-5.5.53-34-g0310b44) > parent(s): f23b41b9b8a30e0e54a1ec7a8923057b0e57e0f5 > committer: Alexey Botchkov > timestamp: 2016-12-20 00:24:20 +0400 > message: > > MDEV-10418 Assertion `m_ex

Re: [Maria-developers] Please review MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*)

2016-12-20 Thread Sergei Golubchik
Hi, Alexander! On Dec 19, Alexander Barkov wrote: > Hello Sergei, > > Please review a patch for MDEV-10386. > > Thanks! > diff --git a/sql/item.cc b/sql/item.cc > index 53666aa..44bd620 100644 > --- a/sql/item.cc > +++ b/sql/item.cc > @@ -1164,7 +1164,9 @@ Item *Item_cache::safe_charset_convert

Re: [Maria-developers] Please review MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*)

2016-12-21 Thread Sergei Golubchik
Hi, Alexander! On Dec 21, Alexander Barkov wrote: > >> diff --git a/sql/item.cc b/sql/item.cc > >> index 53666aa..44bd620 100644 > >> --- a/sql/item.cc > >> +++ b/sql/item.cc > >> @@ -1164,7 +1164,9 @@ Item > >> *Item_cache::safe_charset_converter(CHARSET_INFO *tocs) > >>if (conv == example)

Re: [Maria-developers] check_sql_mode

2016-12-27 Thread Sergei Golubchik
Hi, jerome! On Dec 27, jerome brauge wrote: > Hello, > I'm trying to add an option to sql_mode. > For this, I'm adding in sql_class.h : > #define MODE_CONCAT_NULL_YIELDS_NULL(1ULL << 32) > > But now, my serveur doesn't start and show "Sysvar 'sql_mode' failed 'def_val > <= my_set_bits(typeli

Re: [Maria-developers] [External] check_sql_mode

2016-12-27 Thread Sergei Golubchik
Hi, Simon! On Dec 27, Simon J Mudd wrote: > > Slightly off topic but changes in sql_mode has the potential to cause > problems with major version changes and incompatible behaviour. So > combining all sorts of new settings into this variable does not seem > like a good idea to me. It’s already r

Re: [Maria-developers] check_sql_mode

2016-12-27 Thread Sergei Golubchik
Hi, jerome! On Dec 27, jerome brauge wrote: > Sergei, > On SQLServer these kind of option (ANSI_NULLS, CONCAT_NULL_YIELDS_NULL > and so on) can be set at session level or inside stored procedure (but > not in function). In the last case, the scope of the setting is > limited to the stored procedu

Re: [Maria-developers] 33b01257190: MDEV-11584: GRANT inside an SP does not work well on 2nd execution

2016-12-28 Thread Sergei Golubchik
Hi, Oleksandr! On Dec 21, Oleksandr Byelkin wrote: > revision-id: 33b01257190cef414a4b0f00bf36ee6a3ceda0a7 > (mariadb-10.1.20-6-g33b01257190) > parent(s): 9e032d6150b39cf36a22e7c1503e06fae9c4016d > committer: Oleksandr Byelkin > timestamp: 2016-12-21 20:11:14 +0100 > message: > > MDEV-11584: GRA

Re: [Maria-developers] 33b01257190: MDEV-11584: GRANT inside an SP does not work well on 2nd execution

2016-12-28 Thread Sergei Golubchik
Hi, Oleksandr! On Dec 21, Oleksandr Byelkin wrote: > revision-id: 33b01257190cef414a4b0f00bf36ee6a3ceda0a7 > (mariadb-10.1.20-6-g33b01257190) > parent(s): 9e032d6150b39cf36a22e7c1503e06fae9c4016d > committer: Oleksandr Byelkin > timestamp: 2016-12-21 20:11:14 +0100 > message: > > MDEV-11584: GRA

<    1   2   3   4   5   6   7   8   9   10   >