Re: [Maria-developers] [GSOC Students] Allow to contribute

2016-05-01 Thread Vicențiu Ciorbaru
Hi Daniil! The nice thing about git and Github is that you can do all the coding on your own repository. You don't actually need any specific access for the MariaDB repository. My suggestion is to create your own fork of MariaDB (by clicking the fork button on github). Here is a very short tutoria

Re: [Maria-developers] [Commits] b1ddc7d: MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery

2016-05-04 Thread Vicențiu Ciorbaru
Hi Sanja, Sergey, I think Sergey might have mean the same thing but it is not clear to me. in_optimize never gets set to true. By mentioning that it is redundant that means that it can be removed from the current code right? Also, I would put the "return true" conditions after the "return false"

Re: [Maria-developers] Aggregate Stored Functions

2016-05-19 Thread Vicențiu Ciorbaru
Hi Sanja, Since we have not officially started the coding period, I figured that an exercise in adding a parser syntax would be a good first step. We can do automatic detection by looking at the cursor without to much extra work. Vicentiu On Fri, 20 May 2016 at 08:29, Sanja wrote: > Hi! > > H

Re: [Maria-developers] Aggregate Stored Functions

2016-05-23 Thread Vicențiu Ciorbaru
Hi Varun, Getting the parser to accept the syntax is a good first step. Writing tests is the correct way to go also. Now we need to have a way to pass this extra information to the part of the code that stores / executes this procedure. When we encounter this AGGREGATE_SYM syntax we have to recor

Re: [Maria-developers] Aggregate Stored Functions

2016-05-24 Thread Vicențiu Ciorbaru
to make sure it could >> be used for stored procedures too in the future. >> I have committed the changes on GitHub :) >> >> On Mon, May 23, 2016 at 4:21 PM, Vicențiu Ciorbaru >> wrote: >> >>> Hi Varun, >>> >>> Getting the parser to a

[Maria-developers] Please review MDEV-9497 oqgraph fails to build with boost 1.60

2016-05-29 Thread Vicențiu Ciorbaru
Hi Sergei! Can you please review the following patch for MariaDB 10.0. It fixes a compilation failure in Debian/Ubuntu when boost 1.60 or later is installed. I've looked into the code and checked if the #ifdef'ed code is used anywhere. There is absolutely no reference to it. I doubt it affect any

Re: [Maria-developers] Aggregate Stored Functions

2016-06-06 Thread Vicențiu Ciorbaru
>>>>>>>> On Fri, Jun 3, 2016 at 1:01 PM, Varun Gupta < >>>>>>>>>>> varungupta1...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> For non aggregate function , show output is co

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-02 Thread Vicențiu Ciorbaru
vicentiu wrote: > > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842481 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2016-08-01 14:43:41 +0300 > > m

Re: [Maria-developers] c56c966: MDEV-10563 Crash during shutdown in Master_info_index::any_slave_sql_running

2016-08-16 Thread Vicențiu Ciorbaru
Hi Kristian, Thanks for the quick and thorough reply. As to the patch, you're basically moving the check for NULL into all the > callers. I'm not sure if the check is even needed for all callers, but > then, > I also do not think it's worth it to try and determine where it is needed > and where n

Re: [Maria-developers] Sachin weekly report

2016-08-26 Thread Vicențiu Ciorbaru
Hi Sachim, Sergei! One quick thing I wanted to point out. I did not specifically look at how things get called, but, when defining constants, I don't agree with: > +#define HA_HASH_STR_LEN strlen(HA_HASH_STR) > Or: > > +#define HA_HASH_STR_INDEX_LEN strlen(HA_HASH_STR_I

Re: [Maria-developers] Sachin weekly report

2016-08-26 Thread Vicențiu Ciorbaru
th you but defining > #define HA_HASH_STR_LEN 4 > or > const int HA_HASH_STR_LEN = 4; > > make it independent of length of "hash". Although we rarely gone > change "hash", so I think it > is a good idea. What do you think , Sergei? > Regards

Re: [Maria-developers] Error building mariadb-10.0 with Clang 3.8: Unqualified lookup in templates

2016-10-13 Thread Vicențiu Ciorbaru
Hi Luke! This is a know problem that will be fixed in the upcoming release. https://jira.mariadb.org/browse/MDEV-5944 Regards, Vicențiu On Thu, 13 Oct 2016 at 09:16 Luke Benes wrote: > Building mariadb-10.0 with Clang results in: > > graph_concepts.hpp:93:17: error: call to function 'out_edge

[Maria-developers] Article on git rebasing - follow up from Developer Meetup

2016-10-17 Thread Vicențiu Ciorbaru
Hi everyone! During the Developer Meetup in Amsterdam, we've had quite some productive discussions. One of these was on how to make use of git rebase to clean up our history before pushing final changes. The presentation on it was a bit rushed and perhaps some did not get the full gist out of it.

Re: [Maria-developers] [Commits] aa9bd40: MDEV-10824 - Crash in CREATE OR REPLACE TABLE t1 AS SELECT spfunc()

2016-10-24 Thread Vicențiu Ciorbaru
Hi Sergey! I think you commited the AAA.test file by mystake. Regards, Vicentiu On Mon, 24 Oct 2016 at 13:47 Sergey Vojtovich wrote: > revision-id: aa9bd40f8067e1421ad71d2ada367544a6db78ca > (mariadb-10.0.27-8-gaa9bd40) > parent(s): 4dfb6a3f54cfb26535636197cc5fa70fe5bacc2e > committer: Sergey

[Maria-developers] Community Involvement - GSoC Mentor Summit impressions

2016-11-07 Thread Vicențiu Ciorbaru
Hi everyone! Since MariaDB has completed another Google Summer of Code program this year, with some great projects as well, the MariaDB Foundation was able to send 2 mentors to the summit in California this year. I was one of the people that had the privilege to go. There were a lot of talks ther

Re: [Maria-developers] Deleting unused branches on github

2016-11-07 Thread Vicențiu Ciorbaru
Hi! I'm wondering if it makes sense to have an automatic cleanup process for branches older than X months? We can potentially add some exceptions for work that needs to stay. Regards, Vicențiu On Mon, 7 Nov 2016 at 18:54 Sergey Vojtovich wrote: > Hi! > > ALL BRANCH OWNERS: PLEASE REVIEW AND C

Re: [Maria-developers] Deleting unused branches on github

2016-11-07 Thread Vicențiu Ciorbaru
On Mon, 7 Nov 2016 at 19:40 Elena Stepanova wrote: > Hi, > > On 11/07/2016 08:59 PM, Vicențiu Ciorbaru wrote: > > Hi! > > > > I'm wondering if it makes sense to have an automatic cleanup process for > > branches older than X months? > > Please don

Re: [Maria-developers] GSOC21: MDEV-16375 & MDEV-23143

2021-04-01 Thread Vicențiu Ciorbaru
Hi Songlin! It's great that you are excited about this project! Here are my thoughts on your proposal and what I think you should focus on: JSON_NORMALIZE seems simple at first, but I believe there are a lot of corner cases. In order to get a proper specification for this function can you have a

[Maria-developers] Initial prototype for MDEV-10825 Persist exact view definitions DDL

2021-04-16 Thread Vicențiu Ciorbaru
Hi Sergei! This email is a followup to the brief discussion on Zulip here: https://mariadb.zulipchat.com/#narrow/stream/118759-general/topic/preserve.20original.20formatting.20for.20views You mentioned we store the view's definition (source) inside the FRM. I've used that information to extend t

Re: [Maria-developers] [Commits] 6f1628b: MDEV-25565 Crash on 2-nd execution of SP/PS for query calculating window functions

2021-07-20 Thread Vicențiu Ciorbaru
Hi Igor! The patch looks good, however I suggest the following changes to make it smaller and easier to read & maintain. 1. You do not need to have special if statements for save_partition_list and save_order_list when you do the cleanup. 2. You do not need to have special code that saves the par

Re: [Maria-developers] Google Summer of Code 2022

2022-03-20 Thread Vicențiu Ciorbaru
Hi Sergey! I'm happy to see that you have experience in MariaDB code base already. The MDEV-18827 is definitely up for grabs for GSoC 2022. The project is mostly a part-time project (requiring a commitment of around 175 hours), however depending on your availability we can increase the scope of th

Re: [Maria-developers] Participation in MariaDB Community's Open Source Project

2023-04-08 Thread Vicențiu Ciorbaru
Hi Yingquan! I recommend you start reading this article: https://mariadb.org/get-involved/getting-started-for-developers/ That should guide you in the right direction. Feel free to reach out on zulip https://mariadb.zulipchat.com/ if you have any questions. You can have a look at our beginner fr

<    1   2