Hi Marko,
>
>
> I am sad to see that my comment regarding wsrep_is_BF_lock_timeout()
> that I made in
> https://github.com/MariaDB/server/commit/b74b53f0515b360bb5cddec1a506a2f4d4dc21b3#r52293813
> (June 17) has not been addressed. Do we really need that output? Do we
> see that output in our
Hi Sergei,
>
> > --- a/sql/sql_parse.cc
> > +++ b/sql/sql_parse.cc
> > @@ -2159,6 +2159,7 @@ bool dispatch_command(enum enum_server_command
> command, THD *thd,
> > }
> > DBUG_PRINT("quit",("Got shutdown command for level %u", level));
> > general_log_print(thd, command, NullS);
>
Oct 21, 2021 at 7:52 AM Jan Lindström
wrote:
> Hi Sergei,
>
> This does not seem to work. Consider following:
>
> CREATE TABLE t1 (id INT PRIMARY KEY) ENGINE=InnoDB;
> INSERT INTO t1 VALUES (1);
> connection node_2;
> SET AUTOCOMMIT=OFF;
> START TRANSACTION;
> INSERT INTO
rt_transaction()). Note it's the patch
> for 10.2 at the commit 29bbcac0ee8^ - that is one commit before my fix.
>
> On Oct 12, Jan Lindström wrote:
> > Hi Sergei,
> >
> > Update on wsrep_close_connections problem. My suggestion to fix this
> issue
> > is on
.
R: Jan
On Fri, Oct 15, 2021 at 11:36 AM Sergei Golubchik wrote:
> Hi, Jan!
>
> On Oct 15, Jan Lindström wrote:
> > Few questions:
> >
> > (1) Is this review for a full patch or just problems on
> > wsrep_abort_transaction ?
>
> a full patch
>
> &
rt_transaction()). Note it's the patch
> for 10.2 at the commit 29bbcac0ee8^ - that is one commit before my fix.
>
> On Oct 12, Jan Lindström wrote:
> > Hi Sergei,
> >
> > Update on wsrep_close_connections problem. My suggestion to fix this
> issue
> > is on
> &g
Hi Sergei,
Update on wsrep_close_connections problem. My suggestion to fix this issue
is on
https://github.com/MariaDB/server/commit/99cbe03a44cc95e6f548550df51e7201ebea3b9d
If you have a better solution, please advise.
R: Jan
On Mon, Oct 11, 2021 at 12:52 PM Jan Lindström
wrote:
>
Hi Sergei,
>
> > > trx_rw_is_active needs to be modified to do that, right?
> >
> > No this is current behaviour, I did not change anything on
> > trx_rw_is_active
>
> In xtradb trx_rw_is_active returns bool.
> I think xtradb is still the default innodb in 10.2.
>
> In innobase it returns,
ed, Oct 6, 2021 at 5:03 PM Sergei Golubchik wrote:
> Hi, Jan!
>
> On Oct 06, Jan Lindström wrote:
> > >
> > > > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */
> > > > > > +static int wsrep_thr_abort_thd(void *bf_thd_ptr,
Update on disconnect
>
> > // As trx is now referenced it can't go away
>
> Hmm. What happens if the thd that owns this transaction is killed or the
> user disconnects? THD gets freed. What happens to the referenced trx?
>
I created new mtr-tests (galera_disconnect_debug) to try
Hi Sergei,
Update on what happens after TOI failure.
> What I mean it, what if KILL would ignore WSREP_TO_ISOLATION_BEGIN
> failure and will just proceed killing? Perhaps if
> WSREP_TO_ISOLATION_BEGIN fails it means that there can be no bf aborts
> anyway? Could you try to find it out?
>
After
Hi Sergei,
>
> > if (victim_trx) {
> > const trx_id_t victim_trx_id= victim_trx->id;
> > const longlong victim_thread= thd_get_thread_id(victim_thd);
> > /* This is necessary as correct mutexing order is
> > lock_sys -> trx -> THD::LOCK_thd_data and below
> > function
Hi Sergei,
Answers to your questions below:
On Wed, Oct 6, 2021 at 5:03 PM Sergei Golubchik wrote:
> Hi, Jan!
>
> On Oct 06, Jan Lindström wrote:
> > >
> > > > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */
> > > > > >
Hi Sergei,
Answers below:
>
> > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */
> > > > +static int wsrep_thr_abort_thd(void *bf_thd_ptr, void
> *victim_thd_ptr, my_bool signal)
> > > > +{
> > > > + THD* victim_thd= (THD *) victim_thd_ptr;
> > > > + /* We need to lock
Hi Sergei,
On Fri, Oct 1, 2021 at 9:05 PM Sergei Golubchik wrote:
> Hi, Seppo, Jan!
>
> Note, this is 10.2 patch below.
>
> >
> > MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)
>
> I think this should say
>
> MDEV-23328 Server hang due to Galera lock conflict resolution
>
>
Hi Sujatha,
On Mon, Jan 4, 2021 at 11:45 AM sujatha
wrote:
>
> +for (TABLE_LIST *tables= rgi->tables_to_lock; tables;
> + tables= tables->next_global)
> +{
> + if (slave_run_triggers_for_rbr)
>{
> tables->trg_event_map= new_trg_event_map;
>
Hi Sergei,
>
>
> Not exactly. In 10.2 THD::~THD() only has
>
> mysql_mutex_lock(_thd_data);
> mysql_mutex_unlock(_thd_data);
>
> it's not what Jan did. So I thought it'd be safer to leave it in place.
> But 10.5 has
>
> if (WSREP_NNULL(this)) mysql_mutex_lock(_thd_data);
>
Hi Alexander and thank you for your review.
On Tue, Nov 27, 2018 at 2:18 PM Alexander Barkov wrote:
> Hi Jan,
>
>
> I checked changes to the /sql directory so far.
> Sorry, I'm completely out of this topic.
> So I have only general suggestions.
>
>
>
> 1. General code structure.
>
> There are a
socat to mariabackup
> package aren't much better, as mariabackup users don't really need socat
> either.
>
> May be just a better error message in the script?
>
> On Feb 06, jan wrote:
> > revision-id: 9bc03294c89b16df5f556b7d9fa4cb1eadae451a
> (mariadb-10.1.30-31-g9
On Mon, Dec 11, 2017 at 9:40 AM, sachin wrote:
> revision-id: 8048670e25e5cda915ad7ce16dbd66afa6227aa5
> (mariadb-10.1.29-24-g8048670)
> parent(s): de76cbdcb0728b80c0f7b453b24b0b81f653e450
> author: Sachin Setiya
> committer: Sachin Setiya
> timestamp: 2017-12-11
Hi,
On Mon, Aug 7, 2017 at 2:09 PM, Kristian Nielsen
wrote:
>
> The problem is that somehow the thd_get_durability_property() function was
> introduced into MariaDB code, but it is completely non-functional. So now
> there is code in InnoDB, TokuDB and RocksDB that
Hi,
If we talk about bulk load I would write directly .ibd file format pages,
now as InnoDB has always some order between pages doing this in parallel
has challenges, we can read and parse input, sort it, reformat to InnoDB
pages, write these pages (maybe you could do this also parallel). To
Hi,
Very interesting and nice to see that paper is not full of theorems and
mathematics, very good paper!. Any ideas how to
improve from here ?
R: Jan
On Thu, Apr 27, 2017 at 7:10 PM, Galina Shalygina
wrote:
> мои артиклы
>
>
>
Hi,
Galera cluster (https://github.com/codership/mysql-wsrep/commits/5.6) has
new feature :
commit 14301279075dc2b420f3173cc9c2eb7912db63de
Author: sjaakola
Date: Fri Nov 18 12:45:42 2016 +0200
Refs: MW-319
* replicating write set containing only GTID event of
ok to push.
On Thu, Feb 16, 2017 at 11:17 AM, wrote:
> revision-id: 01d5d6db4c337daae0aa593341e081cc6bfebb8a (mariadb-10.0.29-25-
> g01d5d6db4c3)
> parent(s): 6011fb6daa5ac9e6cb97a23b877e4d2568c85d94
> author: Marko Mäkelä
> committer: Marko Mäkelä
> timestamp:
ok to push.
On Wed, Feb 15, 2017 at 4:02 PM, wrote:
> revision-id: f380e7b5535358bd3d7caf81d22579ef97f6ca24 (mariadb-10.2.3-271-
> gf380e7b5535)
> parent(s): 24911cee4e3be988848f6eab4d768849709f5256
> author: Marko Mäkelä
> committer: Marko Mäkelä
> timestamp:
Hi,
On Mon, Jan 16, 2017 at 2:10 PM, wrote:
>
> diff --git a/storage/innobase/btr/btr0btr.cc b/storage/innobase/btr/
> btr0btr.cc
> index d1d9dfe64fe..1fb5cb06949 100644
> --- a/storage/innobase/btr/btr0btr.cc
> +++ b/storage/innobase/btr/btr0btr.cc
> @@ -215,10 +215,6
Hi,
Number of the fields indeed would solve the ADD COLUMN default case but has
some limitations
ADD COLUMN m default xxx; would be still slow, xxx = NULL maybe possible,
in other cases could we store default on SYS_COLUMNS?
DROP COLUMN would be still slow
Problem naturally is that we do not
On Wed, Dec 28, 2016 at 5:16 PM, wrote:
>
> diff --git a/storage/innobase/fil/fil0crypt.cc b/storage/innobase/fil/
> fil0crypt.cc
> index 75efcdfdab0..095b9f706c0 100644
> --- a/storage/innobase/fil/fil0crypt.cc
> +++ b/storage/innobase/fil/fil0crypt.cc
> @@ -1179,10
ok to push.
Most likely the double free was result of some other bug fixed later.
R: Jan
On Mon, Dec 19, 2016 at 4:00 PM, wrote:
> revision-id: 9f863a15b037c0ddffc2d12c1f7d841466f9f345 (mariadb-10.0.28-27-
> g9f863a15b03)
> parent(s):
Hi,
All other looks correct, I'm concerned only following change that is not
needed
to fix this bug:
On Thu, Dec 8, 2016 at 2:35 PM, wrote:
>
>
> - err = lock_trx_handle_wait(trx,
> - (lock_mutex_taken || already_have_lock_mutex),
>
Hi,
ok to push.
R: Jan
On Thu, Dec 1, 2016 at 8:36 AM, wrote:
> revision-id: 2c9bb42d901fc4f48f4884e4a85af74eae6d0929
> (mariadb-10.2.2-91-g2c9bb42)
> parent(s): dc9f919f27fccfeb0de3ab392f33bc5efdfd59a0
> author: Marko Mäkelä
> committer: Marko Mäkelä
> timestamp:
Hi Nirbhay,
This looks ok but one question (no need to change now):
On Wed, Sep 28, 2016 at 7:36 PM, Nirbhay Choubey
wrote:
>
> +Since some wsrep threads (THDs) are create before plugins are
> +initialized, LOCK_plugin mutex needs to be initialized here.
> + */
>
I'm fine with this. Ok to push #1.
28.9.2016 15.32 "Sergey Petrunia" <ser...@mariadb.com> kirjoitti:
> On Wed, Sep 07, 2016 at 10:36:32AM +0300, Jan Lindström wrote:
> > On Tue, Sep 6, 2016 at 8:37 PM, Sergei Petrunia <pser...@askmonty.org>
&
On Tue, Sep 6, 2016 at 8:37 PM, Sergei Petrunia
wrote:
> revision-id: f2aea435df7e92fcf8f09f8f6c160161168c5bed
> parent(s): a14f61ef749ad9f9ab2b0f5badf6754ba7443c9e
> committer: Sergei Petrunia
> branch nick: 10.0
> timestamp: 2016-09-06 20:37:21 +0300
> message:
>
>
On Fri, Sep 2, 2016 at 2:17 PM, Kristian Nielsen
wrote:
> Michael Widenius writes:
>
>
> Ok, so I prepared patches for this:
>
> http://lists.askmonty.org/pipermail/commits/2016-September/009740.html
>
On Thu, Sep 1, 2016 at 12:31 PM, Kristian Nielsen
wrote:
> Michael Widenius writes:
>
>
>
> This is because of errorneous merge. The original code:
>
> if (waitee_buf_ptr) {
> lock_report_waiters_to_mysql(waitee_buf_ptr,
>
Hi,
On Fri, Aug 12, 2016 at 12:26 PM, Kristian Nielsen wrote:
>
>
> From a quick look at the patch, this seems to be because of code removed
> from innobase_kill_query(). Specifically:
>
> > @@ -4799,65 +5511,11 @@ innobase_kill_query(
> >
Hi,
Please commit and push these changes to your git branch I have not yet seen
them, in my opinion as this is only a working branch you can push often. I
still fail to see any test cases on InnoDB branch, do you have more than
one branch and if you have why ? Depending on extent of these changes
Hi Nirbhay,
I'm not expert on this code area but some questions, comments below.
On Tue, May 3, 2016 at 1:26 AM, Nirbhay Choubey wrote:
> revision-id: a6fb98fd74ab6f14fab0c1ef4630b010ff28880f
> (mariadb-10.1.13-6-ga6fb98f)
> parent(s):
ious comments, see below. Nothing big, nothing that's really
> the approach you've taken. In fact, I like where it's going.
>
> But this is a huge and intrusive patch. I wonder, should we rather do it
> in 10.2? See below, you yourself write:
>
> On Feb 25, Jan Lindström wrote:
&g
question,
do you allow blobs to be foreign keys or not. Finally, unique key with NOT
NULL can be used as primary key i.e. clustered key on InnoDB, using blobs
hash on that might be out of reach on this timetable.
R: Jan Lindström
Principal Engineer
InnoDB
On Wed, Mar 23, 2016 at 6:38 PM, Shubham Barai
Where I get mips machine to test and find out the reason, do we even
support mips ?
On Tue, Feb 2, 2016 at 4:34 PM, Alexander Barkov wrote:
> Hello Jan.
>
> a gentle reminder ;)
>
> Thanks.
>
>
> On 01/26/2016 04:35 PM, Alexander Barkov wrote:
>
>> Hi Jan,
>>
>> can you please
for
this.
R: Jan
On Mon, Jan 11, 2016 at 10:39 AM, Otto Kekäläinen <o...@seravo.fi> wrote:
> 2016-01-11 9:25 GMT+02:00 Jan Lindström <jan.lindst...@mariadb.com>:
> > These warnings are printed because some of the system table definitions
> have
> > been changed
I did not remember to make it totally public, modified version:
https://mariadb.atlassian.net/browse/MDEV-9394
On Mon, Jan 11, 2016 at 12:51 PM, Jan Lindström <jan.lindst...@mariadb.com>
wrote:
> Hi,
>
> I agree with you, I do not fully understand why mysql_upgrade is sep
Hi,
These warnings are printed because some of the system table definitions
have been changed, you should run mysql_upgrade and restart should be again
more silent.
R: Jan
On Mon, Jan 11, 2016 at 8:56 AM, Otto Kekäläinen wrote:
> Hello!
>
> When testing mysql 5.6 -> mariadb
Ok to push.
On Mon, Nov 30, 2015 at 6:45 PM, wrote:
> revision-id: be25be4b1aaf65593d67498c2f30a99fd254ea15
> (mariadb-10.1.8-71-gbe25be4)
> parent(s): cf8cb9ebd810a46154f99a73045b53a6913b6eb6
> committer: Sergei Golubchik
> timestamp: 2015-11-30 17:45:23 +0100
> message:
>
>
Hi Sergey,
Is this true only for innodb_plugin ?
R: Jan
On Wed, Nov 18, 2015 at 2:07 PM, Sergey Vojtovich wrote:
> revision-id: 2709165caed4691d1203f0b91d22d0e7927b
> (mariadb-10.1.8-67-g2709165)
> parent(s): bff6780806f4afed8faaf4c79b1593964564097e
> committer: Sergey
Hi,
Is it possible to know how many transactions/operations slave is behind the
master ?
Assume in above that master is idle for several days, if master then
executes a one
transaction, does that mean that slave is behind the master also several
days ?
R: Jan
On Thu, Oct 22, 2015 at 9:12 AM,
Sergey,
=== modified file 'sql/opt_range.cc'
--- a/sql/opt_range.cc 2014-04-01 16:59:51 +
+++ b/sql/opt_range.cc 2014-04-18 10:07:54 +
@@ -2181,7 +2181,7 @@ int QUICK_ROR_INTERSECT_SELECT::init_ror
quick-record= head-record[0];
}
- if
Hi all,
After careful weighting and selection process, I have selected
following two projects as a starting point to improve InnoDB
(1) InnoDB file space defragmentation
Description: External tool to physically delete delete marked
rows from InnoDB file
Hi,
Hello
I am Suyash Loiwal from India, currently pursuing my B.Tech
from Manipal institute of Technology, Manipal. I would like to
take a project under your organization. Can someone please
guide me how to start?
Thanks
Hi,
I agree all other points except the fact that you do not need to
use SHOW commands. Applications might rely on fact
that internal foreign key names on InnoDB are form
table_name_ibfk_n. But maybe this is only a minor
'matter'.
Current,
Hi,
Change: Another change is that it uses the index name for the
internal dictionary.
Not ok. Firstly, that change should affect many test cases using
foreign keys. Secondly, that would effect applications using
foreign keys. I could only
Hi,
Hi, Jan!
Good point!
On Feb 02, Jan Lindstrm wrote:
Hi,
In my opinion the test case is not complete, you are missing e.g.
ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id);
-- should fail on warning
ALTER TABLE t2 ADD FOREIGN KEY
Hi,
In my opinion the test case is not complete, you are missing e.g.
ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id);
-- should fail on warning
ALTER TABLE t2 ADD FOREIGN KEY IF NOT EXISTS (id) REFERENCES t1(id);
ALTER TABLE t2 ADD FOREIGN
Hi,
MySQL changes look good, InnoDB changes need some work that I will
do, please do not push those.
R: Jan
At file:///home/hf/wmar/10exp/
revno: 3886
revision-id:
Hi,
Yes, there is wsrep_replicate_myisam, this variable controls if MyISAM
will be replicated or not. MyISAM replication is still
experimental and that is one of the reasons why this variable is
set to OFF
by default.
Aria could be used
On 10/01/2013 06:57 AM, Roberto Spadim
wrote:
Hi Jan!
This job is something more dificullt than just copy/paste
the myisam "if"s ?
i don't know how wsrep works, just trying to use aria as
myisam with galera cluster
Hi,
I think I solved this issue by
#ifdef WITH_WSREP
if (!wsrep_emulate_bin_log)
binlog_trans_log_truncate(thd, *(my_off_t*)sv);
#endif
This avoids using the uninitialized memory in Galera, this was
error in merge.
dled in some other MDEV ?
R:
--
Jan Lindström
Principal Engineer
MariaDB | MaxScale | skype: jan_p_lindstrom
www.skysql.com
___
Mailing list: https://launchpad.net/~maria-developers
Post to
2779096485, ha_list = 0xa5a5a5a5a5a5a5a5, mdl_savepoint =
{m_stmt_ticket = 0xa5a5a5a5a5a5a5a5, m_trans_ticket =
0xa5a5a5a5a5a5a5a5}}
Again access to unitialized memory, sv is ok but sv+1 not
R:
--
Jan Lindström
Principa
Seppo,
Hi,
What means:
30925 15:10:36 [ERROR] Slave SQL: Could not execute Update_rows
event on table test.table10_key_pk_parts_2_int_autoinc; Can't find
record in 'table10_key_pk_parts_2_int_autoinc', Error_code: 1032;
handler
REP_LOG(sql_print_error,
##__VA_ARGS__)
Thus , it seems that trx_cache and stmt_cache are not initialized,
where that should happen ?
Jan Lindström jplin...@mariadb.org writes:
Correct log file attached.
==00:00:02:3
In
http://www.ijcit.com/archives/volume2/issue5/Paper020519.pdf
For some reason MySQL/MariaDB is not mentioned.
R:
--
Jan Lindstrm
Principal Engineer
MariaDB | MaxScale | skype: jan_p_lindstrom
www.skysql.com
Hi,
I need help. After merge galera-10.0 with 10.0, rollback asserts.
I seem not to be able to find the actual reason. I added some
extra output on log.cc to dump out the cache_log data from both
trx_cache and stmt_cache, but to me these values do not
not help.
Where I should add some output to narrow down the place where
the corruption happens.
R: Jan
--
Jan Lindström
Principal Engineer
MariaDB | MaxScale | skype: jan_p_lindstrom
www.skysql.com
=--general_log_file=/home/jan/mysql/galera-test/stmt.log
R:
--
Jan Lindström
Principal Engineer
MariaDB | MaxScale | skype: jan_p_lindstrom
www.skysql.com
___
Mailing list: https
Hi,
Background: I merged 10.0 to
lp:~maria-captains/maria/maria-10.0-galera/, merge result is pushed
to the tree.
In testing I hit repeatable to following assertion
#0 0x7f1ff987f037 in __GI_raise (sig=sig@entry=6) at
0xa5a5a5a5a5a5a5a5
(gdb) p cache_log.pos_in_file
$4 = 11936128518282651045
(gdb) p *cache_log.request_pos
$5 = 37 '%'
(gdb) p cache_log.request_pos
$6 = (uchar *) 0x7f214003bb10 "%\374-R\023"'
R: Jan
Jan Lindström jplin...@mariadb.
See:
http://developers.slashdot.org/story/13/09/09/2259206/a-tale-of-two-mysql-bugs
Great work!
--
Jan Lindstrm
Principal Engineer
MariaDB | MaxScale | skype: jan_p_lindstrom
www.skysql.com
On 08/19/2013 07:43 PM, MARK CALLAGHAN wrote:
Welcome back to the MySQL community Jan. It is good to see
SkySQL/MariaDB get more InnoDB expertise.
Thanks, I have really enjoyed back on MySQL community. Many things are
changed but many are as they were when I was moved to develop other
Hi,
From experience working on two storage engines on MySQL and being main
developer for the second one, and one storage engine on big company, I
would say MySQL storage engine API has some legacy problems and clearly
some missing functionality. e.g.
- Some part of the storage engines are
Hi,
On 08/13/2013 09:49 AM, Kristian Nielsen wrote:
You can always use the contents of the binlogs to know this. You can
search the binlogs for your GTID and determine if it was a) logged in
an earlier binlog that was purged, b) found in the binlog, c) a hole
due to filtering or whatever, or
Hi,
On 08/12/2013 02:59 PM, Kristian Nielsen wrote:
I took a close look at your patch for MDEV-4820.
I think there is a fundamental disconnect. In MariaDB GTID, I do not require
or rely on monotonically increasing seqeunce numbers (monoticity is requred
per-server-id, but not between different
Hi,
Before you say they are fully compatible, I point out at least
following types at mysql_com.h that do not exist on MariaDB
mysql_com.h:
MYSQL_TYPE_TIMESTAMP2,
MYSQL_TYPE_DATETIME2,
MYSQL_TYPE_TIME2,
I do not know the details of this particular point (also you did not
76 matches
Mail list logo