Re: [Maria-developers] MDEV-28152: Features for sequence

Hi! I couple of small comments in addition to Sanjas review: > > +longlong sequence_definition::truncate_value(const Longlong_hybrid& > > original) > > +{ > > + if (is_unsigned) > > +return original.to_ulonglong(value_type_max()); > > + else if

Re: [Maria-developers] Review: MDEV-29075 Changing explicit_defaults_for_timestamp within stored procedure works inconsistently

Hi! On Fri, 29 Jul 2022, 07:43 Alexander Barkov, wrote: >Hello Sergei, > > I have a couple of suggestions: > > I suggest considering these ways: > > > 1. Change "bool explicitly_nullable" to "bool explicit_nullability", > which will be: > > - false if nothing was specified > - true if

Re: [Maria-developers] eebebe8ef75: MDEV-23842 Atomic RENAME TABLE

Hi! >> diff --git a/client/mysqltest.cc b/client/mysqltest.cc >> index 350c55edee2..133d1f76839 100644 >> --- a/client/mysqltest.cc >> +++ b/client/mysqltest.cc >> @@ -8095,9 +8095,10 @@ void handle_error(struct st_command *command, >>const char *err_sqlstate, DYNAMIC_STRING

Re: [Maria-developers] c80f867b0df: MDEV-23844 Atomic DROP TABLE

Hi! On Wed, May 12, 2021 at 3:18 PM Sergei Golubchik wrote: > > Hi, Michael! > > On May 12, Michael Widenius wrote: > > revision-id: c80f867b0df (mariadb-10.6.0-78-gc80f867b0df) > > parent(s): eebebe8ef75 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] 9083627c50f: Make rename atomic/repeatable in MyISAM and Aria

Hi! > > + /* > > +This code is written so that it should be possible to re-run a > > +failed rename (even if there is a server crash in between the > > +renames) and complete it. > > + */ > > > > fn_format(from,old_name,"",MARIA_NAME_IEXT,MY_UNPACK_FILENAME|MY_APPEND_EXT); > >

Re: [Maria-developers] 32c73138ff4: Remove some usage of Check_level_instant_set and Sql_mode_save

Hi! On Mon, Apr 19, 2021 at 9:55 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 19, Michael Widenius wrote: > > revision-id: 32c73138ff4 (mariadb-10.5.2-559-g32c73138ff4) > > parent(s): 07708eb9b28 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] 6b06a99e4a4: Avoid creating the .frm file twice in some cases

Hi! On Mon, Apr 19, 2021 at 8:17 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 19, Michael Widenius wrote: > > revision-id: 6b06a99e4a4 (mariadb-10.5.2-557-g6b06a99e4a4) > > parent(s): 9c1e36696f3 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] 9c1e36696f3: MDEV-20025: ADD_MONTHS() Oracle function

Hi! On Fri, Apr 16, 2021 at 8:25 PM Sergei Golubchik wrote: > > +++ b/mysql-test/suite/compat/oracle/r/func_add_months.result > > @@ -0,0 +1,85 @@ > > +Test for ADD_MONTHS > > +CREATE TABLE t1(c1 int, c2 datetime, c3 date, c4 time, c5 timestamp); > > +INSERT INTO t1 VALUES (1, '2011-11-12

Re: [Maria-developers] fbe1dad15a1: Ensure that we do not allocate strings bigger than 4G in String objects.

Hi! On Fri, Apr 16, 2021 at 8:08 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 16, Michael Widenius wrote: > > revision-id: fbe1dad15a1 (mariadb-10.5.2-555-gfbe1dad15a1) > > parent(s): 57c19902326 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] c157c285db9: Optimize Sql_alloc

Hi! On Sat, Mar 27, 2021 at 7:14 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 27, Michael Widenius wrote: > > revision-id: c157c285db9 (mariadb-10.5.2-514-gc157c285db9) > > parent(s): 16e38888c06 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 21eb8969ce9: Improved storage size for Item, Field and some other classes

Hi! > Right. But non-existent commits mean you cannot check out the bitfield > code and run tests with it. It won't compile because columnstore will > fail to check out and cmake will stop before any compilation will even > be able to start. I don't really care if one for 3-5 commits in a

Re: [Maria-developers] 4088269c578d: Improved storage size for Item, Field and some other classes

Hi! On Fri, Dec 4, 2020 at 2:50 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Dec 03, Michael Widenius wrote: > > revision-id: 4088269c578d (mariadb-10.5.2-270-g4088269c578d) > > parent(s): 994ea2af3973 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 16e38888c06: Improved storage size for Item, Field and some other classes

Hi! On Sat, Mar 27, 2021 at 6:53 PM Sergei Golubchik wrote: > > Hi, Michael! > > Did you consider trying -Wpadded? > > '-Wpadded' > Warn if padding is included in a structure, either to align an > element of the structure or to align the whole structure. > Sometimes when this

Re: [Maria-developers] a94502ab674: Added typedef decimal_digits_t (uint16) for number of decimals

Hi! >> Added typedef decimal_digits_t (uint16) for number of decimals >> For fields and Item's uint8 should be good enough. After >> discussions with Alexander Barkov we choose uint16 (for now) >> as some format functions may accept +256 digits. >> >> The reason for this patch was to make the

Re: [Maria-developers] 2be9b69f4ff: MDEV-23001 Precreate static Item_bool() to simplify code

Hi! > > MDEV-23001 Precreate static Item_bool() to simplify code > > > > The following changes where done: > > - Create global Item: Item_false and Item_true > > - Replace all creation if 'FALSE' and 'TRUE' top level items used for > > WHERE/HAVING/ON clauses to use Item_false and Item_true.

Re: [Maria-developers] c76ac1e6de8: MDEV-24089 support oracle syntax: rownum

Hi! On Mon, Apr 19, 2021 at 10:52 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 18, Michael Widenius wrote: > > > > diff --git a/mysql-test/main/rownum.test b/mysql-test/main/rownum.test > > > > new file mode 100644 > > > > inde

Re: [Maria-developers] 57c19902326: MDEV-20017 Implement TO_CHAR() Oracle compatible function

Hi! On Fri, Apr 16, 2021 at 5:44 PM Sergei Golubchik wrote: > > diff --git a/sql/share/errmsg-utf8.txt b/sql/share/errmsg-utf8.txt > > index aecb00563f7..b23522ac830 100644 > > --- a/sql/share/errmsg-utf8.txt > > +++ b/sql/share/errmsg-utf8.txt > > @@ -7975,3 +7975,5 @@

Re: [Maria-developers] a1440737662: MDEV-20021 sql_mode="oracle" does not support MINUS set operator

Hi! > > MINUS is mapped to EXCEPT > > > > diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy > > index 57ba9df42c0..edd2f353dd0 100644 > > --- a/sql/sql_yacc.yy > > +++ b/sql/sql_yacc.yy > > @@ -16037,6 +16038,7 @@ reserved_keyword_udt_not_param_type: > > | MINUTE_MICROSECOND_SYM > >

Re: [Maria-developers] 04a13e6ab8f: MDEV-24285 support oracle build-in function: sys_guid

Hi! On Tue, Apr 13, 2021 at 11:37 AM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 13, Michael Widenius wrote: > > revision-id: 04a13e6ab8f (mariadb-10.5.2-552-g04a13e6ab8f) > > parent(s): c76ac1e6de8 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] c76ac1e6de8: MDEV-24089 support oracle syntax: rownum

On Mon, Apr 12, 2021 at 7:20 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 12, Michael Widenius wrote: > > revision-id: c76ac1e6de8 (mariadb-10.5.2-551-gc76ac1e6de8) > > parent(s): a507eb17708 > > author: Michael Widenius > > committer: Michael Widen

Re: [Maria-developers] d221068ae8b: Change CHARSET_INFO character set and collaction names to LEX_CSTRING

Hi! On Thu, Apr 1, 2021 at 4:19 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 01, Michael Widenius wrote: > > revision-id: d221068ae8b (mariadb-10.5.2-540-gd221068ae8b) > > parent(s): 896c3b0a00a > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] e3971006cca: Give a readable error in mtr if resolve_at_variable fails

Hi! On Mon, Apr 5, 2021 at 5:27 PM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 05, Michael Widenius wrote: > > revision-id: e3971006cca (mariadb-10.5.2-547-ge3971006cca) > > parent(s): ae009435e72 > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] 405a89353b2: Don't reset StringBuffers in loops when not needed

Hi! On Sat, Apr 3, 2021 at 12:54 AM Sergei Golubchik wrote: > > Hi, Monty! > > On Apr 02, Michael Widenius wrote: > > revision-id: 405a89353b2 (mariadb-10.5.2-542-g405a89353b2) > > parent(s): 2dd8d472fcc > > author: Michael Widenius > > committer: Michael Wi

Re: [Maria-developers] f46382ba93c: Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()

Hi! On Thu, Apr 1, 2021 at 12:08 AM Sergei Golubchik wrote: > > Hi, Monty! > Hmm, I don't understand. The difference between > > String a("Hello", 5); > > and > > char hello[5]; > String a(buf, 5); > > is that in the first case the argument is const char*. And in that case >

Re: [Maria-developers] f46382ba93c: Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()

Hi! On Thu, Apr 1, 2021 at 12:03 AM Sergei Golubchik wrote: > > > > - DBUG_PRINT("info", ("Found partition %u is_subpart %d for name %s", > > > > + DBUG_PRINT("info", ("Found partition %u is_subpart %d for name %.*s", > > > >part_def->part_id, part_def->is_subpart, >

Re: [Maria-developers] f46382ba93c: Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()

Hi! Sorry, this was because gmail send it before I wanted to. (I do not like that ctrl+return sends email as this causes problems when one uses this a lot in slack!) > > > --- a/sql/sql_string.h > > > +++ b/sql/sql_string.h > > > @@ -600,25 +600,34 @@ class Binary_string: public

Re: [Maria-developers] f46382ba93c: Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()

On Wed, Mar 31, 2021 at 9:45 PM Michael Widenius wrote: > > Cut > > > Optimize usage of c_ptr(), c_ptr_quick() and String::alloc() > > > > > > The proble was that hen using String::alloc() to allocate a string, > > > > "hen" ? after a min

Re: [Maria-developers] f46382ba93c: Optimize usage of c_ptr(), c_ptr_quick() and String::alloc()

Cut > > Optimize usage of c_ptr(), c_ptr_quick() and String::alloc() > > > > The proble was that hen using String::alloc() to allocate a string, > > "hen" ? after a minute of staring I realized that you probably meant "when". > > (also, "problem") > > > the String ensures that there is space for

Re: [Maria-developers] 1bbc852ef71: Changed field_index to use field_index_t instead of uint16

Hi! On Mon, Mar 29, 2021 at 3:55 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 29, Michael Widenius wrote: > > revision-id: 1bbc852ef71 (mariadb-10.5.2-525-g1bbc852ef71) > > parent(s): 039f4a054bb > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 1d577194654: Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"

Hi! On Mon, Mar 29, 2021 at 4:20 PM Sergei Golubchik wrote: > > Hi, Michael! Only people who do not know me calls me Michael... Who are you? > > Revert MDEV-16592 "Change Item::with_sum_func to a virtual method" > > > > diff --git a/sql/item.cc b/sql/item.cc > > index e5be8699d80..e0ba4ff2c89

Re: [Maria-developers] f8901333a82: Add support for minimum field width for strings to my_vsnprintf()

Hi! On Mon, Mar 29, 2021 at 9:39 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 29, Michael Widenius wrote: > > revision-id: f8901333a82 (mariadb-10.5.2-534-gf8901333a82) > > parent(s): a194c5cfd41 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 25fe7dbad5d: Reduce usage of strlen()

Hi! On Wed, Mar 31, 2021 at 5:18 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 31, Michael Widenius wrote: > > commit 25fe7dbad5d > > Author: Michael Widenius > > Date: Wed Aug 12 20:29:55 2020 +0300 > > > >Reduce usage of strlen() >

Re: [Maria-developers] dbb62d20f36: Fixes that enables my_new.cc (new wrapper using my_malloc)

Hi! On Sun, Mar 28, 2021 at 11:18 PM Sergei Golubchik wrote: > > Hi, Monty! > Here's a simplified patch that works (I've applied it, compiled, run > the test suite, and verified in a debugger that new() from my_new.cc is > used): One which systems did you test it? Also on older systems that

Re: [Maria-developers] dbb62d20f36: Fixes that enables my_new.cc (new wrapper using my_malloc)

Hi! On Sun, Mar 28, 2021 at 3:00 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 28, Michael Widenius wrote: > > revision-id: dbb62d20f36 (mariadb-10.5.2-518-gdbb62d20f36) > > parent(s): 0c37211c2a2 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 0c37211c2a2: Fixed my_addr_resolve

Hi! On Sun, Mar 28, 2021 at 2:54 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Mar 28, Michael Widenius wrote: > > revision-id: 0c37211c2a2 (mariadb-10.5.2-517-g0c37211c2a2) > > parent(s): 555c4470130 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 12d5c4f2813: Fixed problems with S3 after "DROP TABLE FORCE" changes

Hi! On Sun, Oct 18, 2020 at 3:38 PM Sergei Golubchik wrote: > > Hi, Monty! > > Fixed problems with S3 after "DROP TABLE FORCE" changes > > > > MDEV-23691 S3 storage engine: delayed slave can drop the table > > please put the MDEV on the first line of the commit comment I prefer to have the

Re: [Maria-developers] 21eb8969ce9: Improved storage size for Item, Field and some other classes

Hi! On Fri, Sep 11, 2020 at 1:10 PM Sergei Golubchik wrote: > > Hi, Monty! > > Looks ok, but again it doesn't seem you've squashed intermediate commits > as you said you did. I have squashed everything that makes sense. I did leave commits that shows me trying with bit fields and then moving to

Re: [Maria-developers] 2564334b4c1: Backported setting of transcation.on=1 in THD::reset_for_reuse()

Hi! On Fri, Sep 18, 2020 at 1:54 PM Sergei Golubchik wrote: > > Hi, Michael! > > > diff --git a/sql/sql_class.cc b/sql/sql_class.cc > > index 7327f270c33..8f6356b15c7 100644 > > --- a/sql/sql_class.cc > > +++ b/sql/sql_class.cc > > @@ -1640,6 +1640,7 @@ void THD::reset_for_reuse() > >

Re: [Maria-developers] fc07306120f: MDEV-23586 Mariabackup: GTID saved for replication in 10.4.14 is wrong

Hi! On Fri, Sep 25, 2020 at 12:11 PM Sergei Golubchik wrote: > > Hi, Monty! > > Just a couple of minor comments > > Note, the below is from the combined diff of this commit and your > earlier MDEV-21953 commit, so you can see some lines here that are not > part of the fc07306120f. > > > diff

Re: [Maria-developers] On bb-10.6-monty work

Hi! On Fri, Sep 11, 2020 at 8:11 AM Nikita Malyavin wrote: > > -static void _ma_check_print(HA_CHECK *param, const char* msg_type, > > +static void _ma_check_print(HA_CHECK *param, const LEX_CSTRING *msg_type, > > const char *msgbuf) > > I would also suggest

Re: [Maria-developers] On bb-10.6-monty work

Hi! Sorry for the delay, have been very busy with working on bug fixes and internal discussions. On Fri, Sep 11, 2020 at 7:50 AM Nikita Malyavin wrote: > > Hello, Monty! > > I've been asked to review your recent work regarding memory footprint > optimizations. > > --- a/sql/item.h > > +++

Re: [Maria-developers] 099596296ce: Avoid mallocs when using LONGLONG_BUFFER_SIZE

Hi! On Fri, Sep 11, 2020 at 1:29 PM Sergei Golubchik wrote: > > Hi, Michael! > > This is a good catch! > > But note that LONGLONG_BUFFER_SIZE already reserves +1 for '\0', it's > defined as > > /* Max length needed for a buffer to hold a longlong or ulonglong + end \0 */ > #define

Re: [Maria-developers] c48b190824a: Fixed error messages from DROP VIEW to align with DROP TABLE

Hi! On Sat, Jun 13, 2020 at 5:37 PM Sergei Golubchik wrote: > > DROP VIEW IF EXISTS t1; > > Warnings: > > +Warning 1347'test.t1' is not of type 'VIEW' > > please, add a test for the case when a user has no privileges on > test.t1, the object existence is not leaked out (if one has

Re: [Maria-developers] 250bc3b6d74: Ensure that table is truly dropped when using DROP TABLE

> Hi, Michael! Please use Monty. No reason to be formal! > > Ensure that table is truly dropped when using DROP TABLE > > > > MDEV-11412 AliSQL: [Feature] Issue#34 Support force drop table > > please, put this line ^^^ first in the comment comment. Already done, as we discussed > > The used

Re: [Maria-developers] b22a28c2295: fixup! 3fe5cd5e1785e3e8de7add9977a1c2ddd403538b

Hi! On Fri, May 22, 2020 at 3:27 PM Andrei Elkin wrote: CORNER CASES: read-only, pure myisam, binlog-*, @@skip_log_bin, etc > > Aria just makes yet another previously unknown use case of an engine > that produces THD::ha_info but does not support 2pc, which the assert > implied. > > To

Re: [Maria-developers] acbe14b122c: Aria will now register it's transactions

Hi! On Wed, May 20, 2020 at 10:52 AM Sergei Golubchik wrote: > > Hi, Michael! > > +class start_new_trans > > +{ > > + /* container for handler's private per-connection data */ > > + Ha_data old_ha_data[MAX_HA]; > > + struct THD::st_transactions *old_transaction, new_transaction; > > +

Re: [Maria-developers] b22a28c2295: fixup! 3fe5cd5e1785e3e8de7add9977a1c2ddd403538b

Hi! On Wed, May 20, 2020 at 8:14 PM Sergei Golubchik wrote: > > MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in > >MYSQL_BIN_LOG::unlog_xa_prepare > > > > diff --git a/sql/log.cc b/sql/log.cc > > index 7e9e231358a..792c6bb1a99 100644 > > --- a/sql/log.cc > > +++

Re: [Maria-developers] 20d54b09830: Update galera to work with independent sub transactions

Hi! On Wed, May 20, 2020 at 8:32 PM Sergei Golubchik wrote: > > Hi, Michael! > > I see, you basically disable wsrep for these out-of-band transactions. > I'm sure it works fine now, with Aria. > But will it work with InnoDB? > On May 20, Michael Widenius wrote: > &g

Re: [Maria-developers] 8742d176bc2: Added support for more functions when using partitioned S3 tables

Hi! On Fri, Apr 17, 2020 at 3:49 PM Sergei Golubchik wrote: > > +++ b/mysql-test/suite/s3/replication_partition.test > > @@ -0,0 +1,170 @@ > > +--source include/have_s3.inc > > +--source include/have_partition.inc > > +--source include/master-slave.inc > > master-slave should always be

Re: [Maria-developers] 9243921c84b: Make all #sql temporary table names uniform

Hi! On Fri, 17 Apr 2020, 15:52 Marko Mäkelä, wrote: > Monty, > > On Thu, Apr 16, 2020 at 3:32 PM Michael Widenius > wrote: > > > > ALTER PARTITION shadow files: > > > > #sql-shadow-'original_table_name' > > > > > > Please, add a

Re: [Maria-developers] faf8de3aa98: Fixed some assert crashes related to keyread.

Hi! On Fri, 17 Apr 2020, 15:21 Sergei Golubchik, wrote: > Hi, Michael! > > On Apr 16, Michael Widenius wrote: > > Hi! > > > > On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik > wrote: > > > > > > > where's a test case for MDEV-22077

Re: [Maria-developers] faf8de3aa98: Fixed some assert crashes related to keyread.

Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > where's a test case for MDEV-22077? One can't use the test case in MDEV-22077 as it involves a table created by a 32 bit MariaDB version. Doing another test case it's very hard so I ignored it and just did run the test to verify

Re: [Maria-developers] fb29c886701: Handle errors from external_unlock & mysql_unlock_tables

Hi! > > > > Handle errors from external_unlock & mysql_unlock_tables > > > > Other things: > > - Handler errors from ha_maria::implict_commit > > - Disable DBUG in safe_mutex_lock to get trace file easier to read > > > > diff --git a/mysys/thr_mutex.c b/mysys/thr_mutex.c > > index

Re: [Maria-developers] bc5c062b1d1: Don't try to open temporary tables if there are no temporary tables

Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: bc5c062b1d1 (mariadb-10.5.2-124-gbc5c062b1d1) > > parent(s): fb29c886701 > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] bf32018be96: Added support for VISIBLE attribute for indexes in CREATE TABLE

Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: bf32018be96 (mariadb-10.5.2-126-gbf32018be96) > > parent(s): 62c2d0f3e1f > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 9243921c84b: Make all #sql temporary table names uniform

Hi! > > ALTER PARTITION shadow files: > > #sql-shadow-'original_table_name' > > Please, add a thread_id here at the end. normally MDL should ensure that > no two threads can have a shadow for the same table at the same time, > but we have enough bugs as it is to introduce another vector when

Re: [Maria-developers] 3cbe15bd78c: Fixed core dump in alter table if ADD PARTITION fails

Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: 3cbe15bd78c (mariadb-10.5.2-120-g3cbe15bd78c) > > parent(s): d4d332d196d > > author: Michael Widenius > > committer: Michael

Re: [Maria-developers] 5365db70cb8: Improve update handler (long unique keys on blobs)

Hi! > I mean, you have tests, both with PERIOD, but one in the main suite, the > other in the versioning suite. While they both should be in the period > suite. Here, your test from the main/long_unique.test: > +CREATE OR REPLACE TABLE t1 (a INT, b BLOB, s DATE, e DATE, PERIOD FOR > app(s,e),

Re: [Maria-developers] 5365db70cb8: Improve update handler (long unique keys on blobs)

Hi! > > Improve update handler (long unique keys on blobs) > > you may want to remove this line from the commit comment Fixed > > > > diff --git a/mysql-test/main/long_unique.result > > b/mysql-test/main/long_unique.result > > index a4955b3e7b5..fee8e7721bf 100644 > > ---

Re: [Maria-developers] 256753e8ae8: Clean up and speed up interfaces for binary row logging

Hi! On Fri, Feb 28, 2020 at 10:00 PM Sergei Golubchik wrote: ... > > diff --git a/mysql-test/suite/rpl/r/create_or_replace_mix.result > > b/mysql-test/suite/rpl/r/create_or_replace_mix.result > > index 661278aa7ef..6c83d27eef9 100644 > > --- a/mysql-test/suite/rpl/r/create_or_replace_mix.result

Re: [Maria-developers] 5ae74b4823a: mysqld --help will now load mysqld.options table

Hi! On Fri, Feb 28, 2020 at 4:37 PM Sergei Golubchik wrote: > > Hi, Michael! > > --- a/sql/mysqld.cc > > +++ b/sql/mysqld.cc > > @@ -8511,8 +8511,8 @@ static void option_error_reporter(enum loglevel > > level, const char *format, ...) > >va_start(args, format); > > > >/* Don't print

[Maria-developers] Review 2 of compressed columns

Hi! Here is a review for the patches marked with fixup! MDEV-11371 - column compression > commit f1a3cd40ecc4c144ac32d43ab5c1e88c8e4fae7e > Author: Sergey Vojtovich > Date: Mon Jul 31 16:07:39 2017 +0400 > > fixup! MDEV-11371 - column compression > > In worst case we

Re: [Maria-developers] Refactoring in LEX_STRING and LEX_CSTRING

Hi! On 20 Apr 2017 06:10, "Alexander Barkov" wrote: Hello all, Monty is now doing refactoring: 1. Replacing a lot of LEX_STRING to LEX_CSTRING. 2. Fixing functions and methods that have arguments of types: a. pointer "const LEX_STRING *name" and b. reference "const

[Maria-developers] CREATE SEQUENCE is coming

Hi! For those that are trying to port applications to MariaDB from other databases or need more features than the current AUTO_INCREMENT provides, the following may be of interest: First version of sequence is pushed to bb-10.2-sequence. It should be merged to bb-10.2-compatilbity and then to

Re: [Maria-developers] [s...@mariadb.org: [Commits] 02d155a: MDEV-11418 - AliSQL: [Feature] Issue#1 KILL IDLE TRANSACTIONS]

Hi! On Tue, Feb 21, 2017 at 2:37 PM, Sergey Vojtovich wrote: > Hi Monty, > > Please review this patch. > > Thanks, > Sergey > > - Forwarded message from Sergey Vojtovich - > > Date: Tue, 21 Feb 2017 16:29:36 +0400 > From: Sergey Vojtovich

Re: [Maria-developers] Server crashes in inline_mysql_mutex_lock

Hi! > Thread 1 (Thread 0x7fa0f7549700 (LWP 21346)): > #0 0x7fa0f9511101 in __pthread_kill (threadid=, > signo=11) at ../nptl/sysdeps/unix/sysv/linux/pthread_kill.c:61 > #1 0x013f4d28 in my_write_core (sig=11) at > /data/src/bb-10.0-monty/mysys/stacktrace.c:478 > #2

Re: [Maria-developers] Creating test cases for Spider

Hi! > I will today update the 10.2 spider tree with the latest 10.2 tree > that includes all gcov patches and then try this myself. I have now merged 10.2-spider tree with the latest 10.2 tree, which includes the new HASH and better support for gcov. I am now reviewing the last part of

[Maria-developers] Temporary push of multi_range_read support to 10.2

Hi! Kentoku, I have now pushed into 10.2 the code for spider patches: 014,015,023,033,035,037,040,042,044,045,049,050,051,053,059 The push is done to make it easier for Jacob and you to make test cases for the new code. I will work on reviewing and cleaning up this patch during the next few

Re: [Maria-developers] Working on spider patches, MDEV-7701

Hi! >> However, I would like to have a clear comment the purpose of the function >> set_top_table_and_fields(). > > This function is used to get correlating of a parent (table/column) > and children (table/column). When conditions are pushed down to child > table (like child of myisammarge),

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Thu, Nov 24, 2016 at 8:21 PM, kentoku wrote: > Hi! > >> In which case is it lost ? >> Can you add a test to federated_partition.test that shows in which case the >> connection information is lost? > > when create a table like the following > > create table tbl_a( >

[Maria-developers] Working on spider patches, MDEV-7701

Hi! Next patch, MDEV 7701 +++ ./003_mariadb-10.2.0-vp/sql/ha_partition.cc2016-05-05 21:25:04.289731712 +0900 @@ -7238,13 +7239,30 @@ int ha_partition::extra(enum ha_extra_fu } /* Category 9) Operations only used by MERGE */ case HA_EXTRA_ADD_CHILDREN_LIST: +

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Thu, Nov 24, 2016 at 5:18 PM, Michael Widenius <michael.widen...@gmail.com> wrote: > Hi! > > On Wed, Nov 23, 2016 at 3:38 PM, kentoku <kentokush...@gmail.com> wrote: >> Hi Monty! >> >> Thank you for starting this task. I appreciate it. >> >&g

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote: > Hi Monty! > > Thank you for starting this task. I appreciate it. > >> Kentoku, do you have patches for the test files, or should I just take >> them from the above spider branch or from somewhere else ? > > I just

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! On Wed, Nov 23, 2016 at 4:31 PM, kentoku wrote: > Hi Monty! > > Please see comment at 2016-05-07 19:15 for patches for MariaDB 10.2. > >> I don't think this it will work removing the usage of p_elem->connect_string >> >> This is because each partition may have a

Re: [Maria-developers] Working on spider patches, MDEV-7698

Hi! Now working on MDEV-7700 Spiral patch 002_mariadb-10.0.15.spider.diff +++ ./002_mariadb-10.1.8-spider/sql/ha_partition.cc2015-10-14 01:48:53.392665313 +0900 @@ -327,7 +327,9 @@ void ha_partition::init_handler_variable m_file_buffer= NULL; m_name_buffer_ptr= NULL; m_engine_array=

[Maria-developers] Working on spider patches, MDEV-7698

Hi! I have now started to work on the spider patches for MariaDB 10.2, MDEV-7698. I have moved all code from maria-10.1-spider to a new branch maria-10.2-spider and added some more patches. I have closed all related MDEV's in MDEV-7698 that is now included in 10.2-spider. While doing this, I

Re: [Maria-developers] REVIEW: Fwd: [Commits] 8cd4778: MDEV-9114: Bulk operations (Array binding)

Hi! On Sun, Oct 9, 2016 at 1:45 AM, Andrea <mon...@askmonty.org> wrote: > > > > --- Forwarded message --- > From: Oleksandr Byelkin <sa...@montyprogram.com> > Date: 8 October 2016 1:01:58 p.m. > Subject: REVIEW: Fwd: [Commits] 8cd4778: MDEV-9114: Bulk operation

Re: [Maria-developers] [Commits] 49b2502: Fix assertion/hang in read_init_file()

Hi! > Thanks for the patch and for finding the bug! > > However, Serg already removed the thread count handling from > do_handle_bootstrap. > I will today check if the problem still exists and if yes, fix it by > always sending the broadcast. (A quick look suggest it still exist). Just noticed

Re: [Maria-developers] [Commits] 49b2502: Fix assertion/hang in read_init_file()

Hi! On Fri, Sep 9, 2016 at 7:31 PM, Kristian Nielsen wrote: > Monty, > > My latest push uncovered a problem in the 10.2 tree; however the problem was > there before, just not triggered by the testsuite. I pushed the below patch > to fix the test failures in Buildbot,

Re: [Maria-developers] Problem with parallel replication in 10.2

Hi! >> Is it possible for you to create a clean patch for async deadlock for >> bb-10.2-jan >> that Jan and I can review and apply? > > Yes, I'll prepare a patch for review. It's probably easier if I apply it > myself, as I want to do a minimal patch in 10.1 to get optimistic parallel >

Re: [Maria-developers] Problem with parallel replication in 10.2

Hi! > 2016-09-01 10:33:20 140078976283392 [ERROR] Slave SQL: Error during XID > COMMIT: failed to update GTID state in mysql.gtid_slave_pos: 1062: Duplicate > entry '0-53' for key 'PRIMARY', Gtid 0-1-52, Internal MariaDB error code: 1942 > > This happens because the mysql.gtid_slave_pos table

[Maria-developers] Problem with parallel replication in 10.2

Hi! I was trying to run a test that fails in the upcoming bb-10.2-jan on the normal 10.2 tree, when I noticed this strange issue: - Test fails with timeout when running with --debug - When looking at the trace file, I notice that we get a duplicate key error for the table gtid_slave_post (MyISAM

Re: [Maria-developers] Patch for parallel replication DBUG_ASSERT check on DROP TABLE et al

Hi! On Thu, Aug 18, 2016 at 11:03 PM, Kristian Nielsen <kniel...@knielsen-hq.org> wrote: > Michael Widenius <michael.widen...@gmail.com> writes: > >> Do you happen to know of any failures caused by the patch? > > As I mentioned on IRC, the assertion triggers duri

Re: [Maria-developers] Patch for parallel replication DBUG_ASSERT check on DROP TABLE et al

Hi! On Thu, Aug 18, 2016 at 12:24 PM, Kristian Nielsen wrote: > Monty, > > Apparently you pushed this patch into 10.0, even though I explained that it > is incorrect, and why. That's not cool, and you can even see it failing in > Buildbot now. I pushed the patch as I

Re: [Maria-developers] Joinable threads

Hi! On 5 May 2016 17:42, "Sergey Vojtovich" wrote: > > Hi Monty, > > Thanks for you reply. Please allow me to disagree with some points. :) > > Attached please find 2 patches, both fix this memory leak. One approach is > for detached threads, another one is for joinable

Re: [Maria-developers] Joinable threads

Hi! On Wed, May 4, 2016 at 11:13 AM, Sergey Vojtovich wrote: > Hi Monty, > > I vaguely recall you told me once that you like detached threads more than > joinable, specifically for service threads. Could you remind me what were > the reasons behind it? > > I need this to fix

Re: [Maria-developers] Deadlock with STOP SLAVE and LOCK_active_mi

Hi! On Mon, Apr 25, 2016 at 1:18 PM, Kristian Nielsen <kniel...@knielsen-hq.org> wrote: > Michael Widenius <michael.widen...@gmail.com> writes: > >>> 2. To protect access to master_info_index, eg. to prevent a Master_info from >>> disappearing while it i

Re: [Maria-developers] Deadlock with STOP SLAVE and LOCK_active_mi

Hi! >>> Any suggestions for how this is supposed to work? Or is it just broken >>> by design, but saved because normally slave threads do not need to >>> access SHOW STATUS or system variables? > Hm. So I went through all of the code that references LOCK_active_mi to try > and understand this.

Re: [Maria-developers] A proposal to deprecate syntax: SELECT a'test'

Hi! On 25 Feb 2016 19:16, "Alexander Barkov" wrote: >> As ' and " are identical in MySQL mode, I don't see how you can fix >> this without causing even more confusion. I want to emphasise the above, as you haven't really understood the implications of this. This, in addition

Re: [Maria-developers] A proposal to deprecate syntax: SELECT a'test'

Hi! > Hello Monty, all, > > > We discussed this with Sergei and both think that it will be a good idea > to deprecate this syntax: > > SELECT a'test'; > > where 'a' is an identifier and 'test' its alias. Is this dependent on if there is a space or not between a and 'test' ? Note that in MySQL

Re: [Maria-developers] Likely a dead optimizer related code

Hi! Hi Igor, I noticed that during Item_cond::fix_fields() and Item_func_between::fix_fields() update these optimizer related SELECT_LEX members: thd-lex-current_select-cond_count and thd-lex-current_select-between_count The purpose of these members is to allocate optimizer related

Re: [Maria-developers] Probably in a bug in simple_pred()

Hi! From: Alexander Barkov b...@mariadb.org Hi Sergey, I probably found a bug in simple_pred() in opt_sum.cc. In this piece of code: case 3: /* field BETWEEN const AND const */ item= func_item-arguments()[0]-real_item(); if (item-type() == Item::FIELD_ITEM) {

Re: [Maria-developers] MDEV-4119 patch comments

Hi! On Mon, Jul 6, 2015 at 7:37 PM, Sergey Petrunia ser...@mariadb.com wrote: Hi Monty, Please find my comments on the patch for MDEV-4119 below. Sorry for the delay. No problem, thanks for looking into this. + @param split_flagsZero or more of the following flags +

[Maria-developers] Enabling feedback pluging for MariaDB 10.1.4

? Regards, Michael Widenius Creator of MySQL and MariaDB ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https

Re: [Maria-developers] Group commit id in mysqlbinlog output

Hi! Kristian == Kristian Nielsen kniel...@knielsen-hq.org writes: cut Kristian I am not very familiar with timestamps in binlog events. However, all the Kristian transactions in the group commit are written out one after the other, in a Kristian single thread holding the lock on the binlog.

Re: [Maria-developers] first results from replication benchmarks

Hi! Axel == Axel Schwenke a...@askmonty.org writes: Axel Hi everybody, Axel here are some first results from my benchmarks of replication / group commit Axel performance. Axel The benchmark is sysbench OLTP rw, data set fitting in memory. I tested a Axel total of 27 configurations, 9 each

[Maria-developers] MariaDB MySQL community event 3rd of April 2014 in Santa Clara

Hi! I am happy to announce that the MariaDB Foundation is organising a MariaDB MySQL community event in Santa Clara on Thursday the 3rd of April. The venue is the Hilton Santa Clara hotel, a short walk from the Percona Live 2014 event. You can find more information on my blog at:

Re: [Maria-developers] slave_ddl_exec_mode and incompatible change in MariaDB 10.0.8

Hi! Pavel == Pavel Ivanov piva...@google.com writes: Pavel On Wed, Feb 26, 2014 at 8:12 PM, Michael Widenius mo...@askmonty.org wrote: Pavel And then it said that slave died with the stack trace Pavel sql/transaction.cc:139(trans_begin(THD*, unsigned int))[0x788e20] Pavel sql/log_event.cc

Re: [Maria-developers] slave_ddl_exec_mode and incompatible change in MariaDB 10.0.8

Hi! First, very sorry that I was not able to answer this question until now. I have been traveling in Asia for 2 weeks with very limited time for internet + email. Now I am however back and hope to answer all possible questions you have on this topic. Pavel == Pavel Ivanov piva...@google.com

Re: [Maria-developers] slave_ddl_exec_mode and incompatible change in MariaDB 10.0.8

Hi! Pavel == Pavel Ivanov piva...@google.com writes: Pavel And now I found that this change is actually buggy. It turns out that Pavel when slave executes a standalone CREATE TABLE event now it will set Pavel OPTION_BEGIN flag in thd-variables.option_bits and won't reset it. I Pavel don't know

  1   2   3   4   >