[Maria-developers] Correct parsing of BINLOG 'XXX' with comment inside

2018-09-10 Thread Sachin Setia
Hi Bar, Currently if we have generated the sql file using mysqlbinlog -v and if we have big statement binlog , then mysqlbinlog add comment in between of Binlog 'XXX' statement , but unfortunately base64_decode does not understands it, and it through error since # is not a base64 char This

Re: [Maria-developers] 67260fd: MDEV-15130 Assertion `table->s->null_bytes == 0' failed in ...

2018-04-20 Thread Sachin Setia
Hi Serg! Thanks for the review. On Fri, Apr 20, 2018 at 6:36 PM, Sergei Golubchik wrote: > Hi, Sachin! > > On Apr 19, sachin wrote: > >> diff --git a/storage/perfschema/ha_perfschema.cc >> b/storage/perfschema/ha_perfschema.cc >> index e8e9581..d5846f2 100644 >> ---

Re: [Maria-developers] Project Progress Report [Week 3]

2017-06-20 Thread Sachin Setia
Hi ankit! What is your github name/account link? Regards Sachin On Jun 20, 2017 12:30 AM, "ANKIT KUMAR" wrote: > Hi, > In this week, we worked on in-memory structures:- Which representation > to choose(prefix or expression tree), How to store values and how >

Re: [Maria-developers] Race Condition in Seconds behind master.

2017-05-02 Thread Sachin Setia
Hi Kristian, Thanks I will look into it. Regards sachin On Tue, May 2, 2017 at 6:47 PM, Kristian Nielsen wrote: > Sachin Setiya writes: > >> Then I executed Show slave status (couple of times in a second), and >> found Seconds_behind_master

[Maria-developers] Why We can set binlog_format=mixed for session ?

2017-03-23 Thread Sachin Setia
Hi Monty! When flashback is on why we can set binlog_format = Mixed/ statement for session scope, What is use of this and why this is allowed ? Regards sachin ___ Mailing list: https://launchpad.net/~maria-developers Post to :

[Maria-developers] Unique Blob Index for lower transaction isolation levels

2016-09-22 Thread Sachin Setia
Hi Sergei, Actually I was thinking a different way of implementing this. in function ha_write_row , after it calls storage engine write, we can check for inserted values and see if it is inserted more than once. Of course, it can be I/O intensive (or it may not be , because data should be in

[Maria-developers] MariaDB update deficiency

2016-09-14 Thread Sachin Setia
Hello Everyone! This thread is about solving this issue https://jira.mariadb.org/browse/MDEV-10220. I made a google doc https://docs.google.com/document/d/1sor3nVGz2v9Jm4-MDDFfMSn7d7xOip7Qio_T0AqFaNI/edit?usp=sharing In which I am explaining my idea , which i think should solve this problem.

Re: [Maria-developers] Sachin weekly report

2016-08-28 Thread Sachin Setia
Hi Sergei! Actually I changed code as I was suggesting you in previous email. Duplicate scanning , update etc all works fine using this new approach. Currently I am working on optimizer part using this new approach although the normal where works but now I am working on cases involving join and

Re: [Maria-developers] Sachin weekly report

2016-08-26 Thread Sachin Setia
Hi Vicențiu Thanks Vicențiu for your comment. Although I agree with you but defining #define HA_HASH_STR_LEN 4 or const int HA_HASH_STR_LEN = 4; make it independent of length of "hash". Although we rarely gone change "hash", so I think it is a good idea. What do you think ,

Re: [Maria-developers] Sachin weekly report

2016-08-23 Thread Sachin Setia
Hi Sergei! On Tue, Aug 23, 2016 at 4:35 PM, Sergei Golubchik <s...@mariadb.org> wrote: > > Hi, Sachin! > > On Aug 22, Sachin Setia wrote: > > Hi Sergei! > > > > Actually I completed the work on update and delete. Now they will use > > index for looking up

Re: [Maria-developers] Sachin weekly report

2016-08-22 Thread Sachin Setia
Regards sachin On Sat, Aug 20, 2016 at 11:16 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Aug 19, Sachin Setia wrote: > > On Fri, Aug 19, 2016 at 2:42 PM, Sergei Golubchik <s...@mariadb.org> > wrote: > > > > > First. I believe you'll n

Re: [Maria-developers] Sachin weekly report

2016-08-18 Thread Sachin Setia
Hello Sergei! I am stuck at one problem consider table t1(a blob , b blob , unique(a,b)); although select * from t1 where a= 12 and b= 23 works but consider the case like select * from t1 where ( a= 12 or a=45 ) and (b= 23 or b=45 ) does not works and also update and delete using long index does

Re: [Maria-developers] Sachin weekly report

2016-08-01 Thread Sachin Setia
Hello Sergei! Sir I am stuck at one problem. Consider the case create table t1 (abc blob unique, xyz int unique); /* Insert data */ update t1 set abc = 33 where xyz =23; This is not working because xyz = 23 will require index scan and at the time of ha_update_row the inited != NONE and if inited

Re: [Maria-developers] Sachin weekly report

2016-07-26 Thread Sachin Setia
/unique_index_where The only problem i have is explain query fails , trying to solve it let you know if something happens. Regards sachin On Mon, Jul 25, 2016 at 1:34 AM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Actually i find that my_strnncoll wil work :) > Regards > sachin >

Re: [Maria-developers] Sachin weekly report

2016-07-24 Thread Sachin Setia
Actually i find that my_strnncoll wil work :) Regards sachin On Mon, Jul 25, 2016 at 1:17 AM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hello Sergei, > I am getting one problem related to my_strcasecmp() function currently > this function does not allow > string comp

Re: [Maria-developers] Sachin weekly report

2016-07-24 Thread Sachin Setia
Hello Sergei, I am getting one problem related to my_strcasecmp() function currently this function does not allow string comparison upto length l, is there any functon which can do comparison upto length l, or should i write mine. Regards sachin On Fri, Jul 22, 2016 at 9:56 PM, Sachin Setia

Re: [Maria-developers] Sachin weekly report

2016-07-22 Thread Sachin Setia
generation different hash for same data how i solve this problem. Regards sachin On Tue, Jul 19, 2016 at 5:52 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Just give me 3 days after you can review. yes I already merged with 10.2.1 > days ago. > regards > Sachin > &g

Re: [Maria-developers] Sachin weekly report

2016-07-19 Thread Sachin Setia
Just give me 3 days after you can review. yes I already merged with 10.2.1 days ago. regards Sachin On Jul 19, 2016 17:28, "Sergei Golubchik" <s...@mariadb.org> wrote: > Hi, Sachin! > > On Jul 19, Sachin Setia wrote: > > Weekly Report for 8 week of gsoc

Re: [Maria-developers] Sachin weekly report

2016-07-19 Thread Sachin Setia
15, 2016 at 5:29 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > okay sir, i will just store the is_hash flag and on > init_from_binary_frm_image > add flag to key. thanks > Regards > sachin > > On Fri, Jul 15, 2016 at 3:58 PM, Sergei Golubchik <s...@mariad

Re: [Maria-developers] Sachin weekly report

2016-07-15 Thread Sachin Setia
okay sir, i will just store the is_hash flag and on init_from_binary_frm_image add flag to key. thanks Regards sachin On Fri, Jul 15, 2016 at 3:58 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Jul 14, Sachin Setia wrote: >> Hello Sergei >>

Re: [Maria-developers] Sachin weekly report

2016-07-14 Thread Sachin Setia
both ,but as you pointed out in review that it is better to have it in key only but my question is that , whether is this approach is right ? Regards sachin On Tue, Jul 12, 2016 at 2:43 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hello everyone, > > Weekly Report for 7

Re: [Maria-developers] Sachin weekly report

2016-07-12 Thread Sachin Setia
Hello everyone, Weekly Report for 7th week of gsoc 1Now we can alter blob columns query like create table t1(abc blob unique); alter table t1 change column abc a blob; Even we can some multiple changes in one alter create table t1(abc blob unique, xyz blob unique); alter table

Re: [Maria-developers] Sachin weekly report

2016-07-04 Thread Sachin Setia
Hello everyone, Weekly Report for 6th week of gsoc 1.hidden fields fully supported , they also show in extra column 2.suppose if we declare key as unique(abc,df) then instead of key name to be abc it will be abc_df 3.prototype and prototype for how to store information about hash and type of hash

Re: [Maria-developers] HASH and unique constraint for blobs

2016-06-30 Thread Sachin Setia
are already used ,or should i go for another approach. Sir please review the code. Regards sachin On Mon, Jun 6, 2016 at 5:00 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Jun 06, Sachin Setia wrote: >> Hello Sir >> Weekly Report for second wee

Re: [Maria-developers] Sachin weekly report

2016-06-26 Thread Sachin Setia
, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hi Sergei, > > Weekly Report for 4th week of gsoc > > 1. Field property is_row_hash , field_visibility successfully saved and > retrived from frm , using extra2 space > 2. Some tests added. > 3. Solved the error when there

Re: [Maria-developers] Sachin weekly report

2016-06-20 Thread Sachin Setia
if i can add custom field when it says an error. So will not have to use iterator as suggested by you sir. 4 rename the hash field automatically in the case clash. This week On Thu, Jun 16, 2016 at 11:46 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Jun 15, Sac

Re: [Maria-developers] MATCH returns -1

2016-06-08 Thread Sachin Setia
Hello Sergei How can we solve this bug? Regards sachin On Wed, Jun 8, 2016 at 1:28 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Jun 08, Alexander Barkov wrote: > > > > This script: > > > > DROP TABLE IF EXISTS t1; > > CREATE TABLE t1 (a VARCHAR(30), b DOUBLE); > >

Re: [Maria-developers] InnoDB blob for primary key

2016-06-06 Thread Sachin Setia
yes sir https://github.com/SachinSetiya/server regards sachin On Mon, Jun 6, 2016 at 12:39 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > yes sir > https://github.com/SachinSetiya/server > regards > sachin > > On Mon, Jun 6, 2016 at 12:31 PM, Oleksandr Byelkin

Re: [Maria-developers] InnoDB blob for primary key

2016-06-05 Thread Sachin Setia
Hello Sir Weekly Report for second week of gsoc 1. Implemented unique in the case of null 2. Implemented unique(A,b,c) Currently working on tests , field hiding Regards sachin On Tue, May 31, 2016 at 10:49 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On

[Maria-developers] Why Max Length of virtual column string is so small

2016-06-05 Thread Sachin Setia
Hello Everyone, Actually I was thinking why there is so small limit on virtual column string.Does it have any design implication or some other reason Regards sachin ___ Mailing list: https://launchpad.net/~maria-developers Post to :

Re: [Maria-developers] InnoDB blob for primary key

2016-05-19 Thread Sachin Setia
B [a]> I pushed the change in github.Only one thing is remaining is getting the value when hash collides and compare them Regards sachin On Mon, May 16, 2016 at 8:32 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hello Sergei! > Sir please review the prototype at > https

Re: [Maria-developers] InnoDB blob for primary key

2016-05-16 Thread Sachin Setia
Hello Sergei! Sir please review the prototype at https://github.com/SachinSetiya/server/tree/unique_index_sachin this is half code I guess it will be complete by tomorrow Regards sachin On Mon, May 2, 2016 at 8:42 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On

Re: [Maria-developers] InnoDB blob for primary key

2016-05-02 Thread Sachin Setia
y 2, 2016 at 11:43 AM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On May 02, Sachin Setia wrote: > > I am sorry sir Currently my exam are going on > > But i am working on prototype of second project. Will be done by tommorow > > Regards > >

Re: [Maria-developers] InnoDB blob for primary key

2016-04-23 Thread Sachin Setia
Hello Sergei! Actually I am confused about first project. Should I do it for myisam or do i need to do it on upper level (change in sql/ directory) Regards sachin On Sat, Apr 23, 2016 at 2:25 PM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Apr 23, Sac

Re: [Maria-developers] InnoDB blob for primary key

2016-04-18 Thread Sachin Setia
or if they do not give any value we will automatically create and store hash. What do you think? sir. Regards sachin On Sat, Apr 16, 2016 at 7:37 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hi Sergei! > As I already told you i was building prototype.It is some what completed

Re: [Maria-developers] InnoDB blob for primary key

2016-04-16 Thread Sachin Setia
cause problem? what do you think? Regards sachin On Fri, Apr 15, 2016 at 6:37 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hi Sergei! > > Actually I was going through the mysql source code for unique long constraints > in file sql_tmp_table.cc in function create_tmp_tab

Re: [Maria-developers] InnoDB blob for primary key

2016-04-13 Thread Sachin Setia
Hello Sergei Sorry I did not see your mail. Actually i was thinking something like this before implementing the prototype but if i am more closer to innodb the more performance i will i get. I will definitively think about it. Regards sachin On Wed, Apr 13, 2016 at 9:17 PM, Sachin Setia

Re: [Maria-developers] InnoDB blob for primary key

2016-04-13 Thread Sachin Setia
oint of view there is issue if you add a new system generated > column to the row. Firstly, existing tables will not have that column and > secondly it will effect e.g maximum row size and external tools like backup. > > R: Jan > > On Mon, Apr 11, 2016 at 12:33 PM, Sachin Set

[Maria-developers] Fwd: Gsoc 2016 Mdev 371 Unique index for blob

2016-03-29 Thread Sachin Setia
Hi Sergei Did you see the patch.Actually the patch works for every combination of blob and varchars table definition. Can you please tell what extra modification I should make Regards sachin On Mon, Mar 28, 2016 at 9:34 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > >

Re: [Maria-developers] Unique Index for blob

2016-03-28 Thread Sachin Setia
Sorry wrong extension Regards sachin On Mon, Mar 28, 2016 at 9:09 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hello Devlopers > Hi this is sachin. I applied for gsoc 2016(applied by name sachin setiya) > My topic was unique index for blob(MyISAM) > But i already c

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-28 Thread Sachin Setia
ject. > > It would help us choose, if you'd put your prototype code on github and > put the link to the repository into your final proposal. > > Thanks! > > On Mar 15, Sachin Setia wrote: > > Dear Developers, > > > > I was doing prototype for this project a

[Maria-developers] Unique Index for blob

2016-03-28 Thread Sachin Setia
Hello Devlopers Hi this is sachin. I applied for gsoc 2016(applied by name sachin setiya) My topic was unique index for blob(MyISAM) But i already completed some part of it .it is working for blobs varchar for definitions like create table tbl(abc varchar(2000) , xyz blob ,unique(abc,xyz)); I have

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-23 Thread Sachin Setia
r 23, 2016 at 12:06 AM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Mar 22, Sachin Setia wrote: > > Hello Sergei > > Actually I was prototyping for blob and varchar for aria and myisam > > storage engine. > > My prototype worked for com

Re: [Maria-developers] More memory allocation for key seg

2016-03-23 Thread Sachin Setia
Thanks Sergei , this solved the mystery. Regards sachin On Wed, Mar 23, 2016 at 12:03 AM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Mar 22, Sachin Setia wrote: > > Hello Devlopers > > I was debugging the source code of mariadb. My query was &

[Maria-developers] More memory allocation for key seg

2016-03-22 Thread Sachin Setia
Hello Devlopers I was debugging the source code of mariadb. My query was MariaDB [sachin]> create table pro2(abc int primary key,xyz int , ass int ,unique(xyz,ass))engine=myisam; In table2myisam function of file ha_myisam.cc i found that we are allocating more memory for keysegments if

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-22 Thread Sachin Setia
it simply compares values Will write a proposal shortly. On Tue, Mar 22, 2016 at 4:20 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Hello Sergi > Actually I was prototyping for blob and varchar for aria and myisam > storage engine. > My prototype worked for complex definati

Re: [Maria-developers] b1a1e5b: MDEV-6058 MySQL Bug #11766693: LOG-SLOW-ADMIN-STATEMENTS AND LOG-SLOW-SLAVE-STATEMENTS NOT DISPLAYED.

2016-03-18 Thread Sachin Setia
Dear Mr Sergei Sorry for a careless mistake I thought prototype is working but it is working only for InnoDB not for MyIsam because if we look at table creation which I send you MariaDB [sachin]> create table tbl(int_key int primary key , blob_key blob unique); Query OK, 0 rows affected (0.03

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-15 Thread Sachin Setia
Hello everyone @Shubham As I said i am just prototyping This is not the final code It is just poc to see whether if I send some unique key will mi_create work fine or not as it is working fine in create_internal_tmp_table on following query "select distinct(a2) from tbl" where schema of tbl will

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-15 Thread Sachin Setia
know Regards sachin On Wed, Mar 16, 2016 at 12:37 AM, Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Sachin! > > On Mar 15, Sachin Setia wrote: > > > > I was doing prototype for this project as Mr Sergei Golubchik suggested > > > > "This task is about

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-15 Thread Sachin Setia
Sorry one correction @-- I am assuming that unique blob will have 0 zero key @++ I am assuming that unique blob will have 0 zero key length Regards sachin On Tue, Mar 15, 2016 at 11:02 PM, Sachin Setia <sachinsetia1...@gmail.com> wrote: > Dear Developers, > > I was

[Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-15 Thread Sachin Setia
Dear Developers, I was doing prototype for this project as Mr Sergei Golubchik suggested "This task is about creating MI_UNIQUEDEF "uniques" instead of MI_KEYDEF "keys" for long unique constraints." Here is my output MariaDB [sachin]> create table tbl(int_key int primary key , blob_key blob

[Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-14 Thread Sachin Setia
Hello Developers My name is sachin , a third year undergrad student in India.I am interested in gsoc 2016 I was debugging the maria db for following query create table c4(a1 int primary key,b1 int unique,c1 blob) engine=myisam; In mysql_prepare_create_table there is a function name