Hi, Nikita,
See, e.g. handler::is_clustering_key() or handler::ha_rnd_pos_by_record()
On May 28, Nikita Malyavin wrote:
> On Wed, 24 May 2023 at 18:32, Sergei Golubchik wrote:
>
> > > +bool handler::is_root_handler() const
> > > +{
> > > + return this == tab
Hi, Nikita,
As far as I'm concerned, not having an assert there is quite fine too :)
On May 27, Nikita Malyavin wrote:
>
> I suspect I'm able to move the assertion to a more generic place, like
> is_root_handler, but I'd have to check whether a handler's hton is a
> "certainly leaf" one by compa
Hi, Otto,
On May 26, Otto Kekäläinen wrote:
>
> Kernel upgrade seems plausible root cause to Perl not getting the cpu
> data in the same way as before.
>
> Even if the root cause is in the kernel/Perl library, as immediate
> mitigation I will try to test some way to wrap the cpus array check in
Hi, Otto,
On May 25, Otto Kekäläinen wrote:
> Hi!
>
> I noticed that the autopkgtests on Debian on armhf and armel that run
> the mariadb-test-run fail on error:
>
> starting mysql-test-tun.pl...
> Logging: ./mysql-test-run.pl --force --testcase-timeout=120
> --suite-timeout=540 --retry=3 --
>
Hi, Nikita,
On May 24, Nikita Malyavin wrote:
> revision-id: 56e2cd20ed3 (mariadb-11.0.1-114-g56e2cd20ed3)
> parent(s): 47f5c7ae7e4
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-10 01:49:42 +0300
> message:
>
> MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a
Hi, Nikita,
On May 24, Nikita Malyavin wrote:
> revision-id: c75f774d278 (mariadb-11.0.1-118-gc75f774d278)
> parent(s): 319207175bd
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-15 19:43:49 +0300
> message:
>
> MDEV-31058 ER_KEY_NOT_FOUND upon concurrent CHANGE colum
Hi, Nikita,
comments below refer to a combined diff of both commits
On May 23, Nikita Malyavin wrote:
> revision-id: c457f237511 (mariadb-11.0.1-124-gc457f237511)
> parent(s): f4b04ec534d
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-15 21:07:50 +0300
> message:
>
>
Hi, Otto,
On May 18, Otto Kekäläinen wrote:
>
> Now I am working on the final fix, which might even be as simple as
> just deleting both copies of the embedded zlib in MariaDB and MariaDB
> Connector C sources, as embedding source code of external projects is
> bad practice anyway.
Right, it's a
Hi, Otto,
On May 15, Otto Kekäläinen wrote:
> Hello!
>
> While working on
> https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/46
> (Import new upstream version 10.11.3 to Debian) I noticed that
> amd64->arm64 crossbuilding no longer works.
>
> The CI shows that Salsa-CI job `
Hi, Nikita,
On May 08, Nikita Malyavin wrote:
> Sorry, the assertion should be
> DBUG_ASSERT(table->file == this || dynamic_cast(table->file)
> == NULL);
>
> Well, the tests seem passing after adding this assertion (and a similar one
> for myisam):
> https://github.com/MariaDB/server/commit/f221b
Hi, Nikita,
On May 08, Nikita Malyavin wrote:
> On Fri, 5 May 2023 at 20:46, Sergei Golubchik wrote:
>
> > > #ifdef HAVE_REPLICATION
> > > - if (unlikely(!error && table->s->online_alter_binlog))
> > > + if (unlikely(!error && table-
Hi, Nikita,
On May 05, Nikita Malyavin wrote:
> revision-id: 24c653be25a (mariadb-11.0.1-123-g24c653be25a)
> parent(s): c1cbda5a2c8
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-04 20:49:43 +0300
> message:
>
> unpack_row: unpack a correct number of fields
>
> diff
Hi, Nikita,
On May 04, Nikita Malyavin wrote:
> See my new commit b804bcbc6
You forgot to address the following:
> if (do_commit)
> {
> - // do not set STMT_END for last event to leave table open in altering
> thd
> - error= binlog_flush_pending_rows_event(thd, false, true,
Hi, Nikita,
On May 05, Nikita Malyavin wrote:
> revision-id: da5a72f32d4 (mariadb-11.0.1-114-gda5a72f32d4)
> parent(s): 0d6584c019c
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-01 01:15:41 +0300
> message:
>
> MDEV-31033 ER_KEY_NOT_FOUND upon online COPY ALTER on a
Hi, Nikita,
On May 03, Nikita Malyavin wrote:
> revision-id: c5ce597f06a (mariadb-11.0.1-115-gc5ce597f06a)
> parent(s): da5a72f32d4
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-05-01 01:15:41 +0300
> message:
>
> MDEV-31043 ER_KEY_NOT_FOUND upon concurrent ALTER and tr
Hi, Alexander,
A question: if the frm will *always* be created in the canonical,
non-ORACLE mode and always parsed in the same mode, will we even need
these schema-qualified native functions?
okay, the schema-qualified trick will help to avoid creating
REGEX_REPLACE_ORACLE and so on. But is it ne
Hi, Alexander,
On Mar 10, Alexander Barkov wrote:
> On 3/7/23 2:20 PM, Sergei Golubchik wrote:
> > I'm sorry it took a while.
> >
> > I'm still thinking about the whole thing, it's a rather big change
> > for a really fringe functionality. But I failed t
Hi, Alexander,
please add tests with fractional seconds.
remember, that in UTC the max timestamp(2) is 2038-01-19 03:14:07.99
and max timestamp(6) is 2038-01-19 03:14:07.99
On Mar 08, Alexander Barkov wrote:
> revision-id: 8c1ad2a9fe9 (mariadb-10.11.1-48-g8c1ad2a9fe9)
> parent(s): ce4a289f1c
Hi, Alexander,
I'm sorry it took a while.
I'm still thinking about the whole thing, it's a rather big change for
a really fringe functionality. But I failed to come up with something
better so far.
Code-wise the patch is mostly fine. See few small comments below, and
one slightly larger comment
Hi, Julius,
this is the combined diff of both commits:
git diff e1ce867e5ab0c^^ e1ce867e5ab0c
On Feb 10, Julius Goryavsky wrote:
> diff --git a/include/CMakeLists.txt b/include/CMakeLists.txt
> index a7b98a11050..7d87c4a42b3 100644
> --- a/include/CMakeLists.txt
> +++ b/include/CMakeLists.txt
Hi, Daniel,
On Feb 09, Daniel Black wrote:
> revision-id: ceb75e9bd9e (mariadb-10.11.1-152-gceb75e9bd9e)
> parent(s): 526fce28b90
> author: Daniel Black
> committer: Daniel Black
> timestamp: 2023-02-09 12:20:57 +1100
> message:
>
> MDEV-30203: Move mysql symlinks to different package (fixes)
>
Hi, Yuchen,
Thanks!
There are two kinds of comments below, you'll see which is which.
I realize that this patch mainly just moves parts of spider code around.
Some of my comments apply to the new code that didn't exist before and
appeared only in this patch. It's what needs to be fixed (or discu
Hi, Alexander,
On Jan 15, Alexander Barkov wrote:
> revision-id: 06ce67c644b (mariadb-10.4.27-41-g06ce67c644b)
> parent(s): 6cb84346e1b
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2023-01-10 18:27:16 +0400
> message:
>
> MDEV-27653 long uniques don't work with unicode co
Hi, Sergei,
On Jan 13, Sergei Petrunia wrote:
> revision-id: 0bef50e50b5 (mariadb-10.4.27-33-g0bef50e50b5)
> parent(s): 5db970fc760
> author: Sergei Petrunia
> committer: Sergei Petrunia
> timestamp: 2023-01-04 16:50:12 +0300
> message:
>
> MDEV-20501: Assertion `maybe_null || !null_value' failed
Hi, Alexander,
Looks good. A couple of comments, see below
On Jan 06, Alexander Barkov wrote:
> revision-id: 5dcde8f6523 (mariadb-10.4.26-64-g5dcde8f6523)
> parent(s): ce443c85547
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-10-28 15:37:44 +0400
> message:
>
> MDEV-
Hi, Oleksandr,
On Jan 06, Oleksandr Byelkin wrote:
> revision-id: 92ff948d021 (mariadb-10.3.37-53-g92ff948d021)
> parent(s): 180b2bcd538
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-12-05 20:42:03 +0100
> message:
>
> MDEV-29231 View returns wrong value with SQL_MO
Hi, Oleksandr,
On Jan 06, Oleksandr Byelkin wrote:
> revision-id: 6ff49e48e4f (mariadb-10.3.37-54-g6ff49e48e4f)
> parent(s): 92ff948d021
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-12-06 10:22:06 +0100
> message:
>
> MDEV-26161: fix of view protocol
could you ple
Hi, Rucha,
On Dec 28, Rucha Deodhar wrote:
> revision-id: 6a8268b7893 (mariadb-10.6.11-62-g6a8268b7893)
> parent(s): 4ca5a0ec98d
> author: Rucha Deodhar
> committer: Rucha Deodhar
> timestamp: 2022-12-15 17:45:25 +0530
> message:
>
> MDEV-28915: mysql_upgrade fails due to old_mode="", with "Canno
Hi, Alexander,
I'm not sure I understand everything you did there, so questions below
On Dec 28, Alexander Barkov wrote:
> revision-id: 4ddf606debf (mariadb-10.3.37-59-g4ddf606debf)
> parent(s): 8f30973234d
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-12-13 10:35:16
Hi, Julius,
On Dec 27, Julius Goryavsky wrote:
> commit 4d9f8a3c31e
> Author: Julius Goryavsky
> Date: Mon Dec 19 10:29:55 2022 +0100
>
> diff --git a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl
> index 12afab4d28c..8df8198fc99 100755
> --- a/mysql-test/mysql-test-run.pl
> +++
Hi, Daniel,
On Dec 20, Daniel Black wrote:
> updated as bb-11.0-danielblack-MDEV-30203-pkgtest-symlink-packages on top
> of bb-11.0-serg branch
please, rebase again (your three commits adjusting tests to 11.0 will
disappear). Also, see below:
> > > diff --git a/cmake/symlinks.cmake b/cmake/symli
Hi, Daniel,
This is a review of `git diff 12786f0e779f 5f76981eb649`, that is, for
commits:
5f76981eb64 rpm: packages that dont match component name
25eaa0aebfa MDEV-30205: [Cmtr: suite look in mariadb-test path
0981201f027 mtr - wsrep use mariadb executables
eba0b35035a mtr: maradb names for *em
Hi, Vicențiu,
This is a review of _test cases only_.
Mainly, to discuss the behavior.
Random thoughts here and comments inline in the diff.
There are two models for DENY that I can think of: "a hole in grants"
and "a mask".
The difference lies in where DENY is applied. In the "a hole in grants"
Hi, Nikita,
On Nov 01, Nikita Malyavin wrote:
> On Mon, 31 Oct 2022 at 21:22, Sergei Golubchik wrote:
>
> > > I hope RPL_TABLE_LIST can be preserved between the events. Is it
> > > so?
> >
> > Yes, it appears to be created in Table_map_log_event and removed
Hi, Nikita,
On Oct 31, Nikita Malyavin wrote:
> On Mon, 31 Oct 2022 at 14:08, Sergei Golubchik wrote:
> > On Oct 31, Nikita Malyavin wrote:
> > >
> > > > Also, I've looked at your latest branch. What were you
> > > > optimizing with the commit 3af
Hi, Nikita,
On Oct 31, Nikita Malyavin wrote:
>
> > Also, I've looked at your latest branch. What were you optimizing
> > with the commit 3afa3288221 (the one with usable_keys_data)?
> >
> > It's complex and I don't quite see what's the purpose of it. It
> > looks like all you need to do is to de
Hi, Nikita,
On Oct 18, Nikita Malyavin wrote:
> On Tue, 18 Oct 2022 at 01:01, Sergei Golubchik wrote:
>
> > > > > diff --git a/sql/log_event_server.cc b/sql/log_event_server.cc
> > > > > index 422d496d5c3..25705d13641 100644
> > > > >
Hi, Alexander,
Ok to push.
One minor comment below:
On Oct 25, Alexander Barkov wrote:
> revision-id: b2800c06b22 (mariadb-10.4.26-45-gb2800c06b22)
> parent(s): 34163154077
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-10-25 11:53:39 +0400
> message:
>
> MDEV-28545 M
Hi, Nikita,
As we've discussed on slack, this is wrong. The (serialized) behavior
should be as if all DML happened before ALTER.
Because if some DML would've happened after ALTER, it would be able to
see the new table definition and refer to new columns.
On Oct 24, Nikita Malyavin wrote:
> revis
Hi, Oleksandr,
On Oct 21, Oleksandr Byelkin wrote:
> > > > >
> > > > >if (share->view_def->parse((uchar *) &share->tabledef_version,
> > > > > NULL,
> > > > > view_timestamp_parameters, 1,
> > > > > &file_parser_dummy_hook))
> > > >
Hi, Alexander,
ok to push!
On Oct 21, Alexander Barkov wrote:
> revision-id: 99dcf061c8c (mariadb-10.4.26-55-g99dcf061c8c)
> parent(s): 1be451ca797
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-10-21 14:31:02 +0400
> message:
>
> MDEV-29481 mariadb-upgrade prints con
Hi, Oleksandr,
On Oct 19, Oleksandr Byelkin wrote:
> On Wed, Oct 19, 2022 at 5:09 PM Sergei Golubchik wrote:
> > On Oct 19, Oleksandr Byelkin wrote:
> > >
> > >if (share->view_def->parse((uchar *) &share->tabledef_version, NULL,
> > >
Hi, Oleksandr,
Looks good.
Just one question below:
On Oct 19, Oleksandr Byelkin wrote:
> revision-id: 39e20ca7e28 (mariadb-10.3.36-107-g39e20ca7e28)
> parent(s): d6707ab11f6
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-10-18 16:38:09 +0200
> message:
>
> MDEV-297
Hi, Nikita,
On Oct 17, Nikita Malyavin wrote:
> Hello Sergei!
>
> On Tue, 4 Oct 2022 at 21:02, Sergei Golubchik wrote:
>
> > Hi, Nikita,
> >
> > This review applies to the combined diff e2f8dff^..52f489e
> >
> > On Oct 04, Nikita Malyavin wrote:
&g
Hi, Nikita,
Sorry, this comes very late. But the bug is still present in 10.10,
and the filter sorts by the date precisely to highlight these old bugs.
So, here you are.
First comment, please, port it to the latest 10.3. I wasn't able to find
the repository with the fix, but the patch itself is a
Hi, Oleksandr,
On Oct 13, Oleksandr Byelkin wrote:
> revision-id: 19772f9c277 (mariadb-10.3.36-90-g19772f9c277)
> parent(s): e05ab0cfc5f
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-10-12 15:59:46 +0200
> message:
>
> MDEV-29748 ASAN errors or server crash in File_
Hi, Marko,
On Oct 10, Marko Mäkelä wrote:
> On Sun, Oct 9, 2022 at 2:03 PM Sergei Golubchik wrote:
> > I've spent more time on this issue, and it looks like there is no
> > structure in InnoDB with the life time till the end of the statement
> > (or, at least, nothing
Hi, Nikita,
On Sep 01, Sergei Golubchik wrote:
>
> > This new solution simply does the following:
> > * Sets up a referenced table list in TABLE instance (sql_base.cc)
> > * Iterates through it along with dict_table_t::referenced_set
> > (row_upd_check_reference
Hi, Nikita,
On Sep 27, Nikita Malyavin wrote:
> Sergei, I have reworded the commit message, please see it here:
> https://github.com/MariaDB/server/commit/3a3064e355bac20ed56ae807e790068e16dd16f3
Same thing. I still cannot understand from the comment what the problem
was.
>> > This new solution
Hi, Alexander,
See a couple of questions below:
On Oct 04, Alexander Barkov wrote:
> revision-id: dcfc60ea2ee (mariadb-10.4.26-28-gdcfc60ea2ee)
> parent(s): 6c2c825e503
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-10-03 10:32:42 +0400
> message:
>
> MDEV-29481 maria
Hi, Nikita,
This review applies to the combined diff e2f8dff^..52f489e
On Oct 04, Nikita Malyavin wrote:
> diff --git a/sql/log_event.h b/sql/log_event.h
> index 91a910f..8452e665c98 100644
> --- a/sql/log_event.h
> +++ b/sql/log_event.h
> @@ -5275,8 +5278,11 @@ class Rows_log_event : public
Hi, Oleksandr,
On Sep 28, Oleksandr Byelkin wrote:
> > > +bool TABLE_LIST::is_the_same_definition(THD* thd, TABLE_SHARE *s)
> > > +{
> > > + enum enum_table_ref_type tp= s->get_table_ref_type();
> > > + if (m_table_ref_type == tp)
> > > + {
> > > +bool res= m_table_ref_version == s->get_tab
Hi, Oleksandr,
Few minor comments, see below
On Sep 27, Oleksandr Byelkin wrote:
> revision-id: 5265f7001c6 (mariadb-10.3.36-60-g5265f7001c6)
> parent(s): 86953d3df0a
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-09-27 10:23:31 +0200
> message:
>
> MDEV-17124: mari
Hi, Oleksandr,
On Sep 26, Oleksandr Byelkin wrote:
> >
> > > > > +timestamp.second_part= trigger->ms_create_time % 100;
> > > >
> > > > hrtime_to_time() and hrtime_sec_part()
> > >
> > > they made for events, so I made hr_time_to_time, hr_time_from_time
> >
> > What do you mean by "made fo
Hi, Oleksandr,
On Sep 26, Oleksandr Byelkin wrote:
> > >LEX_STRING name; /* name for named prepared statements */
> > >LEX *lex; // parse tree descriptor
> > > + ulonglong ms_prepare_time; // time of preparation in microseconds
> >
> > "ms" here too :(
Hi, Vicentiu,
On Sep 12, Vicentiu Ciorbaru wrote:
> revision-id: f5a8327d016 (mariadb-10.3.36-26-gf5a8327d016)
> parent(s): fa75057b238
> author: Vicențiu Ciorbaru
> committer: Vicențiu Ciorbaru
> timestamp: 2022-09-05 16:40:10 +0300
> message:
>
> MDEV-29458: Role grant commands do not propagate
Hi, Vladislav,
Note, despite what the subject says, below is not for one commit, but
for the diff over them all.
Just a couple of questions and a comment:
> diff --git a/libmariadb b/libmariadb
> index a6665e65c05..22f7ed12b46 16
> --- a/libmariadb
> +++ b/libmariadb
> @@ -1 +1 @@
> -Subproj
Hi, Oleksandr,
On Sep 09, Oleksandr Byelkin wrote:
> revision-id: 3f9e6c9c111 (mariadb-10.3.35-36-g3f9e6c9c111)
> parent(s): 5feb60ce186
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-06-24 15:37:25 +0200
> message:
>
> MDEV-22133 handle_fatal_signal (sig=11) on opti
Hi, Alexander,
On Sep 09, Alexander Barkov wrote:
> revision-id: 68ebe0e2f5e (mariadb-10.3.36-25-g68ebe0e2f5e)
> parent(s): f501f815bc7
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-09-07 08:10:58 +0400
> message:
>
> MDEV-29446 Change SHOW CREATE TABLE to display def
Hi, Andrei,
I still don't understand this.
1. Why rgi->options_to_bin_log is only set for GTID_EVENT?
Is there a guarantee that there always be a GTID_EVENT before a
QUERY_EVENT? What if gtids aren't enabled?
2. how do you guarantee that all query events for a previous value of
options_
Hi, Andrei,
On Sep 01, Andrei wrote:
> revision-id: 489a7fba324 (mariadb-10.5.17-10-g489a7fba324)
> parent(s): 0324bde8469
> author: Andrei
> committer: Andrei
> timestamp: 2022-09-01 14:15:11 +0300
> message:
>
> MDEV-29322 ASAN heap-use-after-free in Query_log_event::do_apply_event
>
> The ASA
Hi, Nikita,
On Aug 30, Nikita Malyavin wrote:
> revision-id: b1b38b64598 (mariadb-10.5.17-4-gb1b38b64598)
> parent(s): 3b656ac8c17
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2022-08-23 00:27:39 +0300
> message:
>
> MDEV-29181 Potential corruption on FK update on a table w
Hi, Nikita,
No, in this case (and commonly for collateral changes) I'd rather prefer
to refine the original (878a92e) commit to not cause the MDEV-29056 in
the first place.
Ignoring LOCK= clause is logically correct and that's what the old code
was doing anyway. But perhaps ALTER TABLE still need
Hi, Nikita,
Few comments below
On Aug 27, Nikita Malyavin wrote:
> commit e2f8dffc056
> Author: Nikita Malyavin
> Date: Mon Jul 25 23:52:24 2022 +0300
>
> diff --git a/sql/log_event_server.cc b/sql/log_event_server.cc
> index 422d496d5c3..ca17c5c07a8 100644
> --- a/sql/log_event_server.cc
> +
Hi, Oleksandr,
> commit 5154e224a97
> Author: Oleksandr Byelkin
> Date: Mon Dec 13 16:15:21 2021 +0100
>
> diff --git a/scripts/mysql_system_tables.sql b/scripts/mysql_system_tables.sql
> index fd2f1c95dda..a1721913b2c 100644
> --- a/scripts/mysql_system_tables.sql
> +++ b/scripts/mysql_system
Hi, Oleksandr,
On Aug 25, Oleksandr Byelkin wrote:
> revision-id: bcfc424d859 (mariadb-10.6.1-483-gbcfc424d859)
> parent(s): 1c3182a99e5
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-08-16 11:49:41 +0200
> message:
>
> MDEV-5215 prerequisite: remove test and test_*
Hi, Oleksandr,
On Aug 25, Oleksandr Byelkin wrote:
> revision-id: 1c3182a99e5 (mariadb-10.6.1-482-g1c3182a99e5)
> parent(s): 7253cdf8928
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-08-16 11:49:41 +0200
> message:
>
> MDEV-5215 prerequisite of prerequisite: if DB i
Hi, Aleksey,
On Aug 03, Aleksey Midenkov wrote:
> > > diff --git a/sql/log_event.h b/sql/log_event.h
> > > index 3adc7a26d93..dc269955c5f 100644
> > > --- a/sql/log_event.h
> > > +++ b/sql/log_event.h
> > > @@ -535,16 +535,12 @@ class String;
> > > */
> > > #define OPTIONS_WRITTEN_TO_BIN_LOG \
>
Hi, Alexander,
> > -ERROR HY000: Illegal parameter data types inet6 and int for operation 'SET'
> > +ERROR HY000: Unknown CAST(int AS inet6) in assignment of 'target'
sorry, forgot to add, let's also add a db/table name here? and use
the proper backtick quoting for identifiers
Regards,
Sergei
V
Hi, Alexander,
a thought about the error message text and a couple of questions
about changes in results, please, see below:
On Aug 05, Alexander Barkov wrote:
> revision-id: a507f126b03 (mariadb-10.7.4-39-ga507f126b03)
> parent(s): 97d16c7544c
> author: Alexander Barkov
> committer: Alexander Ba
Hi, Alexander,
A couple of comments:
On Aug 03, Alexander Barkov wrote:
> revision-id: f3fc58149dd (mariadb-10.7.4-39-gf3fc58149dd)
> parent(s): 97d16c7544c
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-08-03 11:28:31 +0400
> message:
>
> MDEV-29159 Patch for MDEV-28
Hi, Alexander,
On Jul 29, Alexander Barkov wrote:
>Hello Sergei,
>
> I have a couple of suggestions:
>
> > commit 7b8304045272111a6f4d44196d6b37cbfef06f37
> > Author: Sergei Golubchik
> > Date: Wed Jul 20 17:31:48 2022 +0200
&g
Hi, Alexander,
I added tests and created an MDEV.
Specific replies below:
On Jul 29, Alexander Barkov wrote:
>Hello Sergei,
>
> > commit 5a362d486b30fdaf3c7a360737331767154b4ee8
> > Author: Sergei Golubchik
> > Date: Mon Jul 18 22:53:27 2022 +0200
> >
&g
Hi, Nikita,
Sure, as you like
On Jul 13, Nikita Malyavin wrote:
> I did, in rpl_alter_extra_persistent.test.
>
> Btw, maybe also rename this file, into something not referring to
> PERSISTENT?
>
> On Wed, 13 Jul 2022 at 23:41, Sergei Golubchik wrote:
>
> > Hi, Ni
Hi, Nikita,
Please, add a test case for DEFAULT in replication, something like I
described below.
On Jul 13, Nikita Malyavin wrote:
> On Thu, 7 Jul 2022 at 16:05, Sergei Golubchik wrote:
>
> > Hi, Nikita,
> >
> > This is good, but I think fill_extra_persistent_columns
Hi, Nikita,
On Jul 08, Nikita Malyavin wrote:
> revision-id: 3e2d297830b (mariadb-10.6.1-511-g3e2d297830b)
> parent(s): c1feb8c3c32
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2022-07-05 15:20:04 +0300
> message:
>
> MDEV-29013 ER_KEY_NOT_FOUND/lock timeout upon online alt
Hi, Nikita,
On Jul 07, Nikita Malyavin wrote:
>
> diff --git a/sql/log_event_server.cc b/sql/log_event_server.cc
> index aba846453e9..89ca2a41937 100644
> --- a/sql/log_event_server.cc
> +++ b/sql/log_event_server.cc
> @@ -6045,9 +6045,12 @@ int Rows_log_event::do_apply_event(rpl_group_info *rgi)
Hi, Nikita,
This is good, but I think fill_extra_persistent_columns() shouldn't be
used at all.
It doesn't handle default values. I've changed rpl_alter_extra_persistent test
as
-alter table t1 add column z1 int as(a+1) virtual, add column z2 int as (a+2)
persistent;
+alter table t1 add column
Hi, Martijn,
It seems there is no way to distinguish, short of parsing the routine
body looking for 'fetch group next row'.
I've reported it as a bug, https://jira.mariadb.org/browse/MDEV-28849
On Jun 15, Martijn Tonies (Upscene Productions) wrote:
> Hi all,
>
> Since MariaDB 10.3, you can use
Hi, Alexander,
Why haven't you used HASH?
On Jun 11, Alexander Barkov wrote:
> revision-id: 8c2c0e6079a (mariadb-10.9.1-13-g8c2c0e6079a)
> parent(s): 27fa5c10eff
> author: Alexander Barkov
> committer: Alexander Barkov
> timestamp: 2022-05-26 13:17:34 +0400
> message:
>
> MDEV-27265 Improve cont
Hi, Alexander,
Few comments/questions below.
Meanwhile I'm reviewing bb-10.9-bar-uca14
On May 26, Alexander Barkov wrote:
>
> By the way, perhaps some of these statements should display
> short collation names:
>
>SHOW CREATE TABLE t1;
>SHOW CREATE DATABASE db1;
>SELECT COLLATION_NA
Hi, Alexey,
Looks good. Minor comments below.
Ok to push after addressing them.
On May 06, Alexey Botchkov wrote:
> revision-id: 2fdcfaaba09 (mariadb-10.7.2-8-g2fdcfaaba09)
> parent(s): 33fd136c61b
> author: Alexey Botchkov
> committer: Alexey Botchkov
> timestamp: 2022-05-05 15:03:38 +0400
> mes
Hi, Sergei,
On May 04, Sergei Petrunia wrote:
> revision-id: 4ba5b444b4b (mariadb-10.2.43-97-g4ba5b444b4b)
> parent(s): 70555454b4c
> author: Sergei Petrunia
> committer: Sergei Petrunia
> timestamp: 2022-05-04 12:24:48 +0300
> message:
>
> MDEV-28437: Assertion `!eliminated' failed in Item_subse
Hi, Sergei,
The solutions looks fine
Two comments below, about the implementation.
ok to push after addressing them
On May 03, Sergei Petrunia wrote:
> revision-id: 85cc56875e9 (mariadb-10.2.43-75-g85cc56875e9)
> parent(s): 3b6c04f44c4
> author: Sergei Petrunia
> committer: Sergei Petrunia
> ti
Hi, Rucha,
Looks good. please also check that row_number values match what's in a
warning, and then ok to push!
On Apr 26, Rucha Deodhar wrote:
> On Tue, Apr 26, 2022 at 12:41 AM Sergei Golubchik wrote:
> > what if you combine it with union?
> > create table t (a char(
Hi, Rucha,
what if you combine it with union?
create table t (a char(1)) values ('a'),('b') union values ('foo');
please, add a test for that.
On Apr 25, Rucha Deodhar wrote:
> revision-id: 1c0731e0544 (mariadb-10.7.1-33-g1c0731e0544)
> parent(s): 5e6fd4e8043
> author: Rucha Deodhar
> committer
Hi, Anel,
On Apr 25, Anel Husakovic wrote:
> revision-id: 585cd1f52e7 (mariadb-10.5.14-10-g585cd1f52e7)
> parent(s): 52b32c60c26
> author: Anel Husakovic
> committer: Anel Husakovic
> timestamp: 2022-02-14 13:59:24 +0100
> message:
>
> MDEV-26875: Wrong user in SET DEFAULT ROLE error
>
> - Cause
Hi, Rucha,
The fix is ok to push. But as a general comment, better try to define
variables in the smallest scope where they're used. In particular here
it could've been
{
MY_BITMAP *old_map= dbug_tmp_use_all_columns(table,
&table->write_set);
- (void) item->save_in_f
Hi, Aleksey,
ok to push, thanks!
On Apr 20, Aleksey Midenkov wrote:
> Sergei,
>
> I updated the branch accordingly. There is your patch fa444975d0f
> where I added log_current_statement().
>
> On Wed, Apr 20, 2022 at 1:12 PM Sergei Golubchik wrote:
> >
> > H
Hi, Aleksey,
Okay, sure.
I was going to push it after the release.
And in 10.3 to simplify future merges.
On Apr 20, Aleksey Midenkov wrote:
> Hi Sergei!
>
> On Tue, Apr 19, 2022 at 11:13 AM Sergei Golubchik wrote:
> >
> > Hi, Aleksey,
> >
> >
gt;
> Where is your patch?
It's really just renaming, almost nothing else.
But here it is, attached.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
commit 0593fd1926f
Author: Sergei Golubchik
Date: Mon Apr 11 22:06:21 2022 +0200
cleanup: log_
Hi, Alexander,
Some comments/questions here. I'll need to look at the patch again after
I understand why you did it this way better.
On Apr 18, Alexander Barkov wrote:
> revision-id: 96b40a5e2f5 (mariadb-10.3.33-61-g96b40a5e2f5)
> parent(s): 7355f7b1f5c
> author: Alexander Barkov
> committer: Ale
Hi, Aleksey,
> I attached the patch and this still fails rpl.create_or_replace_row.
small mistake in the patch:
> --- a/sql/sql_class.h
> +++ b/sql/sql_class.h
> @@ -2916,7 +2916,7 @@ class THD: public THD_count, /* this must be first */
>
>bool binlog_need_stmt_format(bool is_transactiona
Hi, Aleksey,
> > Take a look at the bb-10.3-serg-MDEV-24176 branch. Three commits
> > there: two cherry-picks from 10.2 (they shouldn't be pushed into
> > 10.3, instead your commit will eventually be rebased on top of them
> > after they're merged into 10.3) and the "work-in-progress" commit
> > t
Hi, Aleksey,
On Apr 13, Aleksey Midenkov wrote:
> >
> > No, quite the opposite.
> > I think (see above) that CONTEXT_ANALYSIS_ONLY_VCOL_EXPR
> > (it's set inside init_lex_with_single_table()) is wrong, what you're
> > doing is not "context analysys only", you're preparing items for
> > evaluation.
Hi, Aleksey,
On Apr 12, Aleksey Midenkov wrote:
> > > > > +bool Vcol_expr_context::init()
> > > > > +{
> > > > > + /*
> > > > > + As this is vcol expression we must narrow down name resolution
> > > > > to
> > > > > + single table.
> > > > > + */
> > > > > + if (init_lex_with_single_
Hi, Aleksey,
Basically, it's fine, but I still didn't like that there's a new flag in
THD to mark a statement that has to be logged. So I tried to change to
log_current_statement. I know you tried that and you told me what tests
fails, rpl.create_or_replace_*. I debugged that a bit, and I think th
Hi, Oleksandr,
On Apr 10, Oleksandr Byelkin wrote:
> revision-id: e3e59c9e38d (mariadb-10.6.6-83-ge3e59c9e38d)
> parent(s): 4e1ca388381
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2022-04-08 10:37:17 +0200
> message:
>
> MDEV-28266 Crash in Field_string::type_handler w
Hi, Aleksey,
This is a review of `git diff 5fbbdbc85ba3 62d3496969db`
Basically, no new comments, see below:
On Apr 07, Aleksey Midenkov wrote:
> diff --git a/libmariadb b/libmariadb
> index f6c3d9fd2af..735a7299dba 16
> --- a/libmariadb
> +++ b/libmariadb
> @@ -1 +1 @@
> -Subproject commit
Hi, Aleksey,
Thanks. I'll send a separate review email, there will be only replies
here:
On Apr 05, Aleksey Midenkov wrote:
> Hi, Sergei!
>
> > > @@ -5709,8 +5708,6 @@ bool Item_field::fix_fields(THD *thd, Item
> > > **reference)
> > >}
> > > #endif
> > >fixed= 1;
> > > - if (field->v
1 - 100 of 2425 matches
Mail list logo
