[Maria-developers] optimizer_switch default settings change for 5.3.2: status?

2011-10-09 Thread Sergey Petrunya
Hi Sanja, I was wondering if you have any progress with optimizer_switch default settings change that we decided to do for the 5.3.2 release? Any ETA on when that will be pushed? BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog:

[Maria-developers] Preparations for 5.3.2 release

2011-09-28 Thread Sergey Petrunya
Hi! As discussed on the yesterday's call, we're starting to prepare for the next 5.3 release, 5.3.2 beta. The intent is to build it on this or on the next weekend. Before the release, we need to do 1. Bugs 2. optimizer_switch changes. 3. Merge from mariadb-5.1 We don't need to address: 1.

[Maria-developers] MWL#182: a problem select_type column, SIMPLE vs PRIMARY

2011-08-27 Thread Sergey Petrunya
Hello, When coding MWL#182, I've found out that it is very difficult to print the same value of select_type as EXPLAIN does. Problem description --- Moreover, any attempt to unify EXPLAIN and SHOW EXPLAIN code cause numerous test failures because of changed select_type.

Re: [Maria-developers] [Commits] Rev 3156: MWL#182: Explain running statements

2011-08-24 Thread Sergey Petrunya
Hi Sergei, On Tue, Aug 23, 2011 at 10:55:40PM +0200, Sergei Golubchik wrote: Hi, Sergey! On Aug 23, Sergey Petrunya wrote: MWL#182: Explain running statements First code - Asynchronous procedure call system I would like to review that part (at least), could you please tell me

Re: [Maria-developers] [Commits] Rev 3166: Fixed bug lp:825018 in file:///home/tsk/mprog/src/5.3/

2011-08-23 Thread Sergey Petrunya
Hi Timour, Ok to push. On Tue, Aug 23, 2011 at 03:41:55PM +0300, tim...@askmonty.org wrote: At file:///home/tsk/mprog/src/5.3/ revno: 3166 revision-id: tim...@askmonty.org-20110823123915-jxf9hvxq2hy03rr7 parent:

Re: [Maria-developers] [Commits] Rev 3135: Subquery cache going on disk management fix: Do not go on disk if hit/miss ration less than 2. in file:///home/bell/maria/bzr/work-maria-5.3-subquerycachedis

2011-07-28 Thread Sergey Petrunya
Hi Sanja A summary of our discussion on irc/skype: Please change EXPCACHE_DISK_HITMISS_RATIO to be a hit ratio, i.e fraction of accesses that result in cache hits, as that's this is the most common number people use when they think about cache performance. Please change one limit into two: 1.

[Maria-developers] Is it time to change 5.3 bugs status from Fix Committed to Fix Released?

2011-07-28 Thread Sergey Petrunya
Hello, The bug database has 197 bugs with status=Fix committed and target_milestone=5.3. Since we've released 5.3, is it time to change status on these bugs to Fix released? BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog:

Re: [Maria-developers] [Commits] Rev 3135: Subquery cache going on disk management fix: Do not go on disk if hit rate is not good. in file:///home/bell/maria/bzr/work-maria-5.3-subquerycachedisk/

2011-07-28 Thread Sergey Petrunya
Hi Sanja, Ok to push. On Thu, Jul 28, 2011 at 05:10:29PM +0300, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.3-subquerycachedisk/ revno: 3135 revision-id:

[Maria-developers] Semi-join processing with Duplicate Elimination

2011-07-21 Thread Sergey Petrunya
Hello, The below really should be in documentation, but for now, I'm posting it here: Semi-join processing with Duplicate Elimination === There are three cases: Semi-join next to outer join ot1 left join (ot10, ot11)

[Maria-developers] Timour please review: [Commits] Rev 3096: BUG#778434 Wrong result with in_to_exists=on in maria-5.3-mwl89

2011-07-13 Thread Sergey Petrunya
Hi Timour, Could you please review the below: - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: comm...@mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date: Thu, 14 Jul 2011 00:43:12 +0400 (MSD) Subject: [Commits] Rev 3096

Re: [Maria-developers] Fwd: [Commits] Rev 3071: Fix LP bug lp:802979 in file:///home/tsk/mprog/src/5.3-mwl89/

2011-07-05 Thread Sergey Petrunya
Hi Timour, On Mon, Jul 04, 2011 at 03:40:49PM +0300, Timour Katchaounov wrote: Sergey Could you please review my fix for bug lp:802979. I need you specifically because I needed to touch the range optimzizer to disable evaluation of single-row subqueries. Please consider if I chose the

[Maria-developers] Default optimizer_switch settings

2011-07-04 Thread Sergey Petrunya
Hello, Following what has been decided on the optimizer call, I'm nearly done with making semi-join optimizations off by default in 5.3. However, some of 5.3's new optimizations are still turned on by default. Here is a list of 5.3 features and flags that control them:

[Maria-developers] Derived table nests not removed by simplify_joins?

2011-07-04 Thread Sergey Petrunya
Hello Igor, I've discovered the following: Consider a testcase for https://bugs.launchpad.net/maria/+bug/803365. There we have a query that's using a derived table that's on the inner side of an outer join: SELECT * FROM t1 WHERE t1.f1 IN ( SELECT t2.f2 FROM t2 LEFT

Re: [Maria-developers] Proposal to split @@optimizer_switch

2011-06-28 Thread Sergey Petrunya
On Tue, Jun 28, 2011 at 01:20:07AM +0200, Vladislav Vaintroub wrote: -Original Message- From: maria-developers- bounces+wlad=montyprogram@lists.launchpad.net [mailto:maria- developers-bounces+wlad=montyprogram@lists.launchpad.net] On Behalf Of Sergey Petrunya Sent

[Maria-developers] Philip please test: Duplicate Elimination for outer joins + semi joins

2011-06-28 Thread Sergey Petrunya
Hello Philip, I'd like to get the tree at lp:~maria-captains/maria/5.3-subqueries-mwl90 tested for Duplicate Elimination with outer+semi-join processing. I'm interested in crashes, as well as wrong query result bugs. The code path that needs to be tested is selected with this @@optimizer_switch

Re: [Maria-developers] [Commits] Rev 3062: Fixed bug lp:800679 in file:///home/tsk/mprog/src/5.3-mwl89/

2011-06-28 Thread Sergey Petrunya
Hi Timour, Ok to push. On Mon, Jun 27, 2011 at 05:40:25PM +0300, tim...@askmonty.org wrote: At file:///home/tsk/mprog/src/5.3-mwl89/ revno: 3062 revision-id: tim...@askmonty.org-20110627144014-r14ahro6uzf77423 parent:

Re: [Maria-developers] [Maria-docs] MariaDB 5.3 docs

2011-06-28 Thread Sergey Petrunya
Hi Daniel, On Tue, Jun 28, 2011 at 09:51:44AM -0400, Daniel Bartholomew wrote: We're getting closer to the first beta release of MariaDB 5.3 and several of the new features have been documented in the Knowledgebase and linked to from this page: http://kb.askmonty.org/en/what-is-mariadb-53

Re: [Maria-developers] Proposal to split @@optimizer_switch

2011-06-27 Thread Sergey Petrunya
On Fri, Jun 10, 2011 at 12:13:12PM +0400, Sergey Petrunya wrote: Hello, Please find below descriptions of problems with current @@optimizer_switch variable, as well as a proposal on how to fix it. Results of IRC discussion on June, 22 (as I interpret them): Everyone agrees that we need

Re: [Maria-developers] Proposal to split @@optimizer_switch

2011-06-27 Thread Sergey Petrunya
On Fri, Jun 10, 2011 at 12:50:34PM +0200, Sergei Golubchik wrote: Hi, Sergey! On Jun 10, Sergey Petrunya wrote: Hello, Please find below descriptions of problems with current @@optimizer_switch variable, as well as a proposal on how to fix it. contents Problems

[Maria-developers] Proposal to split @@optimizer_switch

2011-06-10 Thread Sergey Petrunya
Hello, Please find below descriptions of problems with current @@optimizer_switch variable, as well as a proposal on how to fix it. contents Problems with @@optimizer_switch Proposed solution Details about hooking this into parser Alternate approach1: grouping /contents Problems with

[Maria-developers] Buildbot failures: Microsecond-related changes break innodb_plugin but not xtradb

2011-06-04 Thread Sergey Petrunya
Hi! All of the recent 5.3 builds in buildbot have two failures: innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin' The failure happens only with innodb_plugin. XtraDB is fine. I've investigated the first problem. Its cause is in

Re: [Maria-developers] Buildbot failures: Microsecond-related changes break innodb_plugin but not xtradb

2011-06-04 Thread Sergey Petrunya
On Sat, Jun 04, 2011 at 01:19:42PM +0400, Sergey Petrunya wrote: Hi! All of the recent 5.3 builds in buildbot have two failures: innodb_plugin.innodb_bug54044 'innodb_plugin' skip The problematic changesets are: revno: 3009 [merge] revision-id: mo...@askmonty.org-20110528030022

[Maria-developers] Buildbot failure in filesort.cc:make_sortkey

2011-06-02 Thread Sergey Petrunya
Hi Sergei, Current 5.3 fails as follows: http://buildbot.askmonty.org/buildbot/builders/mac-mini-x86-dbg/builds/771/steps/compile/logs/stdio g++ -DMYSQL_SERVER -DDEFAULT_MYSQL_HOME='/usr/local/mysql' -DMYSQL_DATADIR='/usr/local/mysql/var' -DSHAREDIR='/usr/local/mysql/share/mysql'

[Maria-developers] FYI: MWL#90 pushed into 5.3 main

2011-05-30 Thread Sergey Petrunya
Hello, This is to inform you that today I've pushed MWL#90 into 5.3-main. There was a buildbot run on 5.3-subqueries-mwl90 tree before the push, and it did not show any failures that weren't also present in 5.3-main. The result of my merge has an issue that conceptually it is not a full merge,

[Maria-developers] More MWL#89 questions

2011-05-25 Thread Sergey Petrunya
Hi Timour, While merging, I also got the following questions: == exclude_expensive_cond == make_cond_for_table()'s exclude_expensive_cond parameter is not used anymore. Was it intentional that you kept it in the code? (minimizing MWL#89's diff size could not be a reason because the diff changes

Re: [Maria-developers] [Commits] Rev 2983: MWL#89 - Automatic merge with 5.3 in file:///home/tsk/mprog/src/5.3-mwl89-merge/

2011-05-23 Thread Sergey Petrunya
Hi Timour, On Mon, May 23, 2011 at 12:10:44PM +0300, Timour Katchaounov wrote: Thank you for the review, you manged to spot a couple of real omissions/ problems with the implementation. I implemented or responded to all your review suggestions except two. The two ones that I didn't implement

Re: [Maria-developers] [Commits] Rev 2983: MWL#89 - Automatic merge with 5.3 in file:///home/tsk/mprog/src/5.3-mwl89-merge/

2011-05-16 Thread Sergey Petrunya
Hi Timour, Congratulations on having pushed MWL#89 into 5.3-main! This is quite an achievement which really moves us forward. I've been studying the new code and has got some feedback which I thought I need to share. Please find the notes below, marked with 'psergey'. diff -urN

Re: [Maria-developers] [Commits] Rev 2908: Fixed LP bugs #717577, #724942. in file:///home/igor/maria/maria-5.3-bug717577/

2011-04-23 Thread Sergey Petrunya
Hello Igor, First, an overall comment: there are lots of typos/coding style violations in the patch. To reduce amount of effort spent on such things, I was just fixing them as I saw them and I'm attaching the patch with all the fixes (i.e. this patch should be applied on top of the patch that I

Re: [Maria-developers] [Commits] Rev 2908: Fixed LP bugs #717577, #724942. in file:///home/igor/maria/maria-5.3-bug717577/

2011-04-23 Thread Sergey Petrunya
On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote: Hello Igor, First, an overall comment: there are lots of typos/coding style violations in the patch. To reduce amount of effort spent on such things, I was just fixing them as I saw them and I'm attaching the patch with all

Re: [Maria-developers] [Commits] Rev 2947: Fix LP BUG#613029 in file:///home/tsk/mprog/src/5.3/

2011-03-29 Thread Sergey Petrunya
Hi Timour, Ok to push. On Mon, Mar 28, 2011 at 12:55:43PM +0300, tim...@askmonty.org wrote: At file:///home/tsk/mprog/src/5.3/ revno: 2947 revision-id: tim...@askmonty.org-20110328095536-wbmu1hiwsnhw6bs8 parent:

[Maria-developers] Dgcov coverage for: Re: MWL#90 combined patch for review

2011-03-02 Thread Sergey Petrunya
On Tue, Feb 22, 2011 at 06:03:38PM +0300, Sergey Petrunya wrote: On Tue, Feb 22, 2011 at 05:24:37PM +0300, Sergey Petrunya wrote: Hi Monty, Please find attached the complete patch of MWL#90 for review. The tree with the code is on launchpad/buildbot: https://code.launchpad.net/~maria

[Maria-developers] Igor please review: Rev 2929: BUG#693747: Assertion multi_range_read.cc:908: int DsMrr_impl::dsmrr_init in file:///home/psergey/dev2/5.3-2/]

2011-03-02 Thread Sergey Petrunya
Hello Igor, Could you please review the below: - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: comm...@mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date: Wed, 2 Mar 2011 00:17:53 +0300 (MSK) Subject: [Commits] Rev 2929

[Maria-developers] Igor please review: BUG#707925: Wrong result with join_cache_level=6 optimizer_use_mrr = force (incremental, BKA join) in file:///home/psergey/dev2/5.3/]

2011-03-02 Thread Sergey Petrunya
comparison, as well as simplified the testcase a bit (further simplification is difficult). Please find the result below: - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: comm...@mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date

Re: [Maria-developers] Fwd: [Commits] Rev 2901: BNLH algorithm always used a full table scan over the joined table in file:///home/igor/maria/maria-5.3-mwl128-hashrange/

2011-03-02 Thread Sergey Petrunya
Hello Igor, Here's the promised proof of deadcode: On Fri, Feb 11, 2011 at 08:49:37PM -0800, Igor Babaev wrote: === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2011-02-06 04:57:03 + +++ b/sql/sql_select.cc 2011-02-12 04:41:22 + @@ -8419,6 +8438,11 @@

[Maria-developers] Igor please review: [Commits] Rev 2926: BUG#724275: Crash in JOIN::optimize in maria-5.3 in file:///home/psergey/dev2/5.3-2/]

2011-02-28 Thread Sergey Petrunya
Hello Igor, Could you please review the below: - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: comm...@mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date: Tue, 1 Mar 2011 00:30:02 +0300 (MSK) Subject: [Commits] Rev 2926

[Maria-developers] [pser...@askmonty.org: [Commits] Rev 2921: BUG#723822: Crash in get_constant_key_infix with EXISTS ( SELECT .. DISTINCT ) in file:///home/psergey/dev2/5.3/]

2011-02-25 Thread Sergey Petrunya
Hi Timour, Could you please review the below? (Asking you because the fix is in the loose index scan optimizer) - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: comm...@mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date

[Maria-developers] MWL#90 combined patch for review

2011-02-22 Thread Sergey Petrunya
Hi Monty, Please find attached the complete patch of MWL#90 for review. The tree with the code is on launchpad/buildbot: https://code.launchpad.net/~maria-captains/maria/5.3-subqueries-mwl90 http://buildbot.askmonty.org/buildbot/grid?branch=5.3-subqueries-mwl90 and it has no failures other than

Re: [Maria-developers] Fwd: [Commits] Rev 2901: BNLH algorithm always used a full table scan over the joined table in file:///home/igor/maria/maria-5.3-mwl128-hashrange/

2011-02-22 Thread Sergey Petrunya
On Mon, Feb 21, 2011 at 03:20:13PM -0800, Igor Babaev wrote: === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc2011-02-06 04:57:03 + +++ b/sql/sql_select.cc2011-02-12 04:41:22 + ... @@ -8419,6 +8438,11 @@ sort_by_tab-type= JT_ALL;

Re: [Maria-developers] [Commits] Rev 2833: Fixed LP bug #664508. in file:///home/igor/maria/maria-5.3-mwl128-bug664508/

2011-02-21 Thread Sergey Petrunya
Hello Igor, On Sun, Oct 24, 2010 at 02:22:02PM -0700, Igor Babaev wrote: At file:///home/igor/maria/maria-5.3-mwl128-bug664508/ revno: 2833 revision-id: i...@askmonty.org-20101024212201-t8iius4jikcvm3zb parent:

Re: [Maria-developers] Fwd: [Commits] Rev 2901: BNLH algorithm always used a full table scan over the joined table in file:///home/igor/maria/maria-5.3-mwl128-hashrange/

2011-02-21 Thread Sergey Petrunya
On Fri, Feb 11, 2011 at 08:49:37PM -0800, Igor Babaev wrote: Hi Sergey, Please review this patch that fixes a defect of the current implementation of the mwl #128 that never couples hash join with range/index_merge scans. The patch also adds prefix #hash# to the names of the used hash

Re: [Maria-developers] IMPORTANT: LP bug #611648 does not allow running benchmarks for DS-MRR normally

2011-02-02 Thread Sergey Petrunya
Hi! On Tue, Feb 01, 2011 at 09:16:58PM -0800, Igor Babaev wrote: I've just reported bug #611648 that probably explains the strange results I had when trying to run my benchmark queries for DS-MRR about which I talked at today's optimizer meeting. I don't think that the posted queries show

Re: [Maria-developers] Benchmarking index_merge sort_intersect

2011-01-26 Thread Sergey Petrunya
Per Philip's request, details to replicate the dataset: == Server settings == [mysqld] innodb_file_per_table=1 innodb_file_format=barracuda innodb_log_file_size=100M == DDL == I based on Percona's DDL

Re: [Maria-developers] Benchmarking index_merge sort_intersect

2011-01-26 Thread Sergey Petrunya
Hello Philip, One more note about correlated results: I agree that it's true that the optimizer can't make a good choice if the data is correlated. But since this is intersection, we could take this from other end: when doing intersection scan, calculate utility of using extra indexes on the

[Maria-developers] No Using index support in sort-intersect - intentional?

2011-01-19 Thread Sergey Petrunya
Hello Igor, I was looking at sort-intersect and noticed the following: Consider this table: CREATE TABLE `t1` ( `k1` int(11) DEFAULT NULL, `k2` int(11) DEFAULT NULL, `filler` char(100) DEFAULT NULL, KEY `k1` (`k1`), KEY `k2` (`k2`) ) ENGINE=MyISAM DEFAULT CHARSET=latin1; Let's try

[Maria-developers] index_merge, @@sort_buffer_size, and Sort_XXX counters

2011-01-19 Thread Sergey Petrunya
Hello, index_merge uses @@sort_buffer_size as a guide of how much space it can use for sorting. I think there is an issue with the way it is done. Before index_merge was introduced, @@sort_buffer_size was used only by filesort (also for couple of other cases like GROUP_CONCAT with sorting, but I

Re: [Maria-developers] Proposals for improving BKA/MRR visibility in EXPLAIN and diagnostics

2010-12-16 Thread Sergey Petrunya
Added feedback provided by Igor over skype: On Wed, Dec 15, 2010 at 06:31:52PM +0300, Sergey Petrunya wrote: Below are some ideas on how to make DS-MRR/BKA easier to work with for the users (= those who don't run mysqld under debugger). Questions are marked with 'Q:' but any comments

[Maria-developers] Proposals for improving BKA/MRR visibility in EXPLAIN and diagnostics

2010-12-15 Thread Sergey Petrunya
Hello, Below are some ideas on how to make DS-MRR/BKA easier to work with for the users (= those who don't run mysqld under debugger). Questions are marked with 'Q:' but any comments are welcome. Better EXPLAIN -- Philip has complained numerous times that it is not shown in EXPLAIN

[Maria-developers] Philip please test maria-5.3-mwl128-dsmrr-cpk

2010-12-09 Thread Sergey Petrunya
Hi Philip, The new version of MWL#121-125, DS-MRR impovements, is ready for your testing. I believe all previously reported crashes and wrong query result bugs are no longer there (they've been either targeted and fixed, or were gone after code re-working I've made when addressing review

[Maria-developers] MWL#90: need a list of obvious things to improve

2010-12-09 Thread Sergey Petrunya
Hi Timour, In Helsinki, we've noted the following: MWL#90: Subqueries: Inside-out execution for non-semijoin materialized subqueries in WHERE (4K diff); Critical task = Get the code reviewed/pushed TODO: - Timour will tell the obvious things to improve; Timour 1 day I'm going to need

Re: [Maria-developers] Problem with prep_where (LP BUG#675248)

2010-11-22 Thread Sergey Petrunya
Hi! On Mon, Nov 15, 2010 at 04:47:54PM +0200, Oleksandr Byelkin wrote: Preparation statement for PS looks like this (example uses prep_where, but we have the same problem for other parts stored in st_select_lex::fix_prepare_information()): ... conds-fix_fields(...conds...) /* (1.1)

Re: [Maria-developers] Fwd: [Commits] Rev 2859: Fixed LP #bug 660963. in file:///home/igor/maria/maria-5.3-mwl128-bug660963/

2010-11-19 Thread Sergey Petrunya
Hello Igor, On Thu, Nov 18, 2010 at 02:17:13PM -0800, Igor Babaev wrote: Sergey, Please review this patch ASAP as this bug blocks Philip with testing. If you have any questions contact me by skype. Ok to push after the comment below is addressed. Original Message

Re: [Maria-developers] Fwd: [Commits] Rev 2860: Fixed LP bug #675922. in file:///home/igor/maria/maria-5.3-mwl128-bug675922/

2010-11-19 Thread Sergey Petrunya
Hello Igor, On Thu, Nov 18, 2010 at 10:04:24PM -0800, Igor Babaev wrote: Sergey, Please review this fix. Ok to push after the irc feedback (lack of comments about JOIN_CACHE format) is addressed. Original Message Subject: [Commits] Rev 2860: Fixed LP bug #675922.

Re: [Maria-developers] Review of MWL#128: Block Nested Loop Hash Join

2010-11-12 Thread Sergey Petrunya
On Fri, Nov 12, 2010 at 05:42:25PM +0300, Sergey Petrunya wrote: * EXPLAIN currently shows hash join as follows: MariaDB [hj1] explain extended select * from t1 A, t2 B where A.a=B.a

[Maria-developers] Is it possible to have RQG look for crashes only?

2010-11-09 Thread Sergey Petrunya
Hi Philip, I've been fixing bugs in maria-5.3-mwl128-dsmrr-cpk tree, fixed two of the four problems so far. My general impression is that crashes are easier to fix than wrong results. Is it possible to run RQG in a mode that will cause it to ignore the difference in query results, and stop only

Re: [Maria-developers] [Commits] Rev 2845: Fixed LP bug #668644. in file:///home/igor/maria/maria-5.3-bug668644/

2010-11-08 Thread Sergey Petrunya
Ok to push. On Mon, Nov 08, 2010 at 08:36:33PM -0800, Igor Babaev wrote: At file:///home/igor/maria/maria-5.3-bug668644/ revno: 2845 revision-id: i...@askmonty.org-20101109043632-s053dbydv48cr9nz parent:

[Maria-developers] Tree with DS-MRR improvements ready for testing

2010-11-03 Thread Sergey Petrunya
Hi Philip, The combined tree with DS-MRR improvements and MWL#128 is ready for testing. It is located at lp:~maria-captains/maria/maria-5.3-mwl128-dsmrr-cpk/ . I don't know how hard that is for you, but it would be useful to check the failures - against 5.3-main tree (to see whether the problem

[Maria-developers] RQG

2010-11-01 Thread Sergey Petrunya
Hi Philip, On Tue, Oct 26, 2010 at 03:34:41PM +0300, Philip Stoev wrote: - Our chances of making Random Query Generator a little bit friendlier for bug analyzers/fixers. Hi, Can you list specific issues that you are having or specific bug numbers that were not filed properly? I can't

[Maria-developers] 5.3 compilation warnings

2010-11-01 Thread Sergey Petrunya
Hi Timour, When one compiles 5.3, it produces the following warnings which I believe fall into your turf. Could you please fix them: item_subselect.cc: In member function ‘bool subselect_rowid_merge_engine::init(MY_BITMAP*, MY_BITMAP*)’: item_subselect.cc:4826: warning: ignoring return value of

Re: [Maria-developers] [Commits] Rev 2840: Fixed LP bug #668290. in file:///home/igor/maria/maria-5.3-mwl128-bug668290/

2010-10-30 Thread Sergey Petrunya
Hello Igor, Plese find the comments below. On Sat, Oct 30, 2010 at 12:56:10PM -0700, Igor Babaev wrote: At file:///home/igor/maria/maria-5.3-mwl128-bug668290/ revno: 2840 revision-id:

[Maria-developers] On possible bug in get_partial_join_cost()

2010-10-29 Thread Sergey Petrunya
Hi Timour, Answers to irc questions: timour spetrunia, I found a problem in get_partial_join_cost(), could you please look at this: timour for (uint i= join-const_tables; i n_tables + join-const_tables ; i++) timour spetrunia, why i n_tables + join-const_tables ? isn't the number of tables

Re: [Maria-developers] [Commits] Rev 2827: Ported the fix for bug #57024 (a performance issue for outer joins). in file:///home/igor/maria/maria-5.3-mwl128-bug57024/

2010-10-06 Thread Sergey Petrunya
Hello Igor, Please find some minor comments below. Ok to push after they are addressed. On Wed, Oct 06, 2010 at 05:14:08AM -0700, Igor Babaev wrote: At file:///home/igor/maria/maria-5.3-mwl128-bug57024/ revno: 2827 revision-id:

Re: [Maria-developers] DS-MRR improvements patch r3 ready for review

2010-10-06 Thread Sergey Petrunya
On Mon, Oct 04, 2010 at 10:54:37AM +0400, Sergey Petrunya wrote: Hello Igor, Please find attached the combined patch that addresses all of the review feedback provided so far. The tree is in launchpad and buildbot also: https://code.launchpad.net/~maria-captains/maria/5.3-dsmrr-cpk

Re: [Maria-developers] DS-MRR improvements patch ready for review

2010-08-22 Thread Sergey Petrunya
Hi Philip, On Fri, Aug 20, 2010 at 09:12:19AM +0200, Sergey Petrunya wrote: Please find attached the combined patch of DS-MRR for clustered PKs and key sorting. The tree is in launchpad and buildbot also: https://code.launchpad.net/~maria-captains/maria/5.3-dsmrr-cpk and all observed

Re: [Maria-developers] [Commits] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (igor:2869) Bug#52005

2010-07-27 Thread Sergey Petrunya
Hello Igor, Ok to push. I'm sorry for the delay. On Sun, Jul 25, 2010 at 10:50:03PM -0700, Igor Babaev wrote: #At lp:maria based on revid:mo...@askmonty.org-20100615220051-2xp3g51fysxle1r1 2869 Igor Babaev 2010-07-25 Fixed bug #52005. Corrected coding for Warshall's

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2827) Bug#607566]

2010-07-21 Thread Sergey Petrunya
Hello Igor, Ok to push. On Mon, Jul 19, 2010 at 10:43:18PM -0700, Igor Babaev wrote: Sergey, Please review this patch for the 5.2 tree. Regards, Igor. Original Message Subject: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2827)

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2827) Bug#607177]

2010-07-21 Thread Sergey Petrunya
Hello Igor, Ok to push. On Tue, Jul 20, 2010 at 10:01:30PM -0700, Igor Babaev wrote: Sergey, Please review this trivial patch for the 5.2 tree. Regards, Igor. Original Message Subject: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2823) Bug#604503]

2010-07-17 Thread Sergey Petrunya
Hello Igor, On Sat, Jul 17, 2010 at 12:42:49AM -0700, Igor Babaev wrote: === modified file 'sql/table.cc' --- a/sql/table.cc2010-07-13 14:34:14 + +++ b/sql/table.cc2010-07-17 07:37:48 + @@ -1930,8 +1930,6 @@ end: semantic analysis of the item by calling the the function

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2823) Bug#603186]

2010-07-16 Thread Sergey Petrunya
Hello Igor, On Thu, Jul 15, 2010 at 04:54:37PM -0700, Igor Babaev wrote: Please review this patch for the 5.2 tree. Regards, Igor. Ok to push. Original Message Subject: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2823) Bug#603186 Date:

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2821) Bug#604549]

2010-07-13 Thread Sergey Petrunya
Hello Igor, Please find the feedback below. On Mon, Jul 12, 2010 at 07:08:34PM -0700, Igor Babaev wrote: Please review this patch for the 5.2 tree. Regards, Igor. Original Message Subject: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch

Re: [Maria-developers] [Fwd: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2822) Bug#603654]

2010-07-13 Thread Sergey Petrunya
Hello Igor, Ok to push. On Mon, Jul 12, 2010 at 07:08:58PM -0700, Igor Babaev wrote: Please review this patch for the 5.2 tree. Regards, Igor. Original Message Subject: [Commits] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (igor:2822) Bug#603654

[Maria-developers] MWL#123, sql layer part (was: Re: mwl#121: follow up)

2010-07-04 Thread Sergey Petrunya
Hello Igor, On Thu, Jul 01, 2010 at 11:55:58PM -0700, Igor Babaev wrote: According to our agreement I introduced a new flag for MRR. I called it HA_MRR_MATERIALIZED_KEYS. This flag passed to any MMR interface function that takes mrr_mode as a parameter says: key values used in ranges are

[Maria-developers] MariaDB 5.3: Time to merge from 5.2?

2010-06-24 Thread Sergey Petrunya
Hello 5.3 developers, We all know that 5.3 tree have some buildbot failures that - are unlikely to be result of any 5.3 work, - cannot be observed in 5.2 - still are somehow present. I got suspicious about one failure, and investigated it: https://bugs.launchpad.net/maria/+bug/597742. Long

[Maria-developers] Please review: MWL#121: DS-MRR support for clustered primary keys

2010-06-22 Thread Sergey Petrunya
Hello Igor, Please find below the combined patch for MWL#121. It is ready for review. diff -urN --exclude='.*' maria-5.3-dsmrr-for-cpk-clean/mysql-test/r/innodb_mrr_cpk.result maria-5.3-dsmrr-for-cpk-noc/mysql-test/r/innodb_mrr_cpk.result ---

Re: [Maria-developers] [Commits] Rev 2797: MWL#90, code movearound to unify merged and non-merged semi-join materialization processing in file:///home/psergey/dev/maria-5.3-subqueries-r12/

2010-06-07 Thread Sergey Petrunya
, hence the presence of loads of commented-out old code and lack of real comments. I'll address this a bit later. - The suspicious thing confirmed and fixed. - Style suggestions followed. Sergey == Sergey Petrunya pser...@askmonty.org writes: cut Sergey === modified file 'sql

Re: [Maria-developers] Updated (by Psergey): Push conditions down into non-mergeable VIEWs when possible (119)

2010-05-25 Thread Sergey Petrunya
On Tue, May 25, 2010 at 11:00:02AM +1000, Arjen Lentz wrote: Hi Sergey On 25/05/2010, at 6:59 AM, worklog-nore...@askmonty.org wrote: TASK...: Push conditions down into non-mergeable VIEWs when possible TASK ID: 119 (http://askmonty.org/worklog/?tid=119) Will this have

[Maria-developers] Patch to fix the dbug printout crash in 5.3-subqueries

2010-04-19 Thread Sergey Petrunya
Hi Sanja, Here is the fix: === modified file 'sql/sql_select.cc' --- sql/sql_select.cc 2010-03-29 20:09:40 + +++ sql/sql_select.cc 2010-04-19 17:59:46 + @@ -5214,7 +5214,7 @@ greedy_search(JOIN *join, 'join-best_positions' contains a complete optimal extension of the

Re: [Maria-developers] 5.3 subquery questions

2010-04-07 Thread Sergey Petrunya
Hi Sanja, On Wed, Apr 07, 2010 at 01:54:25PM +0300, Oleksandr Byelkin wrote: I found 1 interesting test case: create table t1 (a int, b int); insert into t1 values (1,2),(3,4),(1,2),(3,4),(3,4),(4,5),(4,5),(5,6), (5,6),(4,5); create table t2 (c int, d int); insert into t2 values

Re: [Maria-developers] 5.3 subquery questions

2010-04-07 Thread Sergey Petrunya
On Wed, Apr 07, 2010 at 04:08:49PM +0400, Sergey Petrunya wrote: Hi Sanja, On Wed, Apr 07, 2010 at 01:54:25PM +0300, Oleksandr Byelkin wrote: I found 1 interesting test case: create table t1 (a int, b int); insert into t1 values (1,2),(3,4),(1,2),(3,4),(3,4),(4,5),(4,5),(5,6), (5,6

[Maria-developers] Rev 2789: MWL#90: Subqueries: Inside-out execution for in file:///home/psergey/dev/maria-5.3-subqueries-r12/

2010-04-06 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r12/ revno: 2789 revision-id: pser...@askmonty.org-20100406081058-ihhw7esolj0mzc9a parent: pser...@askmonty.org-20100405201645-kuavh2rxc9whflc0 committer: Sergey Petrunya pser

[Maria-developers] Rev 2790: MWL#90: Subqueries: Inside-out execution for non-semijoin materialized in file:///home/psergey/dev/maria-5.3-subqueries-r12/

2010-04-06 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r12/ revno: 2790 revision-id: pser...@askmonty.org-20100406083401-36tcbqvit0wtilcx parent: pser...@askmonty.org-20100406081058-ihhw7esolj0mzc9a committer: Sergey Petrunya pser

[Maria-developers] Rev 2791: MWL#90: Subqueries: Inside-out execution for non-semijoin materialized in file:///home/psergey/dev/maria-5.3-subqueries-r12/

2010-04-06 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r12/ revno: 2791 revision-id: pser...@askmonty.org-20100406091710-xamea3aolh3rdspu parent: pser...@askmonty.org-20100406083401-36tcbqvit0wtilcx committer: Sergey Petrunya pser

[Maria-developers] Rev 2792: MWL#90: Subqueries: Inside-out execution for non-semijoin materialized in file:///home/psergey/dev/maria-5.3-subqueries-r12/

2010-04-06 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r12/ revno: 2792 revision-id: pser...@askmonty.org-20100406103533-0upq6g7sse9sjstz parent: pser...@askmonty.org-20100406091710-xamea3aolh3rdspu committer: Sergey Petrunya pser

[Maria-developers] FYI Current stable subquery optimizations pushed to lp:~maria-captains/maria/5.3

2010-04-03 Thread Sergey Petrunya
Hello, As requested, I've pushed the latest 'stable'(*) version of subquery optimizations into lp:~maria-captains/maria/5.3. (*) - stable here means: = there are no subquery-optimizations related failures in buildbot = there are no known new subquery issues (there are still some

[Maria-developers] Rev 2786: MWL#110: Make EXPLAIN always show materialization separately in file:///home/psergey/dev/maria-5.3-subqueries-r10/

2010-03-29 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r10/ revno: 2786 revision-id: pser...@askmonty.org-20100329140435-bb21mofh3i85tt4q parent: pser...@askmonty.org-20100323145750-sr9oucry979i3p60 committer: Sergey Petrunya pser

[Maria-developers] Rev 2787: Fix buildbot compile failure on hardy-amd64-makedist: in file:///home/psergey/dev/maria-5.3-subqueries-r10/

2010-03-29 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r10/ revno: 2787 revision-id: pser...@askmonty.org-20100329200940-9ikx6gpww0gtsx00 parent: pser...@askmonty.org-20100329140435-bb21mofh3i85tt4q committer: Sergey Petrunya pser

[Maria-developers] Rev 2783: Fix merge error in pbxt suite test results in file:///home/psergey/dev/maria-5.3-subqueries-r10/

2010-03-21 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r10/ revno: 2783 revision-id: pser...@askmonty.org-20100321195033-jzl1l091k2nbb6zh parent: pser...@askmonty.org-20100320165930-ehfull9rin1bdme4 committer: Sergey Petrunya pser

[Maria-developers] Rev 2781: Merge in file:///home/psergey/dev/maria-5.3-subqueries-r10/

2010-03-20 Thread Sergey Petrunya
-20100315224130-321rym1lsuwz2j5z committer: Sergey Petrunya pser...@askmonty.org branch nick: maria-5.3-subqueries-r10 timestamp: Sat 2010-03-20 15:08:44 +0300 message: Merge modified: mysql-test/suite/pbxt/r/subselect.result subselect.result-20090402100035-4ilk9i91sh65vjcb-146 mysql-test/suite/pbxt

[Maria-developers] Rev 2782: Fix union.test failure in buildbot: alternate fix for BUG#49734 in file:///home/psergey/dev/maria-5.3-subqueries-r10/

2010-03-20 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r10/ revno: 2782 revision-id: pser...@askmonty.org-20100320165930-ehfull9rin1bdme4 parent: pser...@askmonty.org-20100320120844-n8dvu5loib2fjvwl committer: Sergey Petrunya pser

[Maria-developers] Rev 2777: Update test results for the previous push in file:///home/psergey/dev/maria-5.3-subqueries-r7/

2010-03-15 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7/ revno: 2777 revision-id: pser...@askmonty.org-20100315060659-0spqc4jdav12ja2u parent: pser...@askmonty.org-20100314182543-4t3ehit7df20adu8 committer: Sergey Petrunya pser

[Maria-developers] Rev 2777: Apply fix by Roy Lyseng: in file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/

2010-03-15 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/ revno: 2777 revision-id: pser...@askmonty.org-20100315063254-z1ctm7srl0573s5c parent: pser...@askmonty.org-20100314182543-4t3ehit7df20adu8 committer: Sergey Petrunya pser

[Maria-developers] Rev 2778: Merge in file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/

2010-03-15 Thread Sergey Petrunya
-20100315060659-0spqc4jdav12ja2u committer: Sergey Petrunya pser...@askmonty.org branch nick: maria-5.3-subqueries-r7-rel timestamp: Mon 2010-03-15 09:35:35 +0300 message: Merge modified: mysql-test/r/type_datetime.result sp1f-type_datetime.result-20001228015634-jrgwqpilnfn4kvdp6wm5hp5imvf3tkek

[Maria-developers] Rev 2774: BUG#43768: Prepared query with nested subqueries core dumps on second execution in file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/

2010-03-14 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/ revno: 2774 revision-id: pser...@askmonty.org-20100314175412-umtxuabkn4txl1yd parent: pser...@askmonty.org-20100307154145-ksby2b1l0sqm1xne committer: Sergey Petrunya pser

[Maria-developers] Rev 2775: Fix support-files/build-tags to work with recent versions of bazaar. in file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/

2010-03-14 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/ revno: 2775 revision-id: pser...@askmonty.org-20100314175549-0gcze3pxaudgapxh parent: pser...@askmonty.org-20100314175412-umtxuabkn4txl1yd committer: Sergey Petrunya pser

[Maria-developers] Rev 2776: Merge in file:///home/psergey/dev/maria-5.3-subqueries-r7-rel/

2010-03-14 Thread Sergey Petrunya
-20100313211106-5xyfyl02gfenbi7f committer: Sergey Petrunya pser...@askmonty.org branch nick: maria-5.3-subqueries-r7-rel timestamp: Sun 2010-03-14 21:25:43 +0300 message: Merge modified: mysql-test/r/subselect_mat.result subselect_mat.result-20100117143924-r0jv32dj80dg3b5h-1 mysql-test/r

[Maria-developers] Rev 2774: BUG#45174: XOR in subqueries produces differing results in 5.1 and 5.4 in file:///home/psergey/dev/maria-5.3-subqueries-r7/

2010-03-13 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7/ revno: 2774 revision-id: pser...@askmonty.org-20100313200452-kq4dxayp7b45zum1 parent: pser...@askmonty.org-20100307154145-ksby2b1l0sqm1xne committer: Sergey Petrunya pser

Re: [Maria-developers] bzr commit into mysql-5.4 branch (epotemkin:2814) Bug#45174

2010-03-13 Thread Sergey Petrunya
Hi! I can't offer any testcases but I think this patch has several issues. See below. On Tue, Oct 13, 2009 at 09:38:52AM +, Evgeny Potemkin wrote: #At file:///work/bzrroot/45174-bug-azalea/ based on revid:a...@sun.com-20090702085822-8svd0aslr7qnddbb 2814 Evgeny Potemkin 2009-10-13

[Maria-developers] Rev 2775: Apply fix by oystein.grov...@sun.com 2010-03-12: in file:///home/psergey/dev/maria-5.3-subqueries-r7/

2010-03-13 Thread Sergey Petrunya
At file:///home/psergey/dev/maria-5.3-subqueries-r7/ revno: 2775 revision-id: pser...@askmonty.org-20100313211106-5xyfyl02gfenbi7f parent: pser...@askmonty.org-20100313200452-kq4dxayp7b45zum1 committer: Sergey Petrunya pser

[Maria-developers] Rev 2797: Fixed valgrind failure in select_describe(), read of uninitialized in file:///home/psergey/dev/mariadb-5.1-knielsen/

2010-03-09 Thread Sergey Petrunya
At file:///home/psergey/dev/mariadb-5.1-knielsen/ revno: 2797 revision-id: pser...@askmonty.org-20100309100049-n986bg9spx4mlamp parent: kniel...@knielsen-hq.org-20100304080603-qq61atw8t0im9qf4 committer: Sergey Petrunya pser

Re: [Maria-developers] Help with memory leak in optimiser code

2010-03-09 Thread Sergey Petrunya
. - Forwarded message from Sergey Petrunya pser...@askmonty.org - From: Sergey Petrunya pser...@askmonty.org To: maria-developers@lists.launchpad.net X-Mailer: mail (GNU Mailutils 1.2) Date: Tue, 9 Mar 2010 21:53:58 +0300 (MSK) Subject: [Maria-developers] Rev 2798: Fix a buildbot memory leak due

[Maria-developers] FirstMatch strategy and interleaving

2010-03-07 Thread Sergey Petrunya
Hi! I was looking through subquery code and found the following issue with FirstMatch strategy: Our original intent with FirstMatch strategy was to support join orders where sj-inner tables are interleaved with outer tables that are not correlated with the subquery. FirstMatch spec is here,

  1   2   3   >