Re: [Maria-developers] [Commits] 8bfb140d5dc: Move deletion of old GTID rows to slave background thread

2018-12-07 Thread Kristian Nielsen
andrei.el...@pp.inet.fi writes: >> Note that the cleanup happens asynchroneously, and system load can cause the >> cleanup step to be delayed or > > >even skipped completely in rare cases; > > I only can think of crashes here... Anything else do you mean? There is a small race in the code

Re: [Maria-developers] [Commits] 8bfb140d5dc: Move deletion of old GTID rows to slave background thread

2018-12-07 Thread andrei . elkin
Salute, Kristian! > Hi Andrei, > > Thanks for review! I rebased the patch on 10.4, ran it through another > buildbot run, and pushed it to 10.4. > > I think with this patch I'll close MDEV-12147, ok? Committed :-) > > I wrote up the below documentation, I'm planning on adding it to the >

Re: [Maria-developers] [Commits] 8bfb140d5dc: Move deletion of old GTID rows to slave background thread

2018-12-06 Thread Kristian Nielsen
Hi Andrei, Thanks for review! I rebased the patch on 10.4, ran it through another buildbot run, and pushed it to 10.4. I think with this patch I'll close MDEV-12147, ok? I wrote up the below documentation, I'm planning on adding it to the knowledgebase, unless it is better to send it to someone

Re: [Maria-developers] [Commits] 8bfb140d5dc: Move deletion of old GTID rows to slave background thread

2018-12-03 Thread andrei . elkin
Kristian, hello. The patch is great and instructive in many ways. Thanks! There is something to improve in the test organization, like to base two tests of > storage/rocksdb/mysql-test/rocksdb_rpl/t/mdev12179.test > storage/tokudb /mysql-test/tokudb_rpl /t/mdev12179.test on a common parent. I