Re: [Maria-developers] 0402f6dcb67: MDEV-25477 Auto-create breaks replication when triggering event was not replicated

2022-03-07 Thread Aleksey Midenkov
Hi Sergei, On Wed, Mar 2, 2022 at 10:33 PM Sergei Golubchik wrote: > > Hi, Aleksey, > > On Feb 15, Aleksey Midenkov wrote: > > > On Feb 12, Aleksey Midenkov wrote: > > > > commit 0402f6dcb67 > > > > Author: Aleksey Midenkov > > > > Date: Tue Feb 8 22:54:03 2022 +0300 > > > > > > > > diff

Re: [Maria-developers] 0402f6dcb67: MDEV-25477 Auto-create breaks replication when triggering event was not replicated

2022-03-02 Thread Sergei Golubchik
Hi, Aleksey, On Feb 15, Aleksey Midenkov wrote: > > On Feb 12, Aleksey Midenkov wrote: > > > commit 0402f6dcb67 > > > Author: Aleksey Midenkov > > > Date: Tue Feb 8 22:54:03 2022 +0300 > > > > > > diff --git a/sql/sql_delete.cc b/sql/sql_delete.cc > > > index 0403d6e73c3..06068290247 100644 >

Re: [Maria-developers] 0402f6dcb67: MDEV-25477 Auto-create breaks replication when triggering event was not replicated

2022-02-15 Thread Aleksey Midenkov
Hi Sergei! Updated branch preview-10.8-MDEV-17554-auto-create-partition On Sat, Feb 12, 2022 at 2:31 AM Sergei Golubchik wrote: > > Hi, Aleksey, > > This was quite good, thanks! > > Many cases covered, not just ROLLBACK, but also LIMIT 0 and > impossible WHERE. > > See a couple of comments

Re: [Maria-developers] 0402f6dcb67: MDEV-25477 Auto-create breaks replication when triggering event was not replicated

2022-02-11 Thread Sergei Golubchik
Hi, Aleksey, This was quite good, thanks! Many cases covered, not just ROLLBACK, but also LIMIT 0 and impossible WHERE. See a couple of comments below. Nothing big. On Feb 12, Aleksey Midenkov wrote: > commit 0402f6dcb67 > Author: Aleksey Midenkov > Date: Tue Feb 8 22:54:03 2022 +0300 > >