Re: [Maria-developers] 4670c85a48c: MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf on table with virtual columns and indexes

2019-07-05 Thread Sergei Golubchik
Hi, Aleksey! On Jul 05, Aleksey Midenkov wrote: > Hello Sergei! > > Actually I was aware of that, but open_purge_table() looks so > non-generic, so I decided to push that down. Well, I agree, it's "kind > of" generic and it will be safer to move a bit higher. But why to > remove DEBUG_ASSERT?

Re: [Maria-developers] 4670c85a48c: MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf on table with virtual columns and indexes

2019-07-05 Thread Aleksey Midenkov
Hello Sergei! Actually I was aware of that, but open_purge_table() looks so non-generic, so I decided to push that down. Well, I agree, it's "kind of" generic and it will be safer to move a bit higher. But why to remove DEBUG_ASSERT? update_virtual_field() relies on is_error() from inside. If

Re: [Maria-developers] 4670c85a48c: MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf on table with virtual columns and indexes

2019-07-04 Thread Sergei Golubchik
Hi, Aleksey! Summary: looks ok, but please move clear_error() to the caller (ha_innodb.cc) and remove the assert. On Jul 04, Aleksey Midenkov wrote: > revision-id: 4670c85a48c (mariadb-10.4.5-47-g4670c85a48c) > parent(s): 0f55a9eb73b > author: Aleksey Midenkov > committer: Aleksey Midenkov >