Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-25 Thread Sergei Golubchik
Hi, Jan! On Oct 25, Jan Lindström wrote: > Hi Sergei, > > > > --- a/sql/sql_parse.cc > > > +++ b/sql/sql_parse.cc > > > @@ -2159,6 +2159,7 @@ bool dispatch_command( > > > } > > > DBUG_PRINT("quit",("Got shutdown command for level %u", level)); > > > general_log_print(thd, command,

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-25 Thread Marko Mäkelä
Hi Jan, Ramesh said that he has not observed any "WSREP: BF lock wait long for trx" messages while running tests. This would suggest that the diagnostic output code is essentially untested. I would say that the diagnostic output is related to MDEV-23328 or MDEV-25114, because it involves the

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-25 Thread Jan Lindström
Hi Marko, > > > I am sad to see that my comment regarding wsrep_is_BF_lock_timeout() > that I made in > https://github.com/MariaDB/server/commit/b74b53f0515b360bb5cddec1a506a2f4d4dc21b3#r52293813 > (June 17) has not been addressed. Do we really need that output? Do we > see that output in our

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-25 Thread Jan Lindström
Hi Sergei, > > > --- a/sql/sql_parse.cc > > +++ b/sql/sql_parse.cc > > @@ -2159,6 +2159,7 @@ bool dispatch_command(enum enum_server_command > command, THD *thd, > > } > > DBUG_PRINT("quit",("Got shutdown command for level %u", level)); > > general_log_print(thd, command, NullS); >

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-24 Thread Marko Mäkelä
Hi Sergei, Jan, On Sun, Oct 24, 2021 at 9:11 PM Sergei Golubchik wrote: > > > +/* This is wrapper for wsrep_break_lock in thr_lock.c */ > > +static int wsrep_thr_abort_thd(void *bf_thd_ptr, void *victim_thd_ptr, > > my_bool signal) > > When is it called? Under what conditions? Right, comments

Re: [Maria-developers] 6d0c1f3ae12: MDEV-23328 Server hang due to Galera lock conflict resolution

2021-10-24 Thread Sergei Golubchik
Hi, Jan! This was good! Just a few questions, see below On Oct 24, Jan Lindström wrote: > revision-id: 6d0c1f3ae12 (mariadb-10.2.40-114-g6d0c1f3ae12) > parent(s): 3153cc799e2 > author: Jan Lindström > committer: Jan Lindström > timestamp: 2021-10-22 07:02:39 +0300 > message: > > MDEV-23328